[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

max-kudr added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:55-59 +Expected> IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest &request, ArrayRef current_tids) { - IntelPTP

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

max-kudr added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTPerThreadProcessTrace.cpp:55-59 +Expected> IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest &request, ArrayRef current_tids) { - IntelPTP

[Lldb-commits] [PATCH] D83772: [Windows] Fix limit on command line size

max-kudr accepted this revision. max-kudr added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.llvm.org/D83772 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

max-kudr added a comment. @JDevlieghere This change is is failing LLDB Windows buildbot since build 18051 . Can you please fix that? Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

max-kudr added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85235/new/ https://reviews.llvm.org/D85235 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D85970: [lldb] Fix that log enable's -f parameter causes LLDB to crash when it can't open the log file

max-kudr added a comment. LLDB Windows buildbot is failing after last commit: Build 18298 . Please revert or fix. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D86667: [lldb/Target] Add custom interpreter option to `platform shell`

max-kudr added a comment. Hi @mib, Windows buildbot is broken after this commit. Please fix or revert. Failed Tests (2): lldb-api :: commands/platform/basic/TestPlatformCommand.py lldb-api :: commands/platform/basic/TestPlatformPython.py http://lab.llvm.org:8011/builders/lldb-x64-windows-ni

[Lldb-commits] [PATCH] D86667: [lldb/Target] Add custom interpreter option to `platform shell`

max-kudr added inline comments. Comment at: lldb/test/API/commands/platform/basic/myshell.c:11 + +#ifdef WIN32 + char *cmd_opt = "/C"; mib wrote: > @max-kudr It seems I'm missing the leading `_` (correct me if I'm wrong but > IIUC the macro should be `_WIN32`),

[Lldb-commits] [PATCH] D80308: [lldb] Enable C++14 when evaluating expressions in a C++14 frame

max-kudr added a comment. Hello, I suppose this commit broke Windows LLDB tests (http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/16486 -> logs: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/16486/steps/test/logs/stdio). Can you please fix or rollback it? Than

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

max-kudr added a comment. This broke LLDB tests on Windows Build Bot http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13415 Can you please fix it or revert it? Thank you! Failing Tests (4): lldb-api :: commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

max-kudr added a comment. There is Windows Build Bot failure http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13427. Can you please fix or revert it? Cannot open include file: 'Plugins/DynamicLoader/wasm-DYLD/DynamicLoaderWasmDYLD.h': No such file or directory Repository: