[Lldb-commits] [PATCH] D70386: [lldb-server] Use LLDB_LOG_ERROR to consume Error<> even if logging is disabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG926d283893ae: [lldb-server] Use LLDB_LOG_ERROR to consume Error<> even if logging is disabled (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D70387: [LLDB] [Windows] Allow making subprocesses use the debugger's console with LLDB_INHERIT_CONSOLE=true

mstorsjo added a comment. In D70387#1751090 , @labath wrote: > It's good that you mentioned lldb-server, because it's presence complicates > this behavior even further. If we wanted the console sharing approach to > work, then we'd have to have both lldb

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

mstorsjo added a reviewer: zturner. mstorsjo added a comment. As context (I haven't followed lldb almost at all), what's the general status of lldb on windows - generally working, or still a work in progress? Does it work with dwarf debug info in COFF (as commonly used in mingw environments), in

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

mstorsjo created this revision. mstorsjo added reviewers: asmith, labath, hhb. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. This fixes build errors like these: NativeRegisterContextWindows.h:22:33: error: extra qualification on member 'NativeRegisterContextWindows'

[Lldb-commits] [PATCH] D67857: [LLDB] Include lldb/Host/windows/windows.h on any windows target

mstorsjo created this revision. mstorsjo added reviewers: lanza, hhb, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. This fixes MinGW builds, that otherwise fail due to use of undeclared `GetLastError()` and `ERROR_OPERATION_ABORTED`. The use of `GetLastErro

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

mstorsjo added a comment. In D67856#1677356 , @davide wrote: > If this doesn't break clang and gcc, fine. FWIW, it was with clang that I ran into it, haven't tested building lldb with gcc. But the issue can be tested with a snippet like this: class

[Lldb-commits] [PATCH] D67858: [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition to MSVC defines

mstorsjo created this revision. mstorsjo added reviewers: compnerd, hhb, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. This matches how it is done in all other similar ifdefs throughout lldb (modulo inconsistencies between `_M_AMD64` and `_M_X64`); both MSVC

[Lldb-commits] [PATCH] D67859: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC

mstorsjo created this revision. mstorsjo added reviewers: hhb, labath, amccarth. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D67859 Files: lldb/include/lldb/Host/Socket.h Index: lldb/include/lldb/Host/Socket.h =

[Lldb-commits] [PATCH] D67860: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment

mstorsjo created this revision. mstorsjo added reviewers: asmith, hhb, labath. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. This fixes a warning when built with Clang instead of MSVC. Repository: rLLDB LLDB https://reviews.llvm.org/D67860 Files: lldb/source/Plugin

[Lldb-commits] [PATCH] D67861: [LLDB] Check for the __MINGW32__ define instead of __MINGW64

mstorsjo created this revision. mstorsjo added reviewers: hhb, xen2, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. `__MINGW64__` is only defined for 64 bit targets, and the define without trailing underscores is never defined automatically (neither by clang

[Lldb-commits] [PATCH] D67863: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

mstorsjo created this revision. mstorsjo added reviewers: hhb, labath, compnerd. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. This silences warnings about comparison of integers between unsigned long long (which is what the Windows SOCKET type is) and signed int wh

[Lldb-commits] [PATCH] D67862: [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format strings

mstorsjo created this revision. mstorsjo added reviewers: asmith, hhb, labath, compnerd. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. SetErrorStringWithFormat only supports normal printf style format strings. Repository: rLLDB LLDB https://reviews.llvm.org/D67862 Fi

[Lldb-commits] [PATCH] D67863: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

mstorsjo updated this revision to Diff 221122. mstorsjo added a comment. Use static_cast. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67863/new/ https://reviews.llvm.org/D67863 Files: lldb/source/Host/common/Socket.cpp lldb/tools/lldb-vscode/lldb-vscode.cpp Index: lldb/tools/ll

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

This revision was automatically updated to reflect the committed changes. Closed by commit rL372482: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D67858: [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition to MSVC defines

This revision was automatically updated to reflect the committed changes. Closed by commit rL372483: [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition… (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[Lldb-commits] [PATCH] D67860: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment

This revision was automatically updated to reflect the committed changes. Closed by commit rL372484: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[Lldb-commits] [PATCH] D67862: [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format strings

This revision was automatically updated to reflect the committed changes. Closed by commit rL372485: [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format… (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[Lldb-commits] [PATCH] D67863: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

This revision was automatically updated to reflect the committed changes. Closed by commit rL372486: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

mstorsjo created this revision. mstorsjo added reviewers: amccarth, compnerd, hhb. Herald added subscribers: JDevlieghere, abidh, mgorny. Herald added a project: LLDB. The PECOFF object file plugin uses the dbghelp API, but doesn't specify that it has to be linked in anywhere. Current MSVC based

[Lldb-commits] [PATCH] D67887: Use _WIN32 instead of _MSC_VER

mstorsjo added a comment. Just FTR, this was identical to D67857 that I posted a few days ago. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67887/new/ https://reviews.llvm.org/D67887 __

[Lldb-commits] [PATCH] D67857: [LLDB] Include lldb/Host/windows/windows.h on any windows target

mstorsjo abandoned this revision. mstorsjo added a comment. D67887 was committed with the same change. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67857/new/ https://reviews.llvm.org/D67857

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

mstorsjo added a comment. @hhb - This is the only change left for builds of lldb on mingw to succeed for me (for x86), but I have a whole bunch of more changes lined up that fix warnings and other issues I've found. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64

mstorsjo created this revision. mstorsjo added reviewers: jasonmolenda, jingham. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: LLDB. In these cases, the register number should be calculated from `fpu_d0`, not `fpu_s0`. Repository: rLLDB LLDB https://reviews.l

[Lldb-commits] [PATCH] D67893: [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in general

mstorsjo created this revision. mstorsjo added reviewers: hhb, compnerd, amccarth. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. These ifdefs contain code that isn't specific to MSVC but useful for any windows target, like MinGW. Repository: rLLDB LLDB https://

[Lldb-commits] [PATCH] D67894: [LLDB] Rework a MinGW build fix from D65691

mstorsjo created this revision. mstorsjo added a reviewer: hhb. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. That change didn't contain any explanation for this bit. There shouldn't be any need for a check for MinGW ifdefs here, as long as the include uses lowercas

[Lldb-commits] [PATCH] D67895: [LLDB] Avoid a warning about an unused static variable

mstorsjo created this revision. mstorsjo added reviewers: hhb, compnerd, amccarth. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. The variable is unused on windows. Repository: rLLDB LLDB https://reviews.llvm.org/D67895 Files: lldb/tools/lldb-server/lldb-gdbserver.c

[Lldb-commits] [PATCH] D67896: [LLDB] Add a void* cast when passing object pointers to printf %p

mstorsjo created this revision. mstorsjo added reviewers: hhb, compnerd, amccarth. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. This fixes build warnings in MinGW mode. Repository: rLLDB LLDB https://reviews.llvm.org/D67896 Files: lldb/source/Host/windows/Co

[Lldb-commits] [PATCH] D67861: [LLDB] Check for the __MINGW32__ define instead of __MINGW64

mstorsjo added a comment. In D67861#1678618 , @labath wrote: > Judging by the microsoft docs > , > `vsnprintf` is avali

[Lldb-commits] [PATCH] D67861: [LLDB] Remove a now redundant windows specific workaround

mstorsjo updated this revision to Diff 221276. mstorsjo retitled this revision from "[LLDB] Check for the __MINGW32__ define instead of __MINGW64" to "[LLDB] Remove a now redundant windows specific workaround". mstorsjo edited the summary of this revision. mstorsjo added a comment. Updated the p

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

mstorsjo added a comment. In D67885#1678701 , @MyDeveloperDay wrote: > Just as a drive by comment, there is code in > DebugInfo/Symbolize/Symbolize.cpp that loads dbghelp via #pragma > comment(lib... trick Yes, but as I mentioned in the patch descrip

[Lldb-commits] [PATCH] D67859: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rL372586: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D67895: [LLDB] Avoid a warning about an unused static variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL372589: [LLDB] Avoid a warning about an unused static variable (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

This revision was automatically updated to reflect the committed changes. Closed by commit rL372587: [LLDB] Add a missing specification of linking against dbghelp (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67861: [LLDB] Remove a now redundant windows specific workaround

This revision was automatically updated to reflect the committed changes. Closed by commit rL372591: [LLDB] Remove a now redundant windows specific workaround (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [PATCH] D67896: [LLDB] Add a void* cast when passing object pointers to printf %p

This revision was automatically updated to reflect the committed changes. Closed by commit rL372590: [LLDB] Add a void* cast when passing object pointers to printf %p (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[Lldb-commits] [PATCH] D67893: [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in general

This revision was automatically updated to reflect the committed changes. Closed by commit rL372592: [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in… (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[Lldb-commits] [PATCH] D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW

mstorsjo created this revision. mstorsjo added reviewers: hhb, amccarth, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. Since these defines were added in LLVM SVN r189364 in 2013, mingw-w64 got defines for S_I?GRP, S_IRWXG, S_I?OTH and S_IRWXO in 2015. Repo

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo created this revision. mstorsjo added reviewers: amccarth, labath, hhb, compnerd, asmith. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. While debugging on those architectures might not be supported yet, the generic code should still be buildable. This file

[Lldb-commits] [PATCH] D67912: [LLDB] [PECOFF] Recognize arm64 executables

mstorsjo created this revision. mstorsjo added reviewers: amccarth, compnerd, hhb, labath, asmith. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D67912 Files: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFi

[Lldb-commits] [PATCH] D67913: [LLDB] [Windows] Map COFF ARM machine ids to the right triplet architectures

mstorsjo created this revision. mstorsjo added reviewers: amccarth, compnerd, hhb, labath, asmith. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D67913 Files: lldb/source/Host/windows/Host.cpp Index: lld

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo marked an inline comment as done. mstorsjo added a comment. In D67911#1679333 , @compnerd wrote: > What do you think of adding some sort of notification that hardware > breakpoints are currently unsupported and that we are falling back to > soft

[Lldb-commits] [PATCH] D67913: [LLDB] [Windows] Map COFF ARM machine ids to the right triplet architectures

This revision was automatically updated to reflect the committed changes. Closed by commit rL372658: [LLDB] [Windows] Map COFF ARM machine ids to the right triple architectures (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[Lldb-commits] [PATCH] D67912: [LLDB] [PECOFF] Recognize arm64 executables

This revision was automatically updated to reflect the committed changes. Closed by commit rL372657: [LLDB] [PECOFF] Recognize arm64 executables (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D67894: [LLDB] Rework a MinGW build fix from D65691

This revision was automatically updated to reflect the committed changes. Closed by commit rL372656: [LLDB] Rework a MinGW build fix from D65691 (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo added a comment. In D67911#1679696 , @compnerd wrote: > I think that `printf` is quite an amazing notification :-) Ok, I'll make it an `LLDB_LOG` then, as I'd presume using raw printfs isn't really allowed :-) Repository: rLLDB LLDB CHANGE

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo updated this revision to Diff 221406. mstorsjo added a comment. Added a log message, changed an `x86_64` ifdef into `_WIN64`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67911/new/ https://reviews.llvm.org/D67911 Files: lldb/source/Plugins/Process/Windows/Common/RegisterCo

[Lldb-commits] [PATCH] D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lldb/include/lldb/Host/windows/PosixApi.h:39 #endif +#ifndef S_IRGRP #define S_IRGRP 0 /* read, group */ hhb wrote: > Maybe move these into the defined(_MSC_VER) above? Or th

[Lldb-commits] [PATCH] D67942: Install python dll to bin

mstorsjo added a comment. Sorry, I'm not familiar with how LLDB integrates with python and how all of that works on Windows, so I can't really comment on this one for now... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67942/new/ https://reviews.

[Lldb-commits] [PATCH] D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rL372700: [LLDB] Avoid warnings about redefining posix mode defines on MinGW (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

This revision was automatically updated to reflect the committed changes. Closed by commit rL372699: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D67953: [LLDB] [test] Allow differing order of some matches

mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, amccarth, hhb. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. These can appear in a different order depending on the relative layout of the source and build trees. Repository: rLLDB LLDB https

[Lldb-commits] [PATCH] D67951: [LLDB] Add tests for PECOFF arm architecture identification

mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, amccarth, hhb. Herald added subscribers: JDevlieghere, abidh, kristof.beyls. Herald added a project: LLDB. Add a test case for the change from SVN r372657, and for the preexisting ARM identification. Add a missing ArchDe

[Lldb-commits] [PATCH] D67952: [LLDB] [test] Add a few missing cases of REQUIRES: python

mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, amccarth, hhb. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D67952 Files: lldb/lit/Commands/command-script-import.test lldb/lit/Reproducer/T

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, amccarth, hhb, asmith. Herald added subscribers: JDevlieghere, abidh, kristof.beyls, mgorny. Herald added a project: LLDB. This seems to be enough for getting a backtrace and variable values for MinGW-built binaries for A

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

mstorsjo added a comment. > This seems to be enough for getting a backtrace and variable values for > MinGW-built binaries for ARM64. To clarify; this is binaries that use DWARF debug info. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67954/new/ https://revi

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

mstorsjo added a comment. In D67954#1680536 , @labath wrote: > Have you considered going the "native" route directly? My understanding is > that this route is already functional on x86 (modulo watchpoints, which I > need to get around to reviewing). It w

[Lldb-commits] [PATCH] D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rL372738: [LLDB] Fix typo in RegisterContextDarwin_arm64 (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[Lldb-commits] [PATCH] D67953: [LLDB] [test] Allow differing order of some matches

This revision was automatically updated to reflect the committed changes. Closed by commit rL372740: [LLDB] [test] Allow differing order of some matches (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[Lldb-commits] [PATCH] D67952: [LLDB] [test] Add a few missing cases of REQUIRES: python

This revision was automatically updated to reflect the committed changes. Closed by commit rL372739: [LLDB] [test] Add a few missing cases of REQUIRES: python (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [PATCH] D67951: [LLDB] Add tests for PECOFF arm architecture identification

This revision was automatically updated to reflect the committed changes. Closed by commit rL372741: [LLDB] Add tests for PECOFF arm architecture identification (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth, rnk, compnerd. Herald added subscribers: JDevlieghere, erik.pilkington. Herald added a project: LLDB. I'm unsure if there's any lldb testcase which exercise this directly (I didn't find any); such testcases could be made

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 register contexts

mstorsjo added a comment. In D67954#2515028 , @mgorny wrote: > Is there a specific reason you've only covered x0..x7 in the test? No, only for keeping the test short and cohesive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

mstorsjo added a comment. The change looks ok to me. In my environments, the main branch does build correctly, but this should be good for consistency in any case. (The 12.x release branch does need a cherrypick though - but it'd be good to settle this first.) I can test build it in a couple h

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

mstorsjo added a comment. In D96060#2542890 , @mstorsjo wrote: > I can test build it in a couple hours It still built fine for me now - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96060/new/ http

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

mstorsjo added inline comments. Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:9 + +#if !defined(WIN32) +#include stella.stamenova wrote: > Also, this is no good. It works if you are targeting windows on windows, but > not if you are targeting something else

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mstorsjo added reviewers: labath, amccarth, mstorsjo. mstorsjo added a comment. +1 from me on this, I'm ok with this change. I'm a bit curious as I haven't seen any issues regarding this myself though. I wonder if it something very MSYS2-specific, or is the difference in building with gcc vs cla

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mstorsjo added a comment. In D7#2039069 , @mati865 wrote: > Perhaps you are building with Clang? > I don't remember the message but GCC emits error about incompatible > definition and declaration of `vasprintf`. I can build it without the patch > an

[Lldb-commits] [PATCH] D83881: [lldb/COFF] Remove strtab zeroing hack

mstorsjo added a comment. In D83881#2153687 , @amccarth wrote: > Yes, getting rid of this hack looks like a good idea. If it was actually > necessary, there should have been a test on it, and the comments should have > been clearer. Well in general, I

[Lldb-commits] [PATCH] D84070: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84070 Files: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp lldb/test/Shell/ObjectFile/PECOFF/symbol.yaml In

[Lldb-commits] [PATCH] D84070: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol

mstorsjo added a subscriber: hans. mstorsjo added a comment. @hans - I think this one could be a fairly safe backport to the release branch. (Apparently phab lags behind regarding updating the reviews when they are committed at the moment; this was committed as f07ddbc9c4b66e91aa7a106042512ee90

[Lldb-commits] [PATCH] D84070: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol

This revision was automatically updated to reflect the committed changes. Closed by commit rGf07ddbc9c4b6: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D84070?vs=278893&id=279406#toc Repository:

[Lldb-commits] [PATCH] D70742: [LLDB] [Windows] Avoid using InitializeContext for allocating a CONTEXT. NFC.

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth, asmith, aleksandr.urakov. Herald added a project: LLDB. InitializeContext is useful for allocating a CONTEXT struct in an unaligned byte buffer. In this case, we already have a CONTEXT we want to initialize, and we only

[Lldb-commits] [PATCH] D70745: [LLDB] [PECOFF] Look for the truncated ".eh_fram" section name

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added a project: LLDB. COFF section names can either be stored truncated to 8 chars, in the section header, or as a longer section name, stored separately in the string table. libunwind locates the .eh_frame secti

[Lldb-commits] [PATCH] D70742: [LLDB] [Windows] Avoid using InitializeContext for allocating a CONTEXT. NFC.

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp:158 + memset(&m_context, 0, sizeof(m_context)); + m_context.ContextFlags = kWinContextFlags; if (::SuspendThread( ---

[Lldb-commits] [PATCH] D70742: [LLDB] [Windows] Avoid using InitializeContext for allocating a CONTEXT. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG344bdeb797b3: [LLDB] Avoid using InitializeContext for zero-initializing a CONTEXT. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D70745: [LLDB] [PECOFF] Look for the truncated ".eh_fram" section name

mstorsjo added a comment. In D70745#1760917 , @amccarth wrote: > Is `.eh_frame` the only one that matters? Should this be more general and > compare `const_sect_name` to the full name and the truncated name for any > known section names? Out of the se

[Lldb-commits] [PATCH] D70778: [LLDB] [PECOFF] Factorize mapping section names to types using StringSwitch. NFCI.

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added a project: LLDB. Keep the existing special cases based on combinations of section name, flags and sizes/offsets. Some of those special cases have been added intentionally, with test cases, rather recently,

[Lldb-commits] [PATCH] D70745: [LLDB] [PECOFF] Look for the truncated ".eh_fram" section name

mstorsjo added a comment. In D70745#1761421 , @labath wrote: > In D70745#1761392 , @mstorsjo wrote: > > > > As for the long if-else cascade, the equivalent elf code was recently > > > refactored to use llvm::String

[Lldb-commits] [PATCH] D70745: [LLDB] [PECOFF] Look for the truncated ".eh_fram" section name

mstorsjo updated this revision to Diff 231212. mstorsjo edited the summary of this revision. mstorsjo added a comment. Updated on top of D70778 , added a testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70745/new/ https://reviews.llvm.org/D70745

[Lldb-commits] [PATCH] D70778: [LLDB] [PECOFF] Factorize mapping section names to types using StringSwitch. NFCI.

mstorsjo updated this revision to Diff 231318. mstorsjo added a comment. Split the code into a separate function as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70778/new/ https://reviews.llvm.org/D70778 Files: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

[Lldb-commits] [PATCH] D70796: [LLDB] Always interpret arm instructions as thumb on windows

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added a subscriber: kristof.beyls. Herald added a project: LLDB. Windows on arm always uses thumb mode, and doesn't have most of the mechanisms that are used in e.g. ELF for distinguishing between arm and thumb.

[Lldb-commits] [PATCH] D70797: [LLDB] Use r11 as frame pointer on Windows on ARM

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added a subscriber: kristof.beyls. Herald added a project: LLDB. The change in itself is straightforward based on reading the code, but I don't have a real world case where I know this made a difference, so I don't

[Lldb-commits] [PATCH] D70796: [LLDB] Always interpret arm instructions as thumb on windows

mstorsjo added a comment. In D70796#1762491 , @labath wrote: > Seems reasonable. Just out of curiosity, is this restriction enforced in some > way? E.g., if I manually do a `bx` to an arm address, will the system kill me? No, such simple cases do work (

[Lldb-commits] [PATCH] D70778: [LLDB] [PECOFF] Factorize mapping section names to types using StringSwitch. NFCI.

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:803-804 + (const_sect_name == g_CODE_sect_name))) { +return eSectionTypeCode; + } else if (sect.flags & llvm::COFF::IMAGE_S

[Lldb-commits] [PATCH] D70796: [LLDB] Always interpret arm instructions as thumb on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5c54f40327b: [LLDB] Always interpret arm instructions as thumb on windows (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70796/new/

[Lldb-commits] [PATCH] D70745: [LLDB] [PECOFF] Look for the truncated ".eh_fram" section name

This revision was automatically updated to reflect the committed changes. Closed by commit rG934c025e9bdd: [LLDB] [PECOFF] Look for the truncated ".eh_fram" section name (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D70745?vs=231212&id=231370#toc Repository: rG LL

[Lldb-commits] [PATCH] D70778: [LLDB] [PECOFF] Factorize mapping section names to types using StringSwitch. NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e5bb6d8d944: [LLDB] [PECOFF] Factorize mapping section names to types using StringSwitch. (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D70778?vs=231318&id=231368#toc Repos

[Lldb-commits] [PATCH] D70796: [LLDB] Always interpret arm instructions as thumb on windows

mstorsjo added a comment. In D70796#1762774 , @teemperor wrote: > This is failing for me with: > > (lldb) disassemble -b -n entry > error: Unable to find Disassembler plug-in for the 'armv7' architecture. > > > I assume that's because I run with `LLVM_

[Lldb-commits] [PATCH] D70796: [LLDB] Always interpret arm instructions as thumb on windows

mstorsjo added a comment. I pushed a commit to add such a REQUIRES line now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70796/new/ https://reviews.llvm.org/D70796 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D70797: [LLDB] Use r11 as frame pointer on Windows on ARM

mstorsjo updated this revision to Diff 231416. mstorsjo edited the summary of this revision. mstorsjo added a comment. Added a testcase using a minidump. I had to add recognition of r11 as a potential frame pointer register in thumb mode in the handling of one instruction, to make it pick up the

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added subscribers: kristof.beyls, aprantl. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. Windows on ARM is always thumb, and contrary to ELF, there's no per-symbol flag to indicate arm vs thumb

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1763639 , @labath wrote: > Yeah, this is going to be tricky... I don't really know what's the right way > to do this, but here are the thoughts I have on this so far: > > - The new DWARFDebugInfoEntry member is going to

[Lldb-commits] [PATCH] D70848: [LLDB] Set the right address size on output DataExtractors from ObjectFile

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added a subscriber: aprantl. Herald added a project: LLDB. If filling in a DataExtractor from an ObjectFile, e.g. via the ReadSectionData method, the output DataExtractor gets the address size from the m_data membe

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo updated this revision to Diff 231517. mstorsjo edited the summary of this revision. mstorsjo added a comment. Converted the test to .s form, using lld, split out the ObjectFile changes to D70848 (which this change now depends on for the tests). CHANGE

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1763705 , @mstorsjo wrote: > In D70840#1763639 , @labath wrote: > > > Yeah, this is going to be tricky... I don't really know what's the right > > way to do this, but here are th

[Lldb-commits] [PATCH] D70797: [LLDB] Use r11 as frame pointer on Windows on ARM

This revision was automatically updated to reflect the committed changes. Closed by commit rG45c843de4eb8: [LLDB] [ARM] Use r11 as frame pointer on Windows on ARM (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D70797?vs=231416&id=231527#toc Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D70848: [LLDB] Set the right address size on output DataExtractors from ObjectFile

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d019d1a3be2: [LLDB] Set the right address size on output DataExtractors from ObjectFile (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo marked an inline comment as done. mstorsjo added a comment. In D70840#1765219 , @labath wrote: > debug_aranges is a sort of a lookup table for speeding up address->compile > unit searches. llvm does not generate it by default since, and I think t

[Lldb-commits] [PATCH] D70848: [LLDB] Set the right address size on output DataExtractors from ObjectFile

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lldb/source/Symbol/ObjectFile.cpp:480-486 + size_t ret = data.SetData(m_data, offset, length); + // DataExtractor::SetData copies the address byte size from m_data, but + // m_data's address

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1765373 , @clayborg wrote: > So some background on how address masks are handled in LLDB: > > Typically the way we have tried to take care of the extra Thumb bit for ARM > using: > > lldb::addr_t Address::GetCallableL

<    1   2   3   4   5   >