mstorsjo created this revision. mstorsjo added a reviewer: hhb. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB.
That change didn't contain any explanation for this bit. There shouldn't be any need for a check for MinGW ifdefs here, as long as the include uses lowercase windows.h (as is used consistently elsewhere in the llvm projects). Repository: rLLDB LLDB https://reviews.llvm.org/D67894 Files: lldb/tools/lldb-vscode/VSCode.cpp Index: lldb/tools/lldb-vscode/VSCode.cpp =================================================================== --- lldb/tools/lldb-vscode/VSCode.cpp +++ lldb/tools/lldb-vscode/VSCode.cpp @@ -15,10 +15,8 @@ #include "llvm/Support/FormatVariadic.h" #if defined(_WIN32) -#ifndef __MINGW32__ #define NOMINMAX -#include <Windows.h> -#endif // __MINGW32__ +#include <windows.h> #include <fcntl.h> #include <io.h> #endif
Index: lldb/tools/lldb-vscode/VSCode.cpp =================================================================== --- lldb/tools/lldb-vscode/VSCode.cpp +++ lldb/tools/lldb-vscode/VSCode.cpp @@ -15,10 +15,8 @@ #include "llvm/Support/FormatVariadic.h" #if defined(_WIN32) -#ifndef __MINGW32__ #define NOMINMAX -#include <Windows.h> -#endif // __MINGW32__ +#include <windows.h> #include <fcntl.h> #include <io.h> #endif
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
