[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Mordante created this revision. Mordante added reviewers: Michael137, aprantl. Herald added a project: All. Mordante requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds the data formatters for chrono duration typedefs. Repository:

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Mordante added a comment. In D159127#4626311 , @kastiglione wrote: > Thanks for doing this! > > Question to all: Should the summary string include the unit? lldb doesn't > always show the type, so it could help comprehension if the unit is included. >

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Mordante marked 4 inline comments as done. Mordante added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:986-993 + "^std::__[[:alnum:]]+::chrono::" + "(((nano)|(micro)|(milli)|())seconds)|" + "(minutes)|" + "(hours)|"

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Mordante updated this revision to Diff 555763. Mordante marked an inline comment as done. Mordante added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159127/new/ https://reviews.llvm.org/D159127 Files: lldb/s

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

Mordante added a comment. Herald added subscribers: bviyer, jplehr. For libc++ we like to clean up the review queue for the GitHub PR transition. Is there still interest on working on this patch? If so would it be possible to finish it before the Phabricator is changed to read only mode? CHANG

[Lldb-commits] [PATCH] D116224: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

Mordante requested changes to this revision. Mordante added a comment. This revision now requires changes to proceed. This revision reverts more than intended. Since it now touches libcxx directory it requires libc++ approval. Please reduce the revert to the intended scope. Repository: rG LLV

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

Mordante added inline comments. Comment at: libcxx/utils/gdb/libcxx/printers.py:192 class StdStringPrinter(object): """Print a std::string.""" ldionne wrote: > philnik wrote: > > labath wrote: > > > philnik wrote: > > > > dblaikie wrote: > > > > > philnik

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

Mordante added inline comments. Comment at: libcxx/utils/gdb/libcxx/printers.py:192 class StdStringPrinter(object): """Print a std::string.""" labath wrote: > Mordante wrote: > > ldionne wrote: > > > philnik wrote: > > > > labath wrote: > > > > > philnik

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante created this revision. Herald added a reviewer: bollu. Herald added subscribers: Moerafaat, zero9178, Enna1, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiag

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante added a comment. In D137724#3917616 , @thieta wrote: > I think this is fine as we have discussed before. But I really dislike the > code duplication for the check. We could put it in a include() I guess - but > maybe it's not worth it. I wante

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante added a comment. In D137724#3917644 , @MaskRay wrote: > I think `if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)` checks for > standalone builds is not necessary. The check in `llvm/CMakeLists.txt` > suffices. > It's unlikely the users w

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante marked an inline comment as done. Mordante added a comment. Thanks for all reviews! In D137724#3974764 , @thieta wrote: > I think this is ready to land @Mordante or is there anything else missing? No but I've been quite busy. I needed some time

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rGd40dc417389e: [CMake] Warn when the version is older than 3.20.0. (authored by Mordante). Changed prior t

[Lldb-commits] [PATCH] D142007: [NFC] Fix "form/from" typos

Mordante added a comment. In D142007#4071765 , @pfusik wrote: > @ldionne Can you check it in? Can you provide your name and email address to we can attribute the patch to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D142007: [NFC] Fix "form/from" typos

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG898b5c9f5e77: [NFC] Fix "form/from" typos (authored by pfusik, committed by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D142007: [NFC] Fix "form/from" typos

Mordante added a comment. Thanks for your contribution, I just landed this patch on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142007/new/ https://reviews.llvm.org/D142007 ___ lldb-commit

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante created this revision. Mordante added reviewers: bollu, tstellar, mehdi_amini, MaskRay, ChuanqiXu, to268, kparzysz, thieta, tschuett, mgorny, stellaraccident, mizvekov, ldionne, jdoerfert, phosek. Herald added subscribers: libc-commits, libcxx-commits, Moerafaat, zero9178, Enna1, bzchee

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante updated this revision to Diff 499569. Mordante added a comment. Herald added a subscriber: mstorsjo. Try to fix AIX CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 Files: bolt/runtime/CMake

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante updated this revision to Diff 500547. Mordante added a comment. Rebased to test CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 Files: bolt/runtime/CMakeLists.txt clang/CMakeLists.txt c

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44c6b905f852: [CMake] Bumps minimum version to 3.20.0. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4349921 , @thakis wrote: > Reverted this and follow-ups in d763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6 > for now. > > Sorry this is such a pain to lan

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4349017 , @dyung wrote: > I'm not really sure where else to post this, but the pre-merge linux bot > still seems to be running 3.18.4. > > https://buildkite.com/llvm-project/premerge-checks/builds/152678#018828d2-1837

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4350148 , @thakis wrote: > https://github.com/llvm/llvm-project/issues/62719 is independent of chromium > and others have reported problems above too, from what I understand. Is that > not accurate? That bug report

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4356160 , @hans wrote: > In D144509#4350052 , @Mordante > wrote: > >> In D144509#4349921 , @thakis wrote: >> >>> Reverted this and fo

[Lldb-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

Mordante created this revision. Mordante added reviewers: glandium, hans, thakis. Herald added subscribers: libc-commits, bviyer, ekilmer, Moerafaat, zero9178, Enna1, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. I've created D151344 @glandium @hans @thakis I really would appreciate when you can test the patch locally to avoid another revert round. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[Lldb-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

Mordante accepted this revision. Mordante marked 3 inline comments as done. Mordante added a comment. In D151344#4368926 , @MaskRay wrote: > Thank you for making another try for the treewide change (which is admittedly > very painful and not many people

[Lldb-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rGcbaa3597aaf6: Reland "[CMake] Bumps minimum version to 3.20.0. (authored by Mor

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

Mordante added a comment. Since @ldionne approved this patch it's good to land. If you don't have commit access, can you provide "Your name" , then somebody can commit the change for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 _

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2c319fdc6b3: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR… (authored by gAlfonso-bit, committed by Mordante). Herald added a project: LLDB. Herald added a reviewer: libunwin

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

Mordante added a comment. In D159127#4654774 , @Michael137 wrote: > Was looking at leftover reviews, would be nice to land this Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159127/

[Lldb-commits] [PATCH] D159127: [lldb][libc++] Adds chrono data formatters.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4264ab1e7a: [lldb][libc++] Adds chrono data formatters. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. Thanks a lot for working on this! A few small nits, otherwise LGTM. Comment at: llvm/docs/DeveloperPolicy.rst:112 + +Please help notify users of potential disruptions whe

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

Mordante added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:129 + + People interested in joining the vendors group can do so by clicking the + "Join Project" link on the vendor's "Members" page in Phabricator. aaron.ballman wrote: > Mordante wrote

[Lldb-commits] [PATCH] D71857: Fixes -Wrange-loop-analysis warnings

Mordante created this revision. Mordante added reviewers: aaron.ballman, xbolva00. Mordante added projects: LLVM, LLDB, clang. Herald added subscribers: bmahjour, usaxena95, kadircet, arphaman, jkorous, kbarton, hiraditya, nemanjai, qcolombet, MatzeB. This avoids new warnings due to D68912

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante marked 2 inline comments as done. Mordante added a comment. Thanks for the review! I'll commit all the -Wrange-loop-analysis patches later today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71857/new/ https://reviews.llvm.org/D71857 ___

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante marked 8 inline comments as done. Mordante added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp:22 #include "lldb/Target/Process.h" #include "lldb/Utility/Log.h" xbolva0

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante updated this revision to Diff 235763. Mordante retitled this revision from "Fixes -Wrange-loop-analysis warnings" to "[NFC] Fixes -Wrange-loop-analysis warnings". Mordante added a comment. Reviewed the types and added a `*` for pointers and added a `const` when applicable. CHANGES SIN

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG8dc7b982b455: [NFC] Fixes -Wrange-loop-analysis warnings (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71857/new/ https://reviews.ll

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante added a comment. In D71857#1800663 , @MaskRay wrote: > However, I am afraid I don't like some of the fixes here. You can replace > `const auto` with `const auto &` and call that a fix... IMHO if the type is > not obvious, `const ConcreteType &`

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante added a comment. In D71857#1800663 , @MaskRay wrote: > I think there is a false positive. > > https://github.com/llvm/llvm-project/tree/master/lld/ELF/Relocations.cpp#L1622 > > for (const std::pair ts : isd->thunkSections) > Removing the `c