[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Wed, 01 Jan 2020 09:08:54 -0800 

Mordante marked 8 inline comments as done.
Mordante added inline comments.


================
Comment at: 
lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp:22
 
 #include "lldb/Target/Process.h"
 #include "lldb/Utility/Log.h"
----------------
xbolva00 wrote:
> NFC patch?
Changed to NFC.


================
Comment at: 
lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp:75
     return false;
-  for (const auto &param : call_inst->operand_values())
+  for (auto param : call_inst->operand_values())
     if (isRSAllocationPtrTy(param->getType()))
----------------
aaron.ballman wrote:
> `auto *`?
Changed to  `const auto *`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71857/new/

https://reviews.llvm.org/D71857



_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to