@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/101208
>From 515525357026eb49508b1322b3b9ee40840f7b5e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 29 Jul 2024 16:32:45 -0700
Subject: [PATCH 1/2] [lldb] Unify the way we get the Target in CommandOb
@@ -754,23 +754,29 @@ const char
*CommandObject::GetArgumentDescriptionAsCString(
return g_argument_table[arg_type].help_text;
}
-Target &CommandObject::GetDummyTarget() {
+Target &CommandObject::GetTarget(bool dummy) {
+ // Always return the dummy target if explicitly req
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/101208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> I was hoping to fix everything in one Pull Request so that it at least
> becomes usable once this merges.
The LLVM project generally
[prefers](https://llvm.org/docs/CodeReview.html#code-reviews-speed-and-reciprocity)
smaller patches as they're easier to review. We'll def
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/101243
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/101208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
This makes sense to me. LGTM if Jim is happy.
https://github.com/llvm/llvm-project/pull/101130
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
JDevlieghere wrote:
What I said was that, to the best of my knowledge, we don't have places in LLDB
that rely on `terminfo` but not on `ncruses`. I think that statement still
holds true. The assumption behind it was that `ncurses` provides a superset of
the functionality provided by `terminfo`
JDevlieghere wrote:
> Thanks @JDevlieghere! Could you add this special case?
I'm happy to help but I wouldn't feel comfortable making such a change without
being able to reproduce and test it.
> The authoritatively established and supported way to link with `ncurses` on
> most Linux platfor
Author: Jonas Devlieghere
Date: 2024-07-31T18:06:32-07:00
New Revision: 5dbbc3b14bb04ef4bf2cbf4c23008f94f4253704
URL:
https://github.com/llvm/llvm-project/commit/5dbbc3b14bb04ef4bf2cbf4c23008f94f4253704
DIFF:
https://github.com/llvm/llvm-project/commit/5dbbc3b14bb04ef4bf2cbf4c23008f94f4253704.d
@@ -2570,6 +2570,18 @@ void PruneThreadPlans();
/// information related to the process.
virtual StructuredData::DictionarySP GetMetadata() { return nullptr; }
+ /// Fetch extended crash information held by the process. This will never be
+ /// an empty shared pointe
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/101365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM if @medismailben is happy!
https://github.com/llvm/llvm-project/pull/101365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
Author: Jonas Devlieghere
Date: 2024-08-02T09:53:34-07:00
New Revision: c6ce324fa7fb2438b945fa1205b2a23138327e83
URL:
https://github.com/llvm/llvm-project/commit/c6ce324fa7fb2438b945fa1205b2a23138327e83
DIFF:
https://github.com/llvm/llvm-project/commit/c6ce324fa7fb2438b945fa1205b2a23138327e83.d
@@ -0,0 +1,42 @@
+# REQUIRES: python
+# RUN: %lldb -s %s -o exit | FileCheck %s
+
+scripting template list
+# CHECK:Available scripted extension templates:
+
+# CHECK: Name: OperatingSystemPythonInterface
+# CHECK-NEXT: Language: Python
+# CHECK-NEXT: Description: Mock thread s
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/101726
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM, this looks completely unused.
https://github.com/llvm/llvm-project/pull/101981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/101935
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Matej =?utf-8?q?Košík?=
Message-ID:
In-Reply-To:
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/101981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/102161
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Makes sense.
https://github.com/llvm/llvm-project/pull/102161
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -219,9 +219,9 @@ void ClangUserExpression::ScanContext(ExecutionContext
&exe_ctx, Status &err) {
// whatever runtime the debug info says the object pointer belongs to. Do
// that here.
-ClangASTMetadata *metadata =
-TypeSystemClang::DeclContextGetMetaD
https://github.com/JDevlieghere approved this pull request.
LGTM. Could we cover this scenario by the existing unit test?
https://github.com/llvm/llvm-project/pull/102097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
@@ -561,7 +562,85 @@ static void SetupLangOpts(CompilerInstance &compiler,
lang_opts.NoBuiltin = true;
}
-static void SetupImportStdModuleLangOpts(CompilerInstance &compiler) {
+// NOTE: should be kept in sync with sdkSupportsBuiltinModules in
+// Toolchains/Darwin.cpp
+stat
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/99362
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/99362
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
I haven't had a chance to review this, but I would appreciate if we can keep in
mind how this might affect breaking up the platforms. Right now, the Platform
abstraction covers two concepts:
1. How you connect to a platform and do things like transfer files, list
processe
JDevlieghere wrote:
Thanks @royitaqi! Once the formatting is fixed this is ready to be merged.
https://github.com/llvm/llvm-project/pull/102097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/101929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/102488
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. TILL about `qSpeedTest`.
https://github.com/llvm/llvm-project/pull/92124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/92124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> If this is split out from the other larger PR, should there be `clang/`
> changes in here?
+1, please unstage the `clang` and `openmp` changes.
https://github.com/llvm/llvm-project/pull/91858
___
lldb-commits mailing list
lldb-
JDevlieghere wrote:
> I'm pretty sure lldb was sending these events at some point, but that could
> have change since then. I slightly surprised that this wasn't caught before
> as that would mean noone is running these tests remotely.
>
> Jonas, are you running lldb tests in remote configurat
https://github.com/JDevlieghere commented:
Thanks!
https://github.com/llvm/llvm-project/pull/91688
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere requested changes to this pull request.
As per Aiden's suggestion, please split this up into smaller PRs, grouped by
subproject.
https://github.com/llvm/llvm-project/pull/91856
___
lldb-commits mailing list
lldb-commit
@@ -107,9 +107,20 @@ def test_process_unload(self):
self, "// Break here", lldb.SBFileSpec("main.cpp")
)
err = lldb.SBError()
-self.process().LoadImage(
-lldb.SBFileSpec(self.getBuildArtifact("libshared.so")), err
-)
+
https://github.com/JDevlieghere commented:
Could this use `os.devnull` to pick the right one based on the platform this is
running on?
```
self.do_test(["log enable -f '{}}' lldb commands".format(os.devnull)])
```
https://github.com/llvm/llvm-project/pull/92273
_
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/92268
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -207,11 +207,11 @@ def check_stack(self, process, pid, filename):
self.assertEqual(thread.GetStopReasonDataAtIndex(0), signal.SIGSEGV)
@skipIfLLVMTargetMissing("AArch64")
-def test_aarch64(self):
+def test_aarch64_C(self):
JDevlieghere w
@@ -147,12 +147,12 @@ def check_stack(self, process, pid, filename):
self.check_backtrace(thread, filename, backtrace)
@skipIfLLVMTargetMissing("AArch64")
-def test_aarch64(self):
+def test_aarch64_A(self):
JDevlieghere wrote:
Can we give
@@ -177,12 +177,12 @@ def check_stack(self, process, pid, filename):
self.assertEqual(thread.GetStopReasonDataAtIndex(0), 0)
@skipIfLLVMTargetMissing("AArch64")
-def test_aarch64(self):
+def test_aarch64_B(self):
JDevlieghere wrote:
`test_
https://github.com/JDevlieghere approved this pull request.
Thanks. LGTM!
https://github.com/llvm/llvm-project/pull/92281
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/92286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/92285
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/92273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/92320
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/92428
The README.md is what users see when they look for the extension in the
Marketplace [1]. Right now, it's a mix of developer documentation (for us) and
user documentation. This commit moves the developer doc
Author: Jonas Devlieghere
Date: 2024-05-16T09:54:47-07:00
New Revision: bd6c358d01f6ebc3851996e2c29c47b08e992525
URL:
https://github.com/llvm/llvm-project/commit/bd6c358d01f6ebc3851996e2c29c47b08e992525
DIFF:
https://github.com/llvm/llvm-project/commit/bd6c358d01f6ebc3851996e2c29c47b08e992525.d
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/92428
>From ca9fc570e4b721c36e5a0f9154e3158573bc5483 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 16 May 2024 09:44:57 -0700
Subject: [PATCH] [lldb-dap] Separate user and developer documentation
Th
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/92428
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
I don't think Alex is arguing in favor of keeping the old (wrong) behavior, but
the first file looks like this:
```
foundSpec = False
if [...]
foundSpec = True
[...]
if foundSpec is False:
```
It's pretty obvious this is a boolean and should use `if not foundSpec`.
http
JDevlieghere wrote:
The stream already knows whether color support is enabled, but it looks like
we're only storing that in the underlying llvm stream, which is commonly used
in combination with `WithColor`. I think we could add a member to check if the
stream has colors enabled. It's already
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/92470
None
>From 3bd3650ad624c1d45b118eb1d5bebc2732371b9d Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 16 May 2024 15:46:36 -0700
Subject: [PATCH] [lldb] Include SBLanguages in the SWIG bindings
-
JDevlieghere wrote:
> Actually, this has no dependency tracking. You'll need to add that for this
> to work every time.
It does actually, that's what the `SWIG_HEADERS` glob is used for.
https://github.com/llvm/llvm-project/pull/92470
___
lldb-commi
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/92470
>From 3bd3650ad624c1d45b118eb1d5bebc2732371b9d Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 16 May 2024 15:46:36 -0700
Subject: [PATCH 1/2] [lldb] Include SBLanguages in the SWIG bindings
---
https://github.com/JDevlieghere approved this pull request.
The change looks fine. Was this done with by hand or with the help of a script?
If so please put that in the commit message so we can do the same downstream.
https://github.com/llvm/llvm-project/pull/92476
_
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/92470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
This should really be broken up into separate PRs per subproject. One large PR
like this makes reviewing harder and causes unnecessary churn in the case that
this gets reverted.
https://github.com/llvm/llvm-project/pull/91857
_
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/92490
Reverts llvm/llvm-project#92470
>From ebb9f82e4c6f9b7c6f627da71ffbfb858f655d1e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 16 May 2024 19:58:44 -0700
Subject: [PATCH] Revert "[lldb] Include
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/92490
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> It's a `sed s/== None/is None/g` - what is there to review? 10 separate
> commits/PRs for the same exact `sed` costs more in commit noise (and effort
> on the part of @e-kwsm) than one solid, patient, review here.
In addition to what @ftynse said above, the `sed` might no
JDevlieghere wrote:
> @JDevlieghere @adrian-prantl are there plans to change the presentation layer
> to prevent this kind of shadowing in the future? Would be nice if all we
> needed to do was report progress, and not worry about other progress events
> in the debugger being in-flight
No, on
Author: Jonas Devlieghere
Date: 2024-05-17T09:58:56-07:00
New Revision: d74bc823beabbb7067a4b4ae2d69a36d874f5132
URL:
https://github.com/llvm/llvm-project/commit/d74bc823beabbb7067a4b4ae2d69a36d874f5132
DIFF:
https://github.com/llvm/llvm-project/commit/d74bc823beabbb7067a4b4ae2d69a36d874f5132.d
Author: Jonas Devlieghere
Date: 2024-05-17T10:12:51-07:00
New Revision: a4ad05284e97dd188c44252846486cbfb74a884c
URL:
https://github.com/llvm/llvm-project/commit/a4ad05284e97dd188c44252846486cbfb74a884c
DIFF:
https://github.com/llvm/llvm-project/commit/a4ad05284e97dd188c44252846486cbfb74a884c.d
Author: Jonas Devlieghere
Date: 2024-05-17T14:00:24-07:00
New Revision: bdfb04a63d73c31ee75395064762d0d6ccb45819
URL:
https://github.com/llvm/llvm-project/commit/bdfb04a63d73c31ee75395064762d0d6ccb45819
DIFF:
https://github.com/llvm/llvm-project/commit/bdfb04a63d73c31ee75395064762d0d6ccb45819.d
JDevlieghere wrote:
> @JDevlieghere I know we discussed this in the past and it made sense to me,
> but I'm right now failing to connect the dots. Why couldn't the same
> single-line interface be used to print nested events something like this?
>
> ```
> Evaluating expression > Type Checking >
Author: Jonas Devlieghere
Date: 2024-05-17T18:43:09-07:00
New Revision: 1e9324a8c734aaa933d2672522cc22d5022c6200
URL:
https://github.com/llvm/llvm-project/commit/1e9324a8c734aaa933d2672522cc22d5022c6200
DIFF:
https://github.com/llvm/llvm-project/commit/1e9324a8c734aaa933d2672522cc22d5022c6200.d
JDevlieghere wrote:
> Hello all. I am wondering what I can do to advance this patch? I think it is
> required to support process save-core in linux for lldb. I'd love to move
> this before adding static methods in ThreadEfCore.h to produce populated
> prpsinfo and prstatus structs for inclusio
JDevlieghere wrote:
No objections in the context of LLDB. We don't use terminfo directly (although
I think editline does, but that isn't affected by this) and if we want the TUI
we depend on curses anyway.
https://github.com/llvm/llvm-project/pull/92865
__
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/92953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -44,10 +45,20 @@ bool DWARFDebugInfoEntry::Extract(const DWARFDataExtractor
&data,
const DWARFUnit *cu,
lldb::offset_t *offset_ptr) {
m_offset = *offset_ptr;
+ auto report_error = [&](const char *fmt, co
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/93006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/93169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/93209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
I'm in favor of this. I rarely have a meaningful error code and it makes the
code needlessly verbose.
I was going to ask if we wanted to make an overload of the existing
`createStringError` but without the error code. But then I noticed that it uses
@@ -87,8 +87,8 @@ llvm::Error Socket::Initialize() {
if (err == 0) {
if (wsaData.wVersion < wVersion) {
WSACleanup();
- return llvm::make_error(
- "WSASock version is not expected.", llvm::inconvertibleErrorCode());
+ return llvm::createStringErro
@@ -335,3 +335,14 @@ TypeSystemMap::GetTypeSystemForLanguage(lldb::LanguageType
language,
}
return GetTypeSystemForLanguage(language);
}
+
+bool TypeSystem::SupportsLanguageStatic(lldb::LanguageType language) {
+ if (language == eLanguageTypeUnknown)
+return false;
+
@@ -331,6 +333,7 @@ struct DAP {
// "Content-Length:" field followed by the length, followed by the raw
// JSON bytes.
void SendJSON(const std::string &json_str);
+ bool bp_initted;
JDevlieghere wrote:
This should be next to `exception_breakpoints`, but
https://github.com/JDevlieghere approved this pull request.
Normally I'd ask splitting upcross-project PRs, but this one is trivial and
very unlikely to be cause churn :-) LGMT.
https://github.com/llvm/llvm-project/pull/93260
___
lldb-commits mailing
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/93332
AppleObjCTypeEncodingParser::BuildObjCObjectPointerType currently contains an
lldbassert to detect situations where we have a forward declaration without a
definition. According to the accompanying comment,
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/87550
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/87550
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -61,40 +61,37 @@ DAP::DAP()
DAP::~DAP() = default;
void DAP::PopulateExceptionBreakpoints() {
+ exception_breakpoints = {};
if (debugger.SupportsLanguage(lldb::eLanguageTypeC_plus_plus)) {
-exception_breakpoints.emplace_back(
+exception_breakpoints->emplace_back
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/93332
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-05-28T10:36:20-07:00
New Revision: f69b6d2c99a10847a2d73c7fcd656d2ae22937ce
URL:
https://github.com/llvm/llvm-project/commit/f69b6d2c99a10847a2d73c7fcd656d2ae22937ce
DIFF:
https://github.com/llvm/llvm-project/commit/f69b6d2c99a10847a2d73c7fcd656d2ae22937ce.d
JDevlieghere wrote:
`LLDB_CURSES_LIBS` is scoped to lldbCore, which the EditLine unit test isn't
linking. If its also necessary in Host, then we should hoist it up and link
both libraries against it.
Anyway, that also means my initial assessment was wrong. I looked for the
header include but
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/93712
Use the packaging [1] module for parsing version numbers, instead of
pkg_resources which is distributed with setuptools. I recently switched over to
using the latter, knowing it was deprecated (in favor of
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/93714
Remove setupterm workaround on macOS which caused an issues after the removal
of the terminfo dependency. There's a comment that explains why the workaround
is present, but neither Jim nor I were able to re
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/93714
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> At least at present, this will probably break Fuchsia's build; the Python we
> ship includes `pkg_resources` but not `packaging`. Is the default `cpython`
> build from source intended to build and install `packaging`? Is this
> something that changed recently?
I'm not su
@@ -519,9 +519,9 @@ def _find_windows_sdk_in_registry_view(self, view):
# Windows SDK version numbers consist of 4 dotted components, so we
# have to use LooseVersion, as StrictVersion supports 3 or fewer.
JDevlieghere wrote:
No, it do
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/93712
>From 4666a6a6470fc91ed17a9e60624a005dc97c4531 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 29 May 2024 10:36:47 -0700
Subject: [PATCH 1/2] [lldb] Use packaging module instead of pkg_resources
JDevlieghere wrote:
GreenDragon now has `packaging` and based on David's message, the Linaro bots
do as well.
@labath Does your ✅ mean the
[debian](https://lab.llvm.org/buildbot/#/builders/68) bot has this package
installed?
@mysterymath Can you install this package on the Fuchia bots? I as
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/93880
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -442,16 +443,19 @@ lldb::Format
FormatManager::GetSingleItemFormat(lldb::Format vector_format) {
}
bool FormatManager::ShouldPrintAsOneLiner(ValueObject &valobj) {
+ TargetSP target_sp = valobj.GetTargetSP();
// if settings say no oneline whatsoever
- if (valobj.GetTa
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/93946
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/93946
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
401 - 500 of 5286 matches
Mail list logo
