[Lldb-commits] [PATCH] D104221: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104221/new/ https://reviews.llvm.org/D104221 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

JDevlieghere added a comment. I'm a little suspicious about the changes to `conf.py`. Can you explain why they're necessary and what they're fixing? Comment at: lldb/docs/conf.py:32-33 # set by CMake. -sys.path.insert(0, os.getenv("LLDB_SWIG_MODULE")) +if os.geten

[Lldb-commits] [PATCH] D104893: Add data formatter support for a missing NSDictionary variant

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104893/new/ https://reviews.llvm.org/D104893 ___

[Lldb-commits] [PATCH] D104407: Improve path remapping in cross-debugging scenarios

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with a few nits Comment at: lldb/source/Target/PathMappingList.cpp:160 +auto e = llvm::sys::path::end(components); +if (component != e && +ll

[Lldb-commits] [PATCH] D104951: [lldb] Use the non-locking variant of objc_copyRealizedClassList

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. JDevlieghere requested review of this revision. Avoid standing the Objective-C runtime lock by calling `objc_copyRealizedClassList_nolock` instead of `objc_copyRealizedClassList`. We already guarantee that no other threa

[Lldb-commits] [PATCH] D104951: [lldb] Use the non-locking variant of objc_copyRealizedClassList

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGffc053385587: [lldb] Use the non-locking variant of objc_copyRealizedClassList (authored by JDevlieghere). Herald added a project: LLDB. Repository:

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/InterpreterProperties.td:18 +DefaultStringValue<"">, +Desc<"A path where LLDB will save the session's transcripts.">; def StopCmdSourceOnError: Property<"stop-command-source-on-error", "Boolean">,

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Interpreter/InterpreterProperties.td:18 +DefaultStringValue<"">, +Desc<"A path where LLDB will save the session's transcripts

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2977 + result.SetStatus(eReturnStatusSuccessContinuingResult); result.AppendMessageWithFormat("Session's transcripts saved to %s\n", Why `eReturnStatusSuccessCont

[Lldb-commits] [PATCH] D104406: Express PathMappingList::FindFile() in terms of PathMappingList.h::RemapPath() (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM too CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104406/new/ https://reviews.llvm.org/D104406 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D104405: Change PathMappingList::FindFile to return an optional result (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM modulo formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104405/new/ https://reviews.llvm.org/D104405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

JDevlieghere added inline comments. Comment at: lldb/lldb/test/Shell/Breakpoint/breakpoint-command.test:1 +# RUN: %build %p/Inputs/dummy-target.c -o %t.out +# RUN: %lldb %t.out -o 'b main' -o 'break command add 1 -o "script print(95000 + 126)"' -o 'r' thakis wro

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

JDevlieghere added inline comments. Comment at: lldb/lldb/test/Shell/Breakpoint/breakpoint-command.test:1 +# RUN: %build %p/Inputs/dummy-target.c -o %t.out +# RUN: %lldb %t.out -o 'b main' -o 'break command add 1 -o "script print(95000 + 126)"' -o 'r' JDevlieghe

[Lldb-commits] [PATCH] D105060: [LLDB] dotest.py set selected_platform on remote connection

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105060/new/ https://reviews.llvm.org/D105060 ___ lldb-commits maili

[Lldb-commits] [PATCH] D105136: [lldb Look for the mangled objc_copyRealizedClassList_nolock symbol name

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. JDevlieghere requested review of this revision. When we check if the `objc_copyRealizedClassList_nolock` we need to check for the mangled symbol rather than than the unmangled one as we did for the locking objc_copyReali

[Lldb-commits] [PATCH] D105136: [lldb] Check for the mangled symbol name for objc_copyRealizedClassList_nolock

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71be4db05bbd: [lldb] Check for the mangled symbol name for objc_copyRealizedClassList_nolock (authored by JDevlieghere). Herald added a project: LLDB

[Lldb-commits] [PATCH] D105134: [jenkins] Update script to use cross-project lit test suite

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM! Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105134/new/ https://reviews.llvm.org/D105134 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D100262: [lldb] [gdb-remote client] Support switching PID along with TID

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h:337 - llvm::Optional SendSetCurrentThreadPacket(uint64_t tid, char type); + llvm::Optional> + SendSetCurrentThreadPacket(uint64_t tid, uint64_t pid, char ty

[Lldb-commits] [PATCH] D100261: [lldb] [gdb-remote server] Support selecting process via Hg

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I'm probably not the most qualified to sign off on this, but the review has stalled and I don't see anything obviously wrong here so LGTM. Comment at: lldb/sour

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

JDevlieghere added a comment. There are a bunch of unrelated changes in this patch. Can you please drop them or split them off into a separate patch? Comment at: lldb/docs/conf.py:180-182 +# Add any extra stylesheets and scripts here. +html_css_files = ['lldb.css'] +html_js_fi

[Lldb-commits] [PATCH] D100459: [lldb] [gdb-remote client] Refactor SetCurrentThread*()

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2613 + packet.PutChar(op); if (tid == UINT64_MAX) +packet.PutCSt

[Lldb-commits] [PATCH] D100261: [lldb] [gdb-remote server] Support selecting process via Hg

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2121 +return SendErrorResponse(llvm::make_error( +inconvertibleErrorCode(), "Malformed thread-id")); + mgorny wrote: > JDevlie

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, jingham, clayborg. Herald added a subscriber: dang. JDevlieghere requested review of this revision. Add the ability to silence `command script import`. The motivation for this change is being able to add `command script

[Lldb-commits] [PATCH] D100262: [lldb] [gdb-remote client] Support switching PID along with TID

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! LGTM Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h:588-590 + lldb::pid_t m_curr_pid = + LLDB_INVALID_PROCESS_ID

[Lldb-commits] [PATCH] D105366: [lldb/test] Fix failure caused by synthetic symbol name changes

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I see this is failing on GreenDragon. We should go ahead and land this and deal with potential post-commit review feedback if there is any. LGTM. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D105160: Create synthetic symbol names on demand to improve memory consumption and startup times.

JDevlieghere added a comment. I'm sorry to be the bearer of bad news but this breaks `macosx/dyld-trie-symbols/TestDyldTrieSymbols.py`. Given that it's Friday I'm going to revert to turn the bot green for the (holiday) weekend. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/33379/tes

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

JDevlieghere accepted this revision. JDevlieghere added a comment. Nice! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105034/new/ https://reviews.llvm.org/D105034 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103172/new/ https://reviews.llvm.org/D103172 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

JDevlieghere updated this revision to Diff 357037. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. - Address code review feedback - Use `LoadScriptOptions` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105327/new/ https://reviews.llvm.org/D105327 Files: l

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:2795 Locker::FreeAcquiredLock | - (init_session ? Locker::TearDownSession : 0)); + (init_session ? L

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. I kept the existing behavior everywhere except when `--silent` is passed. I also don't think "being interactive" is a good enough discriminator, I can imagine some people might want to see the work done by the script. H

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9517353959b: [lldb] Add the ability to silently import scripted commands (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [PATCH] D105914: [lldb] Make TargetList iterable

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. JDevlieghere requested review of this revision. Make it possible to iterate over the TargetList. https://reviews.llvm.org/D105914 Files: lldb/include/lldb/Target/TargetList.h Index: lldb/include/lldb/Target/TargetLi

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:402-403 case DW_AT_type: - type = form_value; + if (!type.IsValid()) +type = form_value; break; What's the purpose of this?

[Lldb-commits] [PATCH] D105998: Create synthetic symbol names on demand to improve memory consumption and startup times.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Greg! Assuming this passes on the bot this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105998/new/ https://reviews.ll

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:5504-5513 + WatchpointList &wps = GetTarget().GetWatchpointList(); + size_t wp_count = wps.GetSize(); + for (size_t i = 0; i < wp_count; ++i) { +WatchpointSP wp = w

[Lldb-commits] [PATCH] D106004: [lldb] Always call DestroyImpl from Process::Finalize

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. JDevlieghere requested review of this revision. Always destroy the process, regardless of its private state. This will call the virtual function DoDestroy under the hood, giving our derived class a chance to do the neces

[Lldb-commits] [PATCH] D105914: [lldb] Make TargetList iterable

JDevlieghere updated this revision to Diff 358720. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105914/new/ https://reviews.llvm.org/D105914 Files: lldb/include/lldb/Target/TargetList.h lldb/source/Core/Debugger.cpp Index: lldb/source/Core/Debugger.cpp

[Lldb-commits] [PATCH] D106004: [lldb] Always call DestroyImpl from Process::Finalize

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e4a417ee639: [lldb] Always call DestroyImpl from Process::Finalize (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [PATCH] D105914: [lldb] Make TargetList iterable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde448c0a9e50: [lldb] Make TargetList iterable (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D106122: Add a mutex to guard access to the ThreadPlanStack class

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Target/ThreadPlanStack.h:113 std::unordered_map m_completed_plan_store; + mutable std::recursive_mutex m_stack_mutex; }; --

[Lldb-commits] [PATCH] D106270: [DWARF5] Fix offset check when using .debug_names

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:82 + const DWARFUnit &non_skeleton_cu = cu.GetNonSkeletonUnit(); DWARFMappedHash::DIEInfoArray hash_data; I assume the `const` of the `DWARFUnit` is bei

[Lldb-commits] [PATCH] D106263: [lldb] Make WatchpointList iterable

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Comment at: lldb/include/lldb/Breakpoint/WatchpointList.h:193 + WatchpointIterable Watchpoints() const { +return WatchpointIterable(m_watchpo

[Lldb-commits] [PATCH] D106324: Remove debugserver support for the DarwinLog StructuredData streaming service, lldb tests for it

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106324/new/ https://reviews.llvm.org/D106324 ___

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:125-126 +return Decode(thread)->GetRawTraceSize(); + else +return None; +} No else after return. Seems like a good candidate for a ternary operator. CHA

[Lldb-commits] [PATCH] D106348: Write the # of addressable bits into Mach-O corefiles, read it back out again

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:5575-5613 +addr_t ObjectFileMachO::GetAddressMask() { + addr_t mask = 0; + ModuleSP module_sp(GetModule()); + if (module_sp) { +std::lock_guard guard(module_sp->GetMut

[Lldb-commits] [PATCH] D106122: Add a mutex to guard access to the ThreadPlanStack class

JDevlieghere added a comment. Fair enough. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106122/new/ https://reviews.llvm.org/D106122 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

JDevlieghere accepted this revision. JDevlieghere added a comment. Adrian said "Let's do it!" on the mailing list so LGTM for Darin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 ___

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

JDevlieghere added a comment. In D106584#2907898 , @jasonmolenda wrote: > Looks good! Maybe we should add a setting like > target.file-cache-memory-reads-verify (a boolean) to enable/disable this > check instead of keying off NDEBUG. We can turn it o

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. IIRC the fact that the shared pointer is null is implementation defined and the standard just says that a moved-from object is in an undefined state. Comment at:

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

JDevlieghere added a comment. Should this be enabled in the test suite? (`packages/Python/lldbsuite/test/lldbtest.py:783`, `test/Shell/lit-lldb-init.in`) Comment at: lldb/source/Target/Target.cpp:1773 + if (load_addr != LLDB_INVALID_ADDRESS) { +uint8_t *l

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

JDevlieghere accepted this revision. JDevlieghere added a comment. Seems like this is still missing form `lit-lldb-init.in` which means the shell tests (and by extension the Swift REPL tests downstream) will run with the setting off. Other than that this LGTM. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

JDevlieghere added a comment. I'm supportive of this effort, but if we're removing the plaintext format, I think it's worth sending this out as an RFC. In D107079#2913760 , @teemperor wrote: > Some general notes: > > - Why JSON? In LLVM we have pretty m

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106171/new/ https://reviews.llvm.org/D106171 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D107179: [lldb] Fix remote macOS debugging on Apple Silicon

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a subscriber: kristof.beyls. JDevlieghere requested review of this revision. Update ARMGetSupportedArchitectureAtIndex to consider remote macOS debugging. Currently, it defaults to an iOS triple when IsHo

[Lldb-commits] [PATCH] D107179: [lldb] Fix remote macOS debugging on Apple Silicon

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ad854c41e2b: [lldb] Fix remote macOS debugging on Apple Silicon (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Git

[Lldb-commits] [PATCH] D107206: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, teemperor. JDevlieghere requested review of this revision. As I was trying to understand what `IRExecutionUnit::FindInSymbols` was doing, I couldn't help myself but refactor the code a little bit: - No else after return.

[Lldb-commits] [PATCH] D107015: Add "current" token for the -t option to "break set/modify"

JDevlieghere added a comment. Instead of using the token `current`, wouldn't it feel more natural to allow an empty value more natural? Would we reject that before we get to the option parsing code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[Lldb-commits] [PATCH] D107255: [lldb] Get rid of HAVE_SIGACTION

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107255/new/ https://reviews.llvm.org/D107255 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, jingham. JDevlieghere requested review of this revision. Rather than passing two bools (next to each other), use a struct instead. https://reviews.llvm.org/D107295 Files: lldb/include/lldb/Core/Module.h lldb/includ

[Lldb-commits] [PATCH] D107297: [RFC/WIP] Only look at the symbol table when resolving JIT symbols

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, jingham, clayborg. JDevlieghere requested review of this revision. When resolving missing symbols for the JIT, only look at the symbol table and skip the debug info. I can't think of a situation where we want to resolve

[Lldb-commits] [PATCH] D107297: [RFC/WIP] Only look at the symbol table when resolving JIT symbols

JDevlieghere abandoned this revision. JDevlieghere added a comment. Jim reminded me of static functions, which won't have a symbol, so this is actually pretty common. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107297/new/ https://reviews.llvm.org/D107297 ___

[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

JDevlieghere updated this revision to Diff 363536. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Thanks, updated the diff accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107295/new/ https://reviews.llvm.org/D107295 Files: lldb/include/lldb/Co

[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

JDevlieghere updated this revision to Diff 363887. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107295/new/ https://reviews.llvm.org/D107295 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Core/ModuleList.h lldb/source/API/SBModule.cpp lldb/source/API/SBTarget.cpp lld

[Lldb-commits] [PATCH] D107206: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

JDevlieghere updated this revision to Diff 363908. JDevlieghere added a comment. Convert lambda into a stateful class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107206/new/ https://reviews.llvm.org/D107206 Files: lldb/source/Expression/IRExecutionUnit.cpp Index: lldb/source/Expr

[Lldb-commits] [PATCH] D107206: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Expression/IRExecutionUnit.cpp:785 + auto get_external_load_address = + [target, &symbol_was_missing_weak]( + lldb::addr_t &load_address, lldb::addr_t &best_i

[Lldb-commits] [PATCH] D107446: [lldb] Stop referencing "host_lib" in cmake files

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107446/new/ https://reviews.llvm.org/D107446 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D106984: [lldb] [gdb-remote] Add eOpenOptionReadWrite for future gdb compat

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Host/File.h:47-61 +eOpenOptionReadOnly = (1u << 0), // Open file for reading (only) +eOpenOptionWriteOnly = (1u << 1), // Open file for writing (only) +eOpenOptionReadWrite = +eOpenOptionReadOn

[Lldb-commits] [PATCH] D107444: [lldb] Remove a few unused .exports files

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Yup, we only use the main export file. Thanks for cleaning this up. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107444/new/ https://reviews.llvm.org/D107444 _

[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc020be17ce0a: [lldb] Use a struct to pass function search options to Module::FindFunction (authored by JDevlieghere). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D107206: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGa46bcc60e52f: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC) (authored by JDevlieghere). Herald

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

JDevlieghere created this revision. JDevlieghere added reviewers: friss, jingham. JDevlieghere requested review of this revision. Upstream support for NSConstantArray, NSConstantIntegerNumber, NSConstant{Float,Double}Number and NSConstantDictionary. We would've upstreamed this earlier but testin

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

JDevlieghere updated this revision to Diff 364869. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. - Use `ReadPointerFromMemory` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107660/new/ https://reviews.llvm.org/D107660 Files: lldb/source/Plugins/Language

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:509 +float flt_value = 0.0f; +memcpy(&flt_value, &flt_as_int, sizeof(flt_as_int)); +NSNumber_FormatFloat(valobj, stream, flt_value, options.GetLanguage()); jin

[Lldb-commits] [PATCH] D107673: Use LC_DYLD_EXPORTS_TRIE to locate the dyld trie structure if present

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107673/new/ https://reviews.llvm.org/D107673 ___

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34d78b6a6755: [lldb] Upstream support for Foundation constant classes (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to com

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

JDevlieghere added a comment. Yep, I'm looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107660/new/ https://reviews.llvm.org/D107660 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

JDevlieghere added a comment. In D107660#2932321 , @saugustine wrote: > Thanks for looking. Reverted with 4e5af6ef48590e7248e344ddabf245bb3de71c51 > . What's the point of giving a hea

[Lldb-commits] [PATCH] D107660: [lldb] Upstream support for Foundation constant classes

JDevlieghere added a comment. In D107660#2932334 , @saugustine wrote: > Some people complain if I revert without notification. So I always notify as > soon as I find the patch with the problem. Some reverts are more complicated > than others too. > > I

[Lldb-commits] [PATCH] D107679: [lldb] Move Objective-C constants into ObjCConstants.h

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. JDevlieghere requested review of this revision. Move Objective-C constants into ObjCConstants.h and share them between Cocoa and AppleObjCTypeEncodingParser. https://reviews.llvm.org/D107679 Files: lldb/source/Plugin

[Lldb-commits] [PATCH] D107679: [lldb] Move Objective-C constants into ObjCConstants.h

JDevlieghere updated this revision to Diff 364916. JDevlieghere added a comment. Formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107679/new/ https://reviews.llvm.org/D107679 Files: lldb/source/Plugins/Language/ObjC/Cocoa.cpp lldb/source/Plugins/Language/ObjC/ObjCConstants.

[Lldb-commits] [PATCH] D107679: [lldb] Move Objective-C constants into ObjCConstants.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47a889c668f9: [lldb] Move Objective-C constants into ObjCConstants.h (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [PATCH] D107701: [lldb] [test] Skip Expr/nodefaultlib.cpp test if LD_PRELOAD Is used

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107701/new/ https://reviews.llvm.org/D107701 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D107700: [lldb] [cmake] Add LLVM_LIT_ARGS override support for standalone builds

JDevlieghere added a comment. In D107700#2935385 , @mgorny wrote: > @JDevlieghere, could you also look at this one? I'm not really sure if > anybody maintains LLDBStandalone at this point. I think it's pretty much just me these days. I would really like

[Lldb-commits] [PATCH] D107700: [lldb] [cmake] Add LLVM_LIT_ARGS override support for standalone builds

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A possible alternative would be to export LLVM_LIT_ARGS from the llvm build so that lldb inherits it. I'm pretty much on the fence: on the one hand this doesn't really seems like s

[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

JDevlieghere added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:291 - PyErr_Cleaner py_err_cleaner(true); Unrelated whitespace change? Comment at: lldb/include/lldb/Interpreter/ScriptedInterface.h:25 + virtual S

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:305 + "ScriptedProcess::%s ERROR = %s", __FUNCTION__, + message.str().c_str()); +return false; Same comment as in the other revi

[Lldb-commits] [PATCH] D108053: [lldb] skip host build for lldb_tblgen with LLDB_TABLEGEN_EXE set

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108053/new/ https://reviews.llvm.org/D108053

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

JDevlieghere added inline comments. Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:148 + +std::string proc_fd_path = "/proc/self/fd"; +std::error_code EC; MaskRay wrote: > Can this be a StringRef? Comment at: lldb/sour

[Lldb-commits] [PATCH] D108228: Fix error handling in the libcxx std::string formatter

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM module formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108228/new/ https://reviews.llvm.org/D108228

[Lldb-commits] [PATCH] D108228: Fix error handling in the libcxx std::string formatter

JDevlieghere added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp:102 +std::string *not_a_string = (std::string *) 0x0; +touch_string(*not_a_string); return 0; shafik wrote: > This

[Lldb-commits] [PATCH] D105732: [lldb] Update logic to close inherited file descriptors.

JDevlieghere accepted this revision. JDevlieghere added a comment. Small nit about the comments, but otherwise LGTM Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:160 +// Don't close first three entries since they are +// stdin/stdout/stderr +

[Lldb-commits] [PATCH] D108078: [lldb] Support gdbserver signals

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1344 "qEcho+", + "native-signals+", };

[Lldb-commits] [PATCH] D108078: [lldb] Support gdbserver signals

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Didn't mean to accept yet (originally I thought the native-signals check was inverted) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108078/new/ https://reviews

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. I'm not convinced this warrants a whole new section. Especially since this is focussed on lldb developers rather than end users. Could we move this under the resources/te

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Move best-practices.txt contain to resources/test.rst

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks for the quick turnaround! This LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D10881

[Lldb-commits] [PATCH] D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO

JDevlieghere added a comment. Nice catch, LGTM but I'll defer to Greg to accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108889/new/ https://reviews.llvm.org/D108889 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion using file path.

JDevlieghere added a comment. Thanks for the patch. Can you please add a regression test that covers the previously crashing behavior? I think something like `TestIOHandlerCompletion.py` might serve as inspiration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108515/new/ https://reviews.llvm.org/D108515 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D109101: [lldb] Add an option to specify a VFS overlay

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, clayborg, teemperor, labath. Herald added a subscriber: dang. JDevlieghere requested review of this revision. Add the ability to specify a VFS overlay to the command line driver. The motivation for this functionality is to

<    19   20   21   22   23   24   25   26   27   28   >