JDevlieghere added inline comments.
================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:305
+ "ScriptedProcess::%s ERROR = %s", __FUNCTION__,
+ message.str().c_str());
+ return false;
----------------
Same comment as in the other review: no need to allocate a std::string here.
================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:309-320
+ Status error;
+ lldb::ThreadSP thread_sp;
+ ScriptLanguage language = m_interpreter->GetLanguage();
+
+ if (language != eScriptLanguagePython)
+ return error_with_message(
+ (llvm::Twine("ScriptInterpreter language (") +
----------------
================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:109
+const char *ScriptedThread::GetQueueName() {
+ if (m_name.empty()) {
+ CheckInterpreterAndScriptObject();
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107585/new/
https://reviews.llvm.org/D107585
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
