[Lldb-commits] [PATCH] D74388: [lldb/test] Add alternate symbol to StackFrame Recognizer

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. > This patch reverts commit 6b2979c12300b90a1e69791d43ee9cff14f4265e > The patch is already reverted, this p

[Lldb-commits] [PATCH] D74566: Fix lldb-vscode logging and enable logging for all lldb-vscode tests.

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:136 + << json_str << std::endl; + } + I had this chunk in a local patch, thanks. Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D74637: Unify DIERef vs. user_id_t

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: aprantl. As discussed in D73206 there is both `DIERef` and `user_id_t`

[Lldb-commits] [PATCH] D74670: Simplify user_id_t -> size_t

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: aprantl. Herald added a reviewer: jdoerfert. As discussed in D73206 sim

[Lldb-commits] [PATCH] D74690: Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie()

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added a reviewer: shafik. Reasons are the same as: D74637 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74690 Fi

[Lldb-commits] [PATCH] D74670: Simplify user_id_t -> size_t

This revision was automatically updated to reflect the committed changes. Closed by commit rG516ba158b689: [lldb] [nfc] Simplify user_id_t -> size_t (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74670/new/ https://review

[Lldb-commits] [PATCH] D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map

jankratochvil added a comment. In D74637#1878655 , @labath wrote: > In fact, this field used to hold a DIERef until I changed that in D63322 > . I did not expect that. OK, this D74637 +

[Lldb-commits] [PATCH] D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map

jankratochvil added a comment. In D74637#1878720 , @labath wrote: > the MainCU is stored in the DIERef, which you now say you want to change. Just some wording: If MainCU was in `DIERef` then MainCU needs to be also in `DWARFDIE` which means `DWARFDIE`

[Lldb-commits] [PATCH] D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map

This revision was automatically updated to reflect the committed changes. Closed by commit rG217808887918: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[Lldb-commits] [PATCH] D74690: Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie()

jankratochvil updated this revision to Diff 244976. jankratochvil added a comment. Sorry for that `DenseMap::insert`, I see it is the same as `std::map`, I should study `DenseMap` more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74690/new/ http

[Lldb-commits] [PATCH] D74690: Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie()

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa3e99dc859f: [lldb] [nfc] Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie() (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D74690?vs=244976&id=245185#toc Re

[Lldb-commits] [PATCH] D76316: [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles

jankratochvil created this revision. jankratochvil added reviewers: labath, JDevlieghere. jankratochvil added a project: LLDB. jankratochvil edited the summary of this revision. D63643 added these testfiles but some of the `%t4dwo` and `%t5dwo` builds are the sam

[Lldb-commits] [PATCH] D76316: [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles

jankratochvil updated this revision to Diff 250903. jankratochvil added a comment. With the former patch these both skeleton files: tools/lldb/test/SymbolFile/DWARF/Output/debug-types-expressions.test.tmp4dwo tools/lldb/test/SymbolFile/DWARF/Output/debug-types-expressions.test.tmp5dwo were r

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

jankratochvil added a comment. In D73206#1871895 , @labath wrote: > Yep. It may be interesting to try this out on regular dwo first. Right now, > dwo dodges this problem by storing a CompileUnit pointer on both skeleton and > split units. If we can make

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

jankratochvil added a comment. In D73206#1928869 , @labath wrote: > But I'm not sure that removing `GetBaseSymbolFile` is the right way to start > that, as without it you cannot implement the redirection. Current code is: SymbolFileDWARF::DIEToTypePt

[Lldb-commits] [PATCH] D76316: [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles

This revision was automatically updated to reflect the committed changes. Closed by commit rG3481062bc688: [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

jankratochvil added a comment. On Fedora 31 x86_64 with LLDB using python3 I got: llvm-lit: .../llvm-monorepo2/llvm/utils/lit/lit/TestingConfig.py:102: fatal: unable to parse config file '.../llvm-monorepo2-clangassert/tools/lldb/test/Shell/lit.site.cfg.py', traceback: Traceback (most recent

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

jankratochvil added inline comments. Comment at: lldb/source/Core/SourceManager.cpp:422 if (num_matches > 1) { -SymbolContext sc; +// SymbolContext sc; CompileUnit *test_cu = nullptr; This comment should not stay th

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

jankratochvil added inline comments. Comment at: lldb/source/Host/common/DebugInfoD.cpp:39 + +llvm::Expected findSource(UUID buildID, const std::string &path) { + if (!buildID.IsValid()) `const UUID &buildID` as it is even bigger (40 bytes) than `std::string` (3

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

jankratochvil added inline comments. Comment at: lldb/source/Host/common/DebugInfoD.cpp:59 + char *cache_path = nullptr; + int rc = debuginfod_find_source(client, buildID.GetBytes().data(), + buildID.GetBytes().size(), path.c_str(),

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

jankratochvil added a comment. Have you run the build with address sanitizer? Comment at: lldb/source/Commands/CommandObjectCommands.cpp:530 OptionsWithRaw args_with_suffix(raw_command_line); -const char *remainder = args_with_suffix.GetRawPart().c_str(); +llvm::St

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

jankratochvil added a comment. I do not have the testsuite running with ASAN (it is also failing for me) but I expected to at least run by hand ASAN-built LLDB for the code modified by this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7656

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

jankratochvil added inline comments. Comment at: lldb/source/Host/common/DebugInfoD.cpp:43 + buildID.GetBytes().size() == + sizeof(llvm::support::ulittle32_t)) // .gnu_debuglink crc32 +return llvm::createStringError(llvm::inconvertibleErrorCode(), --

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

jankratochvil added a comment. In D76569#1936796 , @shivammittal99 wrote: > How do I do that? This is my first PR to llvm, so I am not aware of the > tools. Please bear with me. No big deal, just compile it with `-DLLVM_USE_SANITIZER=Address` as you ha

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

jankratochvil added a comment. In D76569#1938577 , @labath wrote: > I wouldn't be too worried about asan as a StringRef provides the same > lifetime guarantees (== none) as a const char *. That's true but ASAN failed for me for the first patch. But that

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

jankratochvil requested changes to this revision. jankratochvil added inline comments. This revision now requires changes to proceed. Comment at: lldb/cmake/modules/FindDebuginfod.cmake:59 +endif() \ No newline at end of file "No newline at end of file", this is

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

jankratochvil added inline comments. Comment at: lldb/source/Core/SourceManager.cpp:415 target->GetImages().ResolveSymbolContextForFilePath( file_spec.GetFilename().AsCString(), 0, check_inlines, SymbolContextItem(eSymbolContextModul

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

jankratochvil accepted this revision. jankratochvil added a comment. The ASan GCC report was valid ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94299#c6 ) but that was really just the first/previous version of the patch. I will try to check why clang ASan does not report it (and also GCC ASan

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

jankratochvil added a comment. In D73206#1949516 , @labath wrote: > The main thing I don't like about the current state is the introduction of > user_id_t into the index classes. It forces a bunch of conversions for a flow > that really should be simple.

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

jankratochvil added a comment. In D75750#1954086 , @clayborg wrote: > Another idea for the SymbolServers: be able to specify a source repository > (git, svn etc) and hash or revision ID. The symbol server can grab the source > from the repo and cache is

[Lldb-commits] [PATCH] D77327: [lldb] [almost-nfc] 2/2: Introduce DWARF callbacks

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added subscribers: arphaman, aprantl. Herald added a reviewer: shafik. As requested by @labath in https://reviews.llvm.org/D73206#1949516 (D73206

[Lldb-commits] [PATCH] D77326: [nfc] [lldb] Unindent code

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. jankratochvil added a project: LLDB. Herald added subscribers: arphaman, aprantl. Herald added a reviewer: jdoerfert. Herald added a reviewer: shafik. It removes some needless deep indentation and some redundant

[Lldb-commits] [PATCH] D77327: [lldb] [almost-nfc] 2/2: Introduce DWARF callbacks

jankratochvil marked 3 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:134 + m_map.begin(), m_map.end(), unique_cstr, Compare( + if (callback(entry.value)) +return true; -

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil marked 6 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2014 -if (!method_die_offsets.empty()) { - DWARFDebugInfo &debug_info = dwarf->DebugInfo(); ---

[Lldb-commits] [PATCH] D77327: [lldb] [almost-nfc] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 254617. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil updated this revision to Diff 254616. jankratochvil marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D77326 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFInde

[Lldb-commits] [PATCH] D77336: Findtypes -gmodules fix

jankratochvil created this revision. jankratochvil added reviewers: labath, kwk. jankratochvil added a project: LLDB. A little fixup so that D77327 can be called NFC. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77336 Files: lldb/source/P

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2387 // dsymutil. - if (num_die_matches < max_matches) { + if (types.GetSize() < max_matches) { UpdateExternalModule

[Lldb-commits] [PATCH] D77336: Findtypes -gmodules fix

jankratochvil added a comment. In D77336#1959094 , @kwk wrote: > Could you explain, why this was done please? As D77327 removes `num_die_matches` as now it is a callback so one cannot use it anymore after D77327

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

jankratochvil added inline comments. Comment at: lldb/include/lldb/Core/SearchFilter.h:102 + /// + /// \note if not overriden, default implementation always \c true. virtual bool ModulePasses(const FileSpec &spec); I am not against it but FYI in a paragraph

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp:524 DIEInfoArray die_info_array; - if (FindByName(name, die_info_array)) -DWARFMappedHash::ExtractDIEArray(die_info_ar

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 254900. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil updated this revision to Diff 254898. jankratochvil marked an inline comment as done. jankratochvil added a comment. I have checked in the really obvious parts as rG80237523193d . The remainder is left here - altho

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2387 // dsymutil. - if (num_die_matches < max_matches) { + if (types.GetSize() < max_matches) { UpdateExternalModule

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 254931. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D77336: Findtypes -gmodules fix

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcab66d5fe53: [lldb] Findtypes -gmodules fix for too many matches (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77336/new/ http

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil updated this revision to Diff 255012. jankratochvil marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D77326 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil marked 4 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp:70-71 const dw_tag_t die_tag = die_info_array[i].tag; -if (die_tag == 0 || die_tag == DW_TAG_class_type || -d

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 255013. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup. In D77376#1961410 , @kwk wrote: > so I had to update the diff by hand with a bit of trouble. I was told h

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:130-163 + bool GetValues(ConstString unique_cstr, + std::function callback) const { +for (const Entry &entry : llvm::mak

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 255340. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 255463. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:130-163 + bool GetValues(ConstString unique_cstr, + std::function callback) const { +for (const Entry &entry : llvm::mak

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil added a comment. In D77327#1967060 , @labath wrote: > I can't say I have tried this, but ummm.. why is there a need for a separate > iterator class for this equal_range stuff? Couldn't this be implemented via > an iterator_pair of the itera

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 255761. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil marked 6 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:102 + // Helper iterator for the 'equal_range' method. + class CString_iterator { aprantl wrote: > /// I am sorry but al

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 255766. jankratochvil marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/so

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil marked 10 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2016 +for (size_t i = 0; i < num_matches; ++i) { + const DIERef &die_ref = method_die_offsets[i];

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil updated this revision to Diff 255801. jankratochvil marked 4 inline comments as done. jankratochvil added a comment. Implemented all the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil updated this revision to Diff 255813. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D77326 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp lldb/source/Plugins/SymbolFile/DWARF

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2951 +type_sp = resolved_type->shared_from_this(); +break; } aprantl wrote: > I think

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 255815. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

jankratochvil added a comment. In D73206#1954668 , @labath wrote: > Having a iterator/callback based api would allow us to minimize the impact of > that, as it would only need to happen for the entries that are really used. > And /I think/ we could make

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:190-195 +const_iterator left = llvm::lower_bound(m_map, unique_cstr, Compare()); +if (left != m_map.end() && left->cstring != unique_

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 255923. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cp

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 256259. jankratochvil marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h lldb/so

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil added a comment. In D77327#1971435 , @labath wrote: > The `bool` return value on all of these methods, is that here just to > implement the `fallback` mechanism in DebugNamesDWARFIndex? Most of them yes. There are still some functions need

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fbac4e1a2f2: [nfc] [lldb] Unindent code (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D773

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. Thanks for catching those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96778/new/ https://reviews.llvm.org/D96778 _

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. In D96778#2565414 , @werat wrote: > I can't claim I fully understand what's the difference here, but this aligns > with your comment at https://reviews.llvm.org/D92643#inline-900717 :) If interested the problem was `DWARFAt

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. In D96778#2566208 , @dblaikie wrote: > I expect it'd be good to have a test case showing the sort of DWARF that DWZ > produces for cross-CU references of enumerators. There is a testcase in D91014

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. In D96778#2567261 , @dblaikie wrote: > That tests some other cross-cu references, but if it was testing the changes > in this patch, wouldn't the test be failing (& I guess it isn't)? It isn't testing the specific cross-CU

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. The D91014 patch has been found by a testsuite regression when running in DWZ mode. This patch has only the same pattern in the code and currently it is unclear whether this change is really reproducible or it is in fact just NFC.

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. In D96778#2566208 , @dblaikie wrote: > I expect it'd be good to have a test case showing the sort of DWARF that DWZ > produces for cross-CU references of enumerators. Here is a new testcase for the second (`DW_TAG_variable`

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. In D96778#2572816 , @dblaikie wrote: > rolls this into one file with two CUs - bit easier to deal with. Then one could not use the `.file` directives and one would need to code also `.debug_line` by hand. > You could remov

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. In D96778#2576881 , @dblaikie wrote: > In D96778#2573076 , @jankratochvil > wrote: > >> Personally I am not interested in DWZ, I am implementing it only as a >> compatibility with ex

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. In D96778#2576927 , @dblaikie wrote: > What part of DWZ is specified by DWARFv5? `DW_*_sup` being used by DWZ with DWARF-4 as `DW_*_GNU_*_alt` (and dwarfstd.org proposal

[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved

jankratochvil added a comment. This new testcase broke buildbots as it is failing after a revert of D96637 : http://lab.llvm.org:8014/#/workers/29 http://lab.llvm.org:8011/#/workers/1 They are now failing on: ` lldb-api :: tools/lldb-vscode/breakpoint-events/Tes

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a subscriber: stella.stamenova. jankratochvil added a comment. @stella.stamenova It failed on a Windows box: https://lab.llvm.org/buildbot/#/builders/83/builds/4202 $ "c:\buildbot\lldb-x64-windows-ninja\build\bin\clang.exe" "--target=specify-a-target-or-use-a-_host-substitu

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. It has been now reverted until the testcase gets resolved: https://github.com/llvm/llvm-project/commit/011e7bcaa3194ed4ca3fec48263f5ef69fc1813c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96778/new/ https://reviews

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

jankratochvil added a comment. In D96778#2595110 , @stella.stamenova wrote: > What is the actual test requirement? It requires x86_64 (it is incompatible with x86_32) and hopefully it is OS-agnostic (after fixing the %clang_host). Repository: rG LLV

[Lldb-commits] [PATCH] D97721: [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC)

jankratochvil created this revision. jankratochvil added reviewers: grimar, labath. jankratochvil added a project: LLVM. jankratochvil requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: LLDB. LLDB has been failing on

[Lldb-commits] [PATCH] D97721: [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC)

jankratochvil updated this revision to Diff 327364. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97721/new/ https://reviews.llvm.org/D97721 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp lldb/source/Plugins/SymbolFile/DWARF

[Lldb-commits] [PATCH] D97765: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2)

jankratochvil accepted this revision. jankratochvil added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s:17 + +// RUN: %clang -o %t --target=x86_64-pc

[Lldb-commits] [PATCH] D97721: [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4096ae06f47a: [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC) (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.or

[Lldb-commits] [PATCH] D97721: [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC)

jankratochvil added a comment. In D97721#2598798 , @kwk wrote: > @jankratochvil out of curiosity. Can you give a pointer to what the C program > looks like that produces the object code? int main() {} Fedora Rawhide: gcc -o main.s main.c -gdwarf-5 -S

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2162 + llvm::StringRef parent_type_name = GetDWARFDeclContext(parent) + .GetQualifiedNameAsConstString() +

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

jankratochvil created this revision. jankratochvil added reviewers: labath, grimar. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Repository:

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.cpp:30 + dw_offset_t attr_die_offset, dw_attr_t attr) { + AttributeValue attr_value = {const_cast(form_value.GetUnit()), +

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

jankratochvil updated this revision to Diff 329064. jankratochvil added a comment. Update after rGfe7333174f54 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98197/new/ https://

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

jankratochvil updated this revision to Diff 329243. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98197/new/ https://reviews.llvm.org/D98197 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp lldb/source/Plugins/SymbolF

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

jankratochvil marked 2 inline comments as done. jankratochvil added a comment. In D98197#2613149 , @labath wrote: > Could you simplify the test case? done > I guess we should also delete > `test/Shell/Breakpoint/implicit_const_form_support.test`, as it'

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf806d91d562: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC) (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.o

[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil created this revision. jankratochvil added reviewers: labath, grimar. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. `DW_AT_ranges` can use `DW_FORM_sec_offset` (instead of `DW_FORM_rnglistx`). In such c

[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added a comment. There is some discussion what is valid vs. invalid DWARF-5 and whether DWARF-5 needs some updates: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99490 The planned change is that with this version of the patch `m_ranges_base` defauled to 0 but my idea for the 'planne

[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added a comment. Ah there is already a discussion from it: http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2021-March/004765.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llvm.org/D98289

[Lldb-commits] [PATCH] D86110: [WIP][DebugInfo] Lazily parse debug_loclist offsets

jankratochvil added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFListTable.h:116 + Optional getOffsetEntry(DataExtractor Data, uint32_t Index) const { +if (Index > HeaderData.OffsetEntryCount) + return None; That is going to be ad

[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 330181. jankratochvil edited the summary of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llv

[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFListTable.h:116 Optional getOffsetEntry(DataExtractor Data, uint32_t Index) const { -if (Index > HeaderData.OffsetEntryCount) +if (Index >= HeaderData.OffsetEntryCount) retur

<    1   2   3   4   5   6   7   8   9   >