[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil added a comment. @xbolva00 As you gave no reprodudcer it would be good to know how those two `DWARFDebugInfoEntry`s differ. Without that I can look at it more only next week - travelling. Repository: rL LLVM https://reviews.llvm.org/D46810 __

[Lldb-commits] [PATCH] D51874: Fix buildbot regression by rL339929: NameError: global name 'test_directory' is not defined

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB343726: Fix buildbot regression by rL339929: NameError: global name 'test_directory' is… (authored by jankratochvil, committed by ). Changed prior to commit: https://reviews.llvm.org/D51874?vs=16470

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath. jankratochvil added a project: LLDB. Herald added subscribers: JDevlieghere, aprantl. xbolva00 bugreported $subj It can happen only from the line: m_die_array.back().S

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:179 + if (!m_die_array.empty()) { +lldbassert(!m_first_die || m_first_die == m_die_array.front()); +m_first_die = m_die_array.front(); labath wrote:

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

jankratochvil added a comment. In https://reviews.llvm.org/D53255#1264782, @xbolva00 wrote: > reproducer archive - 404 not found Fixed, sorry. Repository: rLLDB LLDB https://reviews.llvm.org/D53255 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

This revision was automatically updated to reflect the committed changes. Closed by commit rL344605: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front())… (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

jankratochvil created this revision. jankratochvil added reviewers: aprantl, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. As @aprantl suggested I have merged `DWARFDebugInfoEntry`'s `m_empty_children` into `m_has

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

jankratochvil added a comment. In https://reviews.llvm.org/D53255#1265520, @aprantl wrote: > Out of curiosity: why do we allow for both an empty array and an empty > children sentinel? Is that distinction useful? Filed for that new https://reviews.llvm.org/D53321. Repository: rL LLVM http

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h:285-287 +// It is zero if a DIE says it had +

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

jankratochvil updated this revision to Diff 169850. jankratochvil marked an inline comment as done. Repository: rLLDB LLDB https://reviews.llvm.org/D53321 Files: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h source/Plugins/S

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

jankratochvil updated this revision to Diff 169873. jankratochvil added a comment. Done the conversion of bitfield to uint16_t. Repository: rLLDB LLDB https://reviews.llvm.org/D53321 Files: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp source/Plugins/SymbolFile/DWARF/DWARFDebug

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

jankratochvil marked an inline comment as done. jankratochvil added a comment. Also changed `assert()`->`lldbassert()` for `m_abbr_idx` 16-bit overflow as that could be a tough bug to catch if it ever happens. Repository: rLLDB LLDB https://reviews.llvm.org/D53321

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344644: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children (authored by jankratochvil, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D53321 Files: source/Plugins/Symbol

[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children

jankratochvil added a comment. In https://reviews.llvm.org/D53321#1266912, @clayborg wrote: > Looks good. Nice cleanup. Thanks for the cleanups and fixes. Repository: rLLDB LLDB https://reviews.llvm.org/D53321 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

jankratochvil added a comment. In https://reviews.llvm.org/D53255#1267850, @labath wrote: > It looks like it should be easy to write a test for this by hand-crafting a > minimal .s file and feeding it to lldb-test. Even with such a crafted file (in lldb-repro.tar.xz

[Lldb-commits] [PATCH] D51578: DWARFConcatenatingDataExtractor for D32167

jankratochvil updated this revision to Diff 170342. jankratochvil added a comment. Herald added a subscriber: arphaman. Patch `concat` = original posting with `DWARFConcatenatingDataExtractor` used only for `.debug_info`(+`.debug_types`) section. download

[Lldb-commits] [PATCH] D51578: DWARFConcatenatingDataExtractor for D32167

jankratochvil added a comment. I got an idea to try making the `.debug_info`+`.debug_types` memory contiguous. It cannot be mmapped then but LLDB does not seem to do that now anyway (except maybe MachO but despite some comment I haven't found a mmap() even there). Besides that there could be ev

[Lldb-commits] [PATCH] D54056: Add SetAllowJIT (the SBExpressionOptions equivalent of "expression --allow-jit")

jankratochvil added a comment. It broke the testsuite for me: $ time PYTHONPATH=$PWD/lib64/python2.7/site-packages:$PWD/lib64/python2.7/site-packages/lldb ../llvm-git/tools/lldb/test/dotest.py --executable $PWD/bin/lldb -C $PWD/bin/clang -t ../llvm-git/tools/lldb/packages/Python/lldbsuite/te

[Lldb-commits] [PATCH] D54056: Add SetAllowJIT (the SBExpressionOptions equivalent of "expression --allow-jit")

jankratochvil added a comment. In https://reviews.llvm.org/D54056#1286635, @davide wrote: > I don't think anybody will look at this until Monday, so if you want a quick > fix you might consider renaming the test yourself. Checked in as: https://reviews.llvm.org/rLLDB346089 Repository: rL L

[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

jankratochvil updated this revision to Diff 172548. jankratochvil retitled this revision from "DWARFConcatenatingDataExtractor for D32167" to "Contiguous .debug_info+.debug_types for D32167". jankratochvil edited the summary of this revision. Repository: rLLDB LLDB https://reviews.llvm.org/D51

[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

jankratochvil updated this revision to Diff 172549. Repository: rLLDB LLDB https://reviews.llvm.org/D51578 Files: include/lldb/lldb-forward.h packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/make/Makefile.rules packages/Python/lldbsuite/test/plugins/builder_bas

[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

jankratochvil updated this revision to Diff 173533. jankratochvil edited the summary of this revision. Repository: rLLDB LLDB https://reviews.llvm.org/D51578 Files: include/lldb/lldb-forward.h packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/make/Makefile.rules

[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

jankratochvil marked 2 inline comments as done. jankratochvil added a comment. There is a `_dwarf` -> `_dwarf_type_units` regression for: `-f TestCppTypeLookup.test_namespace_only_dwarf_type_units` ./bin/clang -o 1 ../llvm-git/tools/lldb/packages/Python/lldbsuite/test/lang/cpp/type_lookup/mai

[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

jankratochvil updated this revision to Diff 173535. jankratochvil marked 2 inline comments as done. Repository: rLLDB LLDB https://reviews.llvm.org/D51578 Files: include/lldb/lldb-forward.h packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/make/Makefile.rules pa

[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

jankratochvil updated this revision to Diff 174518. jankratochvil edited the summary of this revision. jankratochvil added a comment. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. I have left here only the sections concatenation. The .debug_types itself by Gr

[Lldb-commits] [PATCH] D54670: Update of D32167 on top of D51578

jankratochvil created this revision. jankratochvil added a reviewer: clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: teemperor. I cannot update the patch of https://reviews.llvm.org/D32167 so I have created this new revision for that. Repository: rLLDB LLDB https://

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jankratochvil added a comment. I could not updates this revision so an updated version of this patch is now: https://reviews.llvm.org/D54670 https://reviews.llvm.org/D32167 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

[Lldb-commits] [PATCH] D54670: .debug_types: Update of D32167 on top of D51578 (.debug_types section concatenation)

jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:268 + if (decl_ctx) +LinkDeclContextToDIE(decl_ctx, die); + return type_sp; I have added these 4 lines - `decl_ctx` copy - which

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. I do not think my approval is sufficient but I agree with the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54751/new/ https://reviews.llvm.org/D54751

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:351 + if (!addr_base) +addr_base = + cu_die.GetAttributeValueAsUnsigned(m_dwarf, this, DW_AT_GNU_addr_base, 0); Here I would find good also a comment: ``` /

[Lldb-commits] [PATCH] D54670: .debug_types: Update of D32167 on top of D51578 (.debug_types section concatenation)

jankratochvil added a comment. @clayborg You have already approved this patchset merged with D51578 in D51578 three weeks ago . I have split it afterwards to: | 1of2 | D51578 | the

[Lldb-commits] [PATCH] D51578: Contiguous .debug_info+.debug_types for D32167

jankratochvil updated this revision to Diff 178353. jankratochvil added a comment. Updated against trunk due to new `getSectionType` from rL348936 . Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51578/new/ https://reviews.llv

[Lldb-commits] [PATCH] D55858: noexternal 1/2: refactor testsuite spawnLldbMi args->exe+args

jankratochvil created this revision. jankratochvil added reviewers: LLDB, labath. jankratochvil added a project: LLDB. Herald added subscribers: abidh, ki.stfu. Currently `spawnLldbMi` accepts both lldb-mi options and executable to debug as a single parameter. Split them. As in the next patch we

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil created this revision. jankratochvil added reviewers: LLDB, labath. jankratochvil added a project: LLDB. Herald added subscribers: abidh, ki.stfu. There is already in use: lit/lit-lldb-init:settings set symbols.enable-external-lookup false packages/Python/lldbsuite/test/lldbtest

[Lldb-commits] [PATCH] D55858: noexternal 1/2: refactor testsuite spawnLldbMi args->exe+args

jankratochvil marked 3 inline comments as done. jankratochvil added a comment. Thanks for the review! Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py:53 +if exe: +self.runCmd("-file-exec-and-symbols \"%s\"" % exe) --

[Lldb-commits] [PATCH] D55858: noexternal 1/2: refactor testsuite spawnLldbMi args->exe+args

jankratochvil updated this revision to Diff 178842. jankratochvil marked an inline comment as done. jankratochvil added a comment. I have put there a comment: self.runCmd("-file-exec-and-symbols \"%s\"" % exe) +# Testcases expect to be able to match output of this com

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil added inline comments. Comment at: source/Host/common/Symbols.cpp:365 + if (!external_lookup) { +Log *log = lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_HOST); labath wrote: > This doesn't sound right to me. It looks like this will prev

[Lldb-commits] [PATCH] D55858: noexternal 1/2: refactor testsuite spawnLldbMi args->exe+args

This revision was automatically updated to reflect the committed changes. Closed by commit rL349607: refactor testsuite spawnLldbMi args->exe+args (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55858?vs=178

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil marked 4 inline comments as done. jankratochvil added a comment. In D55859#1336351 , @friss wrote: > Pretty sure this won't work. It might generate a dSYM, but an empty one. I agree LLDB did not parse such DSYM symbols on Linux. Is the pat

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil updated this revision to Diff 178910. jankratochvil marked an inline comment as done. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55859/new/ https://reviews.llvm.org/D55859 Files: packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil updated this revision to Diff 178911. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55859/new/ https://reviews.llvm.org/D55859 Files: packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py packages/Python/lldbsuite/test/tools/lldb-mi/

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil updated this revision to Diff 179028. jankratochvil added a comment. Herald added a subscriber: krytarowski. Updated symbols.enable-external-lookup description in detail. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55859/new/ https://reviews.llv

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil updated this revision to Diff 179349. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55859/new/ https://reviews.llvm.org/D55859 Files: packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py packages/Python/lldbsuite/test/tools/lldb-mi/

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: source/Core/ModuleList.cpp:72 {}, "Control the use of external tools or libraries to locate symbol files. " + "Directories listed in target.debug-file-search-paths and

[Lldb-commits] [PATCH] D55998: ELF: create "container" sections from PT_LOAD segments

jankratochvil added a comment. > it is in theory possible to create an elf file where only a part of a section > would belong to some segment (and another part to a different one). ELF standard : "//An object file segment contains one or more sections.

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

jankratochvil added subscribers: dblaikie, jankratochvil. jankratochvil added a comment. There is a regression in trunk clang+lldb. Using either 7.0 clang or 7.0 lldb makes the testcases PASS but both trunk clang and trunk lldb makes the testcase FAIL. This commit (rL346165

[Lldb-commits] [PATCH] D56068: Use reference only for DW_FORM_ref*

jankratochvil created this revision. jankratochvil added reviewers: clayborg, aprantl. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. D53530 could interpret `DW_AT_count` in `DW_FORM_data1` as a DIE reference as it did not verify it

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

jankratochvil added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3476 + if (DWARFDIE var_die = die.GetReferencedDIE(DW_AT_count)) { +if (var_die.Tag() == DW_TAG_variable) + if (exe_c

[Lldb-commits] [PATCH] D55991: DWARF: Fix a bug in array size computation

jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp:620 + case DW_FORM_ref_sig8: + case DW_FORM_GNU_ref_alt: +return die_offset; clayborg wrote: > Not sure that this is, but if it isn't an absolute .debug_info

[Lldb-commits] [PATCH] D56068: Use reference only for DW_FORM_ref*

jankratochvil abandoned this revision. jankratochvil added a comment. It is a duplicate of D55991 . Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56068/new/ https://reviews.llvm.org/D56068

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rLLDB350368: symbols.enable-external-lookup=false on all hosts (not just OSX) (authored by jankratochvil, committed by ). Herald added a reviewer: serge-sans-p

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: source/Core/ModuleList.cpp:72 {}, "Control the use of external tools or libraries to locate symbol files. " + "Directories listed in target.debug-file-search-paths and

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: source/Core/ModuleList.cpp:72 {}, "Control the use of external tools or libraries to locate symbol files. " + "Directories listed in target.debug-file-search-paths and

[Lldb-commits] [PATCH] D40470: DWZ 03/07: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil added a comment. Revert "Protect DWARFCompileUnit::m_die_array by a new mutex" Pavel Labath found this patch is incomplete and racy. I think there needs to be some more mutexes even before considering DW_TAG_partial_unit. This reverts commit 331229 which was: https://reviews.llvm.o

[Lldb-commits] [PATCH] D46810: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath. Herald added subscribers: JDevlieghere, aprantl. + // GetUnitDIEPtrOnly() needs to return pointer to the first DIE. + // But the first element of m_die_array after ExtractDIEsIfNeeded(true) + // may move

[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil updated this revision to Diff 146523. jankratochvil retitled this revision from "DWZ 03/07: Protect DWARFCompileUnit::m_die_array by a new mutex" to "Protect DWARFCompileUnit::m_die_array by a new mutex". jankratochvil edited the summary of this revision. https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D46810: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil added a comment. In https://reviews.llvm.org/D46810#1097503, @labath wrote: > - if nothing has been parsed, m_die_array is empty and m_first_die is empty > - if the cu die has been parsed, m_die_array us empty and m_first_die is full > - if everything has been parsed m_first_die an

[Lldb-commits] [PATCH] D46810: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil added a comment. In https://reviews.llvm.org/D46810#1097829, @labath wrote: > I am not sure it's that simple. I've found at least one case > (`SymbolFileDWARF::ParseImportedModuleswhere we call GetFirstChild() on the > value returned by `GetUnitDIEOnly` OK, that is clearly a bug

[Lldb-commits] [PATCH] D47275: 1/3: DWARFDIE split out to DWARFBasicDIE

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. Herald added subscribers: JDevlieghere, aprantl, mgorny. As Pavel Labath said in https://reviews.llvm.org/D46810 this is new `DWARFBasicDIE` to be used for `DWARFUnit::GetUnitDIEOnly()`. This patch is only mech

[Lldb-commits] [PATCH] D47276: 2/3: Use DWARFBasicDIE as compile-time protection

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. Herald added subscribers: JDevlieghere, aprantl. As suggested by Pavel Labath in https://reviews.llvm.org/D46810 `DWARFUnit::GetUnitDIEOnly()` returning a pointer to `m_first_die` should not permit using method

[Lldb-commits] [PATCH] D47275: 1/3: DWARFDIE split out to DWARFBasicDIE

jankratochvil marked 5 inline comments as done. jankratochvil added a comment. In https://reviews.llvm.org/D47275#1110065, @clayborg wrote: > Marked things that don't belong in DWARFBasicDIE. OK, sorry, thanks for reviewing it. > Also DWARFBasicDIE doesn't really explain what it actually is. M

[Lldb-commits] [PATCH] D47275: 1/3: DWARFDIE split out to DWARFBasicDIE

jankratochvil updated this revision to Diff 148360. https://reviews.llvm.org/D47275 Files: source/Plugins/SymbolFile/DWARF/CMakeLists.txt source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp source/Plugins/SymbolFile/DWARF/DWARFDIE.h source/Plugins/SymbolFile/DWARF/DWARFFirstDIE.cpp source/Plug

[Lldb-commits] [PATCH] D47276: 2/3: Use DWARFBasicDIE as compile-time protection

jankratochvil updated this revision to Diff 148362. https://reviews.llvm.org/D47276 Files: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp source/Plugins/SymbolFile/DWARF/DWARFUnit.h source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

[Lldb-commits] [PATCH] D47275: 1/3: DWARFDIE split out to DWARFBasicDIE

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rL333222: DWARFDIE split out to DWARFBaseDIE (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-c

[Lldb-commits] [PATCH] D47276: 2/3: Use DWARFBaseDIE as compile-time protection

jankratochvil updated this revision to Diff 148474. jankratochvil retitled this revision from "2/3: Use DWARFBasicDIE as compile-time protection" to "2/3: Use DWARFBaseDIE as compile-time protection". https://reviews.llvm.org/D47276 Files: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cp

[Lldb-commits] [PATCH] D47276: 2/3: Use DWARFBaseDIE as compile-time protection

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL333224: Use DWARFBaseDIE as a compile-time protection (authored by jankratochvil, committed by ). Herald added a subscribe

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil updated this revision to Diff 148480. https://reviews.llvm.org/D46810 Files: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp source/Plugins/SymbolFile/DWARF/DWARFUnit.

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil added a comment. In https://reviews.llvm.org/D46810#1098110, @clayborg wrote: > So this problem exists both in the LLDB and LLVM DWARF parsers. I am not sure > this fix is safe. I would rather fix this by fixing DWARFDIE class to "do the > right thing". We should be able to teach

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:312 void DWARFUnit::ClearDIEs(bool keep_compile_unit_die) { + m_die_array.clear(); labath wrote: > You are ignoring the keep_compile_unit_die argument here. Is that

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil updated this revision to Diff 148801. jankratochvil added a comment. Split out `ExtractUnitDIEIfNeeded()` out of `ExtractDIEsIfNeeded()`. https://reviews.llvm.org/D46810 Files: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp source/Plugins/SymbolFile/DWARF/DWARFDebugIn

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:86 // Keep a flat array of the DIE for binary lookup by DIE offset - if (!cu_die_only) { + { Log *log( claybor

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rL333437: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:208 +void DWARFUnit::ExtractDIEsEndCheck(lldb::offset_t offset) const { + lldb::offset_t next_cu_offset = GetNextCompileUnitO

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

jankratochvil created this revision. jankratochvil added a reviewer: clayborg. Herald added a subscriber: JDevlieghere. https://reviews.llvm.org/rL145086 introduced `m_die_array.shrink_to_fit()` implemented by `exact_size_die_array.swap`, it was before LLVM became written in C++11. That is fine

[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil updated this revision to Diff 149037. jankratochvil edited the summary of this revision. https://reviews.llvm.org/D40470 Files: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp source/Plugins/SymbolFile/DWARF/DWARFUnit.h Index: source/Plugins/SymbolFile/DWARF/DWARFUnit.h =

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil marked an inline comment as done. jankratochvil added a comment. FYI I also checked in a regression (just looking at the source code) https://reviews.llvm.org/rL333517. Repository: rL LLVM https://reviews.llvm.org/D46810 ___ lldb-c

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

This revision was automatically updated to reflect the committed changes. Closed by commit rL333636: Simplify DWARFUnit::m_die_array swap() to use shrink_to_fit() (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

jankratochvil added a comment. In https://reviews.llvm.org/D47492#1117350, @labath wrote: > it is implemented (in libstdc++ at least) using the swap trick too. Thanks for the heads up, I expected it does `realloc()`: implementation absolutely cannot rely on realloc ... because realloc, if it c

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

jankratochvil added a comment. If it is trivially copyable then IMO libstdc++ could use even that realloc() (that is for a shrink without any copy). Repository: rL LLVM https://reviews.llvm.org/D47492 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.h:181 + // ExtractDIEsIfNeeded() will keep m_die_array populated forever. + uint32_t m_die_array_usecount = 0; // GetUnitDIEPtrOnly() ne

[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil updated this revision to Diff 149255. jankratochvil marked an inline comment as done. jankratochvil added a comment. RAII lock `DWARFUnit::ScopedExtractDIEs` with mutexes `m_die_array_mutex`, `m_die_array_scoped_mutex` and `m_first_die_mutex`. https://reviews.llvm.org/D40470 File

[Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. No regressions on Fedora 28 x86_64. It does set there now `LLDB_EDITLINE_USE_WCHAR` although one still cannot enter unicode characters to `(lldb)` line. https://reviews.llvm.o

[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil updated this revision to Diff 149609. jankratochvil added a comment. Provided variants with a new RAII lock guard vs. unchanged caller `bool clear_dies` variable. And also 1 vs. 2 mutexes for `m_die_array`. Please choose one, I do not mind any. - mutexes2raii.patch

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

jankratochvil added a comment. FYI I have filed it for libstdc++ but I did not really understand their reaction: Bug 86013 - std::vector::shrink_to_fit() could sometimes use realloc() Repository: rL LLVM https://reviews.llvm.org/D47492

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

jankratochvil added a comment. In https://reviews.llvm.org/D47492#1121543, @dblaikie wrote: > Happy to help explain it - which part(s) are you having a bit of trouble with? What's wrong on this implementation ? > It seems like th

[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

This revision was automatically updated to reflect the committed changes. Closed by commit rL333987: Protect DWARFCompileUnit::m_die_array by new mutexes (authored by jankratochvil, committed by ). Changed prior to commit: https://reviews.llvm.org/D40470?vs=149609&id=149917#toc Repository: r

[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil added a comment. FYI I have reordered `m_cu->m_die_array_scoped_mutex.unlock_shared();` in `DWARFUnit::ScopedExtractDIEs::~ScopedExtractDIEs()` during commit (it was written this new way in some other of the 4 offered variants). Repository: rL LLVM https://reviews.llvm.org/D40

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

jankratochvil added a comment. In https://reviews.llvm.org/D47492#1122080, @labath wrote: > It doesn't look like your code verifies that the user hasn't replaced the > global `operator new` by defining a custom version. > http://en.cppreference.com/w/cpp/memory/new/operator_new: I asked about

[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil added a comment. Thanks for https://reviews.llvm.org/rL333996 fixups. Repository: rL LLVM https://reviews.llvm.org/D40470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [PATCH] D40475: DWZ 06/07: DWZ test mode

jankratochvil updated this revision to Diff 153941. https://reviews.llvm.org/D40475 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/lldbinline.py packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/make/Makefile.rules packages/Python/

[Lldb-commits] [PATCH] D40475: DWZ 06/07: DWZ test mode

jankratochvil updated this revision to Diff 153942. https://reviews.llvm.org/D40475 Files: packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/lldbinline.py packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/make/Makefile.rules packages/Python/

[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

jankratochvil added a comment. The DWZ-testmode Makefile.rules part. The DWZ-mode is written as another test matrix dimension. Compared to this DWP-mode it autodetects if all the tools are available on the host for that testsuite m

[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

jankratochvil added inline comments. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:520 $(EXE) : $(OBJECTS) $(ARCHIVE_NAME) $(DYLIB_FILENAME) $(LD) $(OBJECTS) $(ARCHIVE_NAME) -L. -l$(DYLIB_NAME) $(LDFLAGS) -o "$(EXE)" else Shouldn't be

[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

jankratochvil requested changes to this revision. jankratochvil added inline comments. This revision now requires changes to proceed. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:238 +ifneq (,$(wildcard $(DWP))) + MAKE_DWP=YES I was thinking

[Lldb-commits] [PATCH] D40473: DWZ 04/07: Adjust existing code for the DWZ support.

jankratochvil updated this revision to Diff 157897. jankratochvil edited the summary of this revision. https://reviews.llvm.org/D40473 Files: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.cpp source/Plugins/SymbolFile/DWARF/DWARFBaseDIE

[Lldb-commits] [PATCH] D49968: DWZ 02/06: Refactor DWARFUnit::ExtractDIEsScoped

jankratochvil created this revision. jankratochvil added a reviewer: clayborg. Herald added subscribers: JDevlieghere, aprantl. Change the method of construction from: DWARFUnit::ScopedExtractDIEs DWARFUnit::ExtractDIEsScoped() to: DWARFUnit::ScopedExtractDIEs::ScopedExtractDIEs(DWARFUnit *

[Lldb-commits] [PATCH] D40474: DWZ 03/06: Main functionality

jankratochvil updated this revision to Diff 157900. jankratochvil retitled this revision from "DWZ 05/07: Main functionality" to "DWZ 03/06: Main functionality". Herald added a subscriber: jfb. https://reviews.llvm.org/D40474 Files: include/lldb/Utility/ConstString.h include/lldb/Utility/Fil

[Lldb-commits] [PATCH] D49969: DWZ 04/06: ManualDWARFIndex::GetGlobalVariables for DIEs in PUs

jankratochvil created this revision. jankratochvil added reviewers: labath, clayborg. Herald added a subscriber: JDevlieghere. Rarely (`GlobalVariablesTestCase-test_c_global_variables`) a DIE can be only in PU (PartialUnit), that is if a DIE is a static constant variable (`g_file_static_int`) so

[Lldb-commits] [PATCH] D43512: DWZ 06/06: Fix for symlinked .build-id/**.debug files

jankratochvil updated this revision to Diff 157903. jankratochvil retitled this revision from "DWZ 07/07: Fix for symlinked .build-id/**.debug files" to "DWZ 06/06: Fix for symlinked .build-id/**.debug files". https://reviews.llvm.org/D43512 Files: packages/Python/lldbsuite/test/decorators.py

[Lldb-commits] [PATCH] D40475: DWZ 05/06: DWZ test mode

jankratochvil updated this revision to Diff 157902. jankratochvil retitled this revision from "DWZ 06/07: DWZ test mode" to "DWZ 05/06: DWZ test mode". jankratochvil edited the summary of this revision. https://reviews.llvm.org/D40475 Files: packages/Python/lldbsuite/test/dotest.py packages/

  1   2   3   4   5   6   7   8   9   >