jankratochvil added inline comments.

================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp:620
+  case DW_FORM_ref_sig8:
+  case DW_FORM_GNU_ref_alt:
+    return die_offset;
----------------
clayborg wrote:
> Not sure that this is, but if it isn't an absolute .debug_info offset, then 
> we shouldn't return it here
It is DWZ's reference from main debug file into shared DWZ common file - 
implemented by pending D40474.
I agree it needs more complicated handling than this implementation so it 
should not be here.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55991/new/

https://reviews.llvm.org/D55991



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to