hhellyer created this revision.
hhellyer added a subscriber: lldb-commits.
This patch changes the way ProcessElfCore.cpp handles signal information.
The patch changes ProcessElfCore.cpp to use the signal from si_signo in SIGINFO
notes in preference to the value of cursig in PRSTATUS notes. The va
hhellyer updated this revision to Diff 78163.
hhellyer added a comment.
Update with fixes from review comments.
I've run clang-format, fixed the use of iterators and added const qualifiers.
I removed the use of the SIGSTOP constant and use GetUnixSignals instead.
I've also moved that block down a
hhellyer updated this revision to Diff 78173.
hhellyer added a comment.
Update patch due to two missing changes.
https://reviews.llvm.org/D26676
Files:
source/Plugins/Process/elf-core/ProcessElfCore.cpp
source/Plugins/Process/elf-core/ThreadElfCore.cpp
source/Plugins/Process/elf-core/Thre
hhellyer added a comment.
This is marked ready to land and I can land it now but I'm still working on the
testcases.
I can either:
- Land the code changes and do the tests under another patch.
- Hold off on delivering this until I've finished the tests.
I'm not sure which is the preferred optio
hhellyer added a comment.
I haven't solved that yet! ;-)
I'm currently ending up with cores of ~500kb which is probably too big. I'm
seeing what I can do to bring them down but it might be that I can't shrink
them that much. I'm attempting to write two tests, one for multiple threads and
one
hhellyer added a comment.
I'd assumed that gcore would ignore the coredump_filter setting but it turns
out it doesn't so I should be able to use that. lldb seems happy enough opening
the core files produced with a filter of 0 so it's probably the simplest
solution.
I don't think lldb has a cor
hhellyer updated this revision to Diff 78524.
hhellyer added a comment.
Updating the patch to include the test cases and scripts to produce the core
dumps.
I haven't included the core dumps and when I do I'll need to update the pid and
tid values in the test scripts. That can wait until we've dec
hhellyer updated this revision to Diff 79051.
hhellyer added a comment.
Updated to add the test executables and core files.
https://reviews.llvm.org/D26676
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/gcore/
packages/Python/lldbsuite/test/functionalities/postmo
hhellyer added a comment.
@labath If you are happy with the tests and the size of their supporting files
I'll land this, otherwise let me know if anything needs changing.
https://reviews.llvm.org/D26676
___
lldb-commits mailing list
lldb-commits@l
hhellyer updated this revision to Diff 79056.
hhellyer added a comment.
Updating patch to remove executables and create empty targets in the test cases.
https://reviews.llvm.org/D26676
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/gcore/
packages/Python/lldbsuit
hhellyer added a comment.
I'll land these changes tomorrow morning (UK time) so I can watch the builds
and check there's no problems with the tests.
https://reviews.llvm.org/D26676
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
hhellyer added a comment.
I'll land these changes tomorrow morning (UK time) so I can watch the builds
and check there's no problems with the tests.
https://reviews.llvm.org/D26676
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
hhellyer added a comment.
@labath - Yes sorry about that. To be safe I did the "honest" thing of using
arc to pull down the patch from phabriactor and then arc commit to land it to
make sure I committed exactly what was reviewed. Somewhere in that it lost the
contents of the core files and just
Author: hhellyer
Date: Tue Jan 3 05:03:14 2017
New Revision: 290874
URL: http://llvm.org/viewvc/llvm-project?rev=290874&view=rev
Log:
Simplify reading of Linux notes to correctly handle endianess.
Summary:
This patch changes and simplifies the way notes are read from Linux Elf cores.
The current
Author: hhellyer
Date: Thu Feb 23 02:49:49 2017
New Revision: 295947
URL: http://llvm.org/viewvc/llvm-project?rev=295947&view=rev
Log:
Ensure lldb-server waits for child debug servers to start up when passing them
a port number to listen on.
Summary:
When lldb-server is started with the -P or -
hhellyer created this revision.
hhellyer added a reviewer: clayborg.
hhellyer added a subscriber: lldb-commits.
This adds new SB API calls and classes to allow a user of the SB API to obtain
a full list of memory regions accessible within the process. Adding this to the
API makes it possible use
hhellyer updated this revision to Diff 58771.
hhellyer added a comment.
Removed std::enable_shared_from_this from MemoryRegionInfo.h (which removes the
only change from that file)
Renamed region_info to region_info_sp in SBProcess::GetMemoryRegionInfo in
SBProcess.cpp
I also corrected the positi
hhellyer marked 2 inline comments as done.
hhellyer added a comment.
In http://reviews.llvm.org/D20565#442373, @clayborg wrote:
> This looks good as long as SBMemoryRegionInfo and SBMemoryRegionInfoList are
> ready only and will never have any setter functions. If we plan to ever have
> the SBM
hhellyer updated this revision to Diff 59205.
hhellyer added a comment.
I've switch to a unique_ptr from a shared_ptr in SBMemoryRegionInfo.
http://reviews.llvm.org/D20565
Files:
include/lldb/API/LLDB.h
include/lldb/API/SBDefines.h
include/lldb/API/SBMemoryRegionInfo.h
include/lldb/API/
hhellyer added a comment.
In http://reviews.llvm.org/D20565#444507, @clayborg wrote:
> My main reason for making sure we use std::unique_ptr is for API
> compatibility in the future. The size of std::unique_ptr and std::shared_ptr
> differs and if anyone wrote an IDE or tool that links against
hhellyer updated this revision to Diff 59352.
hhellyer added a comment.
Made sure an object was always constructed for the std::unique_ptr in
SBMemoryRegionInfo.cpp.
Removed unused constructor from SBMemoryRegionInfo.h.
http://reviews.llvm.org/D20565
Files:
include/lldb/API/LLDB.h
include/
hhellyer updated this revision to Diff 59524.
hhellyer marked an inline comment as done.
hhellyer added a comment.
Fix the latest code review comments to remove unnecessary tests for a valid
pointer that will always be initialised.
The change to the == operator on SBMemoryRegionInfo required an
hhellyer updated this revision to Diff 60517.
hhellyer added a comment.
Updated to rebase on the latest changes to MemoryRegionInfo.h
http://reviews.llvm.org/D20565
Files:
include/lldb/API/LLDB.h
include/lldb/API/SBDefines.h
include/lldb/API/SBMemoryRegionInfo.h
include/lldb/API/SBMemor
hhellyer added a comment.
Should I be able to deliver these changes now? When I try following the
instructions here: http://llvm.org/docs/Phabricator.html the patch
downloads and applies correctly but whether I use arc via the git or svn
commit methods I'm ultimately prompted for a password fo
hhellyer marked 12 inline comments as done.
hhellyer added a comment.
http://reviews.llvm.org/D20565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
hhellyer updated this revision to Diff 61253.
hhellyer added a comment.
Updating to ensure I have the latest changes.
http://reviews.llvm.org/D20565
Files:
include/lldb/API/LLDB.h
include/lldb/API/SBDefines.h
include/lldb/API/SBMemoryRegionInfo.h
include/lldb/API/SBMemoryRegionInfoList.
hhellyer added a comment.
I re-updated the patch via arc diff (rather than a manual patch upload).
Phabricator now seems to know which revision my changes are based off and has
added the "Next Step: arc commit" status. Do I need to request an svn password
to run arc commit or can you (or someon
Author: hhellyer
Date: Thu Jun 23 03:31:22 2016
New Revision: 273546
URL: http://llvm.org/viewvc/llvm-project?rev=273546&view=rev
Log:
Test commit to verify access, fix typo.
Modified:
lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.h
Modified: lldb/trunk/source/Plugins/Process/m
Author: hhellyer
Date: Thu Jun 23 03:35:37 2016
New Revision: 273547
URL: http://llvm.org/viewvc/llvm-project?rev=273547&view=rev
Log:
Add MemoryRegionInfo to SB API
Summary:
This adds new SB API calls and classes to allow a user of the SB API to obtain
a full list of memory regions accessible w
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273547: Add MemoryRegionInfo to SB API (authored by
hhellyer).
Changed prior to commit:
http://reviews.llvm.org/D20565?vs=61253&id=61648#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20565
Files
hhellyer created this revision.
hhellyer added a reviewer: clayborg.
hhellyer added a subscriber: lldb-commits.
This patch fills in the implementation of GetMemoryRegions() on the Linux and
Mac OS core file implementations of lldb_private::Process
(ProcessElfCore::GetMemoryRegions and ProcessMac
hhellyer updated this revision to Diff 61960.
hhellyer added a comment.
Squashing local commits.
http://reviews.llvm.org/D21751
Files:
include/lldb/Target/Process.h
source/Plugins/Process/elf-core/ProcessElfCore.cpp
source/Plugins/Process/elf-core/ProcessElfCore.h
source/Plugins/Process
hhellyer added a comment.
Since there’s a list of memory regions already created in the Process
implementations for the core fles I thought it made sense just to use that
directly, at least when reading from a core file. It meant there was no
requirement to change those GetMemoryRegionInfo impl
hhellyer added a comment.
In http://reviews.llvm.org/D21751#468976, @clayborg wrote:
> We should document the Process::GetMemoryRegionInfo() and what we expect of
> it so that all plug-ins implement it correctly.
I'll add a full comment in Process.h and I'll make sure the description matches
hhellyer updated this revision to Diff 62675.
hhellyer added a comment.
I’ve added a test in TestLinuxCore.py. It found a bug which the change in
RangeMap.h resolves.
It fills in the implementation of Process::GetMemoryRegions() and makes minor
changes to support the mapped attribute in MemoryR
hhellyer updated this revision to Diff 62839.
hhellyer added a comment.
Updated patch to export IsMapped in the C++ and Python APIs.
Updated the test case to verify all the regions returned in the list are mapped.
http://reviews.llvm.org/D21751
Files:
include/lldb/API/SBMemoryRegionInfo.h
i
Author: hhellyer
Date: Thu Jul 7 03:21:28 2016
New Revision: 274741
URL: http://llvm.org/viewvc/llvm-project?rev=274741&view=rev
Log:
Implement GetMemoryRegions() for Linux and Mac OSX core files.
Summary:
This patch fills in the implementation of GetMemoryRegions() on the Linux and
Mac OS core
hhellyer created this revision.
hhellyer added a reviewer: clayborg.
hhellyer added a subscriber: lldb-commits.
This patch fills in the implementation of GetMemoryRegions() on the Windows
live process and minidump implementations of lldb_private::Process
(ProcessWindowsLive::GetMemoryRegionInfo
hhellyer added a comment.
Arcanist won't upload the patch without the change to .arcconfig yet because of
http://lists.llvm.org/pipermail/llvm-dev/2016-July/102305.html but I think
this will be patched officially shortly! It should disappear if I update the
revision for any reason once that's
hhellyer updated this revision to Diff 63975.
hhellyer added a comment.
.arcconfig has been updated.
https://reviews.llvm.org/D22352
Files:
source/Plugins/Process/Windows/Live/ProcessWindowsLive.cpp
source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
Index: source/Plugins/Proces
hhellyer added inline comments.
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:338
@@ -315,4 +337,3 @@
// truncated.
-error.SetErrorString("address is not in a known range");
return error;
}
Asking for an address outside
hhellyer added inline comments.
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:338
@@ -315,4 +337,3 @@
// truncated.
-error.SetErrorString("address is not in a known range");
return error;
}
amccarth wrote:
> hhellyer wro
Author: hhellyer
Date: Mon Jul 18 03:25:59 2016
New Revision: 275778
URL: http://llvm.org/viewvc/llvm-project?rev=275778&view=rev
Log:
Implement GetMemoryRegions() for Windows Minidumps and live processes.
Summary:
This patch fills in the implementation of GetMemoryRegions() on the Windows
live
hhellyer accepted this revision.
hhellyer added a comment.
This revision is now accepted and ready to land.
Looks good, thanks.
https://reviews.llvm.org/D23948
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
hhellyer added a comment.
The change seems unlikely to pick up many false positives and core dumps from
the type of system described in the bug are only going to get more common.
https://reviews.llvm.org/D25179
___
lldb-commits mailing list
lldb-co
45 matches
Mail list logo
