hhellyer added inline comments.
================
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:338
@@ -315,4 +337,3 @@
// truncated.
- error.SetErrorString("address is not in a known range");
return error;
}
----------------
Asking for an address outside a known range is not actually an error, you just
get back an unmapped range that specifies how far it is to the next mapped
range.
The original discussion about that happened here:
https://reviews.llvm.org/D21751 - GetMemoryRegionInfo should only need to
return an error if it is unimplemented. (I should probably have referenced that
in the summary.)
https://reviews.llvm.org/D22352
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
