clayborg added a comment.
Is there anything we need to do on this review?
https://reviews.llvm.org/D24610
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. One question though: do we always have a shared library that
contains the ASAN runtime? If so, then we can actually put the array of short
to long description into the ASAN dyl
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Much better, looks good.
https://reviews.llvm.org/D26971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: gclayton
Date: Wed Dec 7 17:51:49 2016
New Revision: 288999
URL: http://llvm.org/viewvc/llvm-project?rev=288999&view=rev
Log:
Fixed DoConnectRemote issues where ProcessKDP wasn't switched over to use the
version that needed a StringRef as the URL, and also updated all virtual
functions
Author: gclayton
Date: Wed Dec 7 17:52:27 2016
New Revision: 289000
URL: http://llvm.org/viewvc/llvm-project?rev=289000&view=rev
Log:
Fix an unannotated fallthrough that was causing a warning.
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptE
Author: gclayton
Date: Wed Dec 7 18:22:45 2016
New Revision: 289006
URL: http://llvm.org/viewvc/llvm-project?rev=289006&view=rev
Log:
Improve crashlog.py so it can handle more iOS crashlog files.
Modified:
lldb/trunk/examples/python/crashlog.py
Modified: lldb/trunk/examples/python/crash
Author: gclayton
Date: Thu Dec 8 14:38:19 2016
New Revision: 289100
URL: http://llvm.org/viewvc/llvm-project?rev=289100&view=rev
Log:
Fixed a crasher that has been borking out heap for a long time.
ThreadList had an assignment operator that didn't lock the "rhs" thread list
object. This means
Author: gclayton
Date: Thu Dec 8 19:21:14 2016
New Revision: 289169
URL: http://llvm.org/viewvc/llvm-project?rev=289169&view=rev
Log:
Calling SBDebugger::CeeateTarget being called on multiple threads was crashing
LLDB.
I found the race condition in:
ScriptInterpreter *CommandInterpreter::GetSc
Author: gclayton
Date: Fri Dec 9 10:22:10 2016
New Revision: 289222
URL: http://llvm.org/viewvc/llvm-project?rev=289222&view=rev
Log:
Rename multiple target test so it is unique.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/api/multiple-targets/TestMultipleTargets.py
Modified:
lld
Author: gclayton
Date: Fri Dec 9 10:25:13 2016
New Revision: 289223
URL: http://llvm.org/viewvc/llvm-project?rev=289223&view=rev
Log:
Fix buildbots that are failing due to this test by adding all expected fails
that TestMultipleDebuggers.py has.
Modified:
lldb/trunk/packages/Python/lldbsu
Author: gclayton
Date: Fri Dec 9 11:54:59 2016
New Revision: 289233
URL: http://llvm.org/viewvc/llvm-project?rev=289233&view=rev
Log:
Fix i386 being able to show member variables correctly by not returning empty
objective C types from the runtime.
We don't parse ObjC v1 types from the runtime m
Author: gclayton
Date: Wed Dec 28 15:19:42 2016
New Revision: 290687
URL: http://llvm.org/viewvc/llvm-project?rev=290687&view=rev
Log:
Quiet a warning where we weren't checking if this was the same and rhs.
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/CFBundle.cpp
Modified: lldb/trun
Author: gclayton
Date: Wed Dec 28 15:22:37 2016
New Revision: 290688
URL: http://llvm.org/viewvc/llvm-project?rev=290688&view=rev
Log:
Fix the variable view in the "gui" curses mode so that variables whose children
change will update correctly. Previously the variable view would update the
child
Author: gclayton
Date: Wed Jan 25 15:50:28 2017
New Revision: 293102
URL: http://llvm.org/viewvc/llvm-project?rev=293102&view=rev
Log:
Fix SBData::SetData() so that it always sets the address byte size correctly
and added a test.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_ap
Author: gclayton
Date: Mon Feb 6 12:10:39 2017
New Revision: 294206
URL: http://llvm.org/viewvc/llvm-project?rev=294206&view=rev
Log:
Fix Xcode project.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm
Author: gclayton
Date: Thu Feb 9 11:16:19 2017
New Revision: 294597
URL: http://llvm.org/viewvc/llvm-project?rev=294597&view=rev
Log:
Fixed documentation bug found by Ramana who sent a patch to the lldb-dev list.
Modified:
lldb/trunk/www/test.html
Modified: lldb/trunk/www/test.html
URL:
h
Author: gclayton
Date: Thu Feb 9 11:56:55 2017
New Revision: 294600
URL: http://llvm.org/viewvc/llvm-project?rev=294600&view=rev
Log:
Fixed an issue where AllocatedBlock::ReserveRange does a linear search through
reserved ranges.
After many expressions are evaluated we were spending time lookin
Author: gclayton
Date: Thu Feb 9 12:21:04 2017
New Revision: 294603
URL: http://llvm.org/viewvc/llvm-project?rev=294603&view=rev
Log:
Fix build bots.
Modified:
lldb/trunk/include/lldb/Target/Memory.h
lldb/trunk/source/Target/Memory.cpp
Modified: lldb/trunk/include/lldb/Target/Memory.h
Author: gclayton
Date: Thu Feb 9 12:55:41 2017
New Revision: 294611
URL: http://llvm.org/viewvc/llvm-project?rev=294611&view=rev
Log:
Make sure we only load the OS plug-in once.
Modified:
lldb/trunk/source/Target/Process.cpp
Modified: lldb/trunk/source/Target/Process.cpp
URL:
http://ll
Author: gclayton
Date: Fri Feb 10 17:32:06 2017
New Revision: 294804
URL: http://llvm.org/viewvc/llvm-project?rev=294804&view=rev
Log:
Fix the lldb_private::Function::GetDescription to print out the name and
mangled name correctly. Previously this was getting the function type's name
which was n
Author: gclayton
Date: Mon Feb 13 15:34:58 2017
New Revision: 294990
URL: http://llvm.org/viewvc/llvm-project?rev=294990&view=rev
Log:
FindFunctions now works again with mangled names.
Added:
lldb/trunk/packages/Python/lldbsuite/test/python_api/name_lookup/
lldb/trunk/packages/Python/l
Author: gclayton
Date: Mon Feb 13 16:04:02 2017
New Revision: 294991
URL: http://llvm.org/viewvc/llvm-project?rev=294991&view=rev
Log:
Fix buildbots.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_api/name_lookup/TestNameLookup.py
Modified:
lldb/trunk/packages/Python/lldbsuite
Author: gclayton
Date: Wed Feb 15 12:24:44 2017
New Revision: 295212
URL: http://llvm.org/viewvc/llvm-project?rev=295212&view=rev
Log:
Fix Xcode project.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm
Author: gclayton
Date: Wed Feb 22 15:32:16 2017
New Revision: 295881
URL: http://llvm.org/viewvc/llvm-project?rev=295881&view=rev
Log:
Fix header documentation.
Modified:
lldb/trunk/include/lldb/API/SBTarget.h
Modified: lldb/trunk/include/lldb/API/SBTarget.h
URL:
http://llvm.org/viewvc/llvm
Author: gclayton
Date: Wed Feb 22 15:32:48 2017
New Revision: 295882
URL: http://llvm.org/viewvc/llvm-project?rev=295882&view=rev
Log:
Fix header documentation.
Modified:
lldb/trunk/include/lldb/API/SBAttachInfo.h
Modified: lldb/trunk/include/lldb/API/SBAttachInfo.h
URL:
http://llvm.org/vie
Author: gclayton
Date: Wed Feb 22 17:42:55 2017
New Revision: 295907
URL: http://llvm.org/viewvc/llvm-project?rev=295907&view=rev
Log:
Fixed errors in AllocatedBlock:
- Allow zero byte size request for memory and ensure it gets a unique address
- Exit the free block loop when we find an appropriat
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13154
___
lldb-commits mailing list
lldb
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
This can't be the real fix for this. We must be able to trust the empty()
function call. We must have someone playing with the collection without locking
the mutex. Please find t
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Back from vacation, sorry for the delay.
One quick fix as noted in inlined comments.
Comment at: source/Breakpoint/Watchpoint.cpp:224-235
@@ -223,7 +223,14 @@
clayborg added a comment.
So this fix is really to take care of the case where a class methods might be
defined on only some class instances? Can you explain more of what this fixes?
http://reviews.llvm.org/D13224
___
lldb-commits mailing list
lldb
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13247
___
lldb-commits mailing list
lldb
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13149
___
lldb-commits mailing list
lldb
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good.
http://reviews.llvm.org/D13270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good.
http://reviews.llvm.org/D13271
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg accepted this revision.
clayborg added a comment.
Back from vacation, sorry for the delay. Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13282
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13241
___
lldb-commits mailing list
lldb
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will defer to Jim Ingham on this one.
Repository:
rL LLVM
http://reviews.llvm.org/D13296
___
lldb-commits mailing list
lldb-commits@lists.llv
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good.
http://reviews.llvm.org/D13300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
DeclBase.h will need to be submitted against clang, not LLDB.
Then add Sean Callanan and Jim Ingham as the reviewers as they are the masters
of the expression parser. I helped to get the Compil
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Back from vacation, sorry for the delay. Looks good if Enrico is happy.
http://reviews.llvm.org/D13058
___
lldb-commits mailing list
lldb-com
clayborg accepted this revision.
clayborg added a comment.
Back from vacation, sorry for the delay. Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13201
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: gclayton
Date: Mon Oct 5 17:58:37 2015
New Revision: 249361
URL: http://llvm.org/viewvc/llvm-project?rev=249361&view=rev
Log:
SBTarget::Attach(SBAttachInfo &) was changed to not be asynchronous back in
February and this affected Xcode's abililty to cancel an attach to process by
name.
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D13463
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Thanks for the info, now the patch makes more sense. That is some really lame
DWARF I must say, but alas we must deal with it. Looks good.
http://reviews.llvm.org/D13224
__
Author: gclayton
Date: Wed Oct 7 15:00:28 2015
New Revision: 249600
URL: http://llvm.org/viewvc/llvm-project?rev=249600&view=rev
Log:
Fixed up some first responder issues and added menubar support that isn't in
use yet.
Modified:
lldb/trunk/test/curses_results.py
lldb/trunk/test/lldbcu
Author: gclayton
Date: Wed Oct 7 15:01:13 2015
New Revision: 249601
URL: http://llvm.org/viewvc/llvm-project?rev=249601&view=rev
Log:
Fix a test that should only be run with a dSYM file by adding @skipIfDwarf and
using a new @skipIfDWO.
Modified:
lldb/trunk/test/lang/objc/objc-ivar-strippe
Author: gclayton
Date: Wed Oct 7 15:06:45 2015
New Revision: 249604
URL: http://llvm.org/viewvc/llvm-project?rev=249604&view=rev
Log:
More fixes for binaries that we strip. When we strip a binary we can't do Dwarf
or DWO.
Modified:
lldb/trunk/test/lang/objc/hidden-ivars/TestHiddenIvars.py
Author: gclayton
Date: Wed Oct 7 15:08:26 2015
New Revision: 249605
URL: http://llvm.org/viewvc/llvm-project?rev=249605&view=rev
Log:
Another stripped test that requires darwin and a dSYM (no Dwarf or DWO).
Modified:
lldb/trunk/test/lang/objc/objc-static-method-stripped/TestObjCStaticMethod
Author: gclayton
Date: Wed Oct 7 15:38:20 2015
New Revision: 249613
URL: http://llvm.org/viewvc/llvm-project?rev=249613&view=rev
Log:
This test is useless. It doesn't work and it fails on MacOSX. Removing it.
Removed:
lldb/trunk/test/functionalities/connect_remote/EchoServer.py
lldb/tru
Author: gclayton
Date: Wed Oct 7 17:06:08 2015
New Revision: 249625
URL: http://llvm.org/viewvc/llvm-project?rev=249625&view=rev
Log:
Don't do DWO tests on darwin as they aren't supported. If this is an error and
they are supported, we need to add support _only_ if the clang compiler that is
be
Author: gclayton
Date: Wed Oct 7 17:07:33 2015
New Revision: 249626
URL: http://llvm.org/viewvc/llvm-project?rev=249626&view=rev
Log:
Fix the TestCppNsImport test case for DWARF. It was failing for DWARF in .o
files because SymbolFileDWARFDebugMap didn't implement the following function:
void
P
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Few minor changes.
Comment at:
source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1183
@@ +1182,3 @@
+llvm::StringRef value_str(str
Author: gclayton
Date: Wed Oct 7 17:36:52 2015
New Revision: 249631
URL: http://llvm.org/viewvc/llvm-project?rev=249631&view=rev
Log:
Expected fail this test and supplied the radar number that is tracking the fix.
Modified:
lldb/trunk/test/macosx/queues/TestQueues.py
Modified: lldb/trunk/t
clayborg accepted this revision.
clayborg added a comment.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
Add space in between if and opening ( and this is good to go.
Repository:
rL LLVM
http://reviews.llvm.org/D13548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
Author: gclayton
Date: Thu Oct 8 16:04:34 2015
New Revision: 249747
URL: http://llvm.org/viewvc/llvm-project?rev=249747&view=rev
Log:
Moved the target specific ClangASTContext initialization over into
ClangASTContext::CreateInstance.
This involved changing the TypeSystem::CreateInstance to take
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
We are pretty inconsistent with the space after a function name and before the
( so I don't mind.
Repository:
rL LLVM
http://reviews.llvm.org/D13574
clayborg accepted this revision.
clayborg added a comment.
Wait for the OK from Enrico as well to verify this is OK.
Repository:
rL LLVM
http://reviews.llvm.org/D13577
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D13537
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:73-79
@@ -73,2 +72,9 @@
-class PythonObject
+enum class PyRef
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I would prefer to add an alias name instead of a serial number. If a signal has
more than one possible name, I would rather see that documented up front. It
also makes for cleare
clayborg added a comment.
So I would prefer to have one entry per signal and have that structure describe
everything for that one signal.
Repository:
rL LLVM
http://reviews.llvm.org/D13646
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
clayborg added a comment.
If you have 1000 compile units, will this spawn 1000 threads simultaneously?
http://reviews.llvm.org/D13662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
clayborg added a comment.
I would like to see PythonObject used in place of PyRef, feel free to remove
the operator bool and PyObject, and then the rest of the mostly indent and
style cleanups.
Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:73-79
@@ -7
clayborg added a comment.
std::async is fine as long as it doesn't blow out the threads on any supported
systems. We should also test doing multiple std::async calls in different
places in some test only code to make sure if we run 4 std::async calls at once
on different threads that we don't e
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
It would be nice to compute one hash per string and use that during insertion.
I really like the patch, but can we avoid two string hashes?
Comment at: source/C
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
If you are going to keep on contributing, please get SVN commit access.
Repository:
rL LLVM
http://reviews.llvm.org/D13684
___
lldb-commit
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13699
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I would still like to get down to hashing the string once at some point, but we
can start with this and iterate on it.
http://reviews.llvm.org/D13652
__
Author: gclayton
Date: Tue Oct 13 18:16:29 2015
New Revision: 250248
URL: http://llvm.org/viewvc/llvm-project?rev=250248&view=rev
Log:
Added tree panels.
Modified:
lldb/trunk/test/lldbcurses.py
Modified: lldb/trunk/test/lldbcurses.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/test
clayborg resigned from this revision.
clayborg edited reviewers, added: jingham; removed: clayborg.
clayborg added a comment.
I will get Sean to take a look.
http://reviews.llvm.org/D12809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Missing the TaskPool.h and TaskPool.cpp files?
http://reviews.llvm.org/D13662
___
lldb-commits mailing list
lldb-commits@lists.llvm
clayborg requested changes to this revision.
clayborg added a comment.
I agree with labath's comments and see if we can move TaskPoolImpl into the
.cpp file.
Comment at: include/lldb/Utility/TaskPool.h:39-66
@@ +38,30 @@
+
+class TaskPoolImpl
+{
+public:
+Ta
clayborg added a comment.
Any std::async adoption will need to be able to deliver tasks as they complete
via "TaskRunner::WaitForNextCompletedTask()".
We had a previous example where 1000 items could be pushed onto a std::vector
of tasks and then the code was doing:
for (i=0; ihttp://reviews
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Just saw that patch, so this looks good then pending the other patch.
http://reviews.llvm.org/D13662
___
lldb-commits mailing list
lldb-commi
clayborg added a comment.
BTW: if we can modify clang to produce the Apple accelerator tables, we won't
need to do any of this indexing which will really speed up debugging! We only
produce the Apple accelerator tables on Darwin, but we could on other systems.
There is also a new version of the
clayborg added a comment.
Zach: If these are implementation details, lets get this in first and then
worry about optimizations later.
http://reviews.llvm.org/D13727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Can we change "TcpSocket" to be "TCPSocket" and "UdpSocket" to be "UDPSocket"
in all code and in the file names? Other than that it looks good.
Comment at: sour
Author: gclayton
Date: Wed Oct 14 19:49:36 2015
New Revision: 250353
URL: http://llvm.org/viewvc/llvm-project?rev=250353&view=rev
Log:
Fix the ability to quit and use a custom exception. Also print tree items out
so they are more aligned.
Modified:
lldb/trunk/test/lldbcurses.py
Modified: l
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: include/lldb/Target/UnixSignals.h:101-102
@@ -100,1 +100,4 @@
+ConstString
+GetShortName(ConstString name) const;
+
-
clayborg accepted this revision.
clayborg added a comment.
Very nice! I look forward to seeing this patch and the associated DWARF patches
make it in!
http://reviews.llvm.org/D13727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
clayborg added a comment.
In http://reviews.llvm.org/D13727#268053, @zturner wrote:
> The main thought I had was just that it would make the code simpler and
> delegate more of the synchronization stuff to the library. But if we don't
> get any of that benefit then I guess there's no point in
clayborg added a comment.
> Yes. But an implementation of std::async is either going to use a global
> thread pool or it's not. If it does there's no problem, and if it doesn't,
> it's going to create one thread for each call, and when the work in that
> thread is done, the thread will exit.
clayborg added a comment.
In http://reviews.llvm.org/D13727#268084, @tberghammer wrote:
> Addressing comments from the discussion with destroying the treads not in use
> while keeping a global thread pool with at most hardware_concurrency threads.
We should perf test this, but I would be OK wi
clayborg added a comment.
In http://reviews.llvm.org/D13727#268091, @tberghammer wrote:
> I agree that parking the threads in the kernel should be very cheap (I am not
> sure about Windows) but on high end multi core machines having 40+ threads
> around just to wait for work is a bit strange fo
clayborg added a comment.
I would almost rather change the GetNumChildren() to take a "max" param:
class SBValue
{
uint32_t
GetNumChildren ();
uint32_t
GetNumChildren (uint32_t max = UINT32_MAX);
};
We need to keep the other one so that our public API still has
clayborg added a comment.
If you still care about this, please resubmit against current sources.
http://reviews.llvm.org/D6122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
Stopping the threads is fine as it seems to be desired from most others.
http://reviews.llvm.org/D13727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
For the public API you will need both and not have a default arg.
http://reviews.llvm.org/D13778
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: gclayton
Date: Thu Oct 15 19:34:18 2015
New Revision: 250478
URL: http://llvm.org/viewvc/llvm-project?rev=250478&view=rev
Log:
More general fixes to the tree view and BoxedPanel.
Modified:
lldb/trunk/test/lldbcurses.py
Modified: lldb/trunk/test/lldbcurses.py
URL:
http://llvm.org/vi
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I would rather you be able to ask the current platform for the default memory
cache line size and have lldb_private::Process do this automatically on the
first memory read if the
Author: gclayton
Date: Fri Oct 16 18:34:40 2015
New Revision: 250580
URL: http://llvm.org/viewvc/llvm-project?rev=250580&view=rev
Log:
Split getting the key from a window from the code that handles the key.
Modified:
lldb/trunk/test/lldbcurses.py
Modified: lldb/trunk/test/lldbcurses.py
URL:
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Ok, makes sense then.
Repository:
rL LLVM
http://reviews.llvm.org/D13646
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Please don't check this in. If dwarf_r0 changes from 0 to another value, then
this code will fail. We will need to live with these warnings.
http://reviews.llvm.org/D13866
__
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We can't rely on any specific error codes since different GDB remote servers
will hand back different errors for any packet. Do you have control over the
MIPS debugserver? Is thi
clayborg added a comment.
Yes, lets get this in an iterate on it afterwards!
http://reviews.llvm.org/D13727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. The other way to do this would be to add a key/value pair to the
qHostInfo like "memory_cache_line_byte_size" and return a value that makes
sense for the current Andriod debug
Author: gclayton
Date: Mon Oct 19 15:44:01 2015
New Revision: 250735
URL: http://llvm.org/viewvc/llvm-project?rev=250735&view=rev
Log:
Allow LLDB.framework to locate debugserver even when it doesn't exist in the
LLDB.framework.
This allows open source MacOSX clients to not have to build debugser
clayborg added a comment.
Thanks for doing this.
Repository:
rL LLVM
http://reviews.llvm.org/D13877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg resigned from this revision.
clayborg edited reviewers, added: granata.enrico; removed: clayborg.
clayborg added a comment.
Enrico should take a look and OK this.
Repository:
rL LLVM
http://reviews.llvm.org/D13878
___
lldb-commits mailin
201 - 300 of 3324 matches
Mail list logo
