fjricci added a comment.
Friendly ping.
http://reviews.llvm.org/D18228
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
fjricci created this revision.
fjricci added reviewers: clayborg, granata.enrico, zturner.
fjricci added subscribers: sas, lldb-commits.
This reverts some of the changes made by:
r257644
r250530
r250525
The changes made in these patches result in leaking the FILE* passed
to SetImmediateOutputFile
fjricci added a comment.
Because python 3 doesn't use `FILE*` as the underlying implementation anymore,
I think the only way to make this work is to continue to use `dup()` to make
the `FILE*`, but then to actually keep track of the ownership of the `FILE*`.
This can't be done inside `PythonFil
fjricci added a comment.
When we pass the `FILE*` to `SetImmediateOutputFile`, it then generates a new
`File` from this `FILE*`, but doesn't take ownership, because the
transfer_ownership flag is always false. And the `File` destructor only closes
files if it has ownership of the `FILE*`.
htt
fjricci added inline comments.
Comment at: scripts/Python/python-typemaps.swig:532
@@ -531,3 +524,1 @@
- file.Clear();
-}
}
The problem is that here, we save the `FILE*` (`$1`) and let the `File`
(`file`) go out of scope. So the `File` gets destructe
fjricci added inline comments.
Comment at: scripts/Python/python-typemaps.swig:532
@@ -531,3 +524,1 @@
- file.Clear();
-}
}
zturner wrote:
> zturner wrote:
> > fjricci wrote:
> > > The problem is that here, we save the `FILE*` (`$1`) and let the `File
fjricci added a comment.
Would we want this overloaded method taking an int (fd) instead of a FILE* to
be present in the API? Or hidden somehow? I'm new to swig, but it looks like
python-extensions.swig includes some private extensions to the
CommandReturnObject class already.
Overloading with
fjricci added a comment.
It appears that `%extend` directives only have access to public class members.
So my idea won't work. I'll try to overload with a fd call, presumably that
call can be exposed in the API? Or is it better if it isn't?
The difficulty with overloading is that, for overloade
fjricci added a comment.
I think that would be sufficient to solve the problem.
I could use a `%rename` to rename the `SetImmediateOutputFile (FILE *fh)` call
to a private function in `%extend`, which will then call
`SetImmediateOutputFile (FILE *fh, transfer_ownership=true)` instead.
Does tha
fjricci added a comment.
Actually, I think this may open a new can of worms. Adding that flag to the API
doesn't necessarily achieve what we want. The current bug is that we take a
Python file (owned by the Python caller), and we know that the Python caller
does not want to transfer ownership o
fjricci updated this revision to Diff 51678.
fjricci added a comment.
Extend SBCommandReturnObject API to allow for taking file ownership
http://reviews.llvm.org/D18459
Files:
include/lldb/API/SBCommandReturnObject.h
scripts/interface/SBCommandReturnObject.i
source/API/SBCommandReturnObje
fjricci updated this revision to Diff 51680.
fjricci added a comment.
Correct whitespace change
http://reviews.llvm.org/D18459
Files:
include/lldb/API/SBCommandReturnObject.h
scripts/interface/SBCommandReturnObject.i
source/API/SBCommandReturnObject.cpp
Index: source/API/SBCommandReturnO
fjricci updated this revision to Diff 51698.
fjricci added a comment.
Use function overloading
http://reviews.llvm.org/D18459
Files:
include/lldb/API/SBCommandReturnObject.h
scripts/interface/SBCommandReturnObject.i
source/API/SBCommandReturnObject.cpp
Index: source/API/SBCommandReturnOb
fjricci updated this revision to Diff 51699.
fjricci added a comment.
Fix whitespace
http://reviews.llvm.org/D18459
Files:
include/lldb/API/SBCommandReturnObject.h
scripts/interface/SBCommandReturnObject.i
source/API/SBCommandReturnObject.cpp
Index: source/API/SBCommandReturnObject.cpp
=
fjricci abandoned this revision.
fjricci added a comment.
Committed.
http://reviews.llvm.org/D18459
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
fjricci abandoned this revision.
fjricci added a comment.
Committed.
http://reviews.llvm.org/D16488
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
fjricci created this revision.
fjricci added reviewers: tberghammer, ADodds, tfiala.
fjricci added subscribers: sas, lldb-commits.
The logic to read modules from memory was added to LoadModuleAtAddress
in the dynamic loader, but not in process gdb remote. This means that when
the remote uses svr4
fjricci added a comment.
That was actually one of the fixes I originally tried. My only concern is that
LoadModuleAtAddress is a protected method in the dynamic loader. If you think
it's fine to change it to public, I'll go ahead and do that.
http://reviews.llvm.org/D18531
_
fjricci added a comment.
I see that DynamicLoaderHexagonDYLD also has a LoadModuleAtAddress function,
which seems to be the same as the one in DynamicLoader, except that the member
functions it calls are overloaded, and it is also missing the newly added
ReadFromMemory code.
I think this funct
fjricci updated this revision to Diff 51962.
fjricci added a comment.
Refactor to remove code duplication
http://reviews.llvm.org/D18531
Files:
include/lldb/Target/DynamicLoader.h
source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
source/Plugins/DynamicLoader/Hexagon-D
fjricci created this revision.
fjricci added reviewers: tfiala, clayborg.
fjricci added subscribers: sas, lldb-commits.
Print environment from triple if it exists.
http://reviews.llvm.org/D18620
Files:
source/Core/ArchSpec.cpp
Index: source/Core/ArchSpec.cpp
==
fjricci created this revision.
fjricci added reviewers: clayborg, tfiala, tberghammer.
fjricci added subscribers: sas, lldb-commits.
Herald added subscribers: danalbert, tberghammer, aemerson.
If we determine an OS from the executable, but not an environment,
the existing code will not update the
fjricci abandoned this revision.
fjricci added a comment.
Doesn't appear necessary after applying http://reviews.llvm.org/D18620
http://reviews.llvm.org/D18621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
fjricci created this revision.
fjricci added reviewers: jasonmolenda, tfiala, clayborg.
fjricci added subscribers: sas, lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Fixes "target list" for non-android linux platforms (ie gnu, gnueabi)
http://reviews.llvm.org/D18631
Files:
so
fjricci added a comment.
android is detected from the ELF, so we can get around using the gdb-remote
info.
http://reviews.llvm.org/D18631
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
fjricci created this revision.
fjricci added reviewers: spyffe, jingham, Eugene.Zelenko.
fjricci added subscribers: sas, lldb-commits.
Flag updated in D233237
http://reviews.llvm.org/D18660
Files:
source/Commands/CommandObjectWatchpoint.cpp
Index: source/Commands/CommandObjectWatchpoint.cpp
=
fjricci created this revision.
fjricci added reviewers: zturner, tfiala.
fjricci added subscribers: sas, lldb-commits.
The '-p' option for dotest.py was ignored in multiprocess mode,
as the -p argument to the inferior would overwrite the -p argument
passed on the command line.
http://reviews.llvm
fjricci created this revision.
fjricci added reviewers: jasonmolenda, tfiala, clayborg.
fjricci added subscribers: sas, lldb-commits.
"gcc" is equivalent to "ehframe" in ProcessGDBRemote, but
only "ehframe" was a valid response in the test suite.
I know that "gcc" was replaced by "ehframe" in the
fjricci created this revision.
fjricci added reviewers: zturner, vharron, emaste.
fjricci added subscribers: sas, lldb-commits.
$(lldb -P)/../../ is assumed to be the lldb library directory
by the test suite. However, it is possible that the python
libs would be installed in build/lib64 instead of
fjricci created this revision.
fjricci added reviewers: vharron, zturner, tfiala.
fjricci added subscribers: sas, lldb-commits.
lldb-server tests are currently being skipped on the
check-lldb target. This is because we get the path of
lldb-server by modifying the path to the lldb executable.
How
fjricci added a comment.
When I use LLVM_LIBDIR_SUFFIX=64, it looks like the python _lldb.so symlink
still points to build/lib/liblldb.so, instead of using the lib64 directory. So
if I do this, none of the tests will run on the check-lldb target, since
importing lldb in python fails.
Perhaps t
fjricci added a comment.
So I looked at `finishSwigPythonLLDB.py`, and it does look like that's where
the bug is. This script sets the end of the symlink path with:
strSrc = os.path.join("lib", "liblldb" + strLibFileExtn)
Note here that "lib" is hardcoded, and doesn't use the `LLVM_LIBDIR_SUF
fjricci updated this revision to Diff 54077.
fjricci added a comment.
Pass the lldb lib directory to python swig scripts
http://reviews.llvm.org/D19067
Files:
CMakeLists.txt
scripts/Python/finishSwigPythonLLDB.py
scripts/finishSwigWrapperClasses.py
Index: scripts/finishSwigWrapperClasses
fjricci created this revision.
fjricci added reviewers: ADodds, zturner, tfiala.
fjricci added subscribers: sas, lldb-commits.
When we receive an svr4 packet from the remote, we check for new modules
and add them to the list of images in the target. However, we did not
do the same for modules whic
fjricci added inline comments.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4907
@@ -4883,2 +4906,3 @@
+m_process->GetTarget().ModulesDidUnload (removed_modules, false);
new_modules.ForEach ([&target](const lldb::ModuleSP module_sp) -> bool
fjricci created this revision.
fjricci added reviewers: jingham, clayborg, jasonmolenda.
fjricci added subscribers: sas, lldb-commits.
If the remote uses include features when communicating
xml register info back to lldb, the existing code would reset the
lldb register index at the beginning of e
fjricci created this revision.
fjricci added reviewers: jasonmolenda, clayborg.
fjricci added subscribers: sas, lldb-commits.
eRegisterKindProcessPlugin is used to store the register
indices used by the remote, and eRegisterKindLLDB is used
to store the internal lldb register indices. However, we'
fjricci added a comment.
I can add a comment to the ReadRegister decl.
Alternatively, if you think it would be preferable, I could change the
parameter name from reg_num to something more descriptive, like remote_reg_num
or plugin_reg_num.
Or I could change ReadRegister to take a RegisterInfo
Author: fjricci
Date: Mon Apr 25 15:24:30 2016
New Revision: 267459
URL: http://llvm.org/viewvc/llvm-project?rev=267459&view=rev
Log:
Add missing qRegisterInfo option to gdbremote testcase
Summary:
"gcc" is equivalent to "ehframe" in ProcessGDBRemote, but
only "ehframe" was a valid response in th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267459: Add missing qRegisterInfo option to gdbremote
testcase (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D18807?vs=52743&id=54892#toc
Repository:
rL LLVM
http://reviews
Author: fjricci
Date: Mon Apr 25 15:34:34 2016
New Revision: 267462
URL: http://llvm.org/viewvc/llvm-project?rev=267462&view=rev
Log:
Create _lldb python symlink correctly when LLVM_LIBDIR_SUFFIX is used
Summary:
Do not assume that liblldb.so is located in $(lldb -P)/../../../lib
when creating th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267462: Create _lldb python symlink correctly when
LLVM_LIBDIR_SUFFIX is used (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19067?vs=54077&id=54894#toc
Repository:
rL LLVM
Author: fjricci
Date: Mon Apr 25 15:36:22 2016
New Revision: 267463
URL: http://llvm.org/viewvc/llvm-project?rev=267463&view=rev
Log:
Store absolute path for lldb executable in dotest.py
Summary:
lldb-server tests are currently being skipped on the
check-lldb target. This is because we get the pa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267463: Store absolute path for lldb executable in dotest.py
(authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19082?vs=53637&id=54895#toc
Repository:
rL LLVM
http://reviews.l
Author: fjricci
Date: Mon Apr 25 15:59:11 2016
New Revision: 267466
URL: http://llvm.org/viewvc/llvm-project?rev=267466&view=rev
Log:
Use Process Plugin register indices when communicating with remote
Summary:
eRegisterKindProcessPlugin is used to store the register
indices used by the remote, an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267466: Use Process Plugin register indices when
communicating with remote (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19305?vs=54303&id=54900#toc
Repository:
rL LLVM
ht
fjricci added a comment.
Committed with comment added to ReadRegister declaration to specify that the
argument is an eRegisterKindProcessPlugin register number
Repository:
rL LLVM
http://reviews.llvm.org/D19305
___
lldb-commits mailing list
lldb
Author: fjricci
Date: Mon Apr 25 16:02:24 2016
New Revision: 267467
URL: http://llvm.org/viewvc/llvm-project?rev=267467&view=rev
Log:
Properly unload modules from target image list when using svr4 packets
Summary:
When we receive an svr4 packet from the remote, we check for new modules
and add th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267467: Properly unload modules from target image list when
using svr4 packets (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19230?vs=54083&id=54902#toc
Repository:
rL LLVM
Author: fjricci
Date: Mon Apr 25 16:03:55 2016
New Revision: 267468
URL: http://llvm.org/viewvc/llvm-project?rev=267468&view=rev
Log:
Maintain register numbering across xml include features
Summary:
If the remote uses include features when communicating
xml register info back to lldb, the existin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267468: Maintain register numbering across xml include
features (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19303?vs=54298&id=54904#toc
Repository:
rL LLVM
http://review
Author: fjricci
Date: Mon Apr 25 14:02:05 2016
New Revision: 267443
URL: http://llvm.org/viewvc/llvm-project?rev=267443&view=rev
Log:
test commit
Modified:
lldb/trunk/docs/lldb-for-gdb-users.txt
Modified: lldb/trunk/docs/lldb-for-gdb-users.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/t
101 - 152 of 152 matches
Mail list logo
