[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

emrekultursay created this revision. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There are two DataExtractors in scope: one from the llvm namespace and one from the lldb_private namespace. Some Microsoft Visual C++ compile

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

emrekultursay added a comment. Hi shafik, can you also submit it? I don't have submit permission. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.llvm.org/D120718 ___ ll

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

emrekultursay updated this revision to Diff 412361. emrekultursay added a comment. Removed "using namespace llvm" from the implementation file and qualified all associated references with "llvm::". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12071

[Lldb-commits] [PATCH] D120718: Qualify DataExtractor with lldb_private

emrekultursay added a comment. In D120718#3352450 , @JDevlieghere wrote: > I think the better solution here is to get rid of the `using namespace llvm;` > in the implementation file instead. Done. PTAL. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

emrekultursay updated this revision to Diff 412621. emrekultursay added a comment. Reverted the changes to the header file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.llvm.org/D120718 Files: lldb/source/Core/DataFi

[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

emrekultursay marked an inline comment as done. emrekultursay added a comment. Thanks. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.llvm.org/D120718 ___ lldb-commits ma

[Lldb-commits] [PATCH] D128832: [lldb-server] Skip shared regions for memory allocation

emrekultursay created this revision. Herald added a project: All. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D128832 Files: lldb/include/lldb/Target/Memor

[Lldb-commits] [PATCH] D128832: [lldb-server] Skip shared regions for memory allocation

emrekultursay updated this revision to Diff 441058. emrekultursay added a comment. Added test that covers shared (s) input Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128832/new/ https://reviews.llvm.org/D128832 Files: lldb/include/lldb/Target

[Lldb-commits] [PATCH] D128832: [lldb-server] Skip shared regions for memory allocation

emrekultursay updated this revision to Diff 441060. emrekultursay added a comment. Removed redundant comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128832/new/ https://reviews.llvm.org/D128832 Files: lldb/include/lldb/Target/MemoryRegionI

[Lldb-commits] [PATCH] D128832: [lldb-server] Skip shared regions for memory allocation

emrekultursay marked an inline comment as done. emrekultursay added a comment. PTAL. Comment at: lldb/unittests/Process/Utility/LinuxProcMapsTest.cpp:278 check_regions(params); } DavidSpickett wrote: > I don't see a test for a mapping with "s" for the shari

[Lldb-commits] [PATCH] D128832: [lldb-server] Skip shared regions for memory allocation

emrekultursay marked an inline comment as done. emrekultursay added a comment. Thanks. Please commit on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128832/new/ https://reviews.llvm.org/D128832 _

[Lldb-commits] [PATCH] D131821: Add test that shows the problem with aed965d5

emrekultursay created this revision. Herald added a project: All. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The test is identical to API/lang/c/stepping/ except: 1. It uses C++ and thus needs demangling support 2. It us

[Lldb-commits] [PATCH] D131821: Add test that shows the problem with D118814

emrekultursay added a comment. In D131821#3723474 , @JDevlieghere wrote: > I applied your patch and ran the test and for me it's passing: Thanks Jonas, I believe https://reviews.llvm.org/D127999 (and follow-ups) fixed the bug I was observing. I was syn

[Lldb-commits] [PATCH] D128126: Support expressions in the context of a reference

emrekultursay created this revision. Herald added a project: All. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ...type variable by dereferencing the variable before evaluating the expression. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D128126: Support expressions in the context of a reference

emrekultursay updated this revision to Diff 438156. emrekultursay added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128126/new/ https://reviews.llvm.org/D128126 Files: lldb/source/Expression/UserExpression.cpp lldb/test/AP

[Lldb-commits] [PATCH] D128126: Support expressions in the context of a reference

emrekultursay updated this revision to Diff 438157. emrekultursay added a comment. re-rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128126/new/ https://reviews.llvm.org/D128126 Files: lldb/source/Expression/UserExpression.cpp lldb/test/

[Lldb-commits] [PATCH] D128126: Support expressions in the context of a reference

emrekultursay updated this revision to Diff 438454. emrekultursay added a comment. Use loop instead of code duplication in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128126/new/ https://reviews.llvm.org/D128126 Files: lldb/source/Express

[Lldb-commits] [PATCH] D128126: Support expressions in the context of a reference

emrekultursay marked an inline comment as done. emrekultursay added a comment. Thanks. Please submit the change on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128126/new/ https://reviews.llvm.org/D128126 __

[Lldb-commits] [PATCH] D128264: [lldb/dyld-posix] Avoid reading the module list in inconsistent states

emrekultursay added a comment. > Mainly added you in case you want to try this out on android. Thanks. I tested this on a few Android API levels, and it looks good to me. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:441 + &m

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

emrekultursay created this revision. Herald added a project: All. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Leaving bits uncleared set causes callbacks to be triggered even though there are no events to process. Starting

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

emrekultursay updated this revision to Diff 498257. emrekultursay added a comment. Herald added a subscriber: JDevlieghere. Fix indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144240/new/ https://reviews.llvm.org/D144240 Files: lldb/s

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

emrekultursay added a comment. > As discussed internally, it would be great if we could remove this > android-specific code path (by removing support for OS versions which > necessitated it). For now, Android Studio still requires the ability to debug API levels 16-19. The next time that min A

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

emrekultursay added a comment. Can you submit the change for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144240/new/ https://reviews.llvm.org/D144240 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

emrekultursay added a comment. Sure, you are right that it should be pulled back into release/16.x, and I expect it to apply cleanly. However, I don't know what mechanism should bve used to create cherry-pick changes into release branches on GitHub: (1) this was not a GitHub issue/PR, so I gues

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay created this revision. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When rebase_exec=true in DidAttach(), all modules are loaded before the rendezvous breakpoint is set, which means the LoadInterpreterModule()

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 372711. emrekultursay added a comment. Applied clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYL

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 372982. emrekultursay added a comment. Added m_initial_modules_added=true into LoadAllCurrentModules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: l

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay added a comment. In D109797#3003265 , @labath wrote: > Since the meaning of `m_initial_modules_added` is basically "should I do a > full scan through the linked list" and LoadAllCurrentModules (called from > DidAttach) does a full scan, it

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 373559. emrekultursay added a comment. Add new dlopen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 373560. emrekultursay added a comment. Minor touch-ups to the newly added test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: lldb/source/Plugins/Dyn

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay added a comment. In D109797#3005885 , @labath wrote: > I'm not sure all of this is relevant. I've just tried to debug a very simple > (linux) executable that does a dlopens a library. If I attach to the > executable before the dlopen call,

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 374026. emrekultursay added a comment. Update test to pass on MacOS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: lldb/source/Plugins/DynamicLoader/P

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 374027. emrekultursay added a comment. Minor fix in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay added a comment. plabath/mgorny: This change is ready for another round of review. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 ___ ll

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 374237. emrekultursay edited the summary of this revision. emrekultursay added a comment. Make test also run on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay marked 3 inline comments as done. emrekultursay added a comment. PTAL. The test now passes on Linux, MacOS, and Windows. Comment at: lldb/test/API/functionalities/dlopen/main.cpp:26 + // dlopen the 'liblib_b.so' shared library. + void* h = dlopen(solib, RTLD_LAZ

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 374536. emrekultursay marked 4 inline comments as done. emrekultursay added a comment. Renamed test to load_after_attach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay added a comment. Done. Can you also submit it please? Comment at: lldb/test/API/functionalities/dlopen/main.cpp:26 + // dlopen the 'liblib_b.so' shared library. + void* h = dlopen(solib, RTLD_LAZY); + assert(h && "dlopen failed?"); labath wrote

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

emrekultursay created this revision. emrekultursay added a reviewer: LLDB. Herald added a project: LLDB. When using IPv6 host:port pairs, typically the host is put inside brackets, such as [2601:1234:...:0213]:, and the UriParser can handle this format. However, the Android infrastructure in

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

emrekultursay updated this revision to Diff 252499. emrekultursay edited the summary of this revision. emrekultursay added a comment. Added unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/ https://reviews.llvm.org/D76736 Files: lldb/source/Utility/UriParser.cpp

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

emrekultursay updated this revision to Diff 252622. emrekultursay added a comment. - Added comments to Android-specific test cases, as suggested by labath@. - Reformatted lines that exceeded 80 chars. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/ https://reviews.llvm.org/D7

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

emrekultursay added a comment. I don't have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/ https://reviews.llvm.org/D76736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [PATCH] D76803: Remove m_last_file_sp from SourceManager

emrekultursay created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. emrekultursay updated this revision to Diff 252675. emrekultursay added a comment. emrekultursay updated this revision to Diff 252677. No changes emrekultursay added a comment. Adding 3rd

[Lldb-commits] [PATCH] D76803: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 252677. emrekultursay added a comment. Adding 3rd commit to diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76803/new/ https://reviews.llvm.org/D76803 Files: lldb/include/lldb/Core/Debugger.h lldb

[Lldb-commits] [PATCH] D76803: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 252675. emrekultursay added a comment. No changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76803/new/ https://reviews.llvm.org/D76803 Files: lldb/include/lldb/Core/SourceManager.h lldb/source/Co

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. emrekultursay added a child revision: D76806: Remove m_last_file_sp from SourceManager. Lookup and subsequent insert was done using uninitialized FileSpec object, which caused the cache to

[Lldb-commits] [PATCH] D76804: Add new LLDB setting: use-source-cache

emrekultursay created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. emrekultursay added a child revision: D76805: Fix SourceManager::SourceFileCache insertion. LLDB memory-maps large source files, and at the same time, caches all source files in the Source

[Lldb-commits] [PATCH] D76803: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 252679. emrekultursay added a comment. - Remove m_last_file_sp from SourceManager Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76803/new/ https://reviews.llvm.org/D76803 Files: lldb/include/lldb/Core/

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ...and replace it with m_last_file_spec instead. When Source Cache is enabled, the value stored in m_last_file_sp is already in the Source Cache, and caching it again in SourceManager bring

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay updated this revision to Diff 252702. emrekultursay added a comment. fix link warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76805/new/ https://reviews.llvm.org/D76805 Files: lldb/source/Core/SourceManager.cpp Index: lldb/

[Lldb-commits] [PATCH] D76804: Add new LLDB setting: use-source-cache

emrekultursay added a comment. I did not see any existing tests that validate setting/reading of properties. Can you point to me if you know any that exists? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76804/new/ https://reviews.llvm.org/D76804

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay updated this revision to Diff 252734. emrekultursay added a comment. Herald added a subscriber: mgorny. Add unit tests for SourceManager::SourceFileCache Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76805/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay added a comment. > Does this actually depend on the other patch? It looks like an independent > fix we could commit separately. This bug seems to have existed forever. Fixing it means we will have source file cache enabled for the first time. If it causes any unforeseen issues, I'

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay updated this revision to Diff 252881. emrekultursay marked 3 inline comments as done. emrekultursay added a comment. Applied labath@'s suggestions on test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76805/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay marked 3 inline comments as done. emrekultursay added a comment. In D76806#1943062 , @labath wrote: > It's not clear to me what is the user-visible effect of this. It sounds like > there should be one, but I don't know what it is... If LLD

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 252888. emrekultursay added a comment. Applied suggestions from labath@ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files: lldb/include/lldb/Core/SourceMana

[Lldb-commits] [PATCH] D76804: Add new LLDB setting: use-source-cache

emrekultursay updated this revision to Diff 253013. emrekultursay added a comment. - Apply code review comments from labath@ - Wipe source cache when user sets the property to false - Also expose set/get methods for use-source-cache in SBDebugger Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 253254. emrekultursay added a comment. Added test that verifies end-to-end impact of "setting set use_source_cache false" on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://revie

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay added a comment. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 253260. emrekultursay added a comment. Cleanup the Python test to make it a bit more readable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files: lldb/includ

[Lldb-commits] [PATCH] D76804: Add new LLDB setting: use-source-cache

emrekultursay added a comment. I added an end-to-end test to the entire use-source-cache feature in https://reviews.llvm.org/D76806 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76804/new/ https://reviews.llvm.org/D76804 ___

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay added a comment. In D76805#1949642 , @labath wrote: > Ok, that makes kind of sense, though I am left wondering if we really need > this feature, given that we have survived so long without noticing it is > missing... > > Am I understanding

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 253648. emrekultursay marked 6 inline comments as done. emrekultursay added a comment. PTAL. Applied suggested changes, thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ http

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 253651. emrekultursay added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files: lldb/include/lldb/Core/SourceManager.h lldb/sour

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 254241. emrekultursay marked an inline comment as done. emrekultursay added a comment. use assertGreater instead of assertTrue(x>y) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 254292. emrekultursay added a comment. Fix missing use of GetLastFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files: lldb/include/lldb/Core/SourceManage

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay added a comment. I don't have commit access, can someone with access commit all three approved CLs in this stack? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 ___

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 256416. emrekultursay added a comment. Fix broken tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files: lldb/include/lldb/Core/SourceManager.h lldb/so

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay added a comment. Thanks for noticing the test breakages Pavel. I fixed the bug, and verified that the tests you mentioned pass. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 __

[Lldb-commits] [PATCH] D100977: Use forward type in pointer-to-member

emrekultursay created this revision. Herald added a reviewer: shafik. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This change is similar in spirit to the change at: https://reviews.llvm.org/rG34c697c85e9d0af11a72ac4df5578a

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

emrekultursay updated this revision to Diff 339483. emrekultursay added a comment. Added functionality/lazy-loading test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100977/new/ https://reviews.llvm.org/D100977 Files: lldb/source/Plugins/Symbo

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

emrekultursay updated this revision to Diff 339485. emrekultursay added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100977/new/ https://reviews.llvm.org/D100977 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTPar

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

emrekultursay added a comment. I added a lazy-loading test. I also attempted to write a test similar to `lang/cpp/static_member_type_depending_on_parent_size/TestStaticMemberTypeDependingOnParentSize.py`, but I could not get it to produce an incorrect struct size (just like I couldn't reduce th

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

emrekultursay updated this revision to Diff 339694. emrekultursay added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100977/new/ https://reviews.llvm.org/D100977 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClan

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

emrekultursay added a comment. > DependsOnParam2 x; This must have been the magic glue I was missing, Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100977/new/ https://reviews.llvm.org/D100977 _

[Lldb-commits] [PATCH] D79586: Do not list adb devices when a device id is given

emrekultursay created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. On Android, this method gets called twice: first when establishing a host-server connection, then when attaching to a process id. Each call takes several seconds to finish (especiall

[Lldb-commits] [PATCH] D79757: Try IPv4 before IPv6 when creating TCP connection

emrekultursay created this revision. Herald added subscribers: lldb-commits, mgrang. Herald added a project: LLDB. When connecting to Android, LLDB calls adb#Shell 5 times. At each call, a TCP connection to "localhost:port" needs to be established. On hosts that support IPv4 and IPv6, the "localho

[Lldb-commits] [PATCH] D79757: Try IPv4 before IPv6 when creating TCP connection

emrekultursay updated this revision to Diff 263327. emrekultursay added a comment. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/ https://reviews.llvm.org/D79757 Files: lldb/source/Host/common/TCPSocket.cpp Ind

[Lldb-commits] [PATCH] D79757: Try IPv4 before IPv6 when creating TCP connection

emrekultursay updated this revision to Diff 263599. emrekultursay added a comment. Enforce IPv4 usage only in Android code, revert non-Android changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/ https://reviews.llvm.org/D79757 Files:

[Lldb-commits] [PATCH] D79757: Try IPv4 before IPv6 when creating TCP connection

emrekultursay added a comment. In D79757#2031186 , @labath wrote: > ... > Where do the addresses that we're connecting to come from (the user or lldb > code)? If it's lldb code, maybe we could just replace the relevant > "localhost" names with an explic

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

emrekultursay added a comment. I admit I don't fully understand the details of that CL and how it may interact with this one. However, I can say that I verified this CL with an Android device connected over IPv6. So, I think this CL is ready to be submitted. (I don't have commit access). Repo

[Lldb-commits] [PATCH] D79586: Do not list adb devices when a device id is given

emrekultursay added a comment. I don't have commit access. Can someone submit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79586/new/ https://reviews.llvm.org/D79586 ___ lldb-commits mailing lis