dawn created this revision.
dawn added a reviewer: jasonmolenda.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
Clearly ">=" was meant to be ">". :)
Repository:
rL LLVM
https://reviews.llvm.org/D26260
Files:
source/Plugins/DynamicLoader/MacOSX
Author: dperchik
Date: Wed Nov 2 15:57:34 2016
New Revision: 285858
URL: http://llvm.org/viewvc/llvm-project?rev=285858&view=rev
Log:
Fix typo which broke debugging on older OSX systems after r285172.
Reviewed by: jasonmolenda
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.
dawn added a subscriber: lldb-commits.
Users:
paulherman (Author)
http://reviews.llvm.org/rL247836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn accepted this commit.
dawn added a comment.
> Clang (the LLDB compiler) does not ask for the value ScNSpacGl in the global
> namespace, but just for a value named ScNSpacGl.
Ok, I've opened a separate bug for this then,
https://llvm.org/bugs/show_bug.cgi?id=24994.
Users:
paulherman (A
dawn added a subscriber: dawn.
dawn added a comment.
Bug https://llvm.org/bugs/show_bug.cgi?id=24995 opened for "regressions" after
this commit.
Users:
paulherman (Author)
http://reviews.llvm.org/rL247836
___
lldb-commits mailing list
lldb-commi
dawn accepted this revision.
dawn added a comment.
This revision is now accepted and ready to land.
Please apply requested changes, then it's good to commit. Thanks for fixing
this!
Comment at: source/Commands/CommandObjectExpression.cpp:306
@@ -306,7 +305,3 @@
if (m_
Author: dperchik
Date: Thu Oct 1 16:15:43 2015
New Revision: 249072
URL: http://llvm.org/viewvc/llvm-project?rev=249072&view=rev
Log:
[lldb-mi] Add support for StopAtEntry in MI via "-exec-run --start".
This patch adds a --start option to the lldb-mi -exec-run command for
getting process stopped
dawn added a subscriber: dawn.
dawn added a comment.
This patch fixes bugs:
- https://llvm.org/bugs/show_bug.cgi?id=24994 (::val gets NS::val inside NS
since r247746)
- https://llvm.org/bugs/show_bug.cgi?id=24995 (shadowed var gets ambiguity
since r247836)
See inline comments. Mostly had conc
dawn added a comment.
Was this patch run on the entire set of lldb tests? Were there any regressions?
http://reviews.llvm.org/D13350
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
dawn added a comment.
> You can use clang-format to follow the LLDB coding style, or just do the
> following:
So we've been telling folks to use clang-format, but it's not working correctly
(my version is clang-format version 3.6.0 (217927)). It's turns:
bool
DoesPrintValue (lldb::SBValu
dawn added a comment.
This patch is good to commit now right? It's not marked "accepted" for some
reason.
http://reviews.llvm.org/D13058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
dawn added a comment.
This test is still failing. Can you please have a look? Thanks.
Users:
jaydeep (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
dawn added a comment.
This test is still failing. Can you please have a look? Thanks.
Users:
jaydeep (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
dawn added a comment.
This test is still failing. Can you please have a look? Thanks.
Users:
jingham (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247709
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
dawn added a comment.
Test TestTerminal.LaunchInTerminalTestCase.test_launch_in_terminal is still
failing. Can you please have a look? Thanks.
Users:
spyffe (Author)
dawn (Auditor)
http://reviews.llvm.org/rL248048
___
lldb-commits mailing l
Author: dperchik
Date: Wed Oct 7 14:55:33 2015
New Revision: 249597
URL: http://llvm.org/viewvc/llvm-project?rev=249597&view=rev
Log:
[lldb-mi] Fix evaluation of strings containing characters from non-ascii range
If a string contained characters outside the ASCII range, lldb-mi would
print them
dawn added a subscriber: lldb-commits.
Users:
sas (Author)
http://reviews.llvm.org/rL249434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
This broke the lldb build on OSX using cmake. After this commit, we get:
CMake Error at cmake/modules/AddLLVM.cmake:401 (add_library):
Cannot find source file:
/Users/testuser/build/works
dawn created this revision.
dawn added reviewers: sas, clayborg, zturner.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
This fixes the cmake build on OSX when building in a new workspace. It
reverts r249434 and instead fixes the issue as proposed i
dawn added a comment.
See http://reviews.llvm.org/D13535 for a workaround.
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL249434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: dperchik
Date: Wed Oct 7 17:01:12 2015
New Revision: 249624
URL: http://llvm.org/viewvc/llvm-project?rev=249624&view=rev
Log:
Decide on the expression language inside UserExpression
When the target settings are consulted to decide the expression language
is decided in CommandObjectExpres
dawn added a comment.
In http://reviews.llvm.org/D13535#262225, @zturner wrote:
> I can't verify that this works on MacOSX at the moment. Did you verify that
> this works on other platforms as well?
I've confirmed it works on MacOSX - I'll try to test Linux later today if no
one beats me to
dawn added a comment.
Works fine on Linux too.
Repository:
rL LLVM
http://reviews.llvm.org/D13535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn added a comment.
Can someone accept this patch so I can commit please?
Repository:
rL LLVM
http://reviews.llvm.org/D13535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn added a comment.
What other details are you looking for?
Users:
jaydeep (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
dawn added inline comments.
Comment at: tools/lldb-server/CMakeLists.txt:42
@@ +41,3 @@
+ if (LLDB_VERS_GENERATED_FILE)
+add_dependencies(lldb-server swig_wrapper)
+ endif()
brucem wrote:
> Why is this needed?
You get undefined symbol otherwise (if you build
dawn added inline comments.
Comment at: tools/lldb-server/CMakeLists.txt:42
@@ +41,3 @@
+ if (LLDB_VERS_GENERATED_FILE)
+add_dependencies(lldb-server swig_wrapper)
+ endif()
dawn wrote:
> brucem wrote:
> > Why is this needed?
> You get undefined symbol other
Author: dperchik
Date: Thu Oct 8 07:35:21 2015
New Revision: 249684
URL: http://llvm.org/viewvc/llvm-project?rev=249684&view=rev
Log:
[cmake] Fix cmake build on OSX after r249434.
Reviewed by: zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13535
Modified:
dawn added a comment.
I went ahead and committed this since the build was completely broken - I'd be
happy to apply any suggestions folks make here in subsequent commits.
Repository:
rL LLVM
http://reviews.llvm.org/D13535
___
lldb-commits mailin
dawn added a comment.
In http://reviews.llvm.org/D13535#262670, @brucem wrote:
> The way to do this correctly is something like
> ...
Can you open a new patch which shows your suggested changes please? Or at
least clarify how the add_custom_command should look in this case and where it
shou
dawn added a comment.
In http://reviews.llvm.org/D13535#262672, @brucem wrote:
> I don't know what's broken for you. My build hasn't had any issues on Mac OS
> X using cmake.
In a clean workspace, cmake would fail because LLDB_vers.c hadn't been created
yet. You get the error:
CMake Error
dawn added a comment.
FYI - our Jenkins master build just picked up the change and is finally
building again - yay!! :)
Repository:
rL LLVM
http://reviews.llvm.org/D13535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
dawn accepted this commit.
dawn added a comment.
Build fixed in svn r249684.
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL249434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
dawn added a comment.
Hi Bruce, thanks for this patch! I'll give it a try now...
http://reviews.llvm.org/D13552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn accepted this revision.
dawn added a comment.
This revision is now accepted and ready to land.
Works great! Please commit. (Sorry for delay - I ran into problems with clang
crashing on me for unknown reasons - finally got the build working again so I
could test).
http://reviews.llvm.org
dawn accepted this commit.
dawn added a comment.
The filing test was removed by Greg in r249613.
Users:
jaydeep (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
dawn accepted this commit.
dawn added a comment.
This test is no longer failing.
Users:
jaydeep (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
dawn added a subscriber: lldb-commits.
Users:
sas (Author)
http://reviews.llvm.org/rL250335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
First, sorry for my delay in reviewing your patch, but I've been on vacation
and now am at the C++ ANSI meeting in Kona for this week. But...
This broke the build of cmake on OSX. We get:
[...]
[2
dawn added a comment.
One resolution would be to check for the cmake version and conditionally enable
the new code, but that's beyond my capabilities - anyone know how? If not, can
we please revert this commit?
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL250335
__
dawn added a comment.
Please review http://reviews.llvm.org/D13995 for a proposed fix.
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL250335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
dawn created this revision.
dawn added reviewers: brucem, sas, krytarowski, enlight, labath.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
Older versions of cmake don't support the -E env option which was added in
r250335, causing the build to fail w
Author: dperchik
Date: Thu Oct 22 17:48:52 2015
New Revision: 251073
URL: http://llvm.org/viewvc/llvm-project?rev=251073&view=rev
Log:
[cmake] Fix cmake build on OSX after r250335 for older versions of cmake
Reviewed by: sas
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org
dawn accepted this commit.
dawn added a comment.
Breakage with older cmake versions fixed in svn r251073.
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL250335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists
Author: dperchik
Date: Thu Oct 22 19:02:56 2015
New Revision: 251080
URL: http://llvm.org/viewvc/llvm-project?rev=251080&view=rev
Log:
Summary provider for char.
This patch enables type summary for 'char' type. Given:
char c = 'h';
Before this patch, c evaluates as:
(char) $0 = 'h'
After
Author: dperchik
Date: Thu Oct 22 19:23:53 2015
New Revision: 251082
URL: http://llvm.org/viewvc/llvm-project?rev=251082&view=rev
Log:
[lldb-mi] display summary for simple types + refactor (use lldb formatting for
all cases)
Previously, lldb did not use type summaries for simple types with no ch
dawn created this revision.
dawn added reviewers: jasonmolenda, clayborg.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
svn r251091 introduced references to LC_VERSION_MIN_TVOS and
LC_VERSION_MIN_WATCHOS which aren't defined in XCode versions older t
Author: dperchik
Date: Fri Oct 23 20:24:00 2015
New Revision: 251169
URL: http://llvm.org/viewvc/llvm-project?rev=251169&view=rev
Log:
[debugserver] Fix indentation in RNBRemote.cpp.
Modified:
lldb/trunk/tools/debugserver/source/RNBRemote.cpp
Modified: lldb/trunk/tools/debugserver/source/RNB
Author: dperchik
Date: Fri Oct 23 20:31:12 2015
New Revision: 251172
URL: http://llvm.org/viewvc/llvm-project?rev=251172&view=rev
Log:
[debugserver] Fix OSX build for older XCode versions after r251091.
This fixes the OSX build for XCode versions older than 7 by skipping
references to LC_VERSION_
Author: dperchik
Date: Fri Oct 23 21:01:28 2015
New Revision: 251176
URL: http://llvm.org/viewvc/llvm-project?rev=251176&view=rev
Log:
[lldb-mi] Fix expansion of anonymous structures and unions
A variable of type:
struct S {
union {
inti1;
unsigned u1;
dawn marked an inline comment as done.
dawn added a comment.
In http://reviews.llvm.org/D12115#248069, @chaoren wrote:
> Could you please take a look at these issues?
>
> TestMiSymbol started to fail on Linux with gcc-4.9:
> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds
dawn added a subscriber: dawn.
dawn closed this revision.
dawn added a comment.
This was committed in svn r251820.
Repository:
rL LLVM
http://reviews.llvm.org/D13073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
dawn added a subscriber: dawn.
dawn added a reviewer: evgeny777.
dawn added a comment.
Eugene has been doing some work in this area - perhaps he can accept this patch
for you.
http://reviews.llvm.org/D12809
___
lldb-commits mailing list
lldb-commit
dawn requested changes to this revision.
dawn added a reviewer: dawn.
dawn added a comment.
This revision now requires changes to proceed.
1. Please rebase again - this patch no longer applies cleanly, and fails to
build after fixing merge conflicts.
2. Please add tests.
http://reviews.llvm.org
dawn added a subscriber: dawn.
dawn accepted this revision.
dawn added a reviewer: dawn.
dawn added a comment.
Patch is correct - without it we loop through the same decl context again.
I've tested it locally - there are no new regressions.
http://reviews.llvm.org/D14542
___
Author: dperchik
Date: Wed Nov 11 18:43:22 2015
New Revision: 252831
URL: http://llvm.org/viewvc/llvm-project?rev=252831&view=rev
Log:
[test] Fix comment.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/options/TestExprOptions.py
Modified:
lldb/trunk/packages/Python/
dawn added a comment.
See inline comment.
Comment at: source/Symbol/ClangASTContext.cpp:9191
@@ -9189,2 +9190,3 @@
+continue;
searched.insert(it->second);
symbol_file->ParseDeclsForContext(CompilerDeclContext(this,
it->secon
dawn created this revision.
dawn added reviewers: tberghammer, clayborg, tfiala.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
Other compilers (and older Clang compilers) use data4/data8 forms to specify
addresses in DWARF. This patch fixes lldb to
dawn abandoned this revision.
dawn added a comment.
> If you have a compiler that is actually emitting addresses incorrectly using
> DW_FORM_data* when the values are not offsets, the compiler should be fixed.
Thanks Greg! In this case it indeed appears to be a compiler bug (we are
getting re
dawn added a comment.
In http://reviews.llvm.org/D14631#289917, @tberghammer wrote:
> How you end up in calling DWARFFormValue::Address() with a value what have a
> form type other then DW_FORM_addr and DW_FORM_GNU_addr_index? What is the
> attribute tag and the form type used? Can you post a c
dawn accepted this commit.
dawn added a comment.
Not really an acceptance, but the test that started failing as a result of this
commit (LaunchInTerminalTestCase.test_launch_in_terminal) has been XFAILed o
OSX in svn.252699 thanks to Todd Fiala. None the less, it would be a good idea
to inves
dawn created this revision.
dawn added a reviewer: jingham.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
This patch fixes setting breakpoints on symbol for variants of C and Pascal
where the language is "unknown" within the filtering process added i
dawn accepted this revision.
dawn added a comment.
lgtm. Patch was applied locally and tested with no regressions. Thanks for
fixing the patch.
http://reviews.llvm.org/D12809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.
dawn added a comment.
Jim, this patch doesn't attempt to fix the issue I raised in my comment - it
just fixes the oversight of other C variants (clang picks C99 for example) and
renames your function to a more meaningful name (and matches
Mangled::GuessLanguage which is also uses the name to gu
Author: dperchik
Date: Fri Dec 4 13:34:00 2015
New Revision: 254753
URL: http://llvm.org/viewvc/llvm-project?rev=254753&view=rev
Log:
Fix breakpoint language filtering for other C variants (like C99) and Pascal.
This patch fixes setting breakpoints on symbol for variants of C and
Pascal where th
dawn added a comment.
In http://reviews.llvm.org/D12809#301752, @sivachandra wrote:
> @dawn: Thanks for accepting the patch. I guess I still need to wait for
> sign-off/comments from a CODE_OWNER.
Yeah. Maybe add more proactive reviewers? And definitely be a squeaky wheel
about it. Keep a
dawn created this revision.
dawn added reviewers: paulherman, clayborg, granata.enrico.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
When multiple functions are found by name, lldb removes duplicate entries of
functions with the same type, so the fi
dawn updated this revision to Diff 42115.
dawn added a comment.
Updated patch to removed change related to Pascal language - it should be part
of a separate patch.
Repository:
rL LLVM
http://reviews.llvm.org/D15312
Files:
include/lldb/Symbol/ClangASTContext.h
include/lldb/Symbol/GoASTCo
dawn created this revision.
dawn added a reviewer: jingham.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
This patch reworks the breakpoint filter-by-language patch to use the symbol
context instead of trying to guess the language solely from the sym
dawn added a comment.
bloodbath:~% exit
Thanks Greg! To address your main point:
> So either make it generic, or clang specific.
DeclContextCountDeclLevels's interface follows DeclContextFindDeclByName
(authored by Paul Herman). If DeclContextCountDeclLevels is to change, then
DeclContextFi
dawn added a comment.
> Greg: But going forward I would like to see more of "find a struct named 'X'
in CompilerDeclContext 'Y'" queries, instead of ...
I think lldb should have both, a "search for anything named foo in my scope
context" (for when a user does "p foo"), and a "search for a thin
dawn added a comment.
In http://reviews.llvm.org/D15326#305163, @jingham wrote:
> The part of this fix which is using info in the SymbolContext to make the
> language detection more accurate is fine.
>
> We have to do something better about how we detect the language from a
> mangled name. The
dawn added a reviewer: clayborg.
dawn added a comment.
(Added Greg - he wrote Mangled::GetLanguage - now GuessLanguage).
This patch removes the dependence on determining language from the name
mangling for 99% of cases (there's still the much less common problem for
symbols since Symbol 's GetL
dawn requested a review of this revision.
dawn added a comment.
Please reconsider. Thanks.
Repository:
rL LLVM
http://reviews.llvm.org/D15326
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
dawn marked an inline comment as done.
dawn added a comment.
Thanks Greg. Will fix comment in commit.
@Jim, can you accept please?
Repository:
rL LLVM
http://reviews.llvm.org/D15326
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
dawn marked 6 inline comments as done.
dawn added a comment.
Hi Greg, I'm working on a new revision to change the patch as you suggest
(thanks for your review - you had some great suggestions!).
Sorry, if I'm missing something obviously here, but there's still some things I
don't understand:
1
dawn marked 3 inline comments as done.
dawn added a comment.
> It seems like you combined "find this decl instance within a decl context"
> with "find a decl by name in the CompilerDeclContext and optionally get the
> type".
It it exactly "find this decl instance within a decl context".
> I a
dawn updated this revision to Diff 42375.
dawn added a comment.
This version of the patch makes the API specific to clang.
Repository:
rL LLVM
http://reviews.llvm.org/D15312
Files:
include/lldb/Symbol/ClangASTContext.h
packages/Python/lldbsuite/test/lang/cpp/namespace/Makefile
packages
dawn updated this revision to Diff 42385.
dawn added a comment.
This version of the patch is the API "generic" version of the patch. Please
choose to review which ever is preferred, and I will submit another patch based
on that version if needed.
BTW Greg, thanks for the suggestion of multimap
dawn updated this revision to Diff 42476.
dawn added a comment.
Updated Clang-specific version of patch.
Repository:
rL LLVM
http://reviews.llvm.org/D15312
Files:
include/lldb/Symbol/ClangASTContext.h
packages/Python/lldbsuite/test/lang/cpp/namespace/Makefile
packages/Python/lldbsuite/
dawn added a comment.
ping?
Repository:
rL LLVM
http://reviews.llvm.org/D15326
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: dperchik
Date: Fri Sep 30 15:38:33 2016
New Revision: 282941
URL: http://llvm.org/viewvc/llvm-project?rev=282941&view=rev
Log:
Fix comment - Module::PrepareForFunctionNameLookup should be
Module::LookupInfo::LookupInfo.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileD
dawn created this revision.
dawn added reviewers: ted, zturner, clayborg.
dawn added subscribers: amccarth, lldb-commits.
dawn set the repository for this revision to rL LLVM.
The code added in svn trunk 264332 causes "(lldb)" to be printed in the middle
of program console output. This fix rest
Author: dperchik
Date: Sat Oct 1 05:37:56 2016
New Revision: 283031
URL: http://llvm.org/viewvc/llvm-project?rev=283031&view=rev
Log:
[lldb-mi] Fix prompt which can get inserted in the middle of program output in
lldb-mi
Summary: The code added in svn r264332 causes "(lldb) " to be printed in t
Author: dperchik
Date: Sat Dec 12 13:31:41 2015
New Revision: 255439
URL: http://llvm.org/viewvc/llvm-project?rev=255439&view=rev
Log:
Fix scope-based lookup when more than one function is found.
When multiple functions are found by name, lldb removes duplicate entries of
functions with the same
Author: dperchik
Date: Sat Dec 12 14:44:08 2015
New Revision: 255440
URL: http://llvm.org/viewvc/llvm-project?rev=255440&view=rev
Log:
Test case for "Fix scope-based lookup when more than one function is found."
Missed commit in r255439.
Differential Revision: http://reviews.llvm.org/D15312
Adde
dawn updated this revision to Diff 42911.
dawn added a comment.
Updated patch which changes Mangled::GuessLanguage to use the same algorithm
for detecting the language from the mangled name as was added to
LanguageRuntime::GuessLanguageForSymbolByName.
Jim, sorry for the previous ping - I misse
Author: dperchik
Date: Wed Dec 16 13:40:00 2015
New Revision: 255808
URL: http://llvm.org/viewvc/llvm-project?rev=255808&view=rev
Log:
Rework breakpoint language filtering to use the symbol context's language.
This patch reworks the breakpoint filter-by-language patch to use the
symbol context in
dawn added a comment.
Can a "code owner" please review this patch? Thanks, -Dawn
http://reviews.llvm.org/D12809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn created this revision.
dawn added reviewers: clayborg, ki.stfu, abidh.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
This adds support for the new command:
target modules dump line-entries
which dumps the line entries found for 'file' for al
dawn updated this revision to Diff 43076.
dawn added a comment.
Updated patch to include changes to TestHelp.py.
Repository:
rL LLVM
http://reviews.llvm.org/D15593
Files:
packages/Python/lldbsuite/test/help/TestHelp.py
packages/Python/lldbsuite/test/tools/lldb-mi/symbol/TestMiSymbol.py
dawn added a comment.
In http://reviews.llvm.org/D15593#312571, @jingham wrote:
> I don't think this is sufficiently different from "target modules dump
> line-tables" to warrant a separate command. This seems more like a candidate
> for a flag to "target modules dump line-tables" like --searc
dawn added a comment.
In http://reviews.llvm.org/D15593#312665, @jingham wrote:
> So it seems like your change is adding three flags
>
> --compile-unit-only --only-explicit-matches --show-raw
>
> or something. The current behavior is:
>
> --compile-unit-only true --only-explicit-matches fals
dawn added a comment.
I'm only going to support the combinations:
--compile-unit-only true --only-explicit-matches false --show-raw true
--compile-unit-only false --only-explicit-matches true --show-raw false
OK?
Repository:
rL LLVM
http://reviews.llvm.org/D15593
dawn retitled this revision from "Add "target modules dump line-entries "
command and use it to fix MI's -symbol-list-lines." to "Enhance "target modules
dump line " and use it to fix MI's -symbol-list-lines.".
dawn updated the summary for this revision.
dawn updated this revision to Diff 43103.
dawn marked 6 inline comments as done.
dawn added a comment.
> clang-format your changes please (there are many deviations from the coding
> style)
I've made some fixes even though the code is no longer consistent with the rest
of the file. Alas. I would love to run all of lldb through clang
dawn updated this revision to Diff 43152.
dawn marked an inline comment as done.
dawn added a comment.
Updated patch with suggestions from Ilia's review (thanks Ilia!).
Repository:
rL LLVM
http://reviews.llvm.org/D15593
Files:
packages/Python/lldbsuite/test/help/TestHelp.py
packages/Pyth
dawn added a comment.
In http://reviews.llvm.org/D15593#313342, @clayborg wrote:
> Dawn, if you don't understand what I asked you to do,
Sorry for late reply - been recovering from minor surgery. I have a new patch,
but I've not yet gone through all of Ilia's additional comments - will probab
dawn marked 4 inline comments as done.
dawn added a comment.
Replies to Ilia's comments...
Comment at: source/Commands/CommandObjectTarget.cpp:1543
@@ +1542,3 @@
+continue;
+CompileUnit *cu = cu_sp.get();
+const FileSpecList &c
dawn retitled this revision from "Enhance "target modules dump line " and
use it to fix MI's -symbol-list-lines." to "Add support for "source info" and
use it to fix MI's -symbol-list-lines.".
dawn updated the summary for this revision.
dawn updated this revision to Diff 43429.
dawn marked 2 inli
1 - 100 of 196 matches
Mail list logo
