[Lldb-commits] [PATCH] D14631: [dwarf] Handle DWARF forms for address other than DW_FORM_GNU_addr_index and DW_FORM_addr.

[Dawn Perchik via lldb-commits]

dawn created this revision.
dawn added reviewers: tberghammer, clayborg, tfiala.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.

Other compilers (and older Clang compilers) use data4/data8 forms to specify 
addresses in DWARF.  This patch fixes lldb to correctly read the addresses in 
DWARF generated by those compilers.

Repository:
  rL LLVM

http://reviews.llvm.org/D14631

Files:
  source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp

Index: source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
===================================================================
--- source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
+++ source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
@@ -477,11 +477,10 @@
 {
     SymbolFileDWARF* symbol_file = m_cu->GetSymbolFileDWARF();
 
-    if (m_form == DW_FORM_addr)
+    if (m_form != DW_FORM_GNU_addr_index)
         return Unsigned();
 
     assert(m_cu);
-    assert(m_form == DW_FORM_GNU_addr_index);
 
     if (!symbol_file)
         return 0;



Index: source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
===================================================================
--- source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
+++ source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
@@ -477,11 +477,10 @@
 {
     SymbolFileDWARF* symbol_file = m_cu->GetSymbolFileDWARF();
 
-    if (m_form == DW_FORM_addr)
+    if (m_form != DW_FORM_GNU_addr_index)
         return Unsigned();
 
     assert(m_cu);
-    assert(m_form == DW_FORM_GNU_addr_index);
 
     if (!symbol_file)
         return 0;

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits