[Lldb-commits] [lldb] [lldb] Add test to document alias tab completion behaviour (PR #65760)

2023-09-08 Thread David Spickett via lldb-commits
DavidSpickett wrote: This just documents the status quo - but, I'd like to confirm this is expected and desirable behaviour, hence the review. Seems fine to me as it does prevent the user causing some kinds of chaos. `breakpoint` is perhaps just a bad example because it has the single letter

[Lldb-commits] [lldb] f2b2414 - [lldb][AArch64] Re-enable clone follow tests on AArch64 Linux

2023-09-08 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-08T14:10:08Z New Revision: f2b241474f21cd549c233f020021d41bb803f18a URL: https://github.com/llvm/llvm-project/commit/f2b241474f21cd549c233f020021d41bb803f18a DIFF: https://github.com/llvm/llvm-project/commit/f2b241474f21cd549c233f020021d41bb803f18a.diff LOG

[Lldb-commits] [lldb] 9ce82a1 - Wrong link target in the documentation #62990

2023-09-08 Thread David Spickett via lldb-commits
Author: Author: Eddie Phillips Date: 2023-09-08T15:38:28+01:00 New Revision: 9ce82a10a32203746cef70541de4807fb5c008a5 URL: https://github.com/llvm/llvm-project/commit/9ce82a10a32203746cef70541de4807fb5c008a5 DIFF: https://github.com/llvm/llvm-project/commit/9ce82a10a32203746cef70541de4807fb5c00

[Lldb-commits] [lldb] [lldb] Add test to document alias tab completion behaviour (PR #65760)

2023-09-08 Thread David Spickett via lldb-commits
DavidSpickett wrote: That was my first assumption, that they were all in one pool of commands for completion. Then I thought maybe it had been setup this way to protect the built-ins somehow. Given it wasn't tested it may not have been intentionally implemented that way. If people agree that

[Lldb-commits] [lldb] [lldb] Add test to document alias tab completion behaviour (PR #65760)

2023-09-08 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/65760 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8f2ffb1 - [lldb][AArch64] Add type marker to ReadAll/WriteALLRegisterValues data

2023-09-10 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-11T07:56:59+01:00 New Revision: 8f2ffb1cf31fffda0e139dd8afeb02f4001745e5 URL: https://github.com/llvm/llvm-project/commit/8f2ffb1cf31fffda0e139dd8afeb02f4001745e5 DIFF: https://github.com/llvm/llvm-project/commit/8f2ffb1cf31fffda0e139dd8afeb02f4001745e5.diff

[Lldb-commits] [lldb] [lldb] Correctly invalidate unloaded image tokens (PR #65945)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65945 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correctly invalidate unloaded image tokens (PR #65945)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/65945: Some functions in Process were using LLDB_INVALID_ADDRESS instead of LLDB_INVALID_TOKEN. The only visible effect of this appears to be that "process unload " would complete to 0 even after the image was

[Lldb-commits] [lldb] 825adbe - [lldb] Don't tab complete stop-hook delete beyond 1st argument

2023-09-11 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-11T11:00:57Z New Revision: 825adbe5585219ce731045defa019defaf96faab URL: https://github.com/llvm/llvm-project/commit/825adbe5585219ce731045defa019defaf96faab DIFF: https://github.com/llvm/llvm-project/commit/825adbe5585219ce731045defa019defaf96faab.diff LOG

[Lldb-commits] [lldb] [lldb] Correctly invalidate unloaded image tokens (PR #65945)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/65945: >From b041cf0965a397104cd44d76d29f8d69ab26856d Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 11 Sep 2023 10:46:53 + Subject: [PATCH] [lldb] Correctly invalidate unloaded image tokens Some f

[Lldb-commits] [lldb] [lldb] Improve completion tests (PR #65973)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/65973: * Assert no completions for tests that should not find completions. * Remove regex mode from complete_from_to, which was unused. This exposed bugs in 2 of the tests, target stop-hook and process unload. Th

[Lldb-commits] [lldb] [lldb] Improve completion tests (PR #65973)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65973 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve completion tests (PR #65973)

2023-09-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: This builds on https://github.com/llvm/llvm-project/pull/65945, so the first commit is from that PR. If you review using the per commit tab instead that should make it clearer, I hope. This is me trying to imitate a stacked PR and maybe failing, let's see how it goes. ht

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/65974: Previously we would check all built-ins first for suggestions, then check built-ins and aliases. This meant that if you had an alias brkpt -> breakpoint, "br" would complete to "breakpoint". Instead of giv

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: This is a PR "stacked" on https://github.com/llvm/llvm-project/pull/65973, so the first 2 commits are from that and the original one. Review with the commits tab instead of "files changed". https://github.com/llvm/llvm-project/pull/65974 ___

[Lldb-commits] [lldb] [lldb] Correctly invalidate unloaded image tokens (PR #65945)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/65945 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve completion tests (PR #65973)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/65973: >From ea172bdf8b1d66087076b7ed842021749a49b9fb Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 11 Sep 2023 09:09:31 + Subject: [PATCH] [lldb] Improve completion tests * Assert no completions

[Lldb-commits] [lldb] [lldb] Improve completion tests (PR #65973)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/65973: >From ea172bdf8b1d66087076b7ed842021749a49b9fb Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 11 Sep 2023 09:09:31 + Subject: [PATCH 1/2] [lldb] Improve completion tests * Assert no completi

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/65974: >From ea172bdf8b1d66087076b7ed842021749a49b9fb Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 11 Sep 2023 09:09:31 + Subject: [PATCH 1/3] [lldb] Improve completion tests * Assert no completi

[Lldb-commits] [lldb] 6bf923d - [lldb][Tests] Reformat API tests with black

2023-09-11 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-11T16:44:12Z New Revision: 6bf923d5c3daf5d66e0acf53d037a12ceff4a275 URL: https://github.com/llvm/llvm-project/commit/6bf923d5c3daf5d66e0acf53d037a12ceff4a275 DIFF: https://github.com/llvm/llvm-project/commit/6bf923d5c3daf5d66e0acf53d037a12ceff4a275.diff LOG

[Lldb-commits] [lldb] [lldb] Format more Python files with black (PR #65979)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format more Python files with black (PR #65979)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/65979: By running this from lldb/ $ black --exclude "third_party/|scripts/|utils/" ./ >From 56cea5795e0274fe7672c727340330cf46aa30a4 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 11 Sep 2023 16:52:05

[Lldb-commits] [lldb] [lldb] Format more Python files with black (PR #65979)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format more Python files with black (PR #65979)

2023-09-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: Putting this into review mainly to ask @JDevlieghere if any of these shouldn't be formatted. Third party obviously we don't want to format that. Scripts and utils I don't see why not but maybe there are downstream concerns? https://github.com/llvm/llvm-project/pull/65979

[Lldb-commits] [lldb] [lldb] Format more Python files with black (PR #65979)

2023-09-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: I looked around for a way to exclude dirs from black but unfortunately the way is `--exclude`. I was hoping to place some settings file in third_party/ to disable it. https://github.com/llvm/llvm-project/pull/65979 ___ lldb-commi

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread David Spickett via lldb-commits
@@ -20,7 +20,7 @@ def test_command_abbreviations_and_aliases(self): self.assertTrue(result.Succeeded()) self.assertEqual("apropos script", result.GetOutput()) -command_interpreter.ResolveCommand("h", result) +command_interpreter.ResolveCommand("

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread David Spickett via lldb-commits
@@ -20,7 +20,7 @@ def test_command_abbreviations_and_aliases(self): self.assertTrue(result.Succeeded()) self.assertEqual("apropos script", result.GetOutput()) -command_interpreter.ResolveCommand("h", result) +command_interpreter.ResolveCommand("

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/65974: >From ea172bdf8b1d66087076b7ed842021749a49b9fb Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 11 Sep 2023 09:09:31 + Subject: [PATCH 1/4] [lldb] Improve completion tests * Assert no completi

[Lldb-commits] [lldb] [lldb] Improve completion tests (PR #65973)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/65973: >From ea172bdf8b1d66087076b7ed842021749a49b9fb Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 11 Sep 2023 09:09:31 + Subject: [PATCH 1/3] [lldb] Improve completion tests * Assert no completi

[Lldb-commits] [lldb] [lldb] Improve completion tests (PR #65973)

2023-09-11 Thread David Spickett via lldb-commits
@@ -2254,21 +2251,18 @@ def complete_from_to(self, str_input, patterns, turn_off_re_match=False): for idx in range(1, num_matches + 1): compare_string += match_strings.GetStringAtIndex(idx) + "\n" +# If the singular pattern is the

[Lldb-commits] [lldb] [lldb] Improve completion tests (PR #65973)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/65973 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve completion tests (PR #65973)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/65973 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/65974: >From a279ee8b0a7fca5561f5c4703fc7bdd599419a43 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 11 Sep 2023 11:42:45 + Subject: [PATCH 1/2] [lldb] Treat user aliases the same as built-ins when

[Lldb-commits] [lldb] 8012518 - Revert "[lldb] Improve completion tests (#65973)"

2023-09-11 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-11T17:35:27Z New Revision: 8012518f600bebaa4ed99a57d553eeea25c2d0c9 URL: https://github.com/llvm/llvm-project/commit/8012518f600bebaa4ed99a57d553eeea25c2d0c9 DIFF: https://github.com/llvm/llvm-project/commit/8012518f600bebaa4ed99a57d553eeea25c2d0c9.diff LOG

[Lldb-commits] [lldb] 6bf6c47 - Reland "[lldb] Improve completion tests (#65973)"

2023-09-12 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-12T08:40:43+01:00 New Revision: 6bf6c4762c355ce4f4fb976039375a2c8ff6038f URL: https://github.com/llvm/llvm-project/commit/6bf6c4762c355ce4f4fb976039375a2c8ff6038f DIFF: https://github.com/llvm/llvm-project/commit/6bf6c4762c355ce4f4fb976039375a2c8ff6038f.diff

[Lldb-commits] [lldb] [lldb] Format more Python files with black (PR #65979)

2023-09-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/65979: >From 251eaf5271db6ef9646f843ef037d54406544f8d Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 11 Sep 2023 16:52:05 + Subject: [PATCH] [lldb] Format more Python files with black By running th

[Lldb-commits] [lldb] [lldb] Format more Python files with black (PR #65979)

2023-09-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/65979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-12 Thread David Spickett via lldb-commits
@@ -2462,6 +2483,93 @@ class CommandObjectTargetModulesDumpLineTable CommandOptions m_options; }; +#pragma mark CommandObjectTargetModulesDumpSeparateDebugInfoFiles + +// Image debug dwo dumping command + +class CommandObjectTargetModulesDumpSeparateDebugInfoFiles +: pub

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-12 Thread David Spickett via lldb-commits
@@ -2005,9 +2021,10 @@ class CommandObjectTargetModulesDumpSymtab result.GetOutputStream().EOL(); result.GetOutputStream().EOL(); } - if (INTERRUPT_REQUESTED(GetDebugger(), + if (INTERRUPT_REQUESTED(GetDebugger(), ---

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-12 Thread David Spickett via lldb-commits
@@ -282,6 +283,10 @@ class SymbolFileDWARF : public lldb_private::SymbolFileCommon { void DumpClangAST(lldb_private::Stream &s) override; + /// Retrieve the external dwo files. DavidSpickett wrote: "external dwo file details." ? https://github.com/llvm/

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-12 Thread David Spickett via lldb-commits
@@ -2462,6 +2483,93 @@ class CommandObjectTargetModulesDumpLineTable CommandOptions m_options; }; +#pragma mark CommandObjectTargetModulesDumpSeparateDebugInfoFiles + +// Image debug dwo dumping command + +class CommandObjectTargetModulesDumpSeparateDebugInfoFiles +: pub

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-12 Thread David Spickett via lldb-commits
@@ -4214,6 +4216,62 @@ void SymbolFileDWARF::DumpClangAST(Stream &s) { clang->Dump(s.AsRawOstream()); } +bool SymbolFileDWARF::GetSeparateDebugInfoFiles(StructuredData::Array &array) { + DWARFDebugInfo &info = DebugInfo(); + const size_t num_cus = info.GetNumUnits(); + fo

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-12 Thread David Spickett via lldb-commits
@@ -2462,6 +2483,93 @@ class CommandObjectTargetModulesDumpLineTable CommandOptions m_options; }; +#pragma mark CommandObjectTargetModulesDumpSeparateDebugInfoFiles + +// Image debug dwo dumping command + +class CommandObjectTargetModulesDumpSeparateDebugInfoFiles +: pub

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-12 Thread David Spickett via lldb-commits
DavidSpickett wrote: FYI I committed https://reviews.llvm.org/D157609 recently. Looks like your test cases are pretty straightforward but just in case you are confused why lldb manages to find a file when it didn't previously. https://github.com/llvm/llvm-project/pull/66035 ___

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/65974: >From 2e415b3d0bca50b4c172e12a27697b8adf6fabf0 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 11 Sep 2023 11:42:45 + Subject: [PATCH 1/3] [lldb] Treat user aliases the same as built-ins when

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-12 Thread David Spickett via lldb-commits
@@ -20,7 +20,7 @@ def test_command_abbreviations_and_aliases(self): self.assertTrue(result.Succeeded()) self.assertEqual("apropos script", result.GetOutput()) -command_interpreter.ResolveCommand("h", result) +command_interpreter.ResolveCommand("

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-12 Thread David Spickett via lldb-commits
@@ -20,7 +20,7 @@ def test_command_abbreviations_and_aliases(self): self.assertTrue(result.Succeeded()) self.assertEqual("apropos script", result.GetOutput()) -command_interpreter.ResolveCommand("h", result) +command_interpreter.ResolveCommand("

Re: [Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-13 Thread David Spickett via lldb-commits
> I would never never write Python code that ugly. As usual with formatting the conclusions were as long as the same strange decisions are made consistently, it's worth doing. Discussion: https://discourse.llvm.org/t/python-code-style-and-reformatting-status-update/70641/13 Overall project docs:

[Lldb-commits] [lldb] 11de4c7 - [lldb][AArch64] Add tests for SME's SVE register state to TestArm64DynamicRegsets

2023-09-13 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-13T10:07:36+01:00 New Revision: 11de4c724c8e875f75c2d1c733c38051bc818601 URL: https://github.com/llvm/llvm-project/commit/11de4c724c8e875f75c2d1c733c38051bc818601 DIFF: https://github.com/llvm/llvm-project/commit/11de4c724c8e875f75c2d1c733c38051bc818601.diff

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/65974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f8b2544 - [lldb] Link to LLVM code style in LLDB's contributing page

2023-09-13 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-13T10:48:48+01:00 New Revision: f8b2544c422404b0c8d1225d9240301f50de1cdb URL: https://github.com/llvm/llvm-project/commit/f8b2544c422404b0c8d1225d9240301f50de1cdb DIFF: https://github.com/llvm/llvm-project/commit/f8b2544c422404b0c8d1225d9240301f50de1cdb.diff

[Lldb-commits] [lldb] b6f66c9 - [lldb][AArch64] Reformat register set test with black

2023-09-13 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-13T15:52:24Z New Revision: b6f66c94bce7d9c0ef029d133b85925ba23198b4 URL: https://github.com/llvm/llvm-project/commit/b6f66c94bce7d9c0ef029d133b85925ba23198b4 DIFF: https://github.com/llvm/llvm-project/commit/b6f66c94bce7d9c0ef029d133b85925ba23198b4.diff LOG

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-14 Thread David Spickett via lldb-commits
DavidSpickett wrote: I'll be cheeky and assume this is fine to go in. https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/66345: Running: $ clang-format -i $(find -regex "\./lldb/.*\.c") $(find -regex "\./lldb/.*\.cpp") $(find -regex "\./lldb/.*\.h") Resulted in: 1602 files changed, 25090 insertions(+), 25849 deletions(-) (note: t

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread David Spickett via lldb-commits
DavidSpickett wrote: @bulbazord This would be a good place to put your plugin dependency / const string guidance. Or tell me where it lives now and I'll link to it. https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread David Spickett via lldb-commits
DavidSpickett wrote: If anyone knows the other big differences I'll add them. This is what I came up with from my experience and reading the lllvm style doc. https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/66345: >From bcabec98725255c4abed93311d73837d09ac8dde Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 14 Sep 2023 10:05:44 +0100 Subject: [PATCH] [lldb][Docs] Document our major differences from the LLVM

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3ae76e4 - [lldb][Docs] Link to testing page from debugging page

2023-09-14 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-14T11:16:33+01:00 New Revision: 3ae76e4fdc17ad7a7bb94d84cd746e7a98f7d105 URL: https://github.com/llvm/llvm-project/commit/3ae76e4fdc17ad7a7bb94d84cd746e7a98f7d105 DIFF: https://github.com/llvm/llvm-project/commit/3ae76e4fdc17ad7a7bb94d84cd746e7a98f7d105.diff

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/66345 >From bcabec98725255c4abed93311d73837d09ac8dde Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 14 Sep 2023 10:05:44 +0100 Subject: [PATCH 1/2] [lldb][Docs] Document our major differences from the L

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-15 Thread David Spickett via lldb-commits
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. - - **Test infrastructure**: Like LLVM it is important to submit tests with your - patches, but note that

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-15 Thread David Spickett via lldb-commits
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. - - **Test infrastructure**: Like LLVM it is important to submit tests with your - patches, but note that

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-15 Thread David Spickett via lldb-commits
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. - - **Test infrastructure**: Like LLVM it is important to submit tests with your - patches, but note that

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-15 Thread David Spickett via lldb-commits
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. - - **Test infrastructure**: Like LLVM it is important to submit tests with your - patches, but note that

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-15 Thread David Spickett via lldb-commits
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. - - **Test infrastructure**: Like LLVM it is important to submit tests with your - patches, but note that

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-15 Thread David Spickett via lldb-commits
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. - - **Test infrastructure**: Like LLVM it is important to submit tests with your - patches, but note that

[Lldb-commits] [lldb] [lldb][Docs] Update links in Data Formatter section (PR #66474)

2023-09-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/66474 Neither actually linked anywhere, but I did find a good target for the introduction. For the architecture side I don't see a page that would fit, so I've just removed the sentence. >From fa5f8a30e309212e

[Lldb-commits] [lldb] [lldb][Docs] Update links in Data Formatter section (PR #66474)

2023-09-15 Thread David Spickett via lldb-commits
DavidSpickett wrote: Would skip review, but it's here on the off chance @JDevlieghere knows where the second link was supposed to go to. The original commit was https://github.com/llvm/llvm-project/commit/edb874b2310dc6eeaa27330ca1b1c013da7bdd65. https://github.com/llvm/llvm-project/pull/6647

[Lldb-commits] [lldb] [lldb][Docs] Update links in Data Formatter section (PR #66474)

2023-09-15 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/66474 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1a8b36b - [lldb][Docs] Link up the newly restored data formatters page

2023-09-18 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-18T13:20:42+01:00 New Revision: 1a8b36b16c3778dc458182ea342904e574b008c7 URL: https://github.com/llvm/llvm-project/commit/1a8b36b16c3778dc458182ea342904e574b008c7 DIFF: https://github.com/llvm/llvm-project/commit/1a8b36b16c3778dc458182ea342904e574b008c7.diff

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

2023-09-18 Thread David Spickett via lldb-commits
DavidSpickett wrote: I updated the links to and from this in https://github.com/llvm/llvm-project/commit/1a8b36b16c3778dc458182ea342904e574b008c7. https://github.com/llvm/llvm-project/pull/66527 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-19 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

2023-09-19 Thread David Spickett via lldb-commits
DavidSpickett wrote: This is failing on Arm 32 bit (https://lab.llvm.org/buildbot/#/builders/17/builds/43300), I'll reproduce and fix it. I expect it just needs to expect 8 hex characters instead of 16. https://github.com/llvm/llvm-project/pull/66548 ___

[Lldb-commits] [lldb] 9568601 - [lldb] Correct expected output for variable on 32 bit platforms

2023-09-19 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-19T08:28:34Z New Revision: 956860168b56f135b9facf3827ae9f3634d41f40 URL: https://github.com/llvm/llvm-project/commit/956860168b56f135b9facf3827ae9f3634d41f40 DIFF: https://github.com/llvm/llvm-project/commit/956860168b56f135b9facf3827ae9f3634d41f40.diff LOG

[Lldb-commits] [lldb] 91f46ec - [lldb][AArch64] Document how to control the SVE/SSVE tests

2023-09-19 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-19T08:51:37Z New Revision: 91f46ece9efca7a1109b5837a1b24f2a251bb0cc URL: https://github.com/llvm/llvm-project/commit/91f46ece9efca7a1109b5837a1b24f2a251bb0cc DIFF: https://github.com/llvm/llvm-project/commit/91f46ece9efca7a1109b5837a1b24f2a251bb0cc.diff LOG

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

2023-09-19 Thread David Spickett via lldb-commits
DavidSpickett wrote: https://github.com/llvm/llvm-project/commit/956860168b56f135b9facf3827ae9f3634d41f40 https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] d99d9d8 - [lldb][AArch64] Add SME's Array Storage (ZA) register

2023-09-19 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-19T10:49:57Z New Revision: d99d9d8b74ffcb8ac418fcdafa750b07f2bd9935 URL: https://github.com/llvm/llvm-project/commit/d99d9d8b74ffcb8ac418fcdafa750b07f2bd9935 DIFF: https://github.com/llvm/llvm-project/commit/d99d9d8b74ffcb8ac418fcdafa750b07f2bd9935.diff LOG

[Lldb-commits] [lldb] a0768b8 - [lldb][AArch64] Add SME streaming vector length pseduo register

2023-09-19 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-19T11:18:27Z New Revision: a0768b8237ad83a6493a5053e615e0c38d7410ee URL: https://github.com/llvm/llvm-project/commit/a0768b8237ad83a6493a5053e615e0c38d7410ee DIFF: https://github.com/llvm/llvm-project/commit/a0768b8237ad83a6493a5053e615e0c38d7410ee.diff LOG

[Lldb-commits] [lldb] 46b961f - [lldb][AArch64] Implement resizing of SME's ZA register

2023-09-19 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-19T12:05:22Z New Revision: 46b961f36bc5b1105356d1701f0c7c9d439be9c8 URL: https://github.com/llvm/llvm-project/commit/46b961f36bc5b1105356d1701f0c7c9d439be9c8 DIFF: https://github.com/llvm/llvm-project/commit/46b961f36bc5b1105356d1701f0c7c9d439be9c8.diff LOG

[Lldb-commits] [lldb] e96adfd - [lldb][AArch64] Add testing for SME's ZA and SVG registers

2023-09-19 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-19T12:18:23Z New Revision: e96adfd0dbcf84c27be2087371890f4228890609 URL: https://github.com/llvm/llvm-project/commit/e96adfd0dbcf84c27be2087371890f4228890609 DIFF: https://github.com/llvm/llvm-project/commit/e96adfd0dbcf84c27be2087371890f4228890609.diff LOG

[Lldb-commits] [lldb] [lldb][AArch64] Add release notes and documentation for SME (PR #66767)

2023-09-19 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/66767 This adds a release note for all the SME support now in LLDB and a page where I have documented the user experience (for want of a better term) when using SVE and SME. This includes things like which mode

[Lldb-commits] [lldb] [lldb][AArch64] Add release notes and documentation for SME (PR #66767)

2023-09-19 Thread David Spickett via lldb-commits
DavidSpickett wrote: Replaces https://reviews.llvm.org/D158506. https://github.com/llvm/llvm-project/pull/66767 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

2023-09-19 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/66768 This fixes a bug where writing vg during streaming mode could prevent you reading za directly afterwards. vg is invalided when the write happens. SVE is reconfigured by reading back the new value from the

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

2023-09-19 Thread David Spickett via lldb-commits
DavidSpickett wrote: Replaces https://reviews.llvm.org/D158514. https://github.com/llvm/llvm-project/pull/66768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 87f937e - [lldb][Docs] Fix typo in style docs

2023-09-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-20T08:04:23Z New Revision: 87f937e9d68ae3ceea93982420f06bf90623aeba URL: https://github.com/llvm/llvm-project/commit/87f937e9d68ae3ceea93982420f06bf90623aeba DIFF: https://github.com/llvm/llvm-project/commit/87f937e9d68ae3ceea93982420f06bf90623aeba.diff LOG

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-20 Thread David Spickett via lldb-commits
@@ -18,19 +18,45 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. - - **Test infrastructure**: Like LLVM it is important to submit tests with your - patches, but note that

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1446e3c - Revert "Fix a bug with cancelling "attach -w" after you have run a process previously (#65822)"

2023-09-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-20T08:19:53Z New Revision: 1446e3cf7605f0988b914fac0a34d63045394ff3 URL: https://github.com/llvm/llvm-project/commit/1446e3cf7605f0988b914fac0a34d63045394ff3 DIFF: https://github.com/llvm/llvm-project/commit/1446e3cf7605f0988b914fac0a34d63045394ff3.diff LOG

<    4   5   6   7   8   9   10   11   12   13   >