https://github.com/DavidSpickett commented:
Please update the PR description with an explanation of the bug you are fixing,
along the lines of the comment you wrote previously.
https://github.com/llvm/llvm-project/pull/106950
___
lldb-commits mailing
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/106950
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) {
static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response,
uint64_t fail_result, Status &error)
{
+ // The packet is expected to have the following
@@ -760,6 +772,61 @@ def test_riscv64_regs(self):
self.expect("register read --all")
+@skipIfLLVMTargetMissing("RISCV")
DavidSpickett wrote:
I'm saying that if risc-v grows a lot of strange register state, it will be
better served by separate te
@@ -760,6 +772,61 @@ def test_riscv64_regs(self):
self.expect("register read --all")
+@skipIfLLVMTargetMissing("RISCV")
DavidSpickett wrote:
As an example of what I mean about future extensions being "too weird" -
In the new Arm extension suppor
@@ -760,6 +772,61 @@ def test_riscv64_regs(self):
self.expect("register read --all")
+@skipIfLLVMTargetMissing("RISCV")
DavidSpickett wrote:
> For this PR, just consider renaming the test functions here so that they list
> what they are testing.
Author: David Spickett
Date: 2024-09-04T09:33:35Z
New Revision: 0b2550f8ab77a53f560f6a7a1b401c4803a36d48
URL:
https://github.com/llvm/llvm-project/commit/0b2550f8ab77a53f560f6a7a1b401c4803a36d48
DIFF:
https://github.com/llvm/llvm-project/commit/0b2550f8ab77a53f560f6a7a1b401c4803a36d48.diff
LOG
Author: David Spickett
Date: 2024-09-04T09:43:18Z
New Revision: 5a658ee933065d0e4ef1a65d9a6ddfba2874ee98
URL:
https://github.com/llvm/llvm-project/commit/5a658ee933065d0e4ef1a65d9a6ddfba2874ee98
DIFF:
https://github.com/llvm/llvm-project/commit/5a658ee933065d0e4ef1a65d9a6ddfba2874ee98.diff
LOG
Author: David Spickett
Date: 2024-09-04T10:22:58Z
New Revision: d77ccae4a629ba11b5c28f97222a8834c5e5c183
URL:
https://github.com/llvm/llvm-project/commit/d77ccae4a629ba11b5c28f97222a8834c5e5c183
DIFF:
https://github.com/llvm/llvm-project/commit/d77ccae4a629ba11b5c28f97222a8834c5e5c183.diff
LOG
@@ -728,7 +746,6 @@ def test_riscv64_regs(self):
"fa2",
"fa3",
"fa4",
-"fa5",
DavidSpickett wrote:
I would replace this line with:
```
# fa5 is non-zero and checked in the list above.
```
https://github.com/llvm
DavidSpickett wrote:
Just one more thing then this is good to go.
Do you have commit access or will you need me to merge it for you?
https://github.com/llvm/llvm-project/pull/104547
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
DavidSpickett wrote:
A couple of suggestions.
Perhaps you could reduce the PRs just to the files with the biggest differences
on AIX, and include those changes in the PR. So that it is copying the file +
making the AIX changes in one PR. Even if you have to add files that aren't
used yet, we
@@ -38,6 +38,12 @@ endif()
include(LLDBConfig)
include(AddLLDB)
+# This has been added to keep the AIX build isolated for now.
+# It will need to be modified later.
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ add_definitions("-D__AIX__")
DavidSpickett
@@ -38,6 +38,12 @@ endif()
include(LLDBConfig)
include(AddLLDB)
+# This has been added to keep the AIX build isolated for now.
+# It will need to be modified later.
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ add_definitions("-D__AIX__")
DavidSpickett
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) {
static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response,
uint64_t fail_result, Status &error)
{
+ // The packet is expected to have the following
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) {
static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response,
uint64_t fail_result, Status &error)
{
+ // The packet is expected to have the following
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) {
static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response,
uint64_t fail_result, Status &error)
{
+ // The packet is expected to have the following
DavidSpickett wrote:
Is this part of a larger effort, do you have a link to an RFC or previous PRs?
I assume the motivation is const correctness?
https://github.com/llvm/llvm-project/pull/107536
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
DavidSpickett wrote:
Great, please add that link to the PR description and then this can land.
https://github.com/llvm/llvm-project/pull/107536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/107536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/107536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,96 @@
+"""
+Test RISC-V expressions evaluation.
+"""
DavidSpickett wrote:
Yeah I'm not sure if this is known failures or known passes.
Adding skipif riscv or xfail to the known failures seems like the better
option. Tip for that, the lldb tests call
@@ -0,0 +1,217 @@
+//===--- DirectCallReplacementPass.cpp - RISC-V specific pass
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,62 @@
+//===--- DirectCallReplacementPass.h - RISC-V specific pass
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,44 @@
+//===-- Ptrace.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/108000
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,44 @@
+//===-- Ptrace.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/DavidSpickett commented:
This is exactly the style of PR I was looking for, thanks.
I don't want this to land without some code that uses it however. So I suggest
we iterate on this until it's approved, then you put up the next PR and so on.
We'll find some later point where
@@ -0,0 +1,44 @@
+//===-- Ptrace.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,62 @@
+//===--- DirectCallReplacementPass.h - RISC-V specific pass
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/108072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -491,24 +491,47 @@ NativeProcessWindows::OnDebugException(bool first_chance,
return ExceptionResult::MaskException;
}
case DWORD(STATUS_BREAKPOINT):
- case STATUS_WX86_BREAKPOINT:
-if (FindSoftwareBreakpoint(record.GetExceptionAddress())) {
- LLDB_LOG(log,
@@ -143,8 +142,14 @@
NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64(
const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
-: NativeRegisterContextWindows(native_
@@ -143,8 +142,14 @@
NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64(
const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
-: NativeRegisterContextWindows(native_
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/108072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Remind me, does lldb support hardware breakpoints for x86 right now either?
From the content of this PR, I assume it does not.
(which is fine, I'm just trying to be clear what our starting point is)
https://github.com/llvm/llvm-project/pull/108072
_
DavidSpickett wrote:
ping!
I should also note that all required changes are in the kernel, but not in
firmware. I have used a WIP firmware patch that the kernel contributor also
used, to develop this. So there is a tiny chance that there would be changes
later when official firmware support i
DavidSpickett wrote:
Relates to https://github.com/llvm/llvm-project/issues/80665
https://github.com/llvm/llvm-project/pull/108072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Does this impact https://github.com/llvm/llvm-project/pull/106950 at all?
https://github.com/llvm/llvm-project/pull/108170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
@@ -143,8 +142,14 @@
NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64(
const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
-: NativeRegisterContextWindows(native_
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/108183
I've been testing against qemu-aarch64 using the qemu-user platform, which
doesn't support get-file:
```
AssertionError: False is not true : Command 'platform get-file "/proc/cpuinfo"
<...>/TestAArch64Lin
DavidSpickett wrote:
Note that this is not part of a big push to get the test suite working this
way, it's because I've been working on qemu compatibility as part of
https://github.com/llvm/llvm-project/issues/87471 and need to sanity check my
changes somehow.
https://github.com/llvm/llvm-pro
DavidSpickett wrote:
If anyone wants to actually get the features we'll either have to delay checks
until there is an actual process, or find a command line to qemu to dump out
the features in equivalent form. But either way - not something I'm going to do
myself.
https://github.com/llvm/llvm
@@ -143,8 +142,14 @@
NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64(
const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
-: NativeRegisterContextWindows(native_
DavidSpickett wrote:
> Yes I think there might be a Windows API launch flag that can let us do early
> detection of hardware breakpoints and watchpoints. But so far after lots of
> experimentation I have not been able to find the right set.
Is it possible this is a bug in Windows itself? Thoug
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/108226
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/108183
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-09-12T10:35:11Z
New Revision: adde85e7c3ade54b22c99d405fc9c3add869db0a
URL:
https://github.com/llvm/llvm-project/commit/adde85e7c3ade54b22c99d405fc9c3add869db0a
DIFF:
https://github.com/llvm/llvm-project/commit/adde85e7c3ade54b22c99d405fc9c3add869db0a.diff
LOG
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/108365
Fixes #107864
QEMU decided that when SVE is enabled it will only tell us about SVE registers
in the XML, and not include Neon registers. On the grounds that the Neon V
registers can be read from the bott
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/108365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
The data order of SVE and Neon in this situation is probably wrong, but I'm not
aiming to address that here.
https://github.com/llvm/llvm-project/pull/108365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
@@ -31,6 +31,22 @@ class ProcessInstanceInfo;
class ProcessInstanceInfoMatch;
typedef std::vector ProcessInstanceInfoList;
+// Always on system log category and channel.
DavidSpickett wrote:
So is the log naming `system system` or for now is it just `system`
@@ -0,0 +1,3 @@
+RUN: %lldb -o 'log list' -o 'log disable system' 2>&1 | FileCheck %s
+CHECK-NOT: Logging categories for 'system'
+CHECK: Cannot disable internal log channel 'system'.
DavidSpickett wrote:
This is bikeshedding but perhaps:
```
`system` is an inter
DavidSpickett wrote:
> Unlike other, existing log channels, it is not exposed to users.
This is presumably because:
1. It contains very low level messages they likely won't be interested in.
2. If it weren't hidden, it would be printing into their sessions all the time.
Users can still list it,
DavidSpickett wrote:
>We have a similar concept in the downstream Swift fork and this has proven to
>be extremely valuable. This is especially true on macOS where system log
>messages are automatically captured as part of a sysdiagnose.
Does this mean someone has already been putting non-MacOS
DavidSpickett wrote:
> "if a thread stops at a breakpoint site, we set the thread's stop reason to
> breakpoint-hit, even if the breakpoint hasn't been executed"
What does it look like for a thread to be stopped at a *breakpoint site* but
not to have executed the breakpoint?
Is this just a ti
https://github.com/DavidSpickett approved this pull request.
Still curious exactly how we end up with threads on a breakpoint that didn't
execute it -
https://github.com/llvm/llvm-project/pull/108504#issuecomment-2348626494
But aside from that this LGTM.
https://github.com/llvm/llvm-project/p
DavidSpickett wrote:
Thanks I understand now.
https://github.com/llvm/llvm-project/pull/108504
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-09-17T09:30:14Z
New Revision: b39a100ff4ec16f1f9cafcc48ea7fed920726650
URL:
https://github.com/llvm/llvm-project/commit/b39a100ff4ec16f1f9cafcc48ea7fed920726650
DIFF:
https://github.com/llvm/llvm-project/commit/b39a100ff4ec16f1f9cafcc48ea7fed920726650.diff
LOG
DavidSpickett wrote:
The test case is failing on Windows, for reasons not related to it being
Windows but due to data layout.
The const string is placed at the start of a region:
```
(lldb) p rawptr
(const char *) 0x7ff77fcb5000 "dead"
(lldb) memory region --all
<...>
[0x7ff77fc61000-0x
Author: David Spickett
Date: 2024-09-17T12:51:46Z
New Revision: ab38ec9ac312460e4f71c8ad3f50b9b5723469f6
URL:
https://github.com/llvm/llvm-project/commit/ab38ec9ac312460e4f71c8ad3f50b9b5723469f6
DIFF:
https://github.com/llvm/llvm-project/commit/ab38ec9ac312460e4f71c8ad3f50b9b5723469f6.diff
LOG
DavidSpickett wrote:
I've disabled this on Windows for now but please address the issue generally.
Testing memory region overlaps is tricky. I did it for memory tagging by hoping
that the kernel would allocate pages in the right order, which worked for at
least simulated systems. Pavel recentl
@@ -0,0 +1,96 @@
+"""
+Test RISC-V expressions evaluation.
+"""
DavidSpickett wrote:
Are these tests going to be removed then?
On the grounds that existing tests in the test suite will cover these scenarios.
https://github.com/llvm/llvm-project/pull/99336
_
@@ -1011,6 +1011,135 @@ void RuntimeDyldELF::resolveBPFRelocation(const
SectionEntry &Section,
}
}
+static void applyUTypeImmRISCV(uint8_t *InstrAddr, uint32_t Imm) {
DavidSpickett wrote:
Does this still need to be done?
https://github.com/llvm/llvm-proje
@@ -279,6 +279,9 @@ void IRExecutionUnit::GetRunnableInfo(Status &error,
lldb::addr_t &func_addr,
.setMCJITMemoryManager(std::make_unique(*this))
.setOptLevel(llvm::CodeGenOptLevel::Less);
+ if (triple.isRISCV64())
DavidSpickett wrote:
This shou
DavidSpickett wrote:
If folks could close any of their comments that have now been addressed, it
would be much easier to determine what is left to do.
We're going for the "most thorough review" record here :) Thanks for sticking
with it @dlav-sc .
https://github.com/llvm/llvm-project/pull/993
DavidSpickett wrote:
Will look at this properly tomorrow but just looking at the title, I'm
surprised that https://github.com/llvm/llvm-project/pull/88812 did not also fix
this. Perhaps putfile and install are different paths.
https://github.com/llvm/llvm-project/pull/108996
__
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
DavidSpickett wrote:
Pretty sure you need to follow the specific co-author format as shown on:
https
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
DavidSpickett wrote:
> This is what going to happen right? But than how we will be able to see which
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
DavidSpickett wrote:
If you are working for some kind of group or scheme, I suggest you ask them how
DavidSpickett wrote:
> This is the current issue for symbol search:
> https://github.com/llvm/llvm-project/issues/57372
Put `Fixes 57372` instead.
> Co-author: @junior-jl
This needs to be in the `Co-authored-by: NAME ` format.
https://github.com/llvm/llvm-project/pull/69422
__
@@ -163,7 +166,10 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
dumped_something = true;
if (symbol->GetType() == eSymbolTypeTrampoline)
s->PutCString("symbol stub for: ");
- symbol->GetName().Dump(s);
+ if (p
DavidSpickett wrote:
I expected this coming out of draft to do something with subscribers, but that
hasn't happened. No problem, I'll do it manually.
@llvm/pr-subscribers-lldb This change is now ready for review. There is a lot
of discussion here already but it has all been resolved so you can
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I took the liberty of adding some blank lines to the PR message, just for
readability. Also, I suspect that git might prefer having the co-author line
separated from the message, but it probably doesn't matter anyway.
https://github.com/llvm/llvm-project/pull/69422
___
@@ -265,8 +265,6 @@ class CommandObjectProcessLaunch : public
CommandObjectProcessLaunchOrAttach {
process_sp->SyncIOHandler(0, std::chrono::seconds(2));
llvm::StringRef data = stream.GetString();
DavidSpickett wrote:
If we don't need `data`
@@ -282,6 +280,8 @@ class CommandObjectProcessLaunch : public
CommandObjectProcessLaunchOrAttach {
exe_module_sp->GetFileSpec().GetPath().c_str(), archname);
}
result.SetStatus(eReturnStatusSuccessFinishResult);
+if (!data.empty())
---
DavidSpickett wrote:
I was about to tell you about the `process launch -m` shortcut, then I realised
you added that yourself :)
> Upon implementing this change, two tests failed:
> lldb/test/Shell/Breakpoint/jit-loader_jitlink_elf.test and
> lldb/test/Shell/Breakpoint/jit-loader_rtdyld_elf.te
DavidSpickett wrote:
You can use a few specific terms to auto close an issue when a related PR
lands:
https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests
`Fixes #12345` for example.
https://github.com/llvm/llvm-p
DavidSpickett wrote:
Also could you include a bit more explanation of the problem in the commit
message. The issue is great, but it'll save someone a few clicks if you just
include a sentence or two more in the commit message.
https://github.com/llvm/llvm-project/pull/73173
___
DavidSpickett wrote:
When you're doing these updates, remember that the PR's message is the one used
for the final merge. You can update both if you like, but the PR message wins.
(for llvm-project that is, this is a per-repository setting)
https://github.com/llvm/llvm-project/pull/69422
_
DavidSpickett wrote:
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests
LLVM is "the pull request title and description", from my experience. You get a
final chance to edit it
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
DavidSpickett wrote:
Opinions differ on what goes in a commit message but this seems fine to me, I'd
just remove the sub-headings. My usual rule is that folks can choose not to
read it if they don't want to, include as much information as y
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett approved this pull request.
This LGTM just fixup the PR message and you can merge it.
(if you don't have the permissions to do that, I can do it for you, let me know
when you're ready)
https://github.com/ll
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/73321
…rpreter
It was:
```
error: there is no embedded script interpreter in this mode.
```
1. What does "mode" mean?
2. It implies there might be an embedded script interpreter for some other
"mode", whatever
DavidSpickett wrote:
I might be butchering the meaning of the message, but you see what I'm going
for.
https://github.com/llvm/llvm-project/pull/73321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/73321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/73321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
DavidSpickett wrote:
> Also, I tried using the --fixup flag on the second commit, does that mean the
> squashing is automatic or I need to squash the commits and push again?
Honestly I've never used that flag. I'm not sure it matters with t
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -26,17 +26,19 @@ ScriptInterpreterNone::ScriptInterpreterNone(Debugger
&debugger)
ScriptInterpreterNone::~ScriptInterpreterNone() = default;
+static const char *no_interpreter_err_msg =
+"There is no embedded script interpreter. Check that LLDB was built with a
"
+
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/73321
>From bc00c8f219134554d2dcbcb39e7565797c1ed14c Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 24 Nov 2023 12:05:41 +
Subject: [PATCH] [lldb] Improve error message for script commands when ther
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/73321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2023-11-27T09:10:56Z
New Revision: 772f296214e10323ca16921c02b1852307b7d51b
URL:
https://github.com/llvm/llvm-project/commit/772f296214e10323ca16921c02b1852307b7d51b
DIFF:
https://github.com/llvm/llvm-project/commit/772f296214e10323ca16921c02b1852307b7d51b.diff
LOG
Author: David Spickett
Date: 2023-11-28T09:15:51Z
New Revision: 1459c627f0bc1a4938b5b6a7f4c2bdc1f3ec6a2c
URL:
https://github.com/llvm/llvm-project/commit/1459c627f0bc1a4938b5b6a7f4c2bdc1f3ec6a2c
DIFF:
https://github.com/llvm/llvm-project/commit/1459c627f0bc1a4938b5b6a7f4c2bdc1f3ec6a2c.diff
LOG
DavidSpickett wrote:
I've reverted this due to failures on Linaro's Linux bots.
https://github.com/llvm/llvm-project/pull/68845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
lldb Arm Linux bots all green now, thanks for fixing this.
https://github.com/llvm/llvm-project/pull/73707
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -1618,12 +1621,15 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
if (symbol->ValueIsAddress()) {
DumpAddress(
interpreter.GetExecutionContext().GetBestExecutionC
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -1618,12 +1621,15 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
if (symbol->ValueIsAddress()) {
DumpAddress(
interpreter.GetExecutionContext().GetBestExecutionC
501 - 600 of 2681 matches
Mail list logo
