DavidSpickett wrote:
> If you have a recent build of lldb on windows (with python enabled), could
> you run the scripting template list command and paste the output here.
As of 229a16590a3cd65da77bb868498d3eed63bf6263:
```
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build>.\bin\lldb.exe
(lld
@@ -22,6 +25,60 @@ def _disallow(config, execName):
config.substitutions.append((" {0} ".format(execName),
warning.format(execName)))
+def get_lldb_args(config, suffix=""):
+lldb_args = []
+if "remote-linux" in config.available_features:
+lldb_args += [
+
DavidSpickett wrote:
Ok, that seems reasonable. I'm still in a mode of thinking where a given build
is all remote or all native. `LLDB_SHELL_TESTS_DISABLE_REMOTE` allows you to
reuse all the settings you went to the trouble to set up, but on the host not
the remote.
Though another way of thin
@@ -244,6 +244,7 @@ llvm_canonicalize_cmake_booleans(
LLVM_ENABLE_ZLIB
LLVM_ENABLE_SHARED_LIBS
LLDB_HAS_LIBCXX
+ LLDB_SHELL_TESTS_DISABLE_REMOTE
DavidSpickett wrote:
It would be good to declare this and the other new options in CMake with
docstrings so
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/95986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Looks good to me. @labath should give this another look as the biggest skeptic
here :)
And @JDevlieghere who was also tagged earlier (start with the RFC though
https://discourse.llvm.org/t/rfc-lldb-support-remote-run-of-shell-tests/80072).
https://github.com/llvm/llvm-pro
DavidSpickett wrote:
I don't know, it never occurred to me to do so before now. @omjavaid mentioned
it so maybe he knows something about it.
https://github.com/llvm/llvm-project/pull/100710
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/100487
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/100487
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
What did you intend with `/H`? If anything it would be
https://learn.microsoft.com/en-us/cpp/build/reference/h-restrict-length-of-external-names?view=msvc-170
but clang-cl doesn't support this one.
(yes, the bot uses clang-cl, we really should change the name)
https://git
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/101672
…ld issue"
This reverts commit 9effefbae8d96006a4dd29bb9ab8532fd408559d.
With the include order in ScriptedProcessPythonInterface.cpp fixed (though I
cannot explain exactly why it works) and removes the
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/101672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/101672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I tried making lldb-pthon.h the literal first include of the file but this
doesn't work. When it gets to SWIGPythonBridge.h the redefinition happens
again, no idea why, I'd think NO_PID_T would still be defined.
https://github.com/llvm/llvm-project/pull/101672
DavidSpickett wrote:
I'm not going to merge this myself as I'm finishing for the week, but you can
if you want to get that test added sooner.
https://github.com/llvm/llvm-project/pull/101672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
https://github.com/DavidSpickett approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/101929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
This is for this sort of lookup:
```
(lldb) reg read pc
```
Right? As opposed to tab completion.
This needs a test case or at least a clear example as a comment in the code if
a test is not possible. It seems fine from how you've described it but these
things come across b
https://github.com/DavidSpickett approved this pull request.
So the things listed are "scripting extensions" and then there are templates to
get started using those extensions. Makes sense to me.
https://github.com/llvm/llvm-project/pull/101935
___
ll
DavidSpickett wrote:
I'll apply this PR locally and see what I get.
https://github.com/llvm/llvm-project/pull/96260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I reduced
`lldb/test/API/functionalities/breakpoint/step_over_breakpoint/TestStepOverBreakpoint.py`
a bit to the point where it stalls, which is when it tries to step over from
breakpoint 2 to 3 in `test_step_over`:
```
int b = func(); // breakpoint_2
a = b + func(
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/102144
That aren't the generated `python_api/` pages.
This button is a pencil icon at the top right of the page and takes you to a
GitHub page where you can edit the content, assuming you have a fork already.
I
DavidSpickett wrote:
https://github.com/pradyunsg/furo/blob/main/src/furo/theme/furo/components/edit-this-page.html
is the file that gets extended.
https://github.com/llvm/llvm-project/pull/102144
___
lldb-commits mailing list
lldb-commits@lists.llvm.
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/102144
>From 8fddf6f57dcb4bcdef78139f49718fcc2ea0fd20 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 6 Aug 2024 13:25:32 +0100
Subject: [PATCH 1/2] [lldb][Docs] Add edit link to docs pages
That aren't
DavidSpickett wrote:
> Thanks @DavidSpickett just to be sure, this is armv7 right, not AArch32?
This is an AArch32 container on Armv8. I'm not sure if lldb-server knows the
difference though. Maybe it doesn't need to, and ptrace single step is done in
the kernel which uses the h/w step.
But i
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/102144
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/102590
Removing them simplifies the content and means we don't confuse anyone who
joined after the Phabricator shutdown.
You could use them for review archaeology but this is only a subset of the
names you'd en
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/102601
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -38,6 +38,10 @@ endif()
include(LLDBConfig)
include(AddLLDB)
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ add_definitions("-D__AIX__")
DavidSpickett wrote:
This looks like a macro that a compiler might set for you, is that not the case
here?
http
@@ -11,6 +11,11 @@
#include "lldb/Host/Config.h"
+#if defined(__AIX__)
+//FIXME for AIX
+#undef LLDB_ENABLE_LIBXML2
DavidSpickett wrote:
In theory if you configure with `-DLLDB_ENABLE_LIBXML2=OFF`, the libxml2 parts
will be removed. Was something else being
https://github.com/DavidSpickett commented:
It's worth putting the PR into draft mode just to be extra clear this is a
request for early feedback.
This PR will be later split up of course, so very general comments from me.
Very impressive effort overall.
https://github.com/llvm/llvm-project/p
@@ -40,6 +40,113 @@ add_custom_target(lldb-sbapi-dwarf-enums
DEPENDS ${sb_languages_file})
set_target_properties(lldb-sbapi-dwarf-enums PROPERTIES FOLDER
"LLDB/Tablegenning")
+if(CMAKE_SYSTEM_NAME MATCHES "AIX")
+add_lldb_library(liblldb STATIC ${option_framework}
-
@@ -1510,6 +1510,18 @@ bool Module::SetLoadAddress(Target &target, lldb::addr_t
value,
return false;
}
+bool Module::SetLoadAddressByType(Target &target, lldb::addr_t value,
+bool value_is_offset, bool &changed, int type_id) {
+ ObjectFile *obje
@@ -342,7 +342,7 @@ uint32_t SBBreakpoint::GetIgnoreCount() const {
return count;
}
-void SBBreakpoint::SetThreadID(tid_t tid) {
+void SBBreakpoint::SetThreadID(lldb::tid_t tid) {
DavidSpickett wrote:
If these lldb:: are fixing compilation errors they would
@@ -0,0 +1,62 @@
+//===-- Ptrace.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,7 @@
+
+This product contains small piece of code to support AIX, taken from netbsd.
+
+ * LICENSE:
+* lldb/source/Host/common/LICENSE.aix-netbsd.txt (OpenSSL License)
DavidSpickett wrote:
We'll need to confirm license compatibility for this.
htt
@@ -67,6 +67,10 @@ class RegisterContextUnwind : public
lldb_private::RegisterContext {
bool ReadPC(lldb::addr_t &start_pc);
+#ifdef __AIX__
+ bool ReadLR(lldb::addr_t &lr);
+#endif
+
DavidSpickett wrote:
It's likely we'd ask you to make this a method on
@@ -0,0 +1,7 @@
+
+This product contains small piece of code to support AIX, taken from netbsd.
+
+ * LICENSE:
+* lldb/source/Host/common/LICENSE.aix-netbsd.txt (OpenSSL License)
DavidSpickett wrote:
And if there is a way not to pull in this code, we're like
@@ -38,6 +38,10 @@ endif()
include(LLDBConfig)
include(AddLLDB)
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ add_definitions("-D__AIX__")
DavidSpickett wrote:
Also remember that users may be debugging AIX from a non-AIX host where the
compiler would
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/102601
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -841,12 +841,14 @@ static bool CheckIfWatchpointsSupported(Target *target,
Status &error) {
if (!num_supported_hardware_watchpoints)
return true;
- if (num_supported_hardware_watchpoints == 0) {
-error.SetErrorStringWithFormat(
-"Target supports (%u) har
https://github.com/DavidSpickett requested changes to this pull request.
I think this function got a bit confused when we changed the return type to an
optional, thanks for taking a look at it.
https://github.com/llvm/llvm-project/pull/91882
___
lldb-
DavidSpickett wrote:
LLVM uses a GitHub setting where the PR is squashed, and the commit message is
taken from the PR description rather than the commits themselves. So all you
have to do here is copy the commit message you updated into the PR's
description.
https://github.com/llvm/llvm-proje
https://github.com/DavidSpickett approved this pull request.
LLDB changes look good to me.
https://github.com/llvm/llvm-project/pull/91857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
https://github.com/DavidSpickett approved this pull request.
Makes sense to me. LLDB checks that the folder exists locally, which a remote
folder won't, so it's not in the JSON read back. And this test isn't doing
anything with the module cache itself, so any existing local path will do.
https
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91915
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/91886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
>So each ValueObject has the ability to show its value as an enumeration if its
>format is set to eFormatEnum. If the format is set to eFormatHex,
>eFormatUnsigned, or eFormatSigned, then we show the numeric value.
Sure, the problem I have is that often with registers you'
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91923
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2,7 +2,9 @@
Test platform process launch.
"""
+import lldb
DavidSpickett wrote:
Is this required?
https://github.com/llvm/llvm-project/pull/91923
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
@@ -78,6 +93,7 @@ def test_launch_via_vRun_no_args(self):
self.expect_gdbremote_sequence()
@add_test_categories(["llgs"])
+@skipIfRemote
DavidSpickett wrote:
Why is only this test skipped?
https://github.com/llvm/llvm-project/pull/91931
_
@@ -78,6 +93,7 @@ def test_launch_via_vRun_no_args(self):
self.expect_gdbremote_sequence()
@add_test_categories(["llgs"])
+@skipIfRemote
DavidSpickett wrote:
Ah, because we need to open the file while we attempt to run it, and doing that
on t
https://github.com/DavidSpickett approved this pull request.
LGTM
Surprised we haven't needed this before, but I didn't see any existing function
for it.
https://github.com/llvm/llvm-project/pull/91931
___
lldb-commits mailing list
lldb-commits@lists
@@ -108,6 +109,20 @@ def test_platform_file_wronly_fail(self):
)
self.expect_gdbremote_sequence()
+def remote_install(self, path, filename="test"):
+if lldb.remote_platform:
+remote_path = lldbutil.append_to_process_working_directory(sel
https://github.com/DavidSpickett approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/91882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/91882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
If this is split out from the other larger PR, should there be `clang/` changes
in here?
I've copied your commit message into the PR description, because with the way
llvm is setup, we use the PR's description as the commit message for a squashed
version of the changes.
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/91918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/92077
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/92077
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/92124
Comparing a bit of the mock GDB server code to what was in the document I found
these:
* QLaunchArch
* qSpeedTest
* qSymbol
qSymbol is the most mysterious but it did have some examples in a comment so
I'v
DavidSpickett wrote:
It's used for the `process plugin packet speed-test` command, by whom, I have
no idea :)
https://github.com/llvm/llvm-project/pull/92124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/92124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I'm going to go ahead and land this, don't hesitate to revert if there are
still problems.
https://github.com/llvm/llvm-project/pull/84155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/84155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I'm currently assuming that the process classes will check those HWCAPs and
only add those registers to the register info if they exist. This code only
patches registers that are already in the info, it doesn't add any new ones.
That said, explicit is better than implicit,
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/93158
DumpValueObjectOptions can only be created and modified from C++. This means
it's currently only testable from Python by calling some command that happens
to use one, and even so, you can't pick which opti
@@ -0,0 +1,136 @@
+//===-- DumpValueObjectOptionsTests.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,136 @@
+//===-- DumpValueObjectOptionsTests.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/93158
>From aff2acafd911b9eb07405beb5500a487f5d4fc4e Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 1 May 2024 13:08:54 +
Subject: [PATCH 1/2] [lldb][Test] Add C++ tests for DumpValueObjectOptions a
@@ -0,0 +1,136 @@
+//===-- DumpValueObjectOptionsTests.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
Author: David Spickett
Date: 2024-05-23T12:28:26Z
New Revision: 32c3561d44aa792ef08d72b5a4c342c9965bc4c2
URL:
https://github.com/llvm/llvm-project/commit/32c3561d44aa792ef08d72b5a4c342c9965bc4c2
DIFF:
https://github.com/llvm/llvm-project/commit/32c3561d44aa792ef08d72b5a4c342c9965bc4c2.diff
LOG
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/93158
>From 0c6fe37563d7e7ee338a308b32cbea01d1f3808c Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 1 May 2024 13:08:54 +
Subject: [PATCH 1/2] [lldb][Test] Add C++ tests for DumpValueObjectOptions a
DavidSpickett wrote:
I only intend to use the (soon to be) proposed new options from C++, so I'm
going to land this as is, but we certainly could pursue the API route later.
https://github.com/llvm/llvm-project/pull/93158
___
lldb-commits mailing list
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/93158
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/90059
>From 6344ce3feff235f6a3b1bc1d5eb1e50e5695d320 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 11 Mar 2024 10:18:51 +
Subject: [PATCH] [lldb] Add format eFormatEnumWithValues to ensure raw enum
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/90059
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/90059
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/90059
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
@clayborg I have updated this to instead use a format, inspired by
`eFormatBytesWithASCII`. Which is also one value printed twice. There are
examples in the added c++ tests.
https://github.com/llvm/llvm-project/pull/90059
___
lld
@@ -195,11 +195,15 @@ enum Format {
///< character arrays that can contain non printable
///< characters
eFormatAddressInfo,///< Describe what an address points to (func + offset
- ///< with file/line,
DavidSpickett wrote:
@Endilll This being a format type now might mean you can use it from the
formatters. I'm not familiar with what parts of the API you're using there.
https://github.com/llvm/llvm-project/pull/90059
___
lldb-commits mailing list
lld
@@ -297,8 +312,9 @@ class ModuleCompleter : public Completer {
void DoCompletion(SearchFilter *filter) override { filter->Search(*this); }
private:
- const char *m_file_name;
- const char *m_dir_name;
+ std::optional m_file_name;
DavidSpickett wrote:
Unl
@@ -906,3 +906,38 @@ def test_ambiguous_command(self):
def test_ambiguous_subcommand(self):
"""Test completing a subcommand of an ambiguous command"""
self.complete_from_to("settings s ta", [])
+
+def test_shlib_name(self):
+self.build()
+
DavidSpickett wrote:
The new tests are flaky on Windows on Arm, I'm looking into it.
https://github.com/llvm/llvm-project/pull/92014
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-05-29T10:07:47Z
New Revision: 971f1aaad3ca3680bfbab76212f498ca15b280a2
URL:
https://github.com/llvm/llvm-project/commit/971f1aaad3ca3680bfbab76212f498ca15b280a2
DIFF:
https://github.com/llvm/llvm-project/commit/971f1aaad3ca3680bfbab76212f498ca15b280a2.diff
LOG
DavidSpickett wrote:
The tests were hitting a deadlock trying to kill the test process in async
debug mode. So I've just changed it to sync mode, as I didn't see any reason to
be async here.
It's a symptom of something greater I expect but I don't have time to dig into
it at the moment.
http
Author: David Spickett
Date: 2024-05-29T10:28:10Z
New Revision: 23a09b99313edb67d267a974be6cebfdfd97c7c8
URL:
https://github.com/llvm/llvm-project/commit/23a09b99313edb67d267a974be6cebfdfd97c7c8
DIFF:
https://github.com/llvm/llvm-project/commit/23a09b99313edb67d267a974be6cebfdfd97c7c8.diff
LOG
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/93458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-05-29T14:27:30Z
New Revision: 799316ff26cc82d60f276dc62c4a69b5bba1aef3
URL:
https://github.com/llvm/llvm-project/commit/799316ff26cc82d60f276dc62c4a69b5bba1aef3
DIFF:
https://github.com/llvm/llvm-project/commit/799316ff26cc82d60f276dc62c4a69b5bba1aef3.diff
LOG
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/90063
>From 722704c323a68d426e127308f8e247fb7f94e414 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 11 Mar 2024 10:51:22 +
Subject: [PATCH] [lldb] Add register field enum class
This represents the
@@ -13,11 +13,42 @@
#include
#include
+#include "llvm/ADT/StringSet.h"
+
namespace lldb_private {
class StreamString;
class Log;
+class FieldEnum {
+public:
+ struct Enumerator {
+uint64_t m_value;
+// Short name for the value. Shown in tables and when printi
@@ -13,11 +13,42 @@
#include
#include
+#include "llvm/ADT/StringSet.h"
+
namespace lldb_private {
class StreamString;
class Log;
+class FieldEnum {
+public:
+ struct Enumerator {
+uint64_t m_value;
+// Short name for the value. Shown in tables and when printi
@@ -13,11 +13,42 @@
#include
#include
+#include "llvm/ADT/StringSet.h"
+
namespace lldb_private {
class StreamString;
class Log;
+class FieldEnum {
+public:
+ struct Enumerator {
+uint64_t m_value;
+// Short name for the value. Shown in tables and when printi
DavidSpickett wrote:
Rebased to include
https://github.com/llvm/llvm-project/commit/799316ff26cc82d60f276dc62c4a69b5bba1aef3
and have addressed the open comments.
https://github.com/llvm/llvm-project/pull/90063
___
lldb-commits mailing list
lldb-comm
@@ -519,9 +519,9 @@ def _find_windows_sdk_in_registry_view(self, view):
# Windows SDK version numbers consist of 4 dotted components, so we
# have to use LooseVersion, as StrictVersion supports 3 or fewer.
DavidSpickett wrote:
Does thi
DavidSpickett wrote:
`packaging` is already installed on Linaro's bots, so we're ok with this.
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
@@ -0,0 +1,84 @@
+//===-- RegisterContextPOSIXCore_riscv64.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
201 - 300 of 2684 matches
Mail list logo
