Author: David Spickett Date: 2024-05-29T14:27:30Z New Revision: 799316ff26cc82d60f276dc62c4a69b5bba1aef3
URL: https://github.com/llvm/llvm-project/commit/799316ff26cc82d60f276dc62c4a69b5bba1aef3 DIFF: https://github.com/llvm/llvm-project/commit/799316ff26cc82d60f276dc62c4a69b5bba1aef3.diff LOG: [lldb][NFC] Pass Stream& to ToXML methods in RegisterFlags As suggested in a review of some new code for this file, Stream is more general. The code does not need to know that it's backed by a string. Added: Modified: lldb/include/lldb/Target/RegisterFlags.h lldb/source/Target/RegisterFlags.cpp Removed: ################################################################################ diff --git a/lldb/include/lldb/Target/RegisterFlags.h b/lldb/include/lldb/Target/RegisterFlags.h index 9b343e445678a..29a47540cd4f5 100644 --- a/lldb/include/lldb/Target/RegisterFlags.h +++ b/lldb/include/lldb/Target/RegisterFlags.h @@ -15,7 +15,7 @@ namespace lldb_private { -class StreamString; +class Stream; class Log; class RegisterFlags { @@ -56,7 +56,7 @@ class RegisterFlags { /// Output XML that describes this field, to be inserted into a target XML /// file. Reserved characters in field names like "<" are replaced with /// their XML safe equivalents like ">". - void ToXML(StreamString &strm) const; + void ToXML(Stream &strm) const; bool operator<(const Field &rhs) const { return GetStart() < rhs.GetStart(); @@ -119,7 +119,7 @@ class RegisterFlags { std::string AsTable(uint32_t max_width) const; // Output XML that describes this set of flags. - void ToXML(StreamString &strm) const; + void ToXML(Stream &strm) const; private: const std::string m_id; diff --git a/lldb/source/Target/RegisterFlags.cpp b/lldb/source/Target/RegisterFlags.cpp index b1669b85fd2fe..5274960587bf3 100644 --- a/lldb/source/Target/RegisterFlags.cpp +++ b/lldb/source/Target/RegisterFlags.cpp @@ -190,7 +190,7 @@ std::string RegisterFlags::AsTable(uint32_t max_width) const { return table; } -void RegisterFlags::ToXML(StreamString &strm) const { +void RegisterFlags::ToXML(Stream &strm) const { // Example XML: // <flags id="cpsr_flags" size="4"> // <field name="incorrect" start="0" end="0"/> @@ -213,7 +213,7 @@ void RegisterFlags::ToXML(StreamString &strm) const { strm.Indent("</flags>\n"); } -void RegisterFlags::Field::ToXML(StreamString &strm) const { +void RegisterFlags::Field::ToXML(Stream &strm) const { // Example XML: // <field name="correct" start="0" end="0"/> strm.Indent(); _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
