[Lldb-commits] [lldb] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (PR #84998)

2024-03-13 Thread David Spickett via lldb-commits
@@ -0,0 +1,49 @@ +"""Test that lldb on Darwin ignores metadata in the top byte of addresses.""" + +import os +import re +import subprocess + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class

[Lldb-commits] [lldb] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (PR #84998)

2024-03-13 Thread David Spickett via lldb-commits
@@ -0,0 +1,49 @@ +"""Test that lldb on Darwin ignores metadata in the top byte of addresses.""" + +import os +import re +import subprocess + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class

[Lldb-commits] [lldb] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (PR #84998)

2024-03-13 Thread David Spickett via lldb-commits
@@ -0,0 +1,49 @@ +"""Test that lldb on Darwin ignores metadata in the top byte of addresses.""" DavidSpickett wrote: Oh I get it, you're running a process first then making a core file and expecting to get the same output. This needs to be made clear at the top

[Lldb-commits] [lldb] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (PR #84998)

2024-03-13 Thread David Spickett via lldb-commits
@@ -0,0 +1,49 @@ +"""Test that lldb on Darwin ignores metadata in the top byte of addresses.""" + +import os +import re +import subprocess + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class

[Lldb-commits] [lldb] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (PR #84998)

2024-03-13 Thread David Spickett via lldb-commits
@@ -0,0 +1,13 @@ +#include +#include +union ptrbytes { + int *p; + uint8_t bytes[8]; +}; DavidSpickett wrote: I like this way of avoiding shifts. https://github.com/llvm/llvm-project/pull/84998 ___ lldb-commits mai

[Lldb-commits] [lldb] [lldb] clang-format AuxVector.h (PR #85057)

2024-03-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/85057 Doing this in its own commit so the intent of the previous change is clearer. >From a251b494614a0700f424c2bedebcabd2e053a653 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 6 Mar 2024 09:08:25 +00

[Lldb-commits] [lldb] [lldb] clang-format AuxVector.h (PR #85057)

2024-03-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: This is a stacked PR, first commit here is https://github.com/llvm/llvm-project/pull/84147. https://github.com/llvm/llvm-project/pull/85057 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-03-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/85058 This extends the existing register fields support from AArch64 Linux to AArch64 FreeBSD. So you will now see output like this: ``` (lldb) register read cpsr cpsr = 0x6200 = (N = 0, Z = 1, C

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-03-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: This is a stacked PR, the first two commits are https://github.com/llvm/llvm-project/pull/84147 and https://github.com/llvm/llvm-project/pull/85057. https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] eb21ee4 - [lldb][test] Disable other runlocker test on AArch64 Linux

2024-03-13 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-03-13T14:15:30Z New Revision: eb21ee49cff081911d99d29ba887c1715fc2b8fc URL: https://github.com/llvm/llvm-project/commit/eb21ee49cff081911d99d29ba887c1715fc2b8fc DIFF: https://github.com/llvm/llvm-project/commit/eb21ee49cff081911d99d29ba887c1715fc2b8fc.diff LOG

[Lldb-commits] [lldb] 4e49ee5 - [lldb][Test] Disable ConcurrentVFork tests on Arm/AArch64 Linux

2024-03-13 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-03-13T14:30:40Z New Revision: 4e49ee55c587637e17dec7a72b9ce86d85f8f241 URL: https://github.com/llvm/llvm-project/commit/4e49ee55c587637e17dec7a72b9ce86d85f8f241 DIFF: https://github.com/llvm/llvm-project/commit/4e49ee55c587637e17dec7a72b9ce86d85f8f241.diff LOG

[Lldb-commits] [lldb] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (PR #84998)

2024-03-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/84998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Test] Fix the test case of listing verbose break info on Windows (PR #85200)

2024-03-14 Thread David Spickett via lldb-commits
DavidSpickett wrote: Thanks for the fix! We (Linaro) were about to look into this ourselves. I'm going to merge this now so we can see if it works ASAP. https://github.com/llvm/llvm-project/pull/85200 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [lldb] [LLDB][Test] Fix the test case of listing verbose break info on Windows (PR #85200)

2024-03-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/85200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Test] Fix the test case of listing verbose break info on Windows (PR #85200)

2024-03-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/85200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix nullptr dereference on running x86 binary with x86-disabled llvm (PR #82603)

2024-03-14 Thread David Spickett via lldb-commits
DavidSpickett wrote: I will be away for a while so @jasonmolenda please merge it if it looks fine to you. https://github.com/llvm/llvm-project/pull/82603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] [lldb][FreeBSD] Add FreeBSD specific AT_HWCAP value (PR #84147)

2024-04-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/84147 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] clang-format AuxVector.h (PR #85057)

2024-04-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/85057 >From 705a1a50f9ce847e5dcece3607eb2e95fb8ca18e Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 6 Mar 2024 09:08:25 + Subject: [PATCH] [lldb] clang-format AuxVector.h Doing this in its own comm

[Lldb-commits] [lldb] [lldb] clang-format AuxVector.h (PR #85057)

2024-04-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/85057 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] clang-format AuxVector.h (PR #85057)

2024-04-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: Yes that's because I corrected the title in the previous PR but did not on this branch. I've landed that previous PR and updated this so it's only the formatting change now. https://github.com/llvm/llvm-project/pull/85057 ___ lld

[Lldb-commits] [lldb] [lldb] clang-format AuxVector.h (PR #85057)

2024-04-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: Going to merge this without approval now that it's a simple clang-format. https://github.com/llvm/llvm-project/pull/85057 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] [lldb] clang-format AuxVector.h (PR #85057)

2024-04-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/85057 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-04-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/85058 >From a18b685eda074527abdd127456681b03ec2aed0f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 4 Mar 2024 14:31:40 + Subject: [PATCH] [lldb][FreeBSD][AArch64] Enable register field detection T

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-04-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: @emaste the previous PRs have landed so this is just a single commit now, easier to review. https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] 7c178fd - [lldb] Correct byte order check for 128 bit integer registers

2024-04-03 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-04-03T15:05:13Z New Revision: 7c178fdf0094afbf4757d71b792bc159ddcac72f URL: https://github.com/llvm/llvm-project/commit/7c178fdf0094afbf4757d71b792bc159ddcac72f DIFF: https://github.com/llvm/llvm-project/commit/7c178fdf0094afbf4757d71b792bc159ddcac72f.diff LOG

[Lldb-commits] [lldb] Debuginfod Testing & fixes: 3rd times the charm? (PR #87676)

2024-04-05 Thread David Spickett via lldb-commits
DavidSpickett wrote: When I tried these on Arm, `.note.gnu.build-id` was not the issue, it was failures like those seen in the Fuschia logs. `/bin/sh: 1: ifeq: not found` and `/bin/sh: 1: /b/s/w/ir/x/w/llvm_build/bin/dwp: not found` (plus some other tools). Leave the tests disabled on Arm and

[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

2024-04-16 Thread David Spickett via lldb-commits
@@ -3433,8 +3433,40 @@ bool GDBRemoteCommunicationClient::CalculateMD5( return false; if (response.Peek() && *response.Peek() == 'x') return false; -low = response.GetHexMaxU64(false, UINT64_MAX); -high = response.GetHexMaxU64(false, UINT64_MAX); + +

[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

2024-04-16 Thread David Spickett via lldb-commits
@@ -1184,7 +1184,7 @@ bool Platform::IsCompatibleArchitecture(const ArchSpec &arch, Status Platform::PutFile(const FileSpec &source, const FileSpec &destination, uint32_t uid, uint32_t gid) { Log *log = GetLog(LLDBLog::Platform); - LLDB_LOGF(log, "[

[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

2024-04-16 Thread David Spickett via lldb-commits
@@ -1197,6 +1197,34 @@ Status Platform::PutFile(const FileSpec &source, const FileSpec &destination, if (!source_file) return Status(source_file.takeError()); Status error; + + bool requires_upload = true; + { DavidSpickett wrote: If you really need

[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

2024-04-16 Thread David Spickett via lldb-commits
DavidSpickett wrote: @weliveindetail I think this might fix the problems you were having remote debugging clang-repl (I can't seem to find the actual Discourse thread). https://github.com/llvm/llvm-project/pull/88812 ___ lldb-commits mailing list lldb

[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

2024-04-16 Thread David Spickett via lldb-commits
DavidSpickett wrote: I think this will fix https://github.com/llvm/llvm-project/issues/47549. And make the note at the end of `lldb/docs/use/qemu-testing.rst` outdated. For testing we might be able to send the platform the gdbserver spawn packets and check that it doesn't return the same port

[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

2024-04-16 Thread David Spickett via lldb-commits
@@ -324,6 +335,10 @@ int main_platform(int argc, char *argv[]) { // connections while a connection is active. acceptor_up.reset(); } + +GDBRemoteCommunicationServerPlatform::PortMap portmap_for_child; +portmap_for_child.AllowPort(*port);

[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

2024-04-16 Thread David Spickett via lldb-commits
@@ -301,13 +294,31 @@ int main_platform(int argc, char *argv[]) { exit(socket_error); } printf("Connection established.\n"); + +std::optional port = 0; if (g_server) { // Collect child zombie processes. #if !defined(_WIN32) - while (waitpid(-

[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

2024-04-16 Thread David Spickett via lldb-commits
@@ -301,13 +294,31 @@ int main_platform(int argc, char *argv[]) { exit(socket_error); } printf("Connection established.\n"); + +std::optional port = 0; DavidSpickett wrote: If we're going to use optional then this should be left to default co

[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

2024-04-16 Thread David Spickett via lldb-commits
@@ -301,13 +294,31 @@ int main_platform(int argc, char *argv[]) { exit(socket_error); } printf("Connection established.\n"); + +std::optional port = 0; if (g_server) { // Collect child zombie processes. #if !defined(_WIN32) - while (waitpid(-

[Lldb-commits] [lldb] [lldb/linux] Make sure the process continues running after a detach (PR #88494)

2024-04-16 Thread David Spickett via lldb-commits
DavidSpickett wrote: Will fix https://github.com/llvm/llvm-project/issues/85084. https://github.com/llvm/llvm-project/pull/88494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/linux] Make sure the process continues running after a detach (PR #88494)

2024-04-16 Thread David Spickett via lldb-commits
@@ -0,0 +1,59 @@ +""" +Test that the process continues running after we detach from it. +""" + +import lldb +import time +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class DetachResumesTestCase(TestBase):

[Lldb-commits] [lldb] [lldb/linux] Make sure the process continues running after a detach (PR #88494)

2024-04-16 Thread David Spickett via lldb-commits
DavidSpickett wrote: Thanks for looking into this. I had no idea what it might be but your explanation makes a lot of sense. https://github.com/llvm/llvm-project/pull/88494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [lldb] [lldb/linux] Make sure the process continues running after a detach (PR #88494)

2024-04-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/88494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/linux] Make sure the process continues running after a detach (PR #88494)

2024-04-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/88494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix python extension debug suffix on Win (PR #89037)

2024-04-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: Looks fine but can you just confirm what https://github.com/llvm/llvm-project/blob/d1a69e4a6ee0b04778da7728123c47eef2290564/lldb/bindings/python/get-python-config.py#L70 reports? I assume this does not include `_d`, otherwise there would be no need for this fix? https://

[Lldb-commits] [lldb] [lldb] fix python extension debug suffix on Win (PR #89037)

2024-04-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: The best docs I can find are https://peps.python.org/pep-0720/: "Interpreter-specific Python extension (native module) suffix — generally defined as .{SOABI}.{SHLIB_SUFFIX}." Which is less than helpful. https://peps.python.org/pep-3149/ mentions Windows uses a different fo

[Lldb-commits] [lldb] a16bb07 - [lldb][test] Improve invalid compiler error message

2024-04-17 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-04-17T09:19:26Z New Revision: a16bb0701409376dee3a587ae351a6019d6de4e0 URL: https://github.com/llvm/llvm-project/commit/a16bb0701409376dee3a587ae351a6019d6de4e0 DIFF: https://github.com/llvm/llvm-project/commit/a16bb0701409376dee3a587ae351a6019d6de4e0.diff LOG

[Lldb-commits] [lldb] [lldb] Correct documentation of LLDB_TEST_USER_ARGS (PR #89042)

2024-04-17 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/89042 https://discourse.llvm.org/t/running-lldb-in-a-container/76801/4 found that the obvious way to use this variable doesn't work, despite what our docs and examples say. Perhaps in the past it did but now yo

[Lldb-commits] [lldb] [lldb] fix python extension debug suffix on Win (PR #89037)

2024-04-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: So this PR fixes debug lldb -> release Python, but if I configured against a debug Python then the suffix would be `_d_d`. Debug lldb/release Python is a valid config I think, and likely what 99% of people want anyway. So can we add a check whether the suffix already has `

[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

2024-04-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: If it were a GDB packet it would be in https://sourceware.org/gdb/current/onlinedocs/gdb.html/Host-I_002fO-Packets.html#Host-I_002fO-Packets but I see no sign of it, or in GDB's sources. The first appearance of `vFile:MD5` is e0f8f574c7f41f5b61ec01aa290d52fc55a3f3c9 thoug

[Lldb-commits] [lldb] [lldb] Correct documentation of LLDB_TEST_USER_ARGS (PR #89042)

2024-04-18 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

2024-04-18 Thread David Spickett via lldb-commits
@@ -282,17 +282,10 @@ int main_platform(int argc, char *argv[]) { } } - do { -GDBRemoteCommunicationServerPlatform platform( -acceptor_up->GetSocketProtocol(), acceptor_up->GetSocketScheme()); - -if (port_offset > 0) DavidSpickett wrote:

[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

2024-04-18 Thread David Spickett via lldb-commits
@@ -301,13 +294,35 @@ int main_platform(int argc, char *argv[]) { exit(socket_error); } printf("Connection established.\n"); + if (g_server) { // Collect child zombie processes. #if !defined(_WIN32) - while (waitpid(-1, nullptr, WNOHANG) > 0) -

[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

2024-04-18 Thread David Spickett via lldb-commits
@@ -301,13 +294,35 @@ int main_platform(int argc, char *argv[]) { exit(socket_error); } printf("Connection established.\n"); + if (g_server) { // Collect child zombie processes. #if !defined(_WIN32) - while (waitpid(-1, nullptr, WNOHANG) > 0) -

[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

2024-04-18 Thread David Spickett via lldb-commits
@@ -301,13 +294,35 @@ int main_platform(int argc, char *argv[]) { exit(socket_error); } printf("Connection established.\n"); + if (g_server) { // Collect child zombie processes. #if !defined(_WIN32) - while (waitpid(-1, nullptr, WNOHANG) > 0) -

[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

2024-04-18 Thread David Spickett via lldb-commits
DavidSpickett wrote: @bulbazord please give the final approval if it looks good to you. We can sort out moving from MD5 on an issue. https://github.com/llvm/llvm-project/pull/88812 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [lldb] [lldb][Docs] Document vFile:exists and vFile:MD5 (PR #89357)

2024-04-19 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/89357 These are extensions the lldb platform has to: https://sourceware.org/gdb/current/onlinedocs/gdb.html/Host-I_002fO-Packets.html#Host-I_002fO-Packets >From 518cb052ee364192fc5c813a2962f80f39345cd5 Mon Sep 17

[Lldb-commits] [lldb] [lldb][Docs] Document vFile:exists and vFile:MD5 (PR #89357)

2024-04-19 Thread David Spickett via lldb-commits
DavidSpickett wrote: Ideally they'd be in some sort of order but they are already not, and I'm thinking it would be good to get these on the website anyway. So I'm leaving concerns like that until later. https://github.com/llvm/llvm-project/pull/89357 __

[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

2024-04-19 Thread David Spickett via lldb-commits
DavidSpickett wrote: > So a good follow up PR would be to list it in that document. It's self > explanatory but still, weird that it's not there. https://github.com/llvm/llvm-project/pull/89357 https://github.com/llvm/llvm-project/pull/88812 ___ lldb

[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

2024-04-19 Thread David Spickett via lldb-commits
DavidSpickett wrote: > @bulbazord can you or someone with write permissions revert this PR so I have > time to triage the issue? The next build is green, those DAP tests do fail once in a while so it's unrelated to your change. https://github.com/llvm/llvm-project/pull/88812 _

[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

2024-04-19 Thread David Spickett via lldb-commits
DavidSpickett wrote: Please address @JDevlieghere's comments in a new PR. https://github.com/llvm/llvm-project/pull/88812 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Make formatting regular in lldb-gdb-remote.txt (PR #89587)

2024-04-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: Subsequent PRs will build on this: * Enable Markdown support in the website build. * Use a script to convert this file to Markdown. * Hand correct the result. So we: 1. Have this on the website, just like GDB's protocol specs and 2. It's in a format that's easier to contribu

[Lldb-commits] [lldb] [lldb][Docs] Document vFile:exists and vFile:MD5 (PR #89357)

2024-04-22 Thread David Spickett via lldb-commits
@@ -429,7 +429,43 @@ incompatible with the flags that gdb specifies. // // Response is F, followed by the number of bytes written (base 16) +//-- +// vFile:MD5: +// +// BRIEF +// Generate an MD5 hash of the

[Lldb-commits] [lldb] [lldb][Docs] Document vFile:exists and vFile:MD5 (PR #89357)

2024-04-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/89357 >From 518cb052ee364192fc5c813a2962f80f39345cd5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 19 Apr 2024 09:15:54 + Subject: [PATCH 1/2] [lldb][Docs] Document vFile:exists and vFile:MD5 Thes

[Lldb-commits] [lldb] [lldb][Docs] Document vFile:exists and vFile:MD5 (PR #89357)

2024-04-22 Thread David Spickett via lldb-commits
@@ -429,7 +429,43 @@ incompatible with the flags that gdb specifies. // // Response is F, followed by the number of bytes written (base 16) +//-- +// vFile:MD5: +// +// BRIEF +// Generate an MD5 hash of the

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-04-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: @emaste ping! https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix python extension debug suffix on Win (PR #89037)

2024-04-23 Thread David Spickett via lldb-commits
@@ -75,6 +75,12 @@ if (LLDB_ENABLE_PYTHON) endif() endif() endforeach() + if(WIN32 AND CMAKE_BUILD_TYPE STREQUAL Debug) +string(SUBSTRING ${LLDB_PYTHON_EXT_SUFFIX} 0 2 FIRST_2_CHARS) +if(NOT FIRST_2_CHARS STREQUAL "_d") DavidSpickett wrote:

[Lldb-commits] [lldb] [lldb] Enable support for Markdown documentation pages (PR #89716)

2024-04-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/89716 RST is powerful but usually too powerful for 90% of what we need it for. Markdown is easier to edit and can be previewed easily without building the entire website. This copies what llvm does already, mak

[Lldb-commits] [lldb] [lldb][Docs] Make formatting regular in lldb-gdb-remote.txt (PR #89587)

2024-04-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Make formatting regular in lldb-gdb-remote.txt (PR #89587)

2024-04-23 Thread David Spickett via lldb-commits
DavidSpickett wrote: I'll include this as a commit in a larger PR. https://github.com/llvm/llvm-project/pull/89587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Convert GDB protocol extensions doc to Markdown and add to website (PR #89718)

2024-04-23 Thread David Spickett via lldb-commits
DavidSpickett wrote: As it stands this PR *will not* build, because it requires https://github.com/llvm/llvm-project/pull/89716. I wanted to put up both to show what I'm going to do with all this. First https://github.com/llvm/llvm-project/pull/89716 should land, so we can flush out any build

[Lldb-commits] [lldb] [lldb] Enable support for Markdown documentation pages (PR #89716)

2024-04-23 Thread David Spickett via lldb-commits
DavidSpickett wrote: This will be used by https://github.com/llvm/llvm-project/pull/89718, but I would like to land this PR first to flush out any bot config problems. https://github.com/llvm/llvm-project/pull/89716 ___ lldb-commits mailing list lldb-

[Lldb-commits] [lldb] [lldb][Docs] Make formatting regular in lldb-gdb-remote.txt (PR #89587)

2024-04-23 Thread David Spickett via lldb-commits
DavidSpickett wrote: Opened https://github.com/llvm/llvm-project/pull/89718 instead, which has all the conversion steps in it. https://github.com/llvm/llvm-project/pull/89587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [lldb] [lldb] Enable support for Markdown documentation pages (PR #89716)

2024-04-23 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/89716 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Convert GDB protocol extensions doc to Markdown and add to website (PR #89718)

2024-04-23 Thread David Spickett via lldb-commits
DavidSpickett wrote: The CI build "worked" but there is this warning: ``` /home/runner/work/llvm-project/llvm-project/lldb/docs/index.rst:146: WARNING: toctree contains reference to nonexisting document 'resources/lldbgdbremote' ``` Which is what I expected. Once it knows to look for Markdown it

[Lldb-commits] [lldb] [lldb] Enable support for Markdown documentation pages (PR #89716)

2024-04-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89716 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Convert GDB protocol extensions doc to Markdown and add to website (PR #89718)

2024-04-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89718 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/89913 As before, script did most of the work, hand edits after that. There's a lot more we can do dedupe this and the packets doc, this will come in a follow up PR. >From d9b8ee42dfb753012f2f7032d7fb2dfde3e440f

[Lldb-commits] [lldb] [lldb] fix python extension debug suffix on Win (PR #89037)

2024-04-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM I can merge this for you if you don't have commit access, otherwise go ahead and merge it yourself. https://github.com/llvm/llvm-project/pull/89037 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [lldb] [lldb] fix python extension debug suffix on Win (PR #89037)

2024-04-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89037 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/89913 >From d9b8ee42dfb753012f2f7032d7fb2dfde3e440f0 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 24 Apr 2024 10:21:08 +0100 Subject: [PATCH 1/3] [lldb][Docs] Make formatting in platform packet doc r

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89913 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Link from platform doc to extensions doc (PR #90029)

2024-04-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/90029 So we aren't describing the same packets twice. Basically turning the platform doc into a list of cross links. qLaunchSuccess was missing a description so I added one. The links will have text generated f

[Lldb-commits] [lldb] [lldb][Docs] Link from platform doc to extensions doc (PR #90029)

2024-04-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/90029 >From 034efa46305f001092bbaacd563d9d2635ed49ed Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 24 Apr 2024 11:21:15 +0100 Subject: [PATCH 1/2] [lldb][Docs] Link from platform doc to extensions doc

[Lldb-commits] [lldb] [lldb][Docs] Link from platform doc to extensions doc (PR #90029)

2024-04-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/90029 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Link from platform doc to extensions doc (PR #90029)

2024-04-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: I'll remove the "Brief" subtitles after this. https://github.com/llvm/llvm-project/pull/90029 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document vFile:exists and vFile:MD5 (PR #89357)

2024-04-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: I forgot I didn't land this, so I will instead push a Markdown version of the same content once the other PRs have landed. https://github.com/llvm/llvm-project/pull/89357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [lldb] [lldb][Docs] Link from platform doc to extensions doc (PR #90029)

2024-04-25 Thread David Spickett via lldb-commits
@@ -1,484 +1,49 @@ # LLDB Platform Packets -Here is a brief overview of the packets that an lldb platform server +This is a list of the packets that an lldb platform server needs to implement for the lldb testsuite to be run on a remote target device/system. These are almo

[Lldb-commits] [lldb] [lldb] Add ability to show enum as name and value at the same time (PR #90059)

2024-04-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/90059 When an enum is used to represent certain data it can be useful to know its name and the value of it. For instance, register fields are often set in source code as numbers, but in the debugger you'd like t

[Lldb-commits] [lldb] [lldb] Add ability to show enum as name and value at the same time (PR #90059)

2024-04-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: This is the first change for https://discourse.llvm.org/t/rfc-adding-register-field-enums-to-lldb/77275, though there has been a change of plans and now I'm implementing existing GDB features to get the same result. It is a subset of https://github.com/llvm/llvm-project/p

[Lldb-commits] [lldb] [lldb] Add register field enum class (PR #90063)

2024-04-25 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/90063 This represents the enum type that can be assigned to a field using the `` element in the target XML. https://sourceware.org/gdb/current/onlinedocs/gdb.html/Enum-Target-Types.html Each enumerator has: * A

[Lldb-commits] [lldb] [lldb] Add ability to show enum as name and value at the same time (PR #90059)

2024-04-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: > It's also not clear how this new "presentation mode" is going to be > controlled. While it's not in the scope of this PR, it would be nice if you > can share a bigger picture. For me the picture is limited to register printing. I'll be setting this new option on the reg

[Lldb-commits] [lldb] [lldb] Add ability to show enum as name and value at the same time (PR #90059)

2024-04-25 Thread David Spickett via lldb-commits
DavidSpickett wrote: I understand, so the value is made from `a | b | c` for example. I didn't think of whether register fields could hit this path, but it's equivalent to a C enum they'll be using, so I think it could happen. I'll test this, thanks for bringing it up. https://github.com/llvm

[Lldb-commits] [lldb] [lldb][Docs] Link from platform doc to extensions doc (PR #90029)

2024-04-26 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90029 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] bd53c7c - [lldb][Docs] Document vFile "MD5" and "exists"

2024-04-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-04-26T09:45:17+01:00 New Revision: bd53c7cce418fe7f3e171859d4718df15d03dc2b URL: https://github.com/llvm/llvm-project/commit/bd53c7cce418fe7f3e171859d4718df15d03dc2b DIFF: https://github.com/llvm/llvm-project/commit/bd53c7cce418fe7f3e171859d4718df15d03dc2b.diff

[Lldb-commits] [lldb] [lldb][Docs] Document vFile:exists and vFile:MD5 (PR #89357)

2024-04-26 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document vFile:exists and vFile:MD5 (PR #89357)

2024-04-26 Thread David Spickett via lldb-commits
DavidSpickett wrote: Landed as markdown in https://github.com/llvm/llvm-project/commit/bd53c7cce418fe7f3e171859d4718df15d03dc2b. https://github.com/llvm/llvm-project/pull/89357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] [lldb[Docs] Reduce title noise in packets doc (PR #90183)

2024-04-26 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/90183 This removes the "Brief" and "Description" subtitles and merges the text of both so that the contents listing is clearer. >From 97468a99808fa0562f6c157b8a2703c48acc5ebc Mon Sep 17 00:00:00 2001 From: David

[Lldb-commits] [lldb] [lldb[Docs] Reduce title noise in packets doc (PR #90183)

2024-04-29 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90183 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Remove more subtitles from packets doc (PR #90443)

2024-04-29 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/90443 This removes various subtitles or converts them to bold text so that the table of contents is less cluttered. This includes "Example", "Notes", "Priority To Implement" and "Response". >From 7810ba3e09ef94

[Lldb-commits] [lldb] [lldb][Docs] Remove more subtitles from packets doc (PR #90443)

2024-04-29 Thread David Spickett via lldb-commits
DavidSpickett wrote: After this I am going to sort the entries into alphabetical order and split out the ones that are extensions to existing packets - then I should be done with this doc :) https://github.com/llvm/llvm-project/pull/90443 ___ lldb-co

[Lldb-commits] [lldb] 0c8151a - [lldb][Test] Disable concurrent vfork tests on Arm and AArch64 Linux (again)

2024-04-29 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-04-29T11:41:14+01:00 New Revision: 0c8151ac809c283187e9b19d0cbe72a09c8d74e0 URL: https://github.com/llvm/llvm-project/commit/0c8151ac809c283187e9b19d0cbe72a09c8d74e0 DIFF: https://github.com/llvm/llvm-project/commit/0c8151ac809c283187e9b19d0cbe72a09c8d74e0.diff

[Lldb-commits] [lldb] [lldb][Docs] Remove more subtitles from packets doc (PR #90443)

2024-04-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Remove .txt copy of tutorial (PR #90585)

2024-04-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/90585 This was last modified in 4fd3347d6e4b0c873c789528e1c9a1b55990d1b6 in 2021 and was made obsolete by the RST version that edb874b2310dc6eeaa27330ca1b1c013da7bdd65 added in 2019. There are some differences

<    6   7   8   9   10   11   12   13   14   15   >