[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

DavidSpickett updated this revision to Diff 444628. DavidSpickett added a comment. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129489/new/ https://reviews.llvm.org/D129489 Files: lldb/include/lldb/Target/Process.h lldb/so

[Lldb-commits] [PATCH] D129750: [lldb] Always use APFloat for FP dumping

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I'm no float expert but seems fine. Also checked on AArch64 and no failures there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D129814: Fix stepping over watchpoints in architectures that raise the exception before executing the instruction

DavidSpickett added inline comments. Comment at: lldb/source/Target/StopInfo.cpp:724 + m_watch_sp.reset(); +} +bool ShouldStop(Event *event_ptr) override { Blank line after this. Comment at: lldb/source/Target/StopInfo.cpp:748 +

[Lldb-commits] [PATCH] D129807: [LLDB][NativePDB] Add MSInheritanceAttr when completing CXXRecordDecl

DavidSpickett added a comment. Is this fixing a specific situation and if so, can a test be written for it? I'm sure we have existing tests you can adapt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129807/new/ https://reviews.llvm.org/D129807

[Lldb-commits] [PATCH] D129783: [lldb] Skip tests using int128 on ARM

DavidSpickett added a comment. (in case you aren't familiar when we say "Arm" we mean 32 bit Arm and AArch64 refers to 64 bit, it's not always that way but for this purpose it is) I couldn't find a statement that AArch64 supports int128 but it will compile (https://godbolt.org/z/j5dqz4os4) and

[Lldb-commits] [PATCH] D129783: [lldb] Skip tests using int128 on ARM

DavidSpickett added a comment. > which disabled the test for both 32-bit and 64-bit That one also runs fine on Linux so probably just overly cautious. I see `lldb/test/API/commands/expression/rdar44436068/Test128BitsInteger.py` as well, that only disables Arm. Once your changes have passed the

[Lldb-commits] [PATCH] D129783: [lldb] Skip tests using int128 on ARM

DavidSpickett added a comment. Thanks! The Arm/AArch64 Linux bots were green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129783/new/ https://reviews.llvm.org/D129783 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

DavidSpickett marked an inline comment as done. DavidSpickett added a comment. > I am wondering if we should also test memory reads with correct/wrong tags > for corefiles as well? Do you see any value on doing it or have done it > already in above test and i skipped it? You mean "memory read

[Lldb-commits] [PATCH] D129487: [lldb][AArch64] Add UnpackTagsFromCoreFileSegment to MemoryTagManager

DavidSpickett updated this revision to Diff 446099. DavidSpickett added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129487/new/ https://reviews.llvm.org/D129487 Files: lldb/include/lldb/Target/MemoryTagManager.h lldb/source

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

DavidSpickett updated this revision to Diff 446100. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129489/new/ https://reviews.llvm.org/D129489 Files: lldb/incl

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

DavidSpickett added a comment. > You mean "memory read --show-tags"? The details > are tested on live processes already but a simple smoke test wouldn't hurt, > I'll do that. I checked and to include the memory contents takes the core file from 20k to 300 something k. This isn't the end of th

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

DavidSpickett added a comment. @labath (or indeed anyone else) any objections to this or the previous patch? Happy to make changes but if it's ok as is I'd like to get it landed before the branch next week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D130307: [LLDB][Reliability] Fix register value unpacking

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Thanks! I'm bothered that no test hit this but I deal with that (it's probably because no instruction you'd need to emulate uses these registers). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D130307: [LLDB][Reliability] Fix register value unpacking

DavidSpickett added a comment. So I looked into what *should* be testing this and if it was done comprehensively it would have been testing it. However the Arm emulation tests: - Don't check D registers directly, only S (which is why we didn't miss the upper 32 bits). - Don't verify that memory

[Lldb-commits] [PATCH] D130462: [LLDB][ARM] Generalise adding register state in emulation tests

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Since some s and d registers overlap we will error if we find both. Th

[Lldb-commits] [PATCH] D130464: [lldb][ARM] Print mismatched registers in emulation tests

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Also correct the test failed message. It implies that what it's done i

[Lldb-commits] [PATCH] D130467: [lldb][ARM] Misc improvements to TestEmulations

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Look for files that end width arm/thumb.dat, meaning we don't try to

[Lldb-commits] [PATCH] D130468: [lldb][ARM] Add tests for vpush/vpop D registers

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously we just checked via S regs and were not checking memory con

[Lldb-commits] [PATCH] D130468: [lldb][ARM] Add tests for vpush/vpop D registers

DavidSpickett added a reviewer: clayborg. DavidSpickett added inline comments. Comment at: lldb/test/API/arm/emulation/new-test-files/test-vpush-1-dregs-thumb.dat:70 +0x +0x +] This is the part that fails without the fix from https://reviews.llv

[Lldb-commits] [PATCH] D130307: [LLDB][Reliability] Fix register value unpacking

DavidSpickett added a comment. I've stacked some reviews onto this that end in a new test that covers this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130307/new/ https://reviews.llvm.org/D130307

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:1347 case llvm::COFF::IMAGE_FILE_MACHINE_ARM64: + case llvm::COFF::IMAGE_FILE_MACHINE_RISCV64: ArchSpec arch; Why is this only needed for PECOFF?

[Lldb-commits] [PATCH] D129487: [lldb][AArch64] Add UnpackTagsFromCoreFileSegment to MemoryTagManager

This revision was automatically updated to reflect the committed changes. Closed by commit rG883b0d5b7f87: [lldb][AArch64] Add UnpackTagsFromCoreFileSegment to MemoryTagManager (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Architecture/RISCV64/ArchitectureRISCV64.cpp:23 +void lldb_private::ArchitectureRISCV64::Initialize() { + PluginManager::RegisterPlugin(GetPluginNameStatic(), "RISC-V64", +&Archi

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

DavidSpickett added a comment. Please note in the commit title/description that this is adding riscv64 only. Does this build if you don't have the rest of the changes from https://reviews.llvm.org/D128250? Or do you plan to split out more from that and have this depend on those changes. (thank

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f9fa9ef5387: [lldb][AArch64] Add support for memory tags in core files (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129489/new

[Lldb-commits] [PATCH] D130534: loading a binary at a slide multiple times leaves old entries in the SectionLoadList

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py:34 + +# View the first element of `first` and `second` with +# a load address . Is

[Lldb-commits] [PATCH] D130462: [LLDB][ARM] Generalise adding register state in emulation tests and add D registers

This revision was automatically updated to reflect the committed changes. Closed by commit rG290c4bc7be45: [LLDB][ARM] Generalise adding register state in emulation tests and add D… (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D130464: [lldb][ARM] Print mismatched registers in emulation tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ebd54194446: [lldb][ARM] Print mismatched registers in emulation tests (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130464/new

[Lldb-commits] [PATCH] D130467: [lldb][ARM] Misc improvements to TestEmulations

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4b6e5f9500f: [lldb][ARM] Misc improvements to TestEmulations (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130467/new/ https:/

[Lldb-commits] [PATCH] D130468: [lldb][ARM] Add tests for vpush/vpop D registers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10c2bab50e7a: [lldb][ARM] Add tests for vpush/vpop D registers (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D130582: [lldb] Skip the new mte_core_file test like other MTE tests

DavidSpickett added a comment. The windows bot is also ok with it https://lab.llvm.org/buildbot/#/builders/83/builds/21772. What setup did you have issues on and what did the errors say? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130582/new/ h

[Lldb-commits] [PATCH] D130534: loading a binary at a slide multiple times leaves old entries in the SectionLoadList

DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py:57 + self.assertNotEqual(second_sym.GetStartAddress().GetLoadAddress(target), + second_sym.GetStartAddress().GetFileAddress()) + -

[Lldb-commits] [PATCH] D129750: [lldb] Always use APFloat for FP dumping

DavidSpickett added a comment. @labath Did you forget about this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129750/new/ https://reviews.llvm.org/D129750 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D130686: [LLDB][RISCV] Add DWARF Registers

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I couldn't find a definition for `Alternate Frame Return Column`. Perhaps it's this "alternate link register" I see elsewhere that's used for calling compressed code functions?

[Lldb-commits] [PATCH] D130899: [LLDB][RISCV] Add riscv register enums

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. As I understand it, these registers are the same across riscv32 and riscv64. So LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Given that testing packet speed by sending no packets seems pointless, I wonder if this should be asserts on the packet counts instead. If this speed test is something we do as part of connection setup, you'd probably

[Lldb-commits] [PATCH] D130972: [LLDB][NFC] Fix LLDB_WATCH_TYPE_IS_VALID macro

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Sometimes you wonder how anything works :) I looked at the places this is used and I don't see a way to reach them from the API without the type already being `LLDB_WATCH_TYPE_READ` or `LLDB_WATCH_TYPE_WRITE`. It's ch

[Lldb-commits] [PATCH] D130929: [LLDB][Reliability] Remove dead code.

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130929/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

DavidSpickett added a comment. Tell me if I understand the strategy. If you're on arm64 but the process is actually arm32 and you ask for the general registers, you'll get back something with size < the size you expect for the 64 bit register set. If you're on arm32 then you always assume that

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130985/new/ https://reviews.llvm.org/D130985 _

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

DavidSpickett added a comment. I stopped being lazy and went and found where this is used. It's actually a command you can run from the interpreter that prints out the results of the testing. (lldb) process plugin packet speed-test -c 0 Testing sending 0 packets of various sizes: <...>

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

DavidSpickett added a comment. Thanks for these fixes! I'll fix up the 0 packets sent behaviour when I find some spare time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130939/new/ https://reviews.llvm.org/D130939 __

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/ARMUtils.h:29 +// assert(0 && "Invalid shift type"); +break; case 0: Looking at the codepaths and the reason this function exists, it's either called with a 2 bit num

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

DavidSpickett added a comment. There is also a cmake var `LLDB_USE_SYSTEM_SIX` which can be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 ___ lldb-co

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/ARMUtils.h:49 shift_t = SRType_Invalid; return UINT32_MAX; } This is now dead code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D131312: [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

DavidSpickett added a comment. The original change was https://reviews.llvm.org/D29078. Are you able to run the tests with this applied? Comment at: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp:66 - if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) {

[Lldb-commits] [PATCH] D131312: [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

DavidSpickett added inline comments. Comment at: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp:66 - if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) { result.Printf("Null bounds on map: pointer value = 0x%" PRIu64 "\n", value); haw

[Lldb-commits] [PATCH] D131312: [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

DavidSpickett added inline comments. Comment at: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp:66 - if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) { result.Printf("Null bounds on map: pointer value = 0x%" PRIu64 "\n", value); Dav

[Lldb-commits] [PATCH] D131459: Move FormattersMatchCandidate flags to a struct.

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM, a nice improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131459/new/ https://reviews.llvm.org/D131459

[Lldb-commits] [PATCH] D131460: [LLDB] Remove undefined behavior in TestConstStaticIntegralMember.py

DavidSpickett added a comment. Just looking at the test I think the main thing this removes is checking that we can show an enum as a combination of more than one value plus some extra number (invalid_scoped_enum_val is only one valid name plus extra). Thanks for bringing this to our attention.

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. 1438639a2f7eb9e9cba01454d3a9b1b16d179c9a

[Lldb-commits] [PATCH] D131460: [LLDB] Remove undefined behavior in TestConstStaticIntegralMember.py

DavidSpickett added a comment. https://reviews.llvm.org/D131472 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131460/new/ https://reviews.llvm.org/D131460 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

DavidSpickett updated this revision to Diff 451067. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131472/new/ https://reviews.llvm.org/D131472 Files: lldb/test

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

DavidSpickett added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:63-68 - if(NOT LLDB_USE_SYSTEM_SIX) -add_custom_command(TARGET ${swig_target} POST_BUILD VERBATIM - COMMAND ${CMAKE_COMMAND} -E copy -"${LLDB_SOURCE_DIR}/third_party/Python/modu

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

DavidSpickett updated this revision to Diff 451386. DavidSpickett added a comment. invalid -> not_enumerator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131472/new/ https://reviews.llvm.org/D131472 Files: lldb/test/API/lang/cpp/const_static_i

[Lldb-commits] [PATCH] D131472: [LLDB] Add multi value test for const static enum

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e538c669c76: [LLDB] Add multi value test for const static enum (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add register stuff and make breakpoint work

DavidSpickett added a comment. Can "and make breakpoint work" be made into its own patch? I'd much rather see "register read and write" and "software breakpoints" in their own changes (and please differentiate in commit title/messages between hardware break and software break). (otherwise the

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add riscv register stuff

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. > we can add them back if required in the future. Sounds good to me. Certainly SVE for Arm required a bunch of changes, a lot easier to do it later. This LGTM, but: [LLDB][RI

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

DavidSpickett added a comment. Please include more context (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface) in future patches. Thanks for the tests regardless! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605

[Lldb-commits] [PATCH] D131658: [LLDB] Fix out-of-bounds memory access in EmulationStateArm

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM and I'll add a test later that would break without this fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131658/new/ https:

[Lldb-commits] [PATCH] D131543: [LLDB][NFC] Fix the style issue in TCPSocket

DavidSpickett added a comment. "LLDB’s code style differs from LLVM’s coding style. Unfortunately there is no document describing the differences. Please be consistent with the existing code." Well I don't remember seeing any Yoda conditions elsewhere so LGTM. Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D131663: [LLDB][ARM] Extend testing for vpush emulation

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://reviews.llvm.org/D131658 found a bug in ReadPseudoRegisterValu

[Lldb-commits] [PATCH] D131664: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://reviews.llvm.org/D131658 identified a bug in this and turns ou

[Lldb-commits] [PATCH] D131664: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

DavidSpickett added reviewers: fixathon, JDevlieghere. DavidSpickett added a subscriber: JDevlieghere. DavidSpickett added a comment. @JDevlieghere Unless this is still used in your downstream? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131664/ne

[Lldb-commits] [PATCH] D131663: [LLDB][ARM] Extend testing for vpush emulation

This revision was automatically updated to reflect the committed changes. Closed by commit rG14913fa5d050: [LLDB][ARM] Extend testing for vpush emulation (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131663/new/ https://

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add riscv register definition and read/write

DavidSpickett added a comment. The error appears to be: ../../lldb/source/Plugins/Process/Utility/RegisterInfos_riscv64.h(67,5): error: constant expression evaluates to -1 which cannot be narrowed to type 'uint32_t' (aka 'unsigned int') [-Wc++11-narrowing] DEFINE_GPR64(pc, LLDB_REGNUM_G

[Lldb-commits] [PATCH] D131761: [LLDB] Remove __future__ imports from tests

DavidSpickett created this revision. Herald added a subscriber: wenlei. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Not needed now that we require python 3. Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D131772: [LLDB] Remove __future__ imports from examples

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Not needed now that we require python 3. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1317

[Lldb-commits] [PATCH] D131664: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

DavidSpickett added a comment. Thanks for the review folks. I'll just wait for Jonas to confirm (probably not used downstream but no rush to land this). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131664/new/ https://reviews.llvm.org/D131664 __

[Lldb-commits] [PATCH] D131761: [LLDB] Remove __future__ imports from tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG193259cbcec7: [LLDB] Remove __future__ imports from tests (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131761/new/ https://rev

[Lldb-commits] [PATCH] D131772: [LLDB] Remove __future__ imports from examples

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f947abf94e1: [LLDB] Remove __future__ imports from examples (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131772/new/ https://

[Lldb-commits] [PATCH] D131783: [LLDB][JIT] Set processor for ARM architecture

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Thanks! LGTM. You might see some test failures for TestFPEval if anyone is testing on AIX/PPC/etc. but I think it's fine to go ahead and wait for the buildbots to complain if th

[Lldb-commits] [PATCH] D131664: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

DavidSpickett added a comment. @JDevlieghere ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131664/new/ https://reviews.llvm.org/D131664 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D131664: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

This revision was automatically updated to reflect the committed changes. Closed by commit rG662c1c28813b: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1316

[Lldb-commits] [PATCH] D132353: [LLDB] Fix: make m_target_arch private

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextFreeBSD_powerpc.cpp:227 const RegisterInfo *RegisterContextFreeBSD_powerpc64::GetRegisterInfo() const { // assert (m_target_arch.GetCore() == ArchSpec::eCore_powerpc); + if (

[Lldb-commits] [PATCH] D132353: [LLDB] Fix: make m_target_arch private

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoInterface.h:64 - // FIXME make private. lldb_private::ArchSpec m_target_arch; Rare footage of a fixme getting fixed :) Thanks! Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D132353: [LLDB] Fix: make m_target_arch private

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I think there are a few more commented out asserts, check that a grep for `m_target_arch` in `lldb/` doesn't turn up anything you wouldn't expect. Otherwise LGTM. If you find any

[Lldb-commits] [PATCH] D117559: [lldb] Remove forward-connect ability from lldb-server tests

DavidSpickett added a comment. FYI I am testing this locally, didn't work straight away but I think this might be networking issues on my part. Taking some time to check that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117559/new/ https://revie

[Lldb-commits] [PATCH] D117559: [lldb] Remove forward-connect ability from lldb-server tests

DavidSpickett added a comment. I was able to use the commands I showed before successfully but only after making these changes: --- a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py +++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.p

[Lldb-commits] [PATCH] D121786: [LLDB] Update inspect getargspec to getfullargspec

DavidSpickett added a comment. > by python 11x release Is this a typo or some numbering system not related to the 2.x/3.x cadence? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121786/new/ https://reviews.llvm.org/D121786 ___ lldb-commits ma

[Lldb-commits] [PATCH] D121802: [LLDB] Fix typos in LLDB help output.

DavidSpickett added a comment. Thanks for the corrections! If you didn't already know, you can request commit access https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access for future patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D121912: [lldb] Fix ^C handling in IOHandlerProcessSTDIO

DavidSpickett added a comment. I also found this in the process of looking at https://github.com/llvm/llvm-project/issues/53673 (different issue same area). Bisected it to the same change you got, and this fixes things for me too. Do you know if the pexpect test will cleanup the debugee process

[Lldb-commits] [PATCH] D121999: [lldb][AArch64] Update disassembler feature list and add tests for all extensions

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This updates the disassembler to enable every optional extension. Prev

[Lldb-commits] [PATCH] D121999: [lldb][AArch64] Update disassembler feature list and add tests for all extensions

DavidSpickett added a comment. > Can you make this a shell test? Great idea, I'll do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121999/new/ https://reviews.llvm.org/D121999 ___ lldb-commits mai

[Lldb-commits] [PATCH] D121999: [lldb][AArch64] Update disassembler feature list and add tests for all extensions

DavidSpickett updated this revision to Diff 416476. DavidSpickett added a comment. Switch to a shell test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121999/new/ https://reviews.llvm.org/D121999 Files: lldb/source/Plugins/Disassembler/LLVMC/D

[Lldb-commits] [PATCH] D121999: [lldb][AArch64] Update disassembler feature list and add tests for all extensions

DavidSpickett updated this revision to Diff 416477. DavidSpickett added a comment. Add comment explaining test purpose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121999/new/ https://reviews.llvm.org/D121999 Files: lldb/source/Plugins/Disasse

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

DavidSpickett added a comment. I did something along these lines for lldb-server memory tagging tests in `lldb/test/API/tools/lldb-server/memory-tagging/main.c`. In that case you've got 3 points where you we could skip the test, and you could check the auxv but that was overkill for this exampl

[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

DavidSpickett updated this revision to Diff 417960. DavidSpickett added a comment. Herald added a project: All. Switch to removing non-address bits in lldb instead of lldb-server. The breakpoint issues I mention only really happen if you try to break on a tagged function pointer. Which is pretty

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously if you read a code/data mask before there was a valid threa

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. This smells a little bit like a hack but in some ways it makes sense that an address mask value couldn't possibly be valid until we have a thread setup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett updated this revision to Diff 418221. DavidSpickett added a comment. - Don't require pointer auth hardware for the corefile test. - Remove the program file since all we need to do is read memory from the corefile. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett marked an inline comment as done. DavidSpickett added a comment. > Can we make the core file smaller? Yes we can. I need to find a good way to do that, my first instinct was to strip segments from it but perhaps I'm barking up the wrong tree there. Is there a usual way to make a

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett updated this revision to Diff 418246. DavidSpickett added a comment. - Corefile down to 24k with some tweaking of coredump_filter - Add some prints so when you generate the corefile you know what addresses to test I also found another bug testing this where memory read works but pr

[Lldb-commits] [PATCH] D121999: [lldb][AArch64] Update disassembler feature list and add tests for all extensions

DavidSpickett added a comment. > It sounds like we should figure out a way to enable all extensions with a > single stroke. Totally. llvm-objdump could do with a `-mcpu=max` equivalent too. I think it's possible to get all extension names right now, but not the newest arch version. I'll look i

[Lldb-commits] [PATCH] D121999: [lldb][AArch64] Update disassembler feature list and add tests for all extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rG434b545d4fc7: [lldb][AArch64] Update disassembler feature list and add tests for all… (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

DavidSpickett updated this revision to Diff 420766. DavidSpickett added a comment. Check that the "expression" command also treats pointers as equivalent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118794/new/ https://reviews.llvm.org/D118794 F

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett updated this revision to Diff 420769. DavidSpickett added a comment. Fix "expression"/"p" result by removing non-address bits in processElfCore::ReadMemory. I missed that it overrides this. (it was nothing to do with the target addressable bits setting) Add tests for that and proc

[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

DavidSpickett added a comment. > Do you have any explanation on this from AARM Yes I do. linux arch/arm64/kernel/ptrace.c: /* * The PAC bits can differ across data and instruction pointers * depending on TCR_EL1.TBID*, which we may make use of in future, so * we expose separ

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

DavidSpickett added a comment. Thanks for enabling the test, great to see support for this outside Linux. Comment at: lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp:817 + return address_mask; +} + I was going to suggest deduping this and the Linux function

[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

DavidSpickett planned changes to this revision. DavidSpickett added a comment. Cool. I will apply this to existing code first, in another change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118794/new/ https://reviews.llvm.org/D118794 __

<    1   2   3   4   5   6   7   8   9   10   >