DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment.
Sometimes you wonder how anything works :) I looked at the places this is used and I don't see a way to reach them from the API without the type already being `LLDB_WATCH_TYPE_READ` or `LLDB_WATCH_TYPE_WRITE`. It's checked in `lldb/source/Target/Target.cpp:CreateWatchpoint` but there's no way to fail that check using existing calls, only direct from C++. So adding a test for this isn't possible. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130972/new/ https://reviews.llvm.org/D130972 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
