[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_loongarch64.cpp:221 + + uint8_t *src = const_cast(data_sp->GetBytes()); + if (src == nullptr) { seehearfeel wrote: > DavidSpickett wrote: > > Possibly

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_loongarch64.cpp:221 + + uint8_t *src = const_cast(data_sp->GetBytes()); + if (src == nullptr) { seehearfeel wrote: > DavidSpickett wrote: > > seehearf

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Looks good from the LLDB side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138407/new/ https://reviews.llvm.org/D138407 __

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

DavidSpickett added a comment. Nice, glad to see that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136578/new/ https://reviews.llvm.org/D136578 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D139102: [AArch64] Inline AArch64TargetParser.def

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. > If some script _is_ manually parsing the .def, it ought to be easy enough to > update it to read the .cpp instead (it probably shouldn't do either). True. Hopefully the target

[Lldb-commits] [PATCH] D139102: [AArch64] Inline AArch64TargetParser.def

DavidSpickett added a comment. And thanks for bringing the test up to date in general! (that test is less checking the disassembler, more a reference of what lldb should be capable of, though it has found some bugs) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

DavidSpickett added a comment. > Thanks, all. If there are no more comments, could someone land it for me? I > don't have commit access. Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102208/new/ https://reviews.llvm.org/D102208 ___

[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64* with no hw watchpoints

DavidSpickett added a comment. Is there any command we can run to directly get the number of h/w watchpoints? I'm thinking that a lot of these are: try: doThing() except: if we got this specific error Then you could have this at the start of each test instead: if not self.HasWatc

[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64le with no hw watchpoints

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/watchpoints/hello_watchpoint/TestMyFirstWatchpoint.py:68 +except: +if self.getArchitecture() == 'powerpc64le' \ + and "\nerror: Target supports (0) hardware watchpoint slots

[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64le with no hw watchpoints

DavidSpickett added a comment. > If there isn't a specific command you could do something silly like watch > main and see if it succeeds then remove the watchpoint. Or you could watch address 0, there's no requirement for it to be a symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

DavidSpickett added a comment. I realised my mistake, I thought this was adding a new core file but in fact it's using the one you added for the register tests. So now the outfile is there the test passes. Comment at: lldb/test/API/functionalities/unwind/aarch64_unwind_pac/T

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

DavidSpickett resigned from this revision. DavidSpickett added a comment. Resigning to remove my requested changes, if that works. Looks good from my point of view. @labath You had earlier questions about using the register context, and a few comments that have gotten disconnected from the orig

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 347895. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llvm.org/D97282 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lld

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 347893. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97281/new/ https://reviews.llvm.org/D97281 Files: lldb/include/lldb/Target/MemoryTagManager.h lldb/source/P

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 347896. DavidSpickett added a subscriber: pcc. DavidSpickett added a comment. Rebase, which brings in the include @pcc mentioned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.l

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 347898. DavidSpickett added a comment. Rebase, which brings in the header pcc mentioned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files: lldb/include/lld

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 347899. DavidSpickett added a comment. I was looking at the wrong file, this adds the header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files: lldb/includ

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 347906. DavidSpickett added a comment. Rebase, fix up `SendPacketAndWaitForResponse` use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files: lldb/include/ll

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 347909. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.org/D97285 Files: lldb/source/Commands/CMakeLists.txt lldb/source/Commands/

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett added a comment. In D102757#2781561 , @omjavaid wrote: > Now that we are stripping away top byte is there any information that may be > useful for the remote side and we are removing that on the host side. I am > thinking why we should str

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett added a comment. One thing that you might think of would be the top bits set for kernel alloations. However if we're using the masks and TBI correctly those will be left intact. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757/ne

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Addresses on AArch64 can have top byte tags, memory tags and pointer authentication sign

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. The side effect here is that you do "memory read " and you see untagged addresses for the lines. It's not really that confusing but maybe something we should make a general decision

[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

DavidSpickett created this revision. Herald added subscribers: pengfei, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There is a common pattern: result.AppendError(...); result.SetStatus(eReturnStatusFailed);

[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. There are likely other tests that aren't enabled for x86/AArch64 or sets of registers that I don't have on my machines. So if this change is welcome then the plan would be to land this as is and monitor the bots for a week o

[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

DavidSpickett added a comment. > I can run this for you on macOS and Linux x86 which I think should cover > every test. That would be great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103701/new/ https://reviews.llvm.org/D103701 _

[Lldb-commits] [PATCH] D103744: [lldb][docs] Remove mention of subversion. NFC.

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103744/new/ https://reviews.llvm.org/D103744 _

[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe05b03cf4f45: [lldb] Set return status to failed when adding a com

[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

DavidSpickett added a comment. I've gone ahead and landed it, will revert on failures. Got patches to remove the reundant calls locally so I'll put those up for review once this has had time to go through. (those changes will be fairly mechanical but it's worth someone scanning them for silly m

[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

DavidSpickett added a comment. 1 failure on MacOS "lldb-api :: commands/register/register/register_command/TestRegisters.py", http://green.lab.llvm.org/green/blue/organizations/jenkins/lldb-cmake/detail/lldb-cmake/32693/pipeline/, hence the revert. Should be easy enough to fix the test logic.

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 351428. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97281/new/ https://reviews.llvm.org/D97281 Files: lldb/include/lldb/Target/MemoryTagManager.h lldb/source/P

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 351429. DavidSpickett added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llvm.org/D97282 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h ll

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 351430. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lld

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 351431. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files: lldb/include/lldb/Core/Architecture.h lldb/include/lldb/T

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 351432. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ https://reviews.llvm.org/D97285 Files: lldb/source/Commands/CMakeLists.txt lldb/source/Commands/

[Lldb-commits] [PATCH] D103701: [lldb] Set return status to failed when adding a command error

DavidSpickett added a comment. Relanded in https://reviews.llvm.org/rGa2363c0cf9b6 / https://reviews.llvm.org/rG0f94d68a2e15 (because I have a case of the Monday Mornings). If this does the trick there are 2/3 other tests that use this tactic to check for AVX so I can update those too. Reposi

[Lldb-commits] [PATCH] D104221: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104221/new/ https://reviews.llvm.org/D104221 _

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

DavidSpickett added a comment. Since you landed the underlying ABI patch, looking at this again. Seems like no comments on the BSD side, in which case to be safe we could just have the default `FixWatchpointHitAddress` make no changes. Then remove TBI and PAC for AArch64 Linux, no surprises tha

[Lldb-commits] [PATCH] D104379: [lldb] Remove redundant calls to set eReturnStatusFailed

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Since https://reviews.llvm.org/D103701 AppendError<...> sets this for you. This change includes all of the non-command uses. Some uses rema

[Lldb-commits] [PATCH] D104379: [lldb] Remove redundant calls to set eReturnStatusFailed

DavidSpickett added a reviewer: teemperor. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. There'll be a part 2 once this has passed the bots, which will cover all the `CommandObject*` files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D104380: [lldb] Set return object failed status even if error string is empty

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The idea is now that AppendError<...> will set eReturnStatusFailed for you so you don't have to call SetStatus again. Previously if the erro

[Lldb-commits] [PATCH] D104379: [lldb] Remove redundant calls to set eReturnStatusFailed

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp:835 if (!error.Success()) { result.AppendError(error.AsCString()); - result.SetStatus(eReturnStatusFailed); https://reviews

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett added inline comments. Comment at: lldb/source/Target/Process.cpp:5854 + if (auto abi = GetABI()) { +// TODO: can we always assume data addresses here? +load_addr = abi->FixDataAddress(load_addr); omjavaid wrote: > Yes this is ok for now as

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett added a comment. > Maybe this is something worth considering for LLDB memory dumps? I'm working on that at the moment, it's on my github branch. This is what it looks like with the right options: (others look weird at the moment due to ordering issues) (lldb) memory read mte_bu

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett added a comment. I am going to go over them this afternoon. I'm about to land some lldb patches that allow some easy refactoring, and your ABI patch might be useable too. If using the ABI method is better as a follow up then we can get started landing them. Repository: rG LLVM

[Lldb-commits] [PATCH] D104380: [lldb] Set return object failed status even if error string is empty

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG983ed1b58ef9: [lldb] Set return object failed status even if error string is empty (authored by DavidSpickett). Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D104379: [lldb] Remove redundant calls to set eReturnStatusFailed

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a580f3c28cf: [lldb] Remove redundant calls to set eReturnStatusFailed (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104379/new/

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 352720. DavidSpickett added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97281/new/ https://reviews.llvm.org/D97281 Files: lldb/include/lldb/Target/MemoryTagManager.h ll

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett added a comment. @omjavaid As it stands, RemoveNonAddressBits here removes the top byte unconditionally. You asked for pointer signatures to be removed as well, which would be neatly solved by using the ABI plugin. Ok to land this as is, then write a follow up to migrate to using

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 352722. DavidSpickett added a comment. Rebase, this is good to land as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llvm.org/D97282 Files: lldb/include/lldb/Host/common/

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 352736. DavidSpickett added a comment. Rebase, this is now ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files: lldb/include/lldb/Host/common/N

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 352739. DavidSpickett added a comment. Rebase, now ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files: lldb/include/lldb/Core/Architecture.h

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 352741. DavidSpickett added a comment. Rebase. Remove `result.SetStatus(eReturnStatusFailed)` which is now implicitly done when you add an error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ h

[Lldb-commits] [PATCH] D104380: [lldb] Set return object failed status even if error string is empty

DavidSpickett added a comment. This change would have been part of https://reviews.llvm.org/D103701 if I had realised that this was in fact how it worked. I separated it from the follow ons because of that and to not bury 3 lines of change that apply to all callers of these functions, in 300 li

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett updated this revision to Diff 352954. DavidSpickett added a comment. Remove TODO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757/new/ https://reviews.llvm.org/D102757 Files: lldb/include/lldb/Target/Process.h lldb/source/Pl

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett updated this revision to Diff 352959. DavidSpickett added a comment. - Move DoGetMemoryRegionInfo into protected section, GetMemoryRegionInfo is the public part. - Fix a comment typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1027

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett added a comment. Do you think this needs a test with a core file as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757/new/ https://reviews.llvm.org/D102757 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett updated this revision to Diff 352964. DavidSpickett added a comment. - Add missing include - Rename test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103626/new/ https://reviews.llvm.org/D103626 Files: lldb/source/Commands/Command

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/test/API/linux/aarch64/tagged_memory_read/TestAArch64LinuxTaggedMemoryRead.py:23 +def test_mte_regions(self): +if not self.isAArch64PAuth(): +self.skipTe

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

DavidSpickett created this revision. Herald added a subscriber: inglorion. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The intention is now that AppendError/SetError/AppendRawError only be called with some message to show.

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

DavidSpickett updated this revision to Diff 353310. DavidSpickett added a comment. Use !empty instead of size. All tests passing on X86 and AArch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104525/new/ https://reviews.llvm.org/D104525 Files:

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12ae3cb7ba53: [lldb] Assert that CommandResultObject error messages are not empty (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

DavidSpickett added a comment. Yeah good point, I can do that. I'm gonna go over the remaining SetStatus calls first, then I'll look at it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104525/new/ https://reviews.llvm.org/D104525 ___

[Lldb-commits] [PATCH] D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed)

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Mostly by converting uses of GetErrorStream to AppendError, so that the call to SetStatus is implicit. Some remain where it isn't certain th

[Lldb-commits] [PATCH] D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed)

DavidSpickett updated this revision to Diff 353598. DavidSpickett added a comment. Remove c_str() in Reproducer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104697/new/ https://reviews.llvm.org/D104697 Files: lldb/source/Commands/CommandObject

[Lldb-commits] [PATCH] D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8dd7094d364: [lldb] Remove more redundant SetStatus(eReturnStatusFailed) (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Replacing existing uses with AppendError. SetError is also part of the SBI API. Instead of removing it outright, deprecate it and have it ca

[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. I'm not totally sure about adding AppendError to the API. Should we (and where should I) document that AppendError expects a non empty message? On the other hand if you're using a release build the assert to check that isn'

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

DavidSpickett added a comment. I was going to say we only would need to remove the assert for this one: void CommandReturnObject::SetError(const Status &error, const char *fallback_error_cstr) { Since SetError checks that the `char *` is not null in the API

[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

DavidSpickett added a comment. I was going to say we only would need to remove the assert for this one: void CommandReturnObject::SetError(const Status &error, const char *fallback_error_cstr) { Since SetError checks that the char * is not null in the API l

[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

DavidSpickett updated this revision to Diff 353919. DavidSpickett added a comment. Don't change the API, just have SetError call underlying AppendError. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104768/new/ https://reviews.llvm.org/D104768 Fil

[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b1c8e4a984c: [lldb] Remove CommandReturnObject's SetError(StringRef) (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I added asserts to these in https://reviews.llvm.org/D104525. They are available (directly or otherwise) via the API so we should not assert.

[Lldb-commits] [PATCH] D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError

DavidSpickett added a comment. As noted, the assert in AppendRawError remains. It has two internal callers and no API definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104778/new/ https://reviews.llvm.org/D104778 _

[Lldb-commits] [PATCH] D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError

DavidSpickett added a comment. > LGTM, I'll add them in my patch. Thanks for the quick turnaround! To clarify, is there still a regression with the API? - This removes the asserts so you won't crash - No functions are changed in `lldb/include/lldb/API/SBCommandReturnObject.h` The one thing that

[Lldb-commits] [PATCH] D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe63db25bcc0: [lldb] Remove asserts in CommandReturnObject SetError and AppendError (authored by DavidSpickett). Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0f2744a115c: [lldb][AArch64] Add class for managing memory tags (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d58fbd09efb: [lldb][AArch64] Add memory-tagging qSupported feature (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda2e614f56b1: [lldb][AArch64] Add memory tag reading to lldb-server (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d3436200147: [lldb][AArch64] Add MTE memory tag reading to lldb (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG31f9960c3852: [lldb][AArch64] Add "memory tag read" command (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett added a comment. This was fixed by Omair in https://reviews.llvm.org/rG9ca0171a9ffdef5fdb1511d197a3fd72490362de. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 __

[Lldb-commits] [PATCH] D104914: [lldb] Correct format of qMemTags type field

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The type field is a signed integer. (https://sourceware.org/gdb/current/onlinedocs/gdb/General-Quer

[Lldb-commits] [PATCH] D104914: [lldb] Correct format of qMemTags type field

DavidSpickett updated this revision to Diff 355486. DavidSpickett added a comment. - Remove redundant check on type value - Explain how we check the target has MTE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104914/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D105178: [lldb][AArch64] Annotate synchronous tag faults

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In the latest Linux kernels synchronous tag faults include the tag bits in their address

[Lldb-commits] [PATCH] D105178: [lldb][AArch64] Annotate synchronous tag faults

DavidSpickett added reviewers: omjavaid, pcc. DavidSpickett added a subscriber: pcc. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. @pcc This makes use of the kernel changes you did, let me know if I have anything wrong. Note that the situation where you can't read the a

[Lldb-commits] [PATCH] D105179: [lldb][AArch64] Add tag repeat and unpack to memory tag manager

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. PackTags is used by to compress tags to go in the QMemTags packet and be passed to ptrac

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is implemented using the QMemTags packet, as specified by GDB in: https://sourcewar

[Lldb-commits] [PATCH] D105181: [lldb][AArch64] Add memory tag writing to lldb

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds memory tag writing to Process and the GDB remote code. Supporting work for the

[Lldb-commits] [PATCH] D105182: [lldb] Add "memory tag write" command

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a new command for writing memory tags. It is based on the existing "memory write" command. Syntax: memory tag write [ [...]] (wh

[Lldb-commits] [PATCH] D105183: [lldb] Add "memory tag write" --end-addr option

DavidSpickett created this revision. Herald added a subscriber: dang. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The default mode of "memory tag write" is to calculate the range from the start address and the number of ta

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

DavidSpickett added a comment. For TBI, this looks good as is, I would like to see PAC tested as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101361/new/ https://reviews.llvm.org/D101361 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D105483: [LLDB] Testsuite: Add helper to check for AArch64 target

DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1296 +"""Returns true if the architecture is AArch64.""" +return self.getArchitecture().lower() in ["aarch64"] + This can be: ``` return self.getArchi

[Lldb-commits] [PATCH] D105181: [lldb][AArch64] Add memory tag writing to lldb

DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/MemoryTagManager.h:35 + // alignment/expansion over again. + struct TagManagerWithRange { +const MemoryTagManager *manager; omjavaid wrote: > I was wondering if you can explain reason

[Lldb-commits] [PATCH] D105179: [lldb][AArch64] Add tag repeat and unpack to memory tag manager

DavidSpickett updated this revision to Diff 356900. DavidSpickett added a comment. - Make granules default to 0 for UnpackTagsData - Add more comments to tests (I'll add a method to repeat packed tags in the later patch that'll use it) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

DavidSpickett added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56 # Run the packet stream context = self.expect_gdbremote_sequence() self.assertIsNotNone(context) omjavaid

[Lldb-commits] [PATCH] D105181: [lldb][AArch64] Add memory tag writing to lldb

DavidSpickett added inline comments. Comment at: lldb/source/Target/Process.cpp:6108 +range_callback) { Architecture *arch = GetTarget().GetArchitecturePlugin(); const MemoryTagManager *tag_manager = omjavaid wrote: > The point I was trying to estab

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/watchpoints/watch_tagged_addr/main.c:11 + + __asm__ __volatile__("pacdza %0" : "=r"(tagged_ptr) : "r"(tagged_ptr)); + Add comments to these inline asm lines to explain the instructions. CH

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM with the comments added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101361/new/ https://reviews.llvm.org/D101361 ___

[Lldb-commits] [PATCH] D105483: [LLDB] Testsuite: Add helper to check for AArch64 target

DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1296 +"""Returns true if the architecture is AArch64.""" +return self.getArchitecture().lower() in ["aarch64"] + omjavaid wrote: > DavidSpickett wrote

<    7   8   9   10   11   12   13   14   15   16   >