DavidSpickett added a comment. > LGTM, I'll add them in my patch. Thanks for the quick turnaround!
To clarify, is there still a regression with the API? - This removes the asserts so you won't crash - No functions are changed in `lldb/include/lldb/API/SBCommandReturnObject.h` The one thing that is different is that calling the API SetError with an empty string will now set eReturnStatusFailed. So: s = do_thing_and_return_err_string_if_err(...) return_object.SetError(s) Would now set it to failed even if s is empty. Perhaps the SetError(...) functions should retain the empty message == nop behaviour and AppendError can set the status unconditionally? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104778/new/ https://reviews.llvm.org/D104778 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
