[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary updated this revision to Diff 441073. dmlary added a comment. updated to include test cases for `SBSection.GetAlignment()` and `SBSection.alignment` property. @labath Thanks for the yaml2obj pointer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary updated this revision to Diff 441429. dmlary added a comment. merge tests, rename yml to yaml Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://reviews.llvm.org/D128069 Files: lldb/bindings/interface/SBSection.i lldb/inc

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary marked 2 inline comments as done. dmlary added a comment. @JDevlieghere if I'm reading this right, yours is the last approval this review needs. Is there anything else you would like to be updated in this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary added a comment. I do not have commit access; could someone merge this patch as time allows? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://reviews.llvm.org/D128069 ___ lldb-com

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary created this revision. dmlary added a reviewer: clayborg. dmlary added a project: LLDB. Herald added subscribers: Michael137, JDevlieghere. Herald added a project: All. dmlary requested review of this revision. This commit adds SBSection.GetAlignment(), and SBSection.alignment as a python

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary added a comment. I went through the existing tests for SBSection, and there is only one test case for all the getters & props, and that is for `target_byte_size`. Based on that lack, and the simplicity of the getter, I didn't think a test case was warranted here. If the reviewers feel

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary added a comment. Sent this via email, but doesn't look like it showed up here: > I'm less concerned about the getter and the property and more about the > underlying functionality. It doesn't look like it's being tested, and adding > it to the SB API allows to change that. Just to clari

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary added a comment. > We should test any APIs we add in a python test IMHO. Also testing that the > ".alignment" property works Ok, I'll add tests for the added python function and property. Now for the hard part, what's the recommended way to access elf section details within python with

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

dmlary created this revision. dmlary added a reviewer: LLDB. dmlary added a project: LLDB. Herald added subscribers: JDevlieghere, emaste. Herald added a project: All. dmlary requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. I encountered an issue where `p &variab

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

dmlary added a comment. I'm looking for any suggestions of how to test this. I can create a simple object file with the needed relocation types, but I don't see an easy way to get lldb to apply those relocations (in .`.text` for example). I wanted to see if that was possible before making a fa

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

dmlary added a comment. @labath it doesn't look like the relocations are applied during `lldb-test object-file --contents`: from obj2yaml for rel.c described in summary (with added spacing for readabilty): [...] - Name:.debug_info Type:SHT_PROGBITS Add

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

dmlary added a comment. @labath you are correct, lldb-test is performing the relocations. I'm digging into why I'm not seeing the changes I would expect in the section. I'll update the diff with tests when I get that resolved. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

dmlary updated this revision to Diff 458825. dmlary marked an inline comment as done. dmlary added a comment. - Added test cases for REL and RELA cases - Removed assert & fixme comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132954/new/ https://reviews.llvm.org/D132954 Files: l

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

dmlary added a comment. Could someone please merge this? I do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132954/new/ https://reviews.llvm.org/D132954 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

dmlary added a comment. I saw the build bot failures; looking into them now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132954/new/ https://reviews.llvm.org/D132954 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

dmlary added a comment. I'm not sure what to do about the test cases that now unexpectedly pass. The removal of the `assert()` in `ObjectFileELF::ApplyRelocations` means each of these cases is now passing on what looks like 32-bit arm, but I don't know enough about the three tests to say that