dmlary added a comment.

I'm not sure what to do about the test cases that now unexpectedly pass.  The 
removal of the `assert()` in `ObjectFileELF::ApplyRelocations` means each of 
these cases is now passing on what looks like 32-bit arm, but I don't know 
enough about the three tests to say that it's right to remove the `XPASS`.  I 
think the buildbot is reporting that they do pass, so is it safe?

  Unexpectedly Passed Tests (3):
    lldb-shell :: SymbolFile/DWARF/anon_class_w_and_wo_export_symbols.ll
    lldb-shell :: 
SymbolFile/DWARF/clang-ast-from-dwarf-unamed-and-anon-structs.cpp
    lldb-shell :: SymbolFile/DWARF/split-optimized.c


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132954/new/

https://reviews.llvm.org/D132954

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to