[Lldb-commits] [PATCH] D54084: [LLDB] Fix FreeBSD build

devnexen created this revision. devnexen added reviewers: JDevlieghere, tatyana-krasnukha. devnexen created this object with visibility "All Users". Herald added subscribers: lldb-commits, emaste. ResolvePath is no longer into FileSpec class Repository: rLLDB LLDB https://reviews.llvm.org/D54

[Lldb-commits] [PATCH] D54084: [LLDB] Fix FreeBSD/Darwin build

devnexen updated this revision to Diff 172535. devnexen retitled this revision from "[LLDB] Fix FreeBSD build" to "[LLDB] Fix FreeBSD/Darwin build". https://reviews.llvm.org/D54084 Files: source/Plugins/Process/Darwin/NativeProcessDarwin.cpp source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp

[Lldb-commits] [PATCH] D54084: [LLDB] Fix FreeBSD/Darwin build

devnexen added a comment. Can't test under Darwin but reproduced similar changes. https://reviews.llvm.org/D54084 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54084: [LLDB] Fix FreeBSD/Darwin build

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB346109: [LLDB] Fix FreeBSD/Darwin build (authored by devnexen, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D54084 Files: source/Plugins/Process/Darwin/NativeProcessDarwin.cpp

[Lldb-commits] [PATCH] D57506: [LLDB] FreeBSD suppress compilation warning

devnexen created this revision. devnexen added a reviewer: labath. devnexen created this object with visibility "All Users". Herald added subscribers: lldb-commits, emaste. Repository: rLLDB LLDB https://reviews.llvm.org/D57506 Files: source/Plugins/Process/FreeBSD/ProcessMonitor.cpp Index

[Lldb-commits] [PATCH] D57506: [LLDB] FreeBSD suppress compilation warning

This revision was automatically updated to reflect the committed changes. Closed by commit rL352744: [LLDB] FreeBSD suppress compilation warning (authored by devnexen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57506?vs=184480&id=

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen created this revision. devnexen added reviewers: dim, jbeich. devnexen created this object with visibility "All Users". Herald added subscribers: lldb-commits, JDevlieghere, emaste. Herald added a project: LLDB. devnexen added a comment. With this I do not get segfault anymore. @dim I jus

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen added a comment. With this I do not get segfault anymore. @dim I just looked up the patch on FreeBSD, if this approach is preferred, I ll go along. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762 ___

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen updated this revision to Diff 224256. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762 Files: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp Index: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen abandoned this revision. devnexen added a comment. Just realised there was an existing PR addressing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen accepted this revision. devnexen added a comment. This revision is now accepted and ready to land. LGTM otherwise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68723/new/ https://reviews.llvm.org/D68723 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen added inline comments. Comment at: source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:733 // Finally, start monitoring the child process for change in state. - m_monitor_thread = Host::StartMonitoringChildProcess( + auto monitor_thread = Host::StartMonitoringChildPro

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen added a comment. In D68723#1703098 , @MaskRay wrote: > In D68723#1703051 , @devnexen wrote: > > > LGTM otherwise. > > > I don't think this change should be reverted. It can just be repaired by > adding som

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen added a comment. @dim I LGTMed this but would it a real issue for you to take on a less disruptive approach proposed by MaskRay ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68723/new/ https://reviews.llvm.org/D68723 ___ lldb-co

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen added a comment. In D68723#1703379 , @MaskRay wrote: > In D68723#1703322 , @devnexen wrote: > > > @dim I LGTMed this but would it a real issue for you to take on a less > > disruptive approach proposed by

[Lldb-commits] [PATCH] D63187: [LLDB] Fix FreeBSD build

devnexen created this revision. devnexen added reviewers: aadsm, MaskRay. devnexen created this object with visibility "All Users". Herald added subscribers: lldb-commits, emaste. Herald added a project: LLDB. The auxiliary vector method had wrong signature. Repository: rLLDB LLDB https://rev

[Lldb-commits] [PATCH] D63187: [LLDB] Fix FreeBSD build

This revision was automatically updated to reflect the committed changes. Closed by commit rL363135: [LLDB] Fix FreeBSD build (authored by devnexen, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D63187?vs

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen created this revision. devnexen added reviewers: mgorny, MaskRay. devnexen created this object with visibility "All Users". Herald added subscribers: lldb-commits, jfb, emaste. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D64398 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen marked an inline comment as done. devnexen added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:798 + if (!m_operation_thread) { + Status e("Start launch thread failed"); + error = e; MaskRay wrote: > See D64

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen updated this revision to Diff 208649. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64398/new/ https://reviews.llvm.org/D64398 Files: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.h Index: lldb/source/Plugins/Proce

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen added a comment. By the way quick question, I did not commit since quite a time, is it still subversion ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64398/new/ https://reviews.llvm.org/D64398 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

devnexen added a comment. ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64398/new/ https://reviews.llvm.org/D64398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [PATCH] D64398: [LLDB] Fix FreeBSD build

This revision was automatically updated to reflect the committed changes. Closed by commit rL365761: [LLDB] Fix FreeBSD build. (authored by devnexen, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D64398?v