chaoren created this revision.
chaoren added a reviewer: zturner.
chaoren added a subscriber: lldb-commits.
http://reviews.llvm.org/D11910
Files:
test/dosep.py
Index: test/dosep.py
===
--- test/dosep.py
+++ test/dosep.py
@@ -153,1
chaoren updated this revision to Diff 31683.
chaoren added a comment.
Rebase on top of http://reviews.llvm.org/D11910.
http://reviews.llvm.org/D11846
Files:
test/dosep.py
Index: test/dosep.py
===
--- test/dosep.py
+++ test/dosep
chaoren added a comment.
Zach, there were two more comments since the LGTM.
Comment at: test/dosep.py:1
@@ -1,2 +1,2 @@
-#!/usr/bin/env python
+#!/usr/bin/env python
chaoren wrote:
> I think you added a character here. Could you please double check
> before
chaoren updated this revision to Diff 31703.
chaoren added a comment.
Rebase on top of http://reviews.llvm.org/rL244469.
http://reviews.llvm.org/D11843
Files:
test/dosep.py
Index: test/dosep.py
===
--- test/dosep.py
+++ test/dos
chaoren updated this revision to Diff 31708.
chaoren added a comment.
Accidentally removed timed_out tests from failed tests.
http://reviews.llvm.org/D11910
Files:
test/dosep.py
Index: test/dosep.py
===
--- test/dosep.py
+++ tes
chaoren created this revision.
chaoren added reviewers: zturner, ovyalov.
chaoren added a subscriber: lldb-commits.
http://reviews.llvm.org/D11967
Files:
include/lldb/Host/windows/win32.h
Index: include/lldb/Host/windows/win32.h
=
chaoren added a comment.
Ping?
http://reviews.llvm.org/D11843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: chaoren
Date: Tue Aug 11 20:22:24 2015
New Revision: 244710
URL: http://llvm.org/viewvc/llvm-project?rev=244710&view=rev
Log:
Export snprintf to avoid linking error with liblldb on Windows.
Reviewers: zturner, ovyalov
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244710: Export snprintf to avoid linking error with liblldb
on Windows. (authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D11967?vs=31884&id=31896#toc
Repository:
rL LLVM
http:
chaoren added a subscriber: chaoren.
chaoren added a comment.
Sorry! I'll fix this as soon as I get home.
I have a question though, isn't this only a problem if whatever's linking
against lldb includes this header? This isn't in the API, so that shouldn't
happen. I also don't know if it's correct
it's part of the api. Are we
> sure it can't happen through a transitive include?
>
> As long as the user of liblldb doesn't see the declaration it shouldn't be
> a problem.
>
> On Tue, Aug 11, 2015 at 6:54 PM Chaoren Lin via lldb-commits <
> lldb-c
chaoren added inline comments.
Comment at: test/dosep.py:163
@@ -162,3 @@
-# We're only interested in the test file with the "Test*.py" naming
pattern.
-if not name.startswith("Test") or not name.endswith(".py"):
-continue
From here.
Author: chaoren
Date: Wed Aug 12 13:02:53 2015
New Revision: 244783
URL: http://llvm.org/viewvc/llvm-project?rev=244783&view=rev
Log:
Refactor dosep to use list comprehension. NFC.
Reviewers: zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D11910
Modified:
Author: chaoren
Date: Wed Aug 12 13:02:49 2015
New Revision: 244781
URL: http://llvm.org/viewvc/llvm-project?rev=244781&view=rev
Log:
Make dosep output status by overwriting the same line.
Summary: Update to D11816.
Reviewers: zturner
Subscribers: zturner, lldb-commits
Differential Revision: h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244783: Refactor dosep to use list comprehension. NFC.
(authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D11910?vs=31708&id=31963#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: chaoren
Date: Wed Aug 12 13:02:51 2015
New Revision: 244782
URL: http://llvm.org/viewvc/llvm-project?rev=244782&view=rev
Log:
Don't print number of failures and percentage if no tests ran.
Reviewers: zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D11909
Author: chaoren
Date: Wed Aug 12 13:02:54 2015
New Revision: 244784
URL: http://llvm.org/viewvc/llvm-project?rev=244784&view=rev
Log:
Make dosep.py PEP8 compliant. NFC.
Reviewers: zturner, clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D11846
Modified:
ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244784: Make dosep.py PEP8 compliant. NFC. (authored by
chaoren).
Changed prior to commit:
http://reviews.llvm.org/D11846?vs=31683&id=31964#toc
Repository:
rL LLVM
http://reviews.llvm.org/D11846
Fi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244782: Don't print number of failures and percentage if no
tests ran. (authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D11909?vs=31679&id=31962#toc
Repository:
rL LLVM
http:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244781: Make dosep output status by overwriting the same
line. (authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D11843?vs=31703&id=31961#toc
Repository:
rL LLVM
http://reviews
chaoren added inline comments.
Comment at: test/dosep.py:202
@@ -196,1 +201,3 @@
if status != ePassed]
+xpasses = [name for name, status, _, _, unexpected_successes in results if
unexpected_successes > 0]
+
Don't need status here.
Nit: cou
chaoren accepted this revision.
chaoren added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D12020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
chaoren added inline comments.
Comment at: test/lldbtest.py:943
@@ -947,1 +942,3 @@
+def skipUnlessArch(archlist):
+def myImpl(func):
Is there a reason
```
return unittest2.skipUnless(getArchitecture() in archlist, ...)
```
is not sufficient?
Also, please a
chaoren accepted this revision.
This revision is now accepted and ready to land.
Comment at: test/lldbtest.py:943
@@ -947,1 +942,3 @@
+def skipUnlessArch(archlist):
+def myImpl(func):
zturner wrote:
> chaoren wrote:
> > Is there a reason
> > ```
> > return u
Author: chaoren
Date: Mon Aug 17 19:27:08 2015
New Revision: 245262
URL: http://llvm.org/viewvc/llvm-project?rev=245262&view=rev
Log:
Revert part of "Convert all use of pthreads in tests to c++11 threads."
TestExprDoesntBlock started failing because deadlocks behave differently with
pthread_mutex
chaoren added a subscriber: chaoren.
chaoren added a comment.
Ping? It's been a week, and the buildbot is still red because of this:
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/4923
http://reviews.llvm.org/D11962
___
lldb-commi
Author: chaoren
Date: Tue Aug 18 20:24:57 2015
New Revision: 245398
URL: http://llvm.org/viewvc/llvm-project?rev=245398&view=rev
Log:
Update to r245397.
`ast_transformer` could be null, in which case we should initialize
`m_code_generator` with the ASTContext.
Modified:
lldb/trunk/source/Exp
Author: chaoren
Date: Tue Aug 18 21:55:33 2015
New Revision: 245407
URL: http://llvm.org/viewvc/llvm-project?rev=245407&view=rev
Log:
XFAIL TestCppChainedCalls for GCC.
Modified:
lldb/trunk/test/lang/cpp/chained-calls/TestCppChainedCalls.py
Modified: lldb/trunk/test/lang/cpp/chained-calls/Te
Author: chaoren
Date: Tue Aug 18 23:08:56 2015
New Revision: 245412
URL: http://llvm.org/viewvc/llvm-project?rev=245412&view=rev
Log:
Fix TestCppNsImport and TestCppScope for remote tests.
Modified:
lldb/trunk/test/lang/cpp/nsimport/TestCppNsImport.py
lldb/trunk/test/lang/cpp/scope/TestCp
chaoren added a subscriber: chaoren.
Comment at: test/lang/cpp/global_operators/TestCppGlobalOperators.py:9
@@ +8,3 @@
+class TestCppGlobalOperators(TestBase):
+
+mydir = TestBase.compute_mydir(__file__)
Please be careful of trailing whitespaces.
Author: chaoren
Date: Wed Aug 19 01:21:09 2015
New Revision: 245418
URL: http://llvm.org/viewvc/llvm-project?rev=245418&view=rev
Log:
XFAIL TestCppScope for Darwin.
Modified:
lldb/trunk/test/lang/cpp/scope/TestCppScope.py
Modified: lldb/trunk/test/lang/cpp/scope/TestCppScope.py
URL:
http://
Author: chaoren
Date: Wed Aug 19 12:13:02 2015
New Revision: 245460
URL: http://llvm.org/viewvc/llvm-project?rev=245460&view=rev
Log:
XTIMEOUT TestExitDuringStep for Darwin.
Modified:
lldb/trunk/test/dosep.py
Modified: lldb/trunk/test/dosep.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/t
Author: chaoren
Date: Wed Aug 19 12:22:12 2015
New Revision: 245464
URL: http://llvm.org/viewvc/llvm-project?rev=245464&view=rev
Log:
XTIMEOUT TestEvents and TestThreadStates for Windows to Android.
Modified:
lldb/trunk/test/dosep.py
Modified: lldb/trunk/test/dosep.py
URL:
http://llvm.org/v
Author: chaoren
Date: Wed Aug 19 13:39:25 2015
New Revision: 245477
URL: http://llvm.org/viewvc/llvm-project?rev=245477&view=rev
Log:
XTIMEOUT TestChangeProcessGroup for Linux.
Modified:
lldb/trunk/test/dosep.py
Modified: lldb/trunk/test/dosep.py
URL:
http://llvm.org/viewvc/llvm-project/lld
chaoren added a subscriber: chaoren.
chaoren requested changes to this revision.
chaoren added a reviewer: chaoren.
This revision now requires changes to proceed.
Comment at: test/lang/cpp/chained-calls/TestCppChainedCalls.py:45
@@ -45,3 +44,3 @@
env = None
proce
chaoren requested changes to this revision.
This revision now requires changes to proceed.
Comment at: test/lang/cpp/nsimport/TestCppNsImport.py:37
@@ -36,3 +36,3 @@
# Get the path of the executable
-cwd = os.getcwd()
+cwd = self.get_process_working_direct
Author: chaoren
Date: Wed Aug 19 20:26:57 2015
New Revision: 245532
URL: http://llvm.org/viewvc/llvm-project?rev=245532&view=rev
Log:
XTIMEOUT TestIntegerTypesExpr for Darwin.
Modified:
lldb/trunk/test/dosep.py
Modified: lldb/trunk/test/dosep.py
URL:
http://llvm.org/viewvc/llvm-project/lldb
chaoren created this revision.
chaoren added a reviewer: zturner.
chaoren added a subscriber: lldb-commits.
dllexport doesn't work if linking against a static library with its own
copy of snprintf.
http://reviews.llvm.org/D12206
Files:
include/lldb/Host/windows/win32.h
source/Host/windows/Wi
Author: chaoren
Date: Thu Aug 20 15:53:15 2015
New Revision: 245610
URL: http://llvm.org/viewvc/llvm-project?rev=245610&view=rev
Log:
Inline fake snprintf to avoid linkage issues on Windows.
Summary:
dllexport doesn't work if linking against a static library with its own
copy of snprintf.
Review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245610: Inline fake snprintf to avoid linkage issues on
Windows. (authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D12206?vs=32722&id=32740#toc
Repository:
rL LLVM
http://revie
chaoren created this revision.
chaoren added reviewers: clayborg, jaydeep.
chaoren added a subscriber: lldb-commits.
Update to http://reviews.llvm.org/rL243618.
http://reviews.llvm.org/D12420
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: source/Plugins/Process/gdb-remot
chaoren updated this revision to Diff 33460.
chaoren added a comment.
- Force client side copy.
http://reviews.llvm.org/D12420
Files:
include/lldb/Target/Process.h
source/Plugins/Process/elf-core/ProcessElfCore.cpp
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
source/Target/Pro
chaoren marked an inline comment as done.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:853
@@ -852,3 +852,3 @@
if (platform_sp && platform_sp->IsConnected())
-SetUnixSignals(platform_sp->GetUnixSignals());
+
SetUnixSignals(std
chaoren updated this revision to Diff 33485.
chaoren added a comment.
- ProcessGDBRemote should automatically get a copy of GDBRemoteSignals.
http://reviews.llvm.org/D12420
Files:
include/lldb/Target/Process.h
source/Plugins/Process/elf-core/ProcessElfCore.cpp
source/Plugins/Process/gdb-r
chaoren added inline comments.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:2910
@@ +2909,3 @@
+{
+Process::SetUnixSignals(std::make_shared(signals_sp));
+}
Here's the copy.
http://reviews.llvm.org/D12420
Author: chaoren
Date: Tue Sep 1 11:58:45 2015
New Revision: 246557
URL: http://llvm.org/viewvc/llvm-project?rev=246557&view=rev
Log:
Make ProcessGDBRemote get a //copy// of platform Unix signals.
Summary: Update to http://reviews.llvm.org/rL243618.
Reviewers: jaydeep, clayborg
Subscribers: lab
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246557: Make ProcessGDBRemote get a //copy// of platform
Unix signals. (authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D12420?vs=33485&id=33707#toc
Repository:
rL LLVM
http:/
Author: chaoren
Date: Mon Sep 14 17:39:34 2015
New Revision: 247628
URL: http://llvm.org/viewvc/llvm-project?rev=247628&view=rev
Log:
Fix CMake build.
- Typo: Coca.cpp -> Cocoa.cpp
- Missing include.
Added:
lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp
- copied, changed from r24762
chaoren created this revision.
chaoren added a reviewer: tfiala.
chaoren added a subscriber: lldb-commits.
Linux with ToT clang (3.8) fails.
This reverts commit r247633.
http://reviews.llvm.org/D12868
Files:
test/lang/c/const_variables/TestConstVariables.py
Index: test/lang/c/const_variables
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247648: Revert "Fixup XFAIL marking on TestConstVariables
for clang version" (authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D12868?vs=34764&id=34766#toc
Repository:
rL LLVM
Author: chaoren
Date: Mon Sep 14 19:52:00 2015
New Revision: 247648
URL: http://llvm.org/viewvc/llvm-project?rev=247648&view=rev
Log:
Revert "Fixup XFAIL marking on TestConstVariables for clang version"
Summary:
Linux with ToT clang (3.8) fails.
This reverts commit r247633.
Reviewers: tfiala
S
Author: chaoren
Date: Tue Sep 15 20:20:34 2015
New Revision: 247766
URL: http://llvm.org/viewvc/llvm-project?rev=247766&view=rev
Log:
Fix off-by-one size check.
Modified:
lldb/trunk/source/Expression/IRInterpreter.cpp
Modified: lldb/trunk/source/Expression/IRInterpreter.cpp
URL:
http://llvm
chaoren created this revision.
chaoren added a reviewer: zturner.
chaoren added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
http://reviews.llvm.org/D12909
Files:
test/make/Makefile.rules
Index: test/make/Makefile.rules
=
Author: chaoren
Date: Wed Sep 16 16:32:48 2015
New Revision: 247855
URL: http://llvm.org/viewvc/llvm-project?rev=247855&view=rev
Log:
XFAIL TestCppNsImport for gcc-4.9.
Works for gcc-4.8. A bug in gcc perhaps.
Modified:
lldb/trunk/test/lang/cpp/nsimport/TestCppNsImport.py
Modified: lldb/tru
Author: chaoren
Date: Wed Sep 16 16:51:51 2015
New Revision: 247857
URL: http://llvm.org/viewvc/llvm-project?rev=247857&view=rev
Log:
Fix Makefile for Windows to Android tests.
Reviewers: zturner
Subscribers: tberghammer, lldb-commits, danalbert
Differential Revision: http://reviews.llvm.org/D1
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247857: Fix Makefile for Windows to Android tests. (authored
by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D12909?vs=34905&id=34929#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
Author: chaoren
Date: Wed Sep 16 18:36:41 2015
New Revision: 247863
URL: http://llvm.org/viewvc/llvm-project?rev=247863&view=rev
Log:
XFAIL TestCppNsImport for gcc-4.9 inclusive.
Modified:
lldb/trunk/test/lang/cpp/nsimport/TestCppNsImport.py
Modified: lldb/trunk/test/lang/cpp/nsimport/TestCp
chaoren added a subscriber: chaoren.
chaoren added a comment.
Could you please take a look at these issues?
TestMiSymbol started to fail on Linux with gcc-4.9:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/6387
Comment at: lldb/trunk/tools/lldb-mi/MIUt
Author: chaoren
Date: Thu Sep 17 13:38:55 2015
New Revision: 247914
URL: http://llvm.org/viewvc/llvm-project?rev=247914&view=rev
Log:
Fix TestMiSymbol for gcc-4.9 test.
Modified:
lldb/trunk/test/tools/lldb-mi/symbol/TestMiSymbol.py
Modified: lldb/trunk/test/tools/lldb-mi/symbol/TestMiSymbol.
chaoren created this revision.
chaoren added a reviewer: labath.
chaoren added a subscriber: lldb-commits.
http://reviews.llvm.org/D12976
Files:
test/functionalities/process_group/TestChangeProcessGroup.py
Index: test/functionalities/process_group/TestChangeProcessGroup.py
chaoren updated this revision to Diff 35113.
chaoren added a comment.
Remove old line.
http://reviews.llvm.org/D12976
Files:
test/functionalities/process_group/TestChangeProcessGroup.py
Index: test/functionalities/process_group/TestChangeProcessGroup.py
==
chaoren added a comment.
I thought this was supposed to be fixed, but TestChangeProcessGroup,
TestExpressionInSyscall, and TestRegisters just started failing for me recently
because of this.
http://reviews.llvm.org/D12976
___
lldb-commits mailing
Author: chaoren
Date: Fri Sep 18 19:57:11 2015
New Revision: 248075
URL: http://llvm.org/viewvc/llvm-project?rev=248075&view=rev
Log:
Fix Linux bot.
Modified:
lldb/trunk/test/dosep.py
Modified: lldb/trunk/test/dosep.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/test/dosep.py?rev=24
chaoren added a comment.
Do we still need the original stepInstruction?
http://reviews.llvm.org/D12976
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chaoren updated this revision to Diff 35304.
chaoren added a comment.
Remove existing workaround.
http://reviews.llvm.org/D12976
Files:
test/functionalities/process_group/TestChangeProcessGroup.py
Index: test/functionalities/process_group/TestChangeProcessGroup.py
===
Author: chaoren
Date: Tue Sep 22 12:37:34 2015
New Revision: 248301
URL: http://llvm.org/viewvc/llvm-project?rev=248301&view=rev
Log:
Update TestChangeProcessGroup to remove obsolete workaround.
Expression evaluation in syscalls should work now.
Reviewers: labath
Subscribers: lldb-commits
Diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248301: Update TestChangeProcessGroup to remove obsolete
workaround. (authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D12976?vs=35304&id=35391#toc
Repository:
rL LLVM
http://r
101 - 167 of 167 matches
Mail list logo
