[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

werat added a comment. @jingham @teemperor ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98370/new/ https://reviews.llvm.org/D98370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

werat added a comment. In D98370#2686515 , @jingham wrote: > If persisting already persistent variables is indeed the only failure case, > then I wonder if it wouldn't be more straightforward to just see if the > ValueObject is already a persistent varia

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

werat added a comment. In D98370#2705741 , @jingham wrote: > Sure. But but when I was poking around at it a little bit, it seems like the > other use cases already work, and the only one that was failing was the case > where you call persist on a persis

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

werat added a comment. In D98370#2709828 , @jingham wrote: > Be careful here. There are really two kinds of persistent variables: > "expression results" and variables created in the expression parser. The > former are by design constant. The idea is t

[Lldb-commits] [PATCH] D102685: [lldb] Encode `bool` as unsigned int

werat created this revision. werat added a reviewer: teemperor. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `bool` is considered to be unsigned according to `std::is_unsigned::value` (and `Type::GetTypeInfo`). Encoding it as sig

[Lldb-commits] [PATCH] D102685: [lldb] Encode `bool` as unsigned int

werat updated this revision to Diff 346161. werat added a comment. Keep @skipIfWindows for now Add mroe checks in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102685/new/ https://reviews.llvm.org/D102685 Files: lldb/source/Plugins/TypeSys

[Lldb-commits] [PATCH] D102685: [lldb] Encode `bool` as unsigned int

werat marked 2 inline comments as done. werat added a comment. Thanks for a quick review! Comment at: lldb/test/API/lang/cpp/bitfields/TestCppBitfields.py:21 -# (http://llvm.org/pr21800) -@skipIfWindows def test_and_run_command(self): teemperor wro

[Lldb-commits] [PATCH] D102685: [lldb] Encode `bool` as unsigned int

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. werat marked an inline comment as done. Closed by commit rG0bab7b26f4d9: [lldb] Encode `bool` as unsigned int (authored by werat). Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D102769: [lldb] Enable TestCppBitfields on Windows

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The tests works correctly on Windows, the linked bug has been resolved. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102769 Files: l

[Lldb-commits] [PATCH] D102769: [lldb] Enable TestCppBitfields on Windows

werat updated this revision to Diff 346438. werat added a comment. remove the @skip Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102769/new/ https://reviews.llvm.org/D102769 Files: lldb/test/API/lang/cpp/bitfields/TestCppBitfields.py Index: l

[Lldb-commits] [PATCH] D102769: [lldb] Enable TestCppBitfields on Windows

werat added a comment. Accidentally included only two out of three lines in the commit :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102769/new/ https://reviews.llvm.org/D102769 ___ lldb-commits maili

[Lldb-commits] [PATCH] D102769: [lldb] Enable TestCppBitfields on Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c83d4a60b7d: [lldb] Enable TestCppBitfields on Windows (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D88247: Fix memory leak in SBValue::GetAddress

werat created this revision. werat added a reviewer: labath. werat added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a reviewer: JDevlieghere. werat requested review of this revision. SBAddress constructor accepts a pointer to `lldb_private::Address`, but th

[Lldb-commits] [PATCH] D88247: Fix memory leak in SBValue::GetAddress

werat added a comment. Thanks for reviewing and writing a follow-up change! Changing the ctor to accept a const reference is indeed a cleaner solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88247/new/ https://reviews.llvm.org/D88247 _

[Lldb-commits] [PATCH] D88249: [lldb] Make protected ctor and method of SBAddress take a const reference instead of a pointer.

werat accepted this revision. werat added a comment. This revision is now accepted and ready to land. Thanks for refactoring this! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88249/new/ https://reviews.llvm.org/D88249

[Lldb-commits] [PATCH] D90151: Fix SBError::SetErrorToGenericError

werat created this revision. werat added a reviewer: JDevlieghere. werat added a project: LLDB. Herald added a subscriber: lldb-commits. werat requested review of this revision. `SBError::SetErrorToGenericError` should call `Status::SetErrorToGenericError`, not `Status::SetErrorToErrno`. Reposi

[Lldb-commits] [PATCH] D90151: Fix SBError::SetErrorToGenericError

werat updated this revision to Diff 300652. werat added a comment. Add a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90151/new/ https://reviews.llvm.org/D90151 Files: lldb/source/API/SBError.cpp lldb/test/API/python_api/sberror/TestSBError.py Index: lldb/test/API/pyt

[Lldb-commits] [PATCH] D90151: Fix SBError::SetErrorToGenericError

werat added a comment. Thanks! Yeah, I don't have commit access, thanks for landing it for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90151/new/ https://reviews.llvm.org/D90151 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D90318: Return actual type from SBType::GetArrayElementType

werat created this revision. werat added reviewers: teemperor, jarin. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. werat requested review of this revision. `SBType::GetArrayElementType` should return the actual type, not the canonica

[Lldb-commits] [PATCH] D90318: Return actual type from SBType::GetArrayElementType

werat added a comment. Btw, I don't have commit access, so would be great if someone could land this for me :) (if everything is OK with this patch). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90318/new/ https://reviews.llvm.org/D90318 ___

[Lldb-commits] [PATCH] D90318: Return actual type from SBType::GetArrayElementType

werat added a comment. Ping :) @teemperor @JDevlieghere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90318/new/ https://reviews.llvm.org/D90318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat created this revision. Herald added subscribers: lldb-commits, arphaman. Herald added a project: LLDB. werat requested review of this revision. Herald added a subscriber: JDevlieghere. Static const/constexpr members might have only DW_TAG_member entry with a DW_AT_const_value attribute. Sinc

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat added reviewers: jarin, aprantl, shafik. werat added a comment. Hi, please, take a look at this patch. It seems Pavel already did some work for class-level static const variables in https://reviews.llvm.org/D86615, although that didn't work the case I've encountered. In my example (which

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat updated this revision to Diff 308052. werat added a comment. Simplified test according to teemperor's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92223/new/ https://reviews.llvm.org/D92223 Files: lldb/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat updated this revision to Diff 308053. werat added a comment. Remove unused field Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92223/new/ https://reviews.llvm.org/D92223 Files: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp ll

[Lldb-commits] [PATCH] D88247: Fix memory leak in SBValue::GetAddress

werat abandoned this revision. werat added a comment. Herald added a subscriber: pengfei. Refactored in D88249 to avoid this problem altogether. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88247/new/ https://rev

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat added a comment. Pavel, thanks for review! In D92223#2422184 , @labath wrote: > I am not sure if this is the right way to implement this feature. Changing > ManualDWARFIndex to provide this additional information is easy enough, but > it means tha

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat created this revision. werat requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Static const members initialized inside a class definition might not have a corresponding DW_TAG_variable, so t

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat edited reviewers, added: labath, jarin, teemperor, jankratochvil; removed: jdoerfert. werat added a subscriber: labath. werat added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: JDevlieghere. Hi, please, take a look at this patch! This is an approach suggested b

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat added a comment. In D92643#2433428 , @labath wrote: > Are the static members included in the (SB)Type object that gets created when > parsing the enclosing type? If yes, we might be able to retrieve them that > way. Whether that would be cleaner --

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat added a comment. In D92643#2434050 , @jingham wrote: > I couldn't tell what you meant by this... I would expect that a Type would > tell you that static members exist, and their type, etc. But I wouldn't > expect a Type to be able to get a value

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat added a comment. @labath @teemperor gentle ping :) What do you think about this approach? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92643/new/ https://reviews.llvm.org/D92643 ___ lldb-commits m

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat added a comment. Thanks for your review! If there are no objections to this patch, can you accept and land it for me? :) In D92643#2445146 , @labath wrote: > On a higher level, I am also worried about what this (the fact that we have > to do this

[Lldb-commits] [PATCH] D93690: Add SBType::IsScopedEnumerationType method

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a method to check if the type is a scoped enumeration (i.e. "enum class/struct"). Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D936

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a method for getting the enumeration underlying type. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93696 Files: lldb/bindings/in

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

werat added reviewers: teemperor, JDevlieghere. werat added a subscriber: jarin. werat added inline comments. Comment at: lldb/test/API/python_api/type/TestTypeList.py:156 +self.DebugSBType(int_enum_type) +self.assertEquals(int_enum_type.GetName(), 'unsigned int')

[Lldb-commits] [PATCH] D93690: Add SBType::IsScopedEnumerationType method

werat updated this revision to Diff 313378. werat added a comment. Register the new method using lldb-instr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93690/new/ https://reviews.llvm.org/D93690 Files: lldb/bindings/interface/SBType.i lldb/

[Lldb-commits] [PATCH] D93690: Add SBType::IsScopedEnumerationType method

werat marked an inline comment as done. werat added inline comments. Comment at: lldb/source/API/SBType.cpp:275 +bool SBType::IsScopedEnumerationType() { + LLDB_RECORD_METHOD_NO_ARGS(bool, SBType, IsScopedEnumerationType); + JDevlieghere wrote: > Same comment as

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

werat updated this revision to Diff 313379. werat added a comment. Register the new method using lldb-instr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93696/new/ https://reviews.llvm.org/D93696 Files: lldb/bindings/interface/SBType.i lldb/

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

werat updated this revision to Diff 313380. werat marked an inline comment as done. werat added a comment. Remove the test case for unscoped enum, because it's implementation defined and can break any moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

werat added inline comments. Comment at: lldb/source/API/SBType.cpp:348 +SBType SBType::GetEnumerationIntegerType() { + LLDB_RECORD_METHOD_NO_ARGS(lldb::SBType, SBType, GetEnumerationIntegerType); + JDevlieghere wrote: > You also need to register the new method.

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

werat added a comment. Thanks for a quick review! Can you please land these changes for me since I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93696/new/ https://reviews.llvm.org/D93696

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

werat created this revision. Herald added a subscriber: arphaman. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add unscoped enumeration members to the "globals" manual dwarf index. This effectively makes them discoverable as global

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

werat updated this revision to Diff 314558. werat added a comment. Herald added a subscriber: JDevlieghere. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94077/new/ https://reviews.llvm.org/D94077 Files: lldb/source/Plugins/Expres

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat added a comment. @labath @jankratochvil ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92643/new/ https://reviews.llvm.org/D92643 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

werat updated this revision to Diff 315319. werat added a comment. Herald added a reviewer: shafik. Handle enum constants similar to global variables, support scoped lookup in the expression evaluator. Add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

werat added a comment. In D94077#2479984 , @shafik wrote: > We can have unscoped enums in namespace and class scope and the enumerators > won't leak out from those scopes. Thus we can have shadowing going on e.g.: > > ... > > How does this change deal wit

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

werat added a comment. In D94077#2481942 , @labath wrote: > This suffers from the same problem as the other patch, where the other index > classes (apple_names and debug_names) will essentially never be able to > implement this feature. (Unless they re-i

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

werat updated this revision to Diff 315343. werat added a comment. Generate fully qualified names for enum constants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94077/new/ https://reviews.llvm.org/D94077 Files: lldb/source/Plugins/ExpressionP

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

werat added a comment. Thanks for the explanation, this makes sense. I've checked the mailing list archives and it seems there was already a discussion about the enumerators in the `.debug_names` index back in 2018 -- http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2018-April/004

[Lldb-commits] [PATCH] D95761: [lldb] Use current execution context in SBDebugger

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use `GetSelectedExecutionContext()` instead of `GetCommandInterpreter().GetExecutionContext()` in `SBDebugger::GetInternalVariableValue/SBDebugger::SetInte

[Lldb-commits] [PATCH] D95761: [lldb] Use current execution context in SBDebugger

werat added a comment. Thanks for the review! Can you submit it for me, since I don't have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95761/new/ https://reviews.llvm.org/D95761 ___ lld

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

werat added a comment. In D92164#2534626 , @tatyana-krasnukha wrote: > Removed test since the same case was added by D95761 > . I think your test case is even better, the one in D95761

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat added a comment. In D92223#2546736 , @jankratochvil wrote: > This patch may be superseded by D92643 , not > sure. Yeah, D92643 is an alternative way to implement this, according t

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat added a comment. Thanks for reviewing! In D92643#2546732 , @jankratochvil wrote: > @werat I see you are aware of D81471 . Do > you or someone else have anything against it? I find it more integrated using > the cl

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat updated this revision to Diff 322309. werat added a comment. Change DW_AT_decl_file handling as per @jankratochvil comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92643/new/ https://reviews.llvm.org/D92643 Files: lldb/source/Plugins

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3162 +case DW_AT_decl_file: + decl.SetFile(sc.comp_unit->GetSupportFiles().GetFileSpecAtIndex( + form_value.Unsigned())); jankratochvil wrote: > He

[Lldb-commits] [PATCH] D80995: [Scalar] Fix assignment operator for long long.

werat created this revision. werat added a reviewer: labath. werat added a project: LLDB. werat added a reviewer: teemperor. Assignment operator `operator=(long long)` currently allocates `sizeof(long)`. On some platforms it works as they have `sizeof(long) == sizeof(long long)`, but on others (

[Lldb-commits] [PATCH] D80995: [Scalar] Fix assignment operator for long long.

werat added a comment. In D80995#2068571 , @labath wrote: > Looks good. Given the timings, I am going to assume you are coordinating with > @miko. Thanks! This is very surprising, but we're not coordinating. I've found out about their patch just now. A

<    1   2