werat added inline comments.
================
Comment at: lldb/source/API/SBType.cpp:348
+SBType SBType::GetEnumerationIntegerType() {
+ LLDB_RECORD_METHOD_NO_ARGS(lldb::SBType, SBType, GetEnumerationIntegerType);
+
----------------
JDevlieghere wrote:
> You also need to register the new method. You can add the instrumentation
> automatically with the lldb-instr tool if you remove this line (and the
> `LLDB_RECORD_RESULT` or the return value will get wrapped again).
Thanks, done!
================
Comment at: lldb/test/API/python_api/type/TestTypeList.py:156
+ self.DebugSBType(int_enum_type)
+ self.assertEquals(int_enum_type.GetName(), 'unsigned int')
+
----------------
JDevlieghere wrote:
> werat wrote:
> > Afaik this is implementation defined, so maybe this we shouldn't test this.
> Yeah, I would either remove it or add a comment saying that it's
> implementation defined in case someone (downstream) runs into this.
I've removed the test case to avoid potential confusion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93696/new/
https://reviews.llvm.org/D93696
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
