apolyakov added a comment.
Do you mean `ConnectToRemote` method from
`lldb/tools/lldb-server/lldb-gdbserver.cpp`?
https://reviews.llvm.org/D52139
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
apolyakov added a comment.
AFAIR, adding an `exit(...)` to `ConnectToRemote` won't solve this problem. The
test will still be failing on Arch.
https://reviews.llvm.org/D52139
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
apolyakov added a comment.
If so, we can try to run the script with python2.x. @teemperor can you try to
modify `target-select-so-path.test` this way:
change `# RUN: python %p/inputs/target-select-so-path.py "%debugserver"
"%lldbmi %t" %s` to
`# RUN: python2 %p/inputs/target-select-so-path.py "
apolyakov updated this revision to Diff 166714.
apolyakov added a comment.
Reduced timer from 120 to 30 seconds.
https://reviews.llvm.org/D52139
Files:
lit/tools/lldb-mi/target/inputs/target-select-so-path.py
Index: lit/tools/lldb-mi/target/inputs/target-select-so-path.py
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342915: [lldb-mi] Fix hanging of target-select-so-path.test
(authored by apolyakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52139?vs=1
apolyakov created this revision.
apolyakov added reviewers: teemperor, labath, tatyana-krasnukha, aprantl.
Herald added a subscriber: ki.stfu.
This patch fixes hanging of the test in case of using python3, changes callback
function that will be called if the timer ends;
Also, the test didn't work
apolyakov added a comment.
Thanks Pavel, I fixed it here https://reviews.llvm.org/D52498.
Repository:
rL LLVM
https://reviews.llvm.org/D52139
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
apolyakov updated this revision to Diff 166919.
apolyakov added a comment.
Removed the shebang line since we call the script via `python ...` so that line
doesn't matter.
https://reviews.llvm.org/D52498
Files:
lit/tools/lldb-mi/target/inputs/target-select-so-path.py
Index: lit/tools/lldb-m
apolyakov updated this revision to Diff 166936.
apolyakov added a comment.
Changed python version required to use 'pass_fds' argument to 3.2.
I tested this patch with python 2.7 and 3.5.
https://reviews.llvm.org/D52498
Files:
lit/tools/lldb-mi/target/inputs/target-select-so-path.py
Index: l
apolyakov updated this revision to Diff 166953.
apolyakov edited the summary of this revision.
apolyakov added a comment.
Changed the test to use `%python` variable instead of `python`
https://reviews.llvm.org/D52498
Files:
lit/tools/lldb-mi/target/inputs/target-select-so-path.py
lit/tools/
apolyakov marked an inline comment as done.
apolyakov added inline comments.
Comment at: lit/tools/lldb-mi/target/target-select-so-path.test:4
+# RUN: %cc -o %t %p/inputs/main.c -g
+# RUN: python %p/inputs/target-select-so-path.py "%debugserver" "%lldbmi %t" %s
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB343033: [lldb-mi] Fix bugs in target-select-so-path.test
(authored by apolyakov, committed by ).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52498
Files:
lit/tools/lldb-mi/target/inputs/targ
apolyakov added a comment.
I think that it's worth it to rewrite the test with LIT and FileCheck because
the python approach has some limitations, e.g. timeouts. You can find examples
in `lldb/lit/tools/lldb-mi/`.
Comment at: tools/lldb-mi/MICmdCmdGdbShow.cpp:369
+const C
apolyakov added inline comments.
Comment at: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test:4
+#
+# RUN: %cc -o b.exe %p/inputs/break-insert-pending.c -g
+# RUN: %lldbmi < %s | FileCheck %s
As far as your first command is `file-exec-and-symbols`, t
apolyakov added a comment.
I ran the test and got a fail:
build/bin/llvm-lit -avv
llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test
-- Testing: 1 tests, 1 threads --
FAIL: lldb :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test (1 of
1)
***
apolyakov added a comment.
I only have these options:
build/bin/llvm-lit -avv --dump-input-on-failure
llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test
usage: llvm-lit [-h] [--version] [-j N] [--config-prefix NAME] [-D NAME=VAL]
[-q] [-s] [-v] [
apolyakov added a comment.
Here it is:
build/bin/llvm-lit -avv
llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test
-- Testing: 1 tests, 1 threads --
FAIL: lldb :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test (1 of
1)
TEST 'lldb
apolyakov accepted this revision.
apolyakov added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D52953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
polyakov.alex added a comment.
So, what do you think about the patch? There is no any decision about lldb-mi
tests and I do not know what to do with this.
Repository:
rL LLVM
https://reviews.llvm.org/D46588
___
lldb-commits mailing list
lldb-com
polyakov.alex updated this revision to Diff 146487.
polyakov.alex added a comment.
Moved tests to lit.
Repository:
rL LLVM
https://reviews.llvm.org/D46588
Files:
lit/Breakpoint/Inputs/break-insert.c
lit/Breakpoint/Inputs/break-insert.input
lit/Breakpoint/break-insert.test
lit/lit.cfg
polyakov.alex updated this revision to Diff 146489.
polyakov.alex added a comment.
Added comments describing which lldb-mi command's output is currently parsing.
Repository:
rL LLVM
https://reviews.llvm.org/D46588
Files:
lit/Breakpoint/Inputs/break-insert.c
lit/Breakpoint/Inputs/break-in
polyakov.alex updated this revision to Diff 146693.
polyakov.alex added a comment.
Added more comments about the test.
Repository:
rL LLVM
https://reviews.llvm.org/D46588
Files:
lit/Breakpoint/Inputs/break-insert.c
lit/Breakpoint/Inputs/break-insert.input
lit/Breakpoint/break-insert.te
polyakov.alex added inline comments.
Comment at: lit/Breakpoint/break-insert.test:5
+# cmd: -break-insert breakpoint
+# CHECK: ^done,bkpt={number="1"
+
aprantl wrote:
> Very nice!
>
> What does the actual output format of lldb-mi look like?
> If every reply is o
polyakov.alex added inline comments.
Comment at: lit/Breakpoint/break-insert.test:5
+# cmd: -break-insert breakpoint
+# CHECK: ^done,bkpt={number="1"
+
polyakov.alex wrote:
> aprantl wrote:
> > Very nice!
> >
> > What does the actual output format of lldb-mi loo
polyakov.alex updated this revision to Diff 146777.
polyakov.alex added a comment.
Created separate directory for an lldb-mi tests.
Repository:
rL LLVM
https://reviews.llvm.org/D46588
Files:
lit/lit.cfg
lit/tools/lldb-mi/breakpoint/break-insert.test
lit/tools/lldb-mi/breakpoint/inputs/
polyakov.alex added a comment.
Also, I combined FileCheck commands and lldb-mi input in a single file.
Repository:
rL LLVM
https://reviews.llvm.org/D46588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
polyakov.alex added inline comments.
Comment at: lit/tools/lldb-mi/breakpoint/break-insert.test:10
+-file-exec-and-symbols a.out
+# CHECK-AFTER: ^done
+
labath wrote:
> I'm not familiar with this directive. Are you sure that this actually does
> anything?
I trie
polyakov.alex added inline comments.
Comment at: lit/tools/lldb-mi/breakpoint/break-insert.test:10
+-file-exec-and-symbols a.out
+# CHECK-AFTER: ^done
+
labath wrote:
> polyakov.alex wrote:
> > labath wrote:
> > > I'm not familiar with this directive. Are you sur
polyakov.alex added inline comments.
Comment at: lit/tools/lldb-mi/breakpoint/break-insert.test:10
+-file-exec-and-symbols a.out
+# CHECK-AFTER: ^done
+
labath wrote:
> polyakov.alex wrote:
> > labath wrote:
> > > polyakov.alex wrote:
> > > > labath wrote:
> > >
polyakov.alex added inline comments.
Comment at: lit/tools/lldb-mi/breakpoint/break-insert.test:14
+# CHECK-AFTER: ^running
+# CHECK-AFTER: *stopped,reason="breakpoint-hit"
+
aprantl wrote:
> CHECK-AFTER is not recognized by FileCheck:
>
> https://www.llvm.org/d
polyakov.alex updated this revision to Diff 147117.
polyakov.alex added a comment.
I have all the patches I was sending. I will follow this topic until you decide
what to do with lldb-mi testing.
Repository:
rL LLVM
https://reviews.llvm.org/D46588
Files:
packages/Python/lldbsuite/test/too
polyakov.alex added a comment.
In https://reviews.llvm.org/D46588#1103180, @aprantl wrote:
> My overall mental image of lldb-mi is very incomplete, but I'm imagining
> lldb-mi as having one thread that wakes up every n milliseconds checks for
> command input and then calls into the SBAPI to han
polyakov.alex added a comment.
In https://reviews.llvm.org/D46588#1103237, @aprantl wrote:
> For the experiment you can probably just stick it into
> `CMICmnLLDBDebugger::InitSBDebugger()`.
Yep, after that, test is passing with only `CHECK` directives.
Repository:
rL LLVM
https://reviews.
polyakov.alex created this revision.
polyakov.alex added reviewers: aprantl, clayborg, labath.
Herald added subscribers: llvm-commits, ki.stfu.
Option --synchronous disables asynchronous mode in the lldb-mi driver. Used for
testing only.
Repository:
rL LLVM
https://reviews.llvm.org/D47110
F
polyakov.alex added a comment.
This option is needed by https://reviews.llvm.org/D46588.
Repository:
rL LLVM
https://reviews.llvm.org/D47110
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
polyakov.alex updated this revision to Diff 147681.
polyakov.alex added a comment.
This version of commit uses the new lldb-mi option that I added to review
https://reviews.llvm.org/D47110.
Repository:
rL LLVM
https://reviews.llvm.org/D46588
Files:
lit/lit.cfg
lit/tools/lldb-mi/breakpoi
polyakov.alex updated this revision to Diff 147806.
polyakov.alex added a comment.
Moved the option parsing code down by the others.
Repository:
rL LLVM
https://reviews.llvm.org/D47110
Files:
tools/lldb-mi/MICmnResources.cpp
tools/lldb-mi/MICmnResources.h
tools/lldb-mi/MIDriver.cpp
t
polyakov.alex created this revision.
polyakov.alex added a reviewer: aprantl.
Herald added a subscriber: llvm-commits.
The new method adds to the current target a path to search for a shared objects.
Repository:
rL LLVM
https://reviews.llvm.org/D47302
Files:
include/lldb/API/SBDebugger.h
polyakov.alex added a comment.
In https://reviews.llvm.org/D47302#1110441, @aprantl wrote:
> The missing context here is that the lldb-mi -target-select command currently
> calls `HandleCommand("target modules search-paths add", ...)`.
> Is adding a new SBAPI the right approach to implementing
polyakov.alex added inline comments.
Comment at: lit/lit.cfg:61
+lldb_mi = lit.util.which('lldb-mi', lldb_tools_dir)
+
aprantl wrote:
> aprantl wrote:
> > It looks like "lldb-mi" may not be a valid substitution. On Darwin the
> > command
> >
> > `# RUN: %lldb
polyakov.alex updated this revision to Diff 148323.
polyakov.alex added a comment.
Removed underscore in the lldb-mi variable from lit.cfg.
Repository:
rL LLVM
https://reviews.llvm.org/D46588
Files:
lit/lit.cfg
lit/tools/lldb-mi/breakpoint/break-insert.test
lit/tools/lldb-mi/breakpoint
polyakov.alex added a comment.
In https://reviews.llvm.org/D47302#078, @clayborg wrote:
> It might make sense to create a new SBTargetSettings class that has
> accessors. Then we can have to accessors on SBTarget:
>
> class SBTarget {
> static SBTargetSettings GetGlobalSettings();
>
polyakov.alex added a comment.
In https://reviews.llvm.org/D47302#351, @clayborg wrote:
> In https://reviews.llvm.org/D47302#249, @polyakov.alex wrote:
>
> > In https://reviews.llvm.org/D47302#078, @clayborg wrote:
> >
> > > It might make sense to create a new SBTargetSettings class t
polyakov.alex added a comment.
In https://reviews.llvm.org/D47302#377, @clayborg wrote:
> In https://reviews.llvm.org/D47302#372, @polyakov.alex wrote:
>
> > In https://reviews.llvm.org/D47302#351, @clayborg wrote:
> >
> > > In https://reviews.llvm.org/D47302#249, @polyakov.alex w
polyakov.alex added a comment.
In https://reviews.llvm.org/D47302#497, @clayborg wrote:
> no. Create a new SBTargetSettings class. SBTarget will hand one out for
> global and for target instance settings, Add all settings accessors to
> SBTargetSettings class
What is a difference between
polyakov.alex added a comment.
In https://reviews.llvm.org/D47302#637, @clayborg wrote:
> In https://reviews.llvm.org/D47302#569, @polyakov.alex wrote:
>
> > In https://reviews.llvm.org/D47302#497, @clayborg wrote:
> >
> > > no. Create a new SBTargetSettings class. SBTarget will hand
polyakov.alex created this revision.
polyakov.alex added reviewers: aprantl, clayborg.
Herald added subscribers: llvm-commits, ki.stfu.
Now -exec-continue command uses SB API t resume target's process.
Repository:
rL LLVM
https://reviews.llvm.org/D47415
Files:
lit/tools/lldb-mi/exec/exec-c
polyakov.alex created this revision.
polyakov.alex added reviewers: aprantl, stella.stamenova.
Herald added subscribers: llvm-commits, ki.stfu.
-exec-run command hanged in case of invalid or dummy target.
Repository:
rL LLVM
https://reviews.llvm.org/D47678
Files:
tools/lldb-mi/MICmdCmdExec
polyakov.alex added a comment.
These changes fix the hanging of the lldb-mi lit tests. For example:
`-file-exec-and-symbols a.out` command in test may cause a hanging if `a.out`
is invalid name of binary.
Repository:
rL LLVM
https://reviews.llvm.org/D47678
___
polyakov.alex updated this revision to Diff 149619.
polyakov.alex added a comment.
A bit of refactoring.
Repository:
rL LLVM
https://reviews.llvm.org/D47678
Files:
tools/lldb-mi/MICmdCmdExec.cpp
Index: tools/lldb-mi/MICmdCmdExec.cpp
===
polyakov.alex created this revision.
polyakov.alex added reviewers: aprantl, stella.stamenova.
Herald added subscribers: llvm-commits, ki.stfu.
The default name for a compiler output on Linux is `a.out`, while on Windows
it's `a.exe`. But if we add option `-o a.exe`, the compiler will create the
polyakov.alex added a comment.
I would really appreciate if you guys can check this test on Windows again.
Repository:
rL LLVM
https://reviews.llvm.org/D47679
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
polyakov.alex added a comment.
You are right. I think that the reason of exiting *normally is much deeper.
I'll look at this, but for now I don't have any ideas about what it may cause,
do you have one?
Repository:
rL LLVM
https://reviews.llvm.org/D47679
_
polyakov.alex updated this revision to Diff 149626.
polyakov.alex added a comment.
Added the test.
https://reviews.llvm.org/D47678
Files:
lit/tools/lldb-mi/exec/exec-run-wrong-binary.test
lit/tools/lldb-mi/exec/lit.local.cfg
tools/lldb-mi/MICmdCmdExec.cpp
Index: tools/lldb-mi/MICmdCmdEx
polyakov.alex updated this revision to Diff 149629.
polyakov.alex added a comment.
Due to https://reviews.llvm.org/D47678 we can enable this test with a XFAIL
directive for Windows.
https://reviews.llvm.org/D47679
Files:
lit/tools/lldb-mi/breakpoint/break-insert.test
Index: lit/tools/lldb-
polyakov.alex added a comment.
In https://reviews.llvm.org/D47679#1120039, @stella.stamenova wrote:
> You can actually follow the pattern in the other tests and do:
>
> %cc -o %t %p/inputs/break-insert.c -g
>
> %t then becomes the name of the output file and you can use that in our other
> com
polyakov.alex added a comment.
In https://reviews.llvm.org/D47679#1120172, @stella.stamenova wrote:
> In https://reviews.llvm.org/D47679#1120081, @polyakov.alex wrote:
>
> > Due to https://reviews.llvm.org/D47678 we can enable this test with a XFAIL
> > directive for Windows.
>
>
> Not true. As
polyakov.alex added a comment.
Thank you.
https://reviews.llvm.org/D47679
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
polyakov.alex added a comment.
Do you know another way of implementing AppendImageSearchPaths method?
Repository:
rL LLVM
https://reviews.llvm.org/D47302
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
polyakov.alex created this revision.
polyakov.alex added reviewers: aprantl, clayborg.
Herald added a subscriber: ki.stfu.
Now -exec-next command uses SB API for stepping over.
https://reviews.llvm.org/D47797
Files:
lit/tools/lldb-mi/exec/exec-next.test
lit/tools/lldb-mi/exec/inputs/main.c
polyakov.alex updated this revision to Diff 150137.
polyakov.alex added a reviewer: labath.
polyakov.alex added a comment.
Added some checks for invalid thread id.
https://reviews.llvm.org/D47797
Files:
lit/tools/lldb-mi/exec/exec-next.test
lit/tools/lldb-mi/exec/inputs/main.c
tools/lldb-
polyakov.alex added inline comments.
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:384
+ if (nThreadId != UINT64_MAX) {
+lldb::SBThread sbThread =
rSessionInfo.GetProcess().GetThreadByID(nThreadId);
+if (sbThread.IsValid())
We can't test this branch until
polyakov.alex created this revision.
polyakov.alex added reviewers: aprantl, clayborg, labath, stella.stamenova.
Herald added a subscriber: ki.stfu.
Now -exec-step uses SB API instead of HandleCommand hack.
https://reviews.llvm.org/D47838
Files:
lit/tools/lldb-mi/exec/exec-step.test
tools/l
polyakov.alex added a comment.
I'm a little bit confused about situation with thread id before my changes. For
example:
(gdb)
thread list
~"Process 31642 stopped\n* thread #1: tid = 31642, 0x0041eed0
bash`main, name = 'bash', stop reason = breakpoint 1.1\n"
^done
What we should
polyakov.alex added a comment.
In https://reviews.llvm.org/D47838#1124730, @labath wrote:
> I don't know if there is any spec about what the gdb-mi protocol should use
> for thread identification, but I think the most important part is to be
> consistent. If you use indexes in one place and tid
polyakov.alex updated this revision to Diff 150328.
polyakov.alex added a comment.
Changes for using thread ids in a gdb way. Also added case of specified thread
into test case.
https://reviews.llvm.org/D47797
Files:
lit/tools/lldb-mi/exec/exec-next.test
lit/tools/lldb-mi/exec/inputs/main.
polyakov.alex updated this revision to Diff 150332.
polyakov.alex added a comment.
Changes for using thread ids in a gdb way. Also added case of specified thread
into test case.
https://reviews.llvm.org/D47838
Files:
lit/tools/lldb-mi/exec/exec-step.test
tools/lldb-mi/MICmdCmdExec.cpp
In
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334215: [lldb-mi] Re-implement MI -exec-next command.
(authored by apolyakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47797?vs=150328&
polyakov.alex updated this revision to Diff 150391.
polyakov.alex added a comment.
Updated because of commited -exec-next and -exec-step commands.
https://reviews.llvm.org/D47415
Files:
lit/tools/lldb-mi/exec/exec-continue.test
tools/lldb-mi/MICmdCmdExec.cpp
Index: tools/lldb-mi/MICmdCmdE
polyakov.alex added inline comments.
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:248
}
- } else {
-// ToDo: Re-evaluate if this is required when application near finished as
-// this is parsing LLDB error message
-// which seems a hack and is code brittle
-co
polyakov.alex added inline comments.
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:248
}
- } else {
-// ToDo: Re-evaluate if this is required when application near finished as
-// this is parsing LLDB error message
-// which seems a hack and is code brittle
-co
apolyakov created this revision.
apolyakov added reviewers: aprantl, clayborg.
Herald added a subscriber: ki.stfu.
https://reviews.llvm.org/D47914
Files:
tools/lldb-mi/MICmdBase.cpp
tools/lldb-mi/MICmdBase.h
Index: tools/lldb-mi/MICmdBase.h
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334245: [lldb-mi] Add overloaded method for setting an
error. (authored by apolyakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47914?vs
apolyakov added inline comments.
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:248
}
- } else {
-// ToDo: Re-evaluate if this is required when application near finished as
-// this is parsing LLDB error message
-// which seems a hack and is code brittle
-const
polyakov.alex updated this revision to Diff 150486.
polyakov.alex added a reviewer: labath.
polyakov.alex added a comment.
Removed unnecessary m_lldbResult attribute.
https://reviews.llvm.org/D47415
Files:
lit/tools/lldb-mi/exec/exec-continue.test
tools/lldb-mi/MICmdCmdExec.cpp
tools/lldb
apolyakov added a comment.
No, it's not used in a subsequent commit. Moreover, I think that we should
revert this commit sometimes in a future, since it doesn't provide additional
useful functionality.
Repository:
rL LLVM
https://reviews.llvm.org/D47914
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334350: [lldb, lldb-mi] Re-implement MI -exec-continue
command. (authored by apolyakov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47415?vs=150486&id=150629#toc
Repository:
rL
polyakov.alex updated this revision to Diff 150632.
polyakov.alex added a comment.
Removed unnecessary m_lldbResult attribute, updated python test to successfully
process new error messages in exec-step command.
https://reviews.llvm.org/D47838
Files:
lit/tools/lldb-mi/exec/exec-step.test
p
apolyakov created this revision.
apolyakov added reviewers: aprantl, clayborg, labath.
The new method will allow to get error messages from StepOver function.
https://reviews.llvm.org/D47991
Files:
include/lldb/API/SBThread.h
source/API/SBThread.cpp
Index: source/API/SBThread.cpp
apolyakov added a comment.
Also, I suggest to make similar things in other SBThread methods like StepOut
etc.
https://reviews.llvm.org/D47991
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
apolyakov created this revision.
apolyakov added reviewers: aprantl, clayborg, labath.
Herald added a subscriber: ki.stfu.
https://reviews.llvm.org/D47992
Files:
tools/lldb-mi/MICmdCmdExec.cpp
tools/lldb-mi/MICmdCmdExec.h
Index: tools/lldb-mi/MICmdCmdExec.h
=
apolyakov added a comment.
This patch uses changes from https://reviews.llvm.org/D47991. Is allows to:
(gdb)
-file-exec-and-symbols "bash"
^done
(gdb)
=library-loaded,id="/bin/bash",target-name="/bin/bash",host-name="/bin/bash",symbols-loaded="0",loaded_addr="-",size="0"
-exec-next
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334364: [lldb-mi] Re-implement MI -exec-step command.
(authored by apolyakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47838?vs=150632&
polyakov.alex added inline comments.
Comment at: lldb/trunk/tools/lldb-mi/MICmdCmdExec.cpp:524
bool CMICmdCmdExecStep::Acknowledge() {
- if (m_lldbResult.GetErrorSize() > 0) {
-const char *pLldbErr = m_lldbResult.GetError();
-MIunused(pLldbErr);
-const CMICmnMIValue
apolyakov added inline comments.
Comment at: include/lldb/API/SBThread.h:96
+ void StepOver(SBError &error,
+lldb::RunMode stop_other_threads = lldb::eOnlyDuringStepping);
aprantl wrote:
> Where is the SBAPI documentation that is displayed on h
apolyakov added a comment.
I found it out. Info about each method is located in header file. For example,
you may look at `include/lldb/API/SBThread.h` and find text from docs.
https://reviews.llvm.org/D47991
___
lldb-commits mailing list
lldb-comm
apolyakov added a comment.
In https://reviews.llvm.org/D47991#1128477, @labath wrote:
> In https://reviews.llvm.org/D47991#1128433, @aprantl wrote:
>
> > Hmm.. it looks like most C++ API calls don't have any documentation.
> >
> > http://lldb.llvm.org/cpp_reference/html/classlldb_1_1SBThread.html
apolyakov updated this revision to Diff 150814.
apolyakov retitled this revision from "Add method SBThread::StepOver with
SBError parameter." to "Improve SBThread's stepping API using SBError
parameter.".
apolyakov edited the summary of this revision.
apolyakov added a comment.
Documented change
apolyakov added a comment.
In https://reviews.llvm.org/D47991#1128831, @aprantl wrote:
> Have you looked into making the error the first vs the last argument? If the
> majority of all SBAPI calls put the error last, we should do this here, too.
As you could see, SBError is on first place only
apolyakov added a comment.
By the way, we can do something like:
void StepOver() {
StepOver(lldb:eOnlyDuringStepping);
}
void StepOver(lldb::RunMode stop_other_threads) {
SBError error;
StepOver(stop_other_threads, error);
}
and so on.
https://reviews.llvm.org/D47991
apolyakov updated this revision to Diff 150913.
apolyakov added a comment.
Some readability improvements(more comments). I think that we should keep
`StepOver` signature as
void StepOver(SBError &error, lldb::RunMode stop_other_threads);
since it seems that in SBThread methods SBError paramat
apolyakov updated this revision to Diff 150983.
apolyakov added a comment.
Added early exits.
https://reviews.llvm.org/D47991
Files:
include/lldb/API/SBThread.h
scripts/interface/SBThread.i
source/API/SBThread.cpp
Index: source/API/SBThread.cpp
===
apolyakov added inline comments.
Comment at: source/API/SBThread.cpp:1136
bool result = false;
if (exe_ctx.HasThreadScope()) {
Process::StopLocker stop_locker;
@aprantl do you think that we should use early exit here? There is printing to
log at the e
apolyakov updated this revision to Diff 150996.
apolyakov added a comment.
Added `StepOver` overload without optional parameters.
https://reviews.llvm.org/D47991
Files:
include/lldb/API/SBThread.h
scripts/interface/SBThread.i
source/API/SBThread.cpp
Index: source/API/SBThread.cpp
===
apolyakov added inline comments.
Comment at: source/API/SBThread.cpp:816
+error.SetErrorString("passed a frame from another thread");
+return;
}
I found this place and added `return`.
https://reviews.llvm.org/D47991
___
apolyakov updated this revision to Diff 151000.
apolyakov added a comment.
Minor update: moved `error.SetErrorString` to the top of `if` statement to
increase readability.
https://reviews.llvm.org/D47991
Files:
include/lldb/API/SBThread.h
scripts/interface/SBThread.i
source/API/SBThread.
apolyakov added a comment.
In https://reviews.llvm.org/D47991#1131043, @clayborg wrote:
> Looks good. Just a question about including the commented out default
> arguments
Don't you think it increases readability of this code?
https://reviews.llvm.org/D47991
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334860: Revert "[lldb-mi] Add overload method for
setting an error" (authored by apolyakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48
apolyakov added a comment.
If you look at `bool CMICmdCmdExecContinue::Execute()`, you'll see that there
are cases in which we need a flexible way to finish MI command(specific action
in error case for example). We have a few options: not to add such an utility
function, add and use it in simpl
polyakov.alex updated this revision to Diff 151682.
polyakov.alex retitled this revision from "[lldb, lldb-mi] Add method
AddCurrentTargetSharedObjectPath to the SBDebugger." to "[WIP] New class
SBTargetSettings to store and manipulate all target's properties.".
polyakov.alex edited the summary o
1 - 100 of 223 matches
Mail list logo
