[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

alexfh added a comment. One more problem related to this patch: it changes the behavior of __PRETTY_FUNCTION__: https://gcc.godbolt.org/z/Mvnj9j74E. There may be dependencies upon the specific format of expansions of this macro: tests, log processing tools, libraries like ctti, and probably oth

[Lldb-commits] [PATCH] D148099: [lldb] Reduce chances of spurious failures in some build setups

alexfh created this revision. alexfh added reviewers: JDevlieghere, rupprecht, brooksmoses. Herald added a project: All. alexfh requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The test may fail when running from a directory that contains th

[Lldb-commits] [PATCH] D148099: [lldb] Reduce chances of spurious failures in some build setups

alexfh updated this revision to Diff 512748. alexfh added a comment. Use full expressions in the CHECK-NOT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148099/new/ https://reviews.llvm.org/D148099 Files: lldb/test/Shell/Commands/command-stop-h

[Lldb-commits] [PATCH] D148099: [lldb] Reduce chances of spurious failures in some build setups

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca7a20df1082: [lldb] Reduce chances of spurious failures in some build setups (authored by alexfh). Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [PATCH] D148099: [lldb] Reduce chances of spurious failures in some build setups

alexfh added a comment. In D148099#4260897 , @DavidSpickett wrote: > Looks good to me. Thanks for the prompt and helpful review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148099/new/ https://reviews.

[Lldb-commits] [PATCH] D114111: Remove a useless temporary of a base class type.

alexfh created this revision. alexfh added a reviewer: clayborg. alexfh requested review of this revision. Herald added a project: LLDB. This was found by clang-tidy bugprone-undelegated-constructor check. Was there since the very first commit back in 2016. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

alexfh added a comment. Hi Matheus, 279fe6281d2ca5b2318c7437316c28750feaac8d causes compilation timeout on some of our internal files. We're trying to get a test case we can share, but so far the only information I can provid

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

alexfh added a comment. In D136565#3913065 , @mizvekov wrote: > In D136565#3911884 , @alexfh wrote: > >> Hi Matheus, 279fe6281d2ca5b2318c7437316c28750feaac8d >>

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

alexfh added a comment. In D136565#3913932 , @mizvekov wrote: > @alexfh Thanks! > > While there is a huge increase in the amount of UsingTypes, it seems the > total amount is still reasonable and does not explain the perf hit. > > Perhaps this is a case

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

alexfh added a comment. And another problem with this patch: there's another pattern (or multiple different patterns?) in the code, that result in around 3x clang memory usage increase after this patch. The result of `-print-stats` doesn't make it clear where the additional allocations come fro

[Lldb-commits] [PATCH] D114111: Remove a useless temporary of a base class type.

alexfh updated this revision to Diff 479873. alexfh added a comment. Herald added a subscriber: Michael137. Herald added a project: All. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114111/new/ https://reviews.llvm.org/D114111 Files:

[Lldb-commits] [PATCH] D114111: Remove a useless temporary of a base class type.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc95922c71797: Remove a useless temporary of a base class type. (authored by alexfh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO