alexfh created this revision. alexfh added reviewers: JDevlieghere, rupprecht, brooksmoses. Herald added a project: All. alexfh requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits.
The test may fail when running from a directory that contains the string used in CHECK-NOT. We observe flakiness rate of around 3/100000. Increasing the length helps reducing the rate of failures. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D148099 Files: lldb/test/Shell/Commands/command-stop-hook-no-target.test Index: lldb/test/Shell/Commands/command-stop-hook-no-target.test =================================================================== --- lldb/test/Shell/Commands/command-stop-hook-no-target.test +++ lldb/test/Shell/Commands/command-stop-hook-no-target.test @@ -1,4 +1,4 @@ # RUN: %clang_host -g %S/Inputs/main.c -o %t -# RUN: %lldb -b -o 'target stop-hook add --name test --shlib test -o "expression 95000 + 126"' -o 'file %t' -o 'b main' -o 'r' 2>&1 | FileCheck %s +# RUN: %lldb -b -o 'target stop-hook add --name test --shlib test -o "expression 473895000 + 126"' -o 'file %t' -o 'b main' -o 'r' 2>&1 | FileCheck %s # CHECK: Stop hook #1 added -# CHECK-NOT: 95126 +# CHECK-NOT: 473895126
Index: lldb/test/Shell/Commands/command-stop-hook-no-target.test =================================================================== --- lldb/test/Shell/Commands/command-stop-hook-no-target.test +++ lldb/test/Shell/Commands/command-stop-hook-no-target.test @@ -1,4 +1,4 @@ # RUN: %clang_host -g %S/Inputs/main.c -o %t -# RUN: %lldb -b -o 'target stop-hook add --name test --shlib test -o "expression 95000 + 126"' -o 'file %t' -o 'b main' -o 'r' 2>&1 | FileCheck %s +# RUN: %lldb -b -o 'target stop-hook add --name test --shlib test -o "expression 473895000 + 126"' -o 'file %t' -o 'b main' -o 'r' 2>&1 | FileCheck %s # CHECK: Stop hook #1 added -# CHECK-NOT: 95126 +# CHECK-NOT: 473895126
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
