@@ -53,10 +54,32 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
public:
LibCXXFrameRecognizer()
- : m_hidden_function_regex(
-R"(^std::__1::(__function.*::operator\(\)|__invoke))"
-R"((\[.*\])?)"// ABI tag.
-R"(( c
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From 19b4370c240cfcf4a57a5c38a64c8ba933d8102c Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/4] [lldb-dap] Add frame recognizers for libc++ `std:
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From 19b4370c240cfcf4a57a5c38a64c8ba933d8102c Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/4] [lldb-dap] Add frame recognizers for libc++ `std:
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From 19b4370c240cfcf4a57a5c38a64c8ba933d8102c Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/4] [lldb-dap] Add frame recognizers for libc++ `std:
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From 19b4370c240cfcf4a57a5c38a64c8ba933d8102c Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/4] [lldb-dap] Add frame recognizers for libc++ `std:
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From 19b4370c240cfcf4a57a5c38a64c8ba933d8102c Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/5] [lldb-dap] Add frame recognizers for libc++ `std:
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/4] [lldb-dap] Add frame recognizers for libc++ `std:
vogelsgesang wrote:
Would be interesting if this is fixed by #105695. How can I run the test cases
against libc++'s unstable ABI locally?
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/3] [lldb-dap] Add frame recognizers for libc++ `std:
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/3] [lldb-dap] Add frame recognizers for libc++ `std:
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/4] [lldb-dap] Add frame recognizers for libc++ `std:
vogelsgesang wrote:
I updated https://github.com/llvm/llvm-project/pull/105695 and locally verified
that it now fixes the test case for libc++ ABI v2
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llv
@@ -53,10 +54,32 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
public:
LibCXXFrameRecognizer()
- : m_hidden_function_regex(
-R"(^std::__1::(__function.*::operator\(\)|__invoke))"
-R"((\[.*\])?)"// ABI tag.
-R"(( c
@@ -196,8 +197,8 @@
AbortWithPayloadFrameRecognizer::RecognizeFrame(lldb::StackFrameSP frame_sp) {
abort_dict_sp->AddStringItem(reason_key, reason_string);
abort_dict_sp->AddIntegerItem(flags_key, flags_val);
- // This will overwrite the abort_with_payload information in
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/5] [lldb-dap] Add frame recognizers for libc++ `std:
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/6] [lldb-dap] Add frame recognizers for libc++ `std:
@@ -305,7 +307,9 @@ def test_frame_recognizer_target_specific(self):
self.expect(
"frame recognizer list",
-substrs=["recognizer.MyFrameRecognizer, module a.out, symbol bar"],
+substrs=[
+"recognizer.MyFrameRecognizer
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/7] [lldb-dap] Add frame recognizers for libc++ `std:
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/105695
>From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Thu, 22 Aug 2024 10:50:13 +
Subject: [PATCH 1/7] [lldb-dap] Add frame recognizers for libc++ `std:
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/106281
None
>From 2fdc99f2e42ac7bc12449e420ff653fb963cee24 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Tue, 27 Aug 2024 20:14:36 +
Subject: [PATCH] [lldb] Fix test expectation in `TestFrameRecogn
vogelsgesang wrote:
fixed in #106281
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/106281
>From b32e85a07ab0e6dc55d28706d50eb84345575bc6 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Tue, 27 Aug 2024 20:14:36 +
Subject: [PATCH] [lldb] Fix test expectation in `TestFrameRecognizer.p
vogelsgesang wrote:
@adrian-prantl It seems I overlooked this test expectation. This hopefully
fixes the build issue in
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/10463/ .
Unfortunately, i was not able to run this test locally, it is marked as
"unsupported" for some r
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/106281
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -160,9 +160,14 @@
"default": "${workspaceRoot}"
},
"env": {
-"type": "array",
-"description": "Additional environment variables to set when
launching the program. This is an array of strings that co
@@ -194,9 +199,14 @@
"description": "Specify a source path to remap \"./\" to allow
full paths to be used when setting breakpoints in binaries that have relative
source paths."
},
"sourceMap": {
-"type": "array",
-
@@ -151,6 +152,26 @@ bool ObjectContainsKey(const llvm::json::Object &obj,
llvm::StringRef key);
/// strings, numbers or booleans.
std::vector GetStrings(const llvm::json::Object *obj,
llvm::StringRef key);
+/// Extract an object of key
@@ -151,6 +152,26 @@ bool ObjectContainsKey(const llvm::json::Object &obj,
llvm::StringRef key);
/// strings, numbers or booleans.
std::vector GetStrings(const llvm::json::Object *obj,
llvm::StringRef key);
+/// Extract an object of key
@@ -151,6 +152,26 @@ bool ObjectContainsKey(const llvm::json::Object &obj,
llvm::StringRef key);
/// strings, numbers or booleans.
std::vector GetStrings(const llvm::json::Object *obj,
llvm::StringRef key);
+/// Extract an object of key
@@ -299,9 +309,14 @@
"description": "Specify a source path to remap \"./\" to allow
full paths to be used when setting breakpoints in binaries that have relative
source paths."
},
"sourceMap": {
-"type": "array",
-
@@ -1831,7 +1831,13 @@ lldb::SBError LaunchProcess(const llvm::json::Object
&request) {
launch_info.SetArguments(MakeArgv(args).data(), true);
// Pass any environment variables along that the user specified.
- auto envs = GetStrings(arguments, "env");
+ auto envMap =
vogelsgesang wrote:
> I am not sure if it possible to use a dict for sourceMaps since a source can
> map to multiple destination see test
Interestingly, CodeLLDB also uses an object, see
https://github.com/vadimcn/codelldb/blob/v1.10.0/MANUAL.md#source-path-remapping.
Probably they just don't
vogelsgesang wrote:
Hi @clayborg,
sorry for the late reply - got knocked out by Covid for a while 😷
> Let me know what you think of my idea to always just show the load address of
> any SBValue. I think that is the best for LLDB, but I am open to opinions.
I did check the other lldb-based de
vogelsgesang wrote:
Hi @jennphilqc,
Great minds think alike - I actually also implemented the `readMemory` request
in #104317.
Thankfully, we didn't literally do the same, duplicated work
* your PR also implements `writeMemory` which my PR is still lacking. Here your
PR is clearly further al
https://github.com/vogelsgesang approved this pull request.
Thanks for fixing this! 🙂
https://github.com/llvm/llvm-project/pull/108227
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
vogelsgesang wrote:
Hi @clayborg,
Are you still planning to review this (as requested by @walter-erquinigo)? Or
are you fine with me landing this change without your review?
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing li
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104317
>From 88b48a5df0153a44276f14872c48e10639dcb673 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 14 Aug 2024 11:52:40 +
Subject: [PATCH 1/9] [lldb-dap] Support inspecting memory
Adds suppor
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104317
>From 88b48a5df0153a44276f14872c48e10639dcb673 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Wed, 14 Aug 2024 11:52:40 +
Subject: [PATCH 01/10] [lldb-dap] Support inspecting memory
Adds supp
vogelsgesang wrote:
@clayborg the code is now up-to-date and ready for another review 🙂
https://github.com/llvm/llvm-project/pull/104317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/108870
This commit changes the libc++ frame recognizer to hide implementation details
of libc++ more aggressively. The applied heuristic is rather straightforward:
We consider every function name starting with `_
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/104317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
@adrian-prantl Now that https://github.com/llvm/llvm-project/pull/105695 is
merged, do you still want to open a follow-up pull request to change the
assert-recognizer and the verbose-trap-recognizer to use `ePreferMangled`?
https://github.com/llvm/llvm-project/pull/105756
_
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/102928
>From 7dfcc909b97efe61e3af8bb9468ddc973f19b52d Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Sat, 10 Aug 2024 23:59:55 +
Subject: [PATCH] [lldb-dap] Implement declaration locations
This comm
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
The above test failure above is in `lld`, not `lldb`. I don't see how this
could have been caused by my change to `lldb-dap`
https://github.com/llvm/llvm-project/pull/102928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104589
>From 72c725469268d0bd39666d20f94404f81a0cb7ad Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Mon, 12 Aug 2024 14:53:31 +
Subject: [PATCH] [lldb-dap] Implement value locations for function poi
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/104589
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104589
>From 79684ccb2b6312b0938de73641e89d7cd29ce1a8 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Mon, 12 Aug 2024 14:53:31 +
Subject: [PATCH] [lldb-dap] Implement value locations for function poi
https://github.com/vogelsgesang ready_for_review
https://github.com/llvm/llvm-project/pull/104589
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
Now that #102928 landed, this commit is also ready for review
https://github.com/llvm/llvm-project/pull/104589
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
> [...] like I said I'm a bit scared of it being too aggressive.
Yes, this is also my main concern here. E.g., for `std::ranges::sort`, it
already turns out to be slightly too aggressive, as discussed in the commit
message and the test case comment. The "`std::ranges::sort`
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/108870
>From 60b26a50218e20431dd645b93d341403ff5b2ee4 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Tue, 27 Aug 2024 17:34:11 +
Subject: [PATCH 1/2] [lldb][libc++] Hide all libc++ implementation det
@@ -78,6 +78,15 @@
"scope": "resource",
"type": "string",
"description": "The log path for lldb-dap (if any)"
+},
+ "lldb-dap.environment": {
vogelsgesang wrote:
Use whitespaces instead of tabs for indentatio
https://github.com/vogelsgesang approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/108948
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/108948
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Vogelsgesang
Date: 2022-08-24T14:40:53-07:00
New Revision: 91389000abe8ef5d06d98cbbefd3fa03ac7e4480
URL:
https://github.com/llvm/llvm-project/commit/91389000abe8ef5d06d98cbbefd3fa03ac7e4480
DIFF:
https://github.com/llvm/llvm-project/commit/91389000abe8ef5d06d98cbbefd3fa03ac7e4480
Thank you for that hint, Jim! This infrastructure indeed looks very
interesting for my use case.
I will most likely use the HistoryThread class to represent the backtrace
of the logical coroutine threads.
Is my understanding correct, that `GetExtendedBacktraceThreads` only allows
me to append addi
Hi Jason,
Sorry for the late reply - your mail got caught in my spam filter, and I
just realized about the build breakage now after you reverted the commits.
Just to confirm:
I looked at the original change again, and I think I know what's going
wrong here: Devirtualization fails, and `promise_ty
Hm... wait a second...
Which clang-version is
https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ using? Is it
using an older version of clang? Does that version already contain the
patch https://reviews.llvm.org/D132580?
If not, that might explain things...
On Fri, Nov 25, 2022 at 11:18
> I don't know what tools are installed on the builder but I'll ask around
the office on Monday, I know there are people who are more familiar with
how these bots are set up.
Sounds good. Thank you!
> FWIW I could repo promise_type failure on my macOS desktop which has the
current Xcode 14 tools
Author: Adrian Vogelsgesang
Date: 2023-01-31T07:40:31-08:00
New Revision: 8aa313755118bf43c6042fb316b6c243b2c59be2
URL:
https://github.com/llvm/llvm-project/commit/8aa313755118bf43c6042fb316b6c243b2c59be2
DIFF:
https://github.com/llvm/llvm-project/commit/8aa313755118bf43c6042fb316b6c243b2c59be2
Author: Adrian Vogelsgesang
Date: 2023-02-08T10:22:50-08:00
New Revision: 54d4a2550d3167d51a9d386d9823a06aca459531
URL:
https://github.com/llvm/llvm-project/commit/54d4a2550d3167d51a9d386d9823a06aca459531
DIFF:
https://github.com/llvm/llvm-project/commit/54d4a2550d3167d51a9d386d9823a06aca459531
https://github.com/vogelsgesang commented:
I can't provide feedback on the lldb integration aspects, as I don't know the
lldb code base well enough
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
@@ -41,7 +41,10 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
: LanguageRuntime(process) {}
bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {
- return name == g_this;
+ // FIXME: use a list when the list grows more.
+ return name == g_this
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Vogelsgesang
Date: 2022-08-25T17:11:57-07:00
New Revision: 6f88388f61327b375112e76ff4b80741a1b349cb
URL:
https://github.com/llvm/llvm-project/commit/6f88388f61327b375112e76ff4b80741a1b349cb
DIFF:
https://github.com/llvm/llvm-project/commit/6f88388f61327b375112e76ff4b80741a1b349cb
Author: Adrian Vogelsgesang
Date: 2022-11-11T09:37:08-08:00
New Revision: 558db7787005348e2efaabb628ec36f1c461a741
URL:
https://github.com/llvm/llvm-project/commit/558db7787005348e2efaabb628ec36f1c461a741
DIFF:
https://github.com/llvm/llvm-project/commit/558db7787005348e2efaabb628ec36f1c461a741
Author: Adrian Vogelsgesang
Date: 2022-11-11T10:00:58-08:00
New Revision: d7e1c2770fa57fb8df2f09f74d433ac9cf80a595
URL:
https://github.com/llvm/llvm-project/commit/d7e1c2770fa57fb8df2f09f74d433ac9cf80a595
DIFF:
https://github.com/llvm/llvm-project/commit/d7e1c2770fa57fb8df2f09f74d433ac9cf80a595
Author: Adrian Vogelsgesang
Date: 2022-11-20T06:35:16-08:00
New Revision: 01f4c305fae9ff2f165ce0f635a90f8e2292308c
URL:
https://github.com/llvm/llvm-project/commit/01f4c305fae9ff2f165ce0f635a90f8e2292308c
DIFF:
https://github.com/llvm/llvm-project/commit/01f4c305fae9ff2f165ce0f635a90f8e2292308c
Author: Adrian Vogelsgesang
Date: 2022-11-20T10:30:29-08:00
New Revision: fb61dce1adc4572e794e836861915d8ae372749d
URL:
https://github.com/llvm/llvm-project/commit/fb61dce1adc4572e794e836861915d8ae372749d
DIFF:
https://github.com/llvm/llvm-project/commit/fb61dce1adc4572e794e836861915d8ae372749d
Author: Adrian Vogelsgesang
Date: 2022-11-20T11:18:52-08:00
New Revision: 4346318f5c700f4e85f866610fb8328fc429319b
URL:
https://github.com/llvm/llvm-project/commit/4346318f5c700f4e85f866610fb8328fc429319b
DIFF:
https://github.com/llvm/llvm-project/commit/4346318f5c700f4e85f866610fb8328fc429319b
Author: Adrian Vogelsgesang
Date: 2022-11-20T14:26:36-08:00
New Revision: cd3091a88f7c55c90d9b5fff372ce1cdfc71948d
URL:
https://github.com/llvm/llvm-project/commit/cd3091a88f7c55c90d9b5fff372ce1cdfc71948d
DIFF:
https://github.com/llvm/llvm-project/commit/cd3091a88f7c55c90d9b5fff372ce1cdfc71948d
vogelsgesang wrote:
friendly ping, @walter-erquinigo @clayborg
https://github.com/llvm/llvm-project/pull/104589
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
@Da-Viper do you have the necessary permissions to merge PRs by yourself? Or do
you need somebody to merge this on your behalf?
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.
vogelsgesang wrote:
see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access for
instructions
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/110784
This commit improves the auto-completion in the Debug Console provided by
VS-Code.
So far, we were always suggesting completions for both LLDB commands and for
variables / expressions, even if the heurist
@@ -290,6 +290,30 @@ The initial repl-mode can be configured with the cli flag
`--repl-mode=`
and may also be adjusted at runtime using the lldb command
`lldb-dap repl-mode `.
+ `lldb-dap custom-event`
vogelsgesang wrote:
Thanks, the updated documentatio
@@ -962,6 +962,44 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger
debugger,
return true;
}
+// Sends a custom DAP event with an optional body.
+//
+// See
+//
https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent
+bool
@@ -962,6 +962,68 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger
debugger,
return true;
}
+// Sends a DAP event with an optional body.
+//
+// See
+//
https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent
+bool SendEv
@@ -962,6 +962,44 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger
debugger,
return true;
}
+// Sends a custom DAP event with an optional body.
+//
+// See
+//
https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent
+bool
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/112384
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang approved this pull request.
https://github.com/llvm/llvm-project/pull/112384
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -962,6 +962,68 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger
debugger,
return true;
}
+// Sends a DAP event with an optional body.
+//
+// See
+//
https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent
+bool SendEv
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/108870
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/113787
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -6,25 +6,21 @@
//
//===--===//
-#include
#include
#include
#include
#include
#include "llvm/ADT/StringRef.h"
-#include "llvm/Support/FormatAdapters.h"
#include "llvm/Support/FormatVariadic.h"
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/114122
Because of a build failure with libc++17.
See
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-matrix/912/execution/node/107/log/
>From 00d136ed33cdc4362f7f23804ee184ddb1fb2539 Mon Sep 17 0
vogelsgesang wrote:
see #114122
https://github.com/llvm/llvm-project/pull/108870
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
> does this feature require compiling target with -gcolumn-info to work?
Apparently, `-gcolumn-info` is on by default. If I pass `-gno-column-info`, the
test case actually fails. But as long as I don't pass anything, column info
seems to be included in the debug info.
htt
@@ -910,6 +911,183 @@ void request_attach(const llvm::json::Object &request) {
}
}
+// "BreakpointLocationsRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+// "description": "The `breakpointLocations` request returns all poss
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/113787
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -9,21 +9,28 @@
#ifndef LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
#define LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
-#include "llvm/Support/JSON.h"
#include
+#include "llvm/Support/JSON.h"
+
+#include "DAPForward.h"
+
namespace lldb_dap {
struct BreakpointBase {
+ // Associat
https://github.com/vogelsgesang commented:
partial review
https://github.com/llvm/llvm-project/pull/114881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -12,15 +12,19 @@
namespace lldb_dap {
-SourceBreakpoint::SourceBreakpoint(const llvm::json::Object &obj)
-: Breakpoint(obj), logMessage(std::string(GetString(obj, "logMessage"))),
+SourceBreakpoint::SourceBreakpoint(DAP *dap, const llvm::json::Object &obj)
+: Break
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/114881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -9,21 +9,28 @@
#ifndef LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
#define LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
-#include "llvm/Support/JSON.h"
#include
+#include "llvm/Support/JSON.h"
+
+#include "DAPForward.h"
+
namespace lldb_dap {
struct BreakpointBase {
+ // Associat
101 - 200 of 594 matches
Mail list logo
