[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-27 Thread Adrian Prantl via lldb-commits
@@ -194,6 +192,54 @@ class CompilerType { bool IsTypedefType() const; bool IsVoidType() const; + + bool IsSmartPtrType() const; + + bool IsInteger() const; + + bool IsFloat() const; + + bool IsEnumerationType() const; + + bool IsUnscopedEnumerationType() const; + + b

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-27 Thread Adrian Prantl via lldb-commits
@@ -194,6 +192,54 @@ class CompilerType { bool IsTypedefType() const; bool IsVoidType() const; + + bool IsSmartPtrType() const; + + bool IsInteger() const; + + bool IsFloat() const; + + bool IsEnumerationType() const; + + bool IsUnscopedEnumerationType() const; + + b

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-11-27 Thread Adrian Prantl via lldb-commits
@@ -194,6 +192,54 @@ class CompilerType { bool IsTypedefType() const; bool IsVoidType() const; + + bool IsSmartPtrType() const; adrian-prantl wrote: Some methods like this one could benefit from a Doxygen comment that explains what the semantics are. h

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Remove redundant parameter to AddMethodToObjCObjectType (PR #73832)

2023-11-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/73832 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFCI] Make ParsedDWARFTypeAttributes parameter const (PR #73833)

2023-11-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/73833 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Delete unreachable code and unnecessary string conversions (PR #74119)

2023-12-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/74119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-12-05 Thread Adrian Prantl via lldb-commits
@@ -194,6 +192,54 @@ class CompilerType { bool IsTypedefType() const; bool IsVoidType() const; + + bool IsSmartPtrType() const; + + bool IsInteger() const; + + bool IsFloat() const; + + bool IsEnumerationType() const; + + bool IsUnscopedEnumerationType() const; + + b

[Lldb-commits] [lldb] [lldb] Correctly check and report error states in StackFrame.cpp (PR #74414)

2023-12-05 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > Is testing this possible? If this weren't inside of StackFrame we could write a reliable test based on LLVM IR, but it might be difficult to reliably produce debug info with optimized out variables from source code on all platforms. If you have any suggestions, let me k

[Lldb-commits] [llvm] [clang-tools-extra] [lldb] [clang] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

2023-12-05 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Is this a performance optimization or a function al change? https://github.com/llvm/llvm-project/pull/73067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-12-05 Thread Adrian Prantl via lldb-commits
@@ -194,6 +192,54 @@ class CompilerType { bool IsTypedefType() const; bool IsVoidType() const; + + bool IsSmartPtrType() const; + + bool IsInteger() const; + + bool IsFloat() const; + + bool IsEnumerationType() const; + + bool IsUnscopedEnumerationType() const; + + b

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-12-05 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/73472 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF][NFC] Remove unnecessary calls to GetDWARFDeclContext (PR #74523)

2023-12-05 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/74523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

2023-12-05 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: SGTM, maybe wait one more day for @JDevlieghere to chime in. https://github.com/llvm/llvm-project/pull/73067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correctly check and report error states in StackFrame.cpp (PR #74414)

2023-12-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/74414 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Return index of element in ValueObject path instead of the element's value (PR #74413)

2023-12-08 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > > doesn't appear to be anything that calls these methods > > Candidate for removal then? If so it still makes sense to fix them, then > remove them. Saves fixing them again if they are brought back. > > Either way, I'm not going to block this by requiring a test case. I

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Sorry, it's been a while since I last reviewed this and I must admit I forgot about this in the mean time. The only thing I'd like to check before we can land this is to hear from @Michael137 who has been actively working on FindTypes performance recently whether this alig

[Lldb-commits] [lldb] [lldb][draft] All ValueObjectSP instances are now valid (non-null) but have an error state (PR #74912)

2023-12-11 Thread Adrian Prantl via lldb-commits
@@ -1984,84 +1984,75 @@ void ValueObject::GetExpressionPath(Stream &s, } } -ValueObjectSP ValueObject::GetValueForExpressionPath( -llvm::StringRef expression, ExpressionPathScanEndReason *reason_to_stop, -ExpressionPathEndResultType *final_value_type, +std::optional

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-12 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Given that Michael is okay with it, too, let's land this! https://github.com/llvm/llvm-project/pull/74786 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [lldb] Return index of element in ValueObject path instead of the element's value (PR #74413)

2023-12-13 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/74413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-13 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @clayborg Do you by any chance happen to already have a version of this patch that applies cleanly to apple/llvm-project stable/20230725? If not @Michael137 might try to backport it. https://github.com/llvm/llvm-project/pull/74786 ___

[Lldb-commits] [lldb] Add a test for evicting unreachable modules from the global module cache (PR #74894)

2023-12-13 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,169 @@ +""" +Test the use of the global module cache in lldb +""" + +import lldb + +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +import os +import shutil +from pathlib import Path +import time + +cl

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-12-13 Thread Adrian Prantl via lldb-commits
@@ -302,6 +302,195 @@ bool CompilerType::IsBeingDefined() const { return false; } +bool CompilerType::IsInteger() const { + bool is_signed = false; // May be reset by the call below. + return IsIntegerType(is_signed); +} + +bool CompilerType::IsFloat() const { + uint32_t

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-12-13 Thread Adrian Prantl via lldb-commits
@@ -302,6 +302,195 @@ bool CompilerType::IsBeingDefined() const { return false; } +bool CompilerType::IsInteger() const { + bool is_signed = false; // May be reset by the call below. + return IsIntegerType(is_signed); +} + +bool CompilerType::IsFloat() const { + uint32_t

[Lldb-commits] [lldb] [lldb] Skip 2 newly introduced tests from running on DWARF2 and clang 11 (PR #75406)

2023-12-13 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/75406 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Skip 2 newly introduced tests from running on DWARF2 and clang 11 (PR #75406)

2023-12-13 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/75406 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

2023-12-14 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Thanks for addressing all my feedback! https://github.com/llvm/llvm-project/pull/73472 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] [lldb] Fix a quirk in SBValue::GetDescription (PR #75793)

2023-12-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/75793 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Remove unused FileSPec::IsResolved() functionality. (PR #75840)

2023-12-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/75840 This API seems to be completely unused. Should we just remove it? >From ce51a6c5b8f023a190023ddd4f189dea04fc1d63 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 18 Dec 2023 10:25:23 -0800 Subject:

[Lldb-commits] [lldb] [lldb] Remove unused GetChildAtIndexPath(...) methods from ValueObject.cpp (PR #75870)

2023-12-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/75870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

2023-12-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/75865 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/75880 LLVM supports DWARF 5 linetable extension to store source files inline in DWARF. This is particularly useful for compiler-generated source code. This implementation tries to materialize them as temporary f

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-18 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/75880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-18 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: The primary use-case I have in mind for this are Swift macro expansions, which may produce hundreds of tiny inline files per source file, hence the lazy approach. https://github.com/llvm/llvm-project/pull/75880 ___ lldb-commits m

[Lldb-commits] [lldb] [lldb][Type] Add TypeQuery::SetLanguages API (PR #75926)

2023-12-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/75926 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-19 Thread Adrian Prantl via lldb-commits
@@ -17,13 +17,40 @@ namespace lldb_private { class Stream; +/// Represents a source file whose contents is known (for example +/// because it can be reconstructed from debug info), but that +/// hasn't been written to a local disk yet. +struct LazyFileSpec { + virtual ~LazyFi

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-19 Thread Adrian Prantl via lldb-commits
@@ -38,7 +65,10 @@ class FileSpecList { FileSpecList(FileSpecList &&rhs) = default; /// Initialize this object from a vector of FileSpecs - FileSpecList(std::vector &&rhs) : m_files(std::move(rhs)) {} + FileSpecList(std::vector &&rhs) { +for (auto &fs : rhs) + m

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-19 Thread Adrian Prantl via lldb-commits
@@ -235,6 +236,51 @@ ParseSupportFilesFromPrologue(const lldb::ModuleSP &module, for (size_t idx = first_file_idx; idx <= last_file_idx; ++idx) { std::string remapped_file; if (auto file_path = GetFileByIndex(prologue, idx, compile_dir, style)) { + auto entry = p

[Lldb-commits] [lldb] Remove unused FileSPec::IsResolved() functionality. (PR #75840)

2023-12-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/75840 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-19 Thread Adrian Prantl via lldb-commits
@@ -38,7 +65,10 @@ class FileSpecList { FileSpecList(FileSpecList &&rhs) = default; /// Initialize this object from a vector of FileSpecs - FileSpecList(std::vector &&rhs) : m_files(std::move(rhs)) {} + FileSpecList(std::vector &&rhs) { +for (auto &fs : rhs) + m

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/75880 >From 437b7803c8011745c7e57faf74f15210cbbf1f09 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 18 Dec 2023 15:59:00 -0800 Subject: [PATCH] Add support for inline DWARF source files. LLVM supports D

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-19 Thread Adrian Prantl via lldb-commits
@@ -38,7 +65,10 @@ class FileSpecList { FileSpecList(FileSpecList &&rhs) = default; /// Initialize this object from a vector of FileSpecs - FileSpecList(std::vector &&rhs) : m_files(std::move(rhs)) {} + FileSpecList(std::vector &&rhs) { +for (auto &fs : rhs) + m

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/75880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove unused GetChildAtIndexPath(...) methods from ValueObject.cpp (PR #75870)

2023-12-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/75870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/75880 >From e089e1d67c01a42da16b7544abf8c4935cde4aed Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 18 Dec 2023 15:59:00 -0800 Subject: [PATCH 1/2] Add support for inline DWARF source files. LLVM suppor

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2023-12-19 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @JDevlieghere and I had an offline conversation about whether we couldn't separate out a SupportFileList from FileSpecList to limit the amount of places that need to think about lazy files and also to potentially move the FileSpec::m_checksum into. Here is a very rough pat

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2024-01-03 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Ping @JDevlieghere https://github.com/llvm/llvm-project/pull/75880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2024-01-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/75880 >From e089e1d67c01a42da16b7544abf8c4935cde4aed Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 18 Dec 2023 15:59:00 -0800 Subject: [PATCH 1/3] Add support for inline DWARF source files. LLVM suppor

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2024-01-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/75880 >From e089e1d67c01a42da16b7544abf8c4935cde4aed Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 18 Dec 2023 15:59:00 -0800 Subject: [PATCH 1/3] Add support for inline DWARF source files. LLVM suppor

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2024-01-03 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @JDevlieghere I think I addressed your comments. Mind taking another look? https://github.com/llvm/llvm-project/pull/75880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2024-01-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/75880 >From e089e1d67c01a42da16b7544abf8c4935cde4aed Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 18 Dec 2023 15:59:00 -0800 Subject: [PATCH 1/4] Add support for inline DWARF source files. LLVM suppor

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

2024-01-03 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @JDevlieghere I merged the two. This made the regular (on-disk) case somewhat less efficient because all SupportFiles are now on the Heap but that probably isn't even measurable. https://github.com/llvm/llvm-project/pull/75880 __

[Lldb-commits] [lldb] Add support for inline DWARF source files. (PR #75880)

2024-01-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/75880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add support for inline DWARF source files. (PR #75880)

2024-01-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/75880 >From bce832068582908b521b6ded591eb7a0240f647e Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 18 Dec 2023 15:59:00 -0800 Subject: [PATCH] Add support for inline DWARF source files. LLVM supports D

[Lldb-commits] [lldb] Add support for inline DWARF source files. (PR #75880)

2024-01-03 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/75880 >From 43685190a62752ccac84fbc0e37cad7328ab6a49 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 18 Dec 2023 15:59:00 -0800 Subject: [PATCH] Add support for inline DWARF source files. LLVM supports D

[Lldb-commits] [lldb] Add support for inline DWARF source files. (PR #75880)

2024-01-04 Thread Adrian Prantl via lldb-commits
@@ -235,6 +233,53 @@ ParseSupportFilesFromPrologue(const lldb::ModuleSP &module, for (size_t idx = first_file_idx; idx <= last_file_idx; ++idx) { std::string remapped_file; if (auto file_path = GetFileByIndex(prologue, idx, compile_dir, style)) { + auto entry = p

[Lldb-commits] [lldb] Add support for inline DWARF source files. (PR #75880)

2024-01-04 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/75880 >From 919f93cdb351b35853d236641c727f1eade0fefd Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 18 Dec 2023 15:59:00 -0800 Subject: [PATCH] Add support for inline DWARF source files. LLVM supports D

[Lldb-commits] [lldb] Add support for inline DWARF source files. (PR #75880)

2024-01-04 Thread Adrian Prantl via lldb-commits
@@ -17,6 +17,89 @@ namespace lldb_private { class Stream; +/// Wraps either a FileSpec that represents a local file or a source +/// file whose contents is known (for example because it can be +/// reconstructed from debug info), but that hasn't been written to a +/// file yet

[Lldb-commits] [lldb] Add support for inline DWARF source files. (PR #75880)

2024-01-04 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/75880 >From 9af00c37715c614cac700cd8763ee3d8167111e5 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Mon, 18 Dec 2023 15:59:00 -0800 Subject: [PATCH] Add support for inline DWARF source files. LLVM supports D

[Lldb-commits] [lldb] Add support for inline DWARF source files. (PR #75880)

2024-01-04 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/75880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9f9dd6b - Wrap local type declarations in anonymous namespace to fix modules build.

2024-01-04 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-01-04T09:30:00-08:00 New Revision: 9f9dd6be0d21a156dcfee01ebbd571eca79b08bd URL: https://github.com/llvm/llvm-project/commit/9f9dd6be0d21a156dcfee01ebbd571eca79b08bd DIFF: https://github.com/llvm/llvm-project/commit/9f9dd6be0d21a156dcfee01ebbd571eca79b08bd.diff

[Lldb-commits] [lldb] c041fa1 - XFAIL test with dsymutil

2024-01-04 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-01-04T10:25:47-08:00 New Revision: c041fa1093c3ad7be040fb362a10ca3900c698a4 URL: https://github.com/llvm/llvm-project/commit/c041fa1093c3ad7be040fb362a10ca3900c698a4 DIFF: https://github.com/llvm/llvm-project/commit/c041fa1093c3ad7be040fb362a10ca3900c698a4.diff

[Lldb-commits] [lldb] [lldb][DWARFIndex][nfc] Factor out fully qualified name query (PR #76977)

2024-01-05 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/76977 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFIndex][nfc] Factor out fully qualified name query (PR #76977)

2024-01-05 Thread Adrian Prantl via lldb-commits
@@ -102,6 +110,12 @@ class DWARFIndex { } void ReportInvalidDIERef(DIERef ref, llvm::StringRef name) const; + + /// Implementation of `GetFullyQualifiedType` to check a single entry, + /// shareable with derived classes. adrian-prantl wrote: What does t

[Lldb-commits] [lldb] [lldb] DWARFDIE: Follow DW_AT_specification when computing CompilerCo… (PR #77157)

2024-01-05 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/77157 …ntext Following the specification chain seems to be clearly the expected behavior of GetDeclContext(). Otherwise C++ methods have an empty CompilerContext instead of being nested in their struct/class.

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] GetClangDeclForDIE: don't create VarDecl for static data members (PR #77155)

2024-01-05 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/77155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] GetClangDeclForDIE: don't create VarDecl for static data members (PR #77155)

2024-01-05 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/77155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] GetClangDeclForDIE: don't create VarDecl for static data members (PR #77155)

2024-01-05 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,23 @@ +# UNSUPPORTED: system-darwin, system-windows adrian-prantl wrote: Just out of curiosity — we are evaluating a static constant. Do we actually need to *run* the binary, or could we run the expression against e.g., an ELF binary on Darwin, too,

[Lldb-commits] [lldb] [lldb] DWARFDIE: Follow DW_AT_specification when computing CompilerCo… (PR #77157)

2024-01-08 Thread Adrian Prantl via lldb-commits
@@ -404,7 +409,7 @@ std::vector DWARFDIE::GetDeclContext() const { push_ctx(CompilerContextKind::Enum, GetName()); break; case DW_TAG_subprogram: -push_ctx(CompilerContextKind::Function, GetPubname()); +push_ctx(CompilerContextKind::Function, GetName());

[Lldb-commits] [lldb] [lldb] DWARFDIE: Follow DW_AT_specification when computing CompilerCo… (PR #77157)

2024-01-08 Thread Adrian Prantl via lldb-commits
@@ -375,16 +375,21 @@ std::vector DWARFDIE::GetDeclContextDIEs() const { std::vector DWARFDIE::GetDeclContext() const { std::vector context; - const dw_tag_t tag = Tag(); - if (tag == DW_TAG_compile_unit || tag == DW_TAG_partial_unit) -return context; DWARFDIE pare

[Lldb-commits] [lldb] [lldb] DWARFDIE: Follow DW_AT_specification when computing CompilerCo… (PR #77157)

2024-01-08 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/77157 >From 5f34a103d0b06220bb93b55525865e23694854b4 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 5 Jan 2024 15:11:24 -0800 Subject: [PATCH] [lldb] DWARFDIE: Follow DW_AT_specification when computing

[Lldb-commits] [lldb] [lldb] DWARFDIE: Follow DW_AT_specification when computing CompilerCo… (PR #77157)

2024-01-08 Thread Adrian Prantl via lldb-commits
@@ -375,16 +375,21 @@ std::vector DWARFDIE::GetDeclContextDIEs() const { std::vector DWARFDIE::GetDeclContext() const { std::vector context; - const dw_tag_t tag = Tag(); - if (tag == DW_TAG_compile_unit || tag == DW_TAG_partial_unit) -return context; DWARFDIE pare

[Lldb-commits] [lldb] Add support for inline DWARF source files. (PR #75880)

2024-01-08 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: I'll probably need some help from someone with a windows machine to debug this. Your hunch about path separators sounds plausible. https://github.com/llvm/llvm-project/pull/75880 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [lldb] [lldb][[DWARFDeclContext] Add function to extract qualified names as vector (PR #77349)

2024-01-08 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/77349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][[DWARFDeclContext] Add function to extract qualified names as vector (PR #77349)

2024-01-08 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/77349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][[DWARFDeclContext] Add function to extract qualified names as vector (PR #77349)

2024-01-08 Thread Adrian Prantl via lldb-commits
@@ -68,6 +68,11 @@ class DWARFDeclContext { const char *GetQualifiedName() const; + /// Returns a vector of string, one string per entry in the fully qualified + /// name. For example, for the DeclContext `A::B::C`, this methods returns + /// `{"C", "B", "A"}` + llvm::S

[Lldb-commits] [lldb] [lldb][[DWARFDeclContext] Add function to extract qualified names as vector (PR #77349)

2024-01-08 Thread Adrian Prantl via lldb-commits
@@ -55,6 +55,12 @@ const char *DWARFDeclContext::GetQualifiedName() const { return m_qualified_name.c_str(); } +llvm::SmallVector +DWARFDeclContext::GetQualifiedNameAsVector() const { + return llvm::to_vector_of( + llvm::map_range(m_entries, GetName));

[Lldb-commits] [lldb] [lldb] DWARFDIE: Follow DW_AT_specification when computing CompilerCo… (PR #77157)

2024-01-09 Thread Adrian Prantl via lldb-commits
@@ -2574,11 +2574,12 @@ void SymbolFileDWARF::FindFunctions(const Module::LookupInfo &lookup_info, Module::LookupInfo no_tp_lookup_info(lookup_info); no_tp_lookup_info.SetLookupName(ConstString(name_no_template_params)); - m_index->GetFunctions(no_tp_lookup_i

[Lldb-commits] [lldb] [lldb] DWARFDIE: Follow DW_AT_specification when computing CompilerCo… (PR #77157)

2024-01-09 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/77157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][[DWARFDeclContext] Add function to extract qualified names as vector (PR #77349)

2024-01-09 Thread Adrian Prantl via lldb-commits
@@ -68,6 +68,11 @@ class DWARFDeclContext { const char *GetQualifiedName() const; + /// Returns a vector of string, one string per entry in the fully qualified + /// name. For example, for the DeclContext `A::B::C`, this methods returns + /// `{"C", "B", "A"}` + llvm::S

[Lldb-commits] [lldb] [lldb][[DWARFDeclContext] Add function to extract qualified names as vector (PR #77349)

2024-01-09 Thread Adrian Prantl via lldb-commits
@@ -68,6 +68,11 @@ class DWARFDeclContext { const char *GetQualifiedName() const; + /// Returns a vector of string, one string per entry in the fully qualified + /// name. For example, for the DeclContext `A::B::C`, this methods returns + /// `{"C", "B", "A"}` + llvm::S

[Lldb-commits] [lldb] [lldb][[DWARFDeclContext] Add function to extract qualified names as vector (PR #77349)

2024-01-09 Thread Adrian Prantl via lldb-commits
@@ -68,6 +68,11 @@ class DWARFDeclContext { const char *GetQualifiedName() const; + /// Returns a vector of string, one string per entry in the fully qualified + /// name. For example, for the DeclContext `A::B::C`, this methods returns + /// `{"C", "B", "A"}` + llvm::S

[Lldb-commits] [lldb] [lldb] Add color support to StreamString (PR #77380)

2024-01-10 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/77380 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f09f0a6 - [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

2023-07-21 Thread Adrian Prantl via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2023-07-21T16:42:16-07:00 New Revision: f09f0a6b10765f0993255e52a62268472f586830 URL: https://github.com/llvm/llvm-project/commit/f09f0a6b10765f0993255e52a62268472f586830 DIFF: https://github.com/llvm/llvm-project/commit/f09f0a6b10765f0993255e52a62268472

[Lldb-commits] [lldb] d227c8a - Add missing nullptr check.

2023-09-05 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2023-09-05T09:48:06-07:00 New Revision: d227c8a1200081fdab14e93165927787544c5f12 URL: https://github.com/llvm/llvm-project/commit/d227c8a1200081fdab14e93165927787544c5f12 DIFF: https://github.com/llvm/llvm-project/commit/d227c8a1200081fdab14e93165927787544c5f12.diff

[Lldb-commits] [lldb] [lldb][Docs] Additions to debuging LLDB page (PR #65635)

2023-09-07 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/65635 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread Adrian Prantl via lldb-commits
@@ -2996,10 +2996,22 @@ void CommandInterpreter::FindCommandsForApropos(llvm::StringRef search_word, m_alias_dict); } -ExecutionContext CommandInterpreter::GetExecutionContext() const { - return !m_overriden_exe_contexts.empty() - ? m_o

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread Adrian Prantl via lldb-commits
@@ -127,3 +128,61 @@ def tearDown(self): # Call super's tearDown(). TestBase.tearDown(self) + +def test_run_then_attach_wait_interrupt(self): +# Test that having run one process doesn't cause us to be unable +# to interrupt a

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-12 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Have (should we) we documented that we format all python code with black somewhere and how to install the tool? https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-12 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl review_requested https://github.com/llvm/llvm-project/pull/66035 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-12 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Oh nice! I was unsuccessfully looking in the LLDb subdir because I had assumed this was LLDB-specific! https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [lldb] Accept optional module in Value::ResolveValue (PR #66286)

2023-09-13 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/66286 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Clean up test case (PR #66400)

2023-09-14 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/66400: None >From d14e5d08571ea206b1ee8dd0ffc66f896306d15e Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 14 Sep 2023 09:44:15 -0700 Subject: [PATCH] Clean up test case --- .../Makefile

[Lldb-commits] [lldb] Clean up test case (PR #66400)

2023-09-14 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl review_requested https://github.com/llvm/llvm-project/pull/66400 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Clean up test case (PR #66400)

2023-09-14 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl review_requested https://github.com/llvm/llvm-project/pull/66400 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Clean up test case (PR #66400)

2023-09-14 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl review_requested https://github.com/llvm/llvm-project/pull/66400 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Clean up test case (PR #66400)

2023-09-14 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/66400 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Accept optional module in Value::ResolveValue (PR #66286)

2023-09-14 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: IIUC, this is an infrastructure change that fixes a test failure in swift branch. Augusto can speak to whether it's testable on `main`. https://github.com/llvm/llvm-project/pull/66286 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [lldb] 15c8a76 - Skip tests with earlier versions of clang

2023-09-18 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2023-09-18T09:55:33-07:00 New Revision: 15c8a7628320f928d44317e3b3b706a4f57aa58d URL: https://github.com/llvm/llvm-project/commit/15c8a7628320f928d44317e3b3b706a4f57aa58d DIFF: https://github.com/llvm/llvm-project/commit/15c8a7628320f928d44317e3b3b706a4f57aa58d.diff

[Lldb-commits] [lldb] Improve and modernize logging for Process::CompleteAttach() (PR #82717)

2024-02-22 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/82717 Target::SetArchitecture() does not necessarily set the triple that is being passed in, and will unconditionally log the real architecture to the log channel. By flipping the order between the log outputs,

[Lldb-commits] [lldb] Improve and modernize logging for Process::CompleteAttach() (PR #82717)

2024-02-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/82717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    1   2   3   4   5   6   7   8   9   10   >