https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/75840
This API seems to be completely unused. Should we just remove it?
>From ce51a6c5b8f023a190023ddd4f189dea04fc1d63 Mon Sep 17 00:00:00 2001
From: Adrian Prantl <apra...@apple.com>
Date: Mon, 18 Dec 2023 10:25:23 -0800
Subject: [PATCH] Remove unused FileSPec::IsResolved() functionality.
---
lldb/include/lldb/Utility/FileSpec.h | 19 -------------------
lldb/source/Host/common/FileSystem.cpp | 1 -
2 files changed, 20 deletions(-)
diff --git a/lldb/include/lldb/Utility/FileSpec.h
b/lldb/include/lldb/Utility/FileSpec.h
index ccd25a81c11f36..e4276e8398b464 100644
--- a/lldb/include/lldb/Utility/FileSpec.h
+++ b/lldb/include/lldb/Utility/FileSpec.h
@@ -386,21 +386,6 @@ class FileSpec {
/// The triple which is used to set the Path style.
void SetFile(llvm::StringRef path, const llvm::Triple &triple);
- bool IsResolved() const { return m_is_resolved; }
-
- /// Set if the file path has been resolved or not.
- ///
- /// If you know a file path is already resolved and avoided passing a \b
- /// true parameter for any functions that take a "bool resolve_path"
- /// parameter, you can set the value manually using this call to make sure
- /// we don't try and resolve it later, or try and resolve a path that has
- /// already been resolved.
- ///
- /// \param[in] is_resolved
- /// A boolean value that will replace the current value that
- /// indicates if the paths in this object have been resolved.
- void SetIsResolved(bool is_resolved) { m_is_resolved = is_resolved; }
-
FileSpec CopyByAppendingPathComponent(llvm::StringRef component) const;
FileSpec CopyByRemovingLastPathComponent() const;
@@ -440,7 +425,6 @@ class FileSpec {
/// state in this object.
void PathWasModified() {
m_checksum = Checksum();
- m_is_resolved = false;
m_absolute = Absolute::Calculate;
}
@@ -459,9 +443,6 @@ class FileSpec {
/// The optional MD5 checksum of the file.
Checksum m_checksum;
- /// True if this path has been resolved.
- mutable bool m_is_resolved = false;
-
/// Cache whether this path is absolute.
mutable Absolute m_absolute = Absolute::Calculate;
diff --git a/lldb/source/Host/common/FileSystem.cpp
b/lldb/source/Host/common/FileSystem.cpp
index 52227a9f63a526..5153a0a9ec5134 100644
--- a/lldb/source/Host/common/FileSystem.cpp
+++ b/lldb/source/Host/common/FileSystem.cpp
@@ -259,7 +259,6 @@ void FileSystem::Resolve(FileSpec &file_spec) {
file_spec.SetDirectory(path);
else
file_spec.SetPath(path);
- file_spec.SetIsResolved(true);
}
template <typename T>
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
