[Lldb-commits] [lldb] [lldb][Breakpoint] Allow whitespace in breakpoint address expression (PR #126053)

2025-02-06 Thread Adrian Prantl via lldb-commits
@@ -262,8 +262,10 @@ OptionArgParser::DoToAddress(const ExecutionContext *exe_ctx, llvm::StringRef s, // 3: The symbol/reg name if there is an offset // 4: +/- // 5: The offset value. + // clang-format off static RegularExpression g_symbol_plus_offset_regex( - "

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-31 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: This is breaking macOS bots: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/19569/ https://github.com/llvm/llvm-project/pull/123945 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

2025-01-31 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: I'm going to revert this for now, let me know if you need help understanding the failure cause! https://github.com/llvm/llvm-project/pull/123945 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] 87b7f63 - Revert "Reland "[lldb] Implement basic support for reverse-continue" (#125242)"

2025-01-31 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2025-01-31T13:11:20-08:00 New Revision: 87b7f63a117c340a6d9ca47959335fd7ef6c7ad2 URL: https://github.com/llvm/llvm-project/commit/87b7f63a117c340a6d9ca47959335fd7ef6c7ad2 DIFF: https://github.com/llvm/llvm-project/commit/87b7f63a117c340a6d9ca47959335fd7ef6c7ad2.diff

[Lldb-commits] [lldb] [lldb] Disallow left shifts of negative values in the interpreter (PR #119620)

2024-12-11 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/119620 This trips UBSAN and probably isn't partiuclarly useful either. >From 104f0d227f5642bf7a02311482fafb4edc667c67 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 11 Dec 2024 13:57:43 -0800 Subject: [

[Lldb-commits] [lldb] [lldb] Disallow left shifts of negative values in the interpreter (PR #119620)

2024-12-11 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/119620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-12-10 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/114333 >From 1a650fde4a885420c6f2991b41039c4b16ff42e1 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 24 Jan 2024 12:42:45 -0800 Subject: [PATCH 1/2] [lldb] Load embedded type summary section (#7859) (#8040)

[Lldb-commits] [lldb] 1a650fd - [lldb] Load embedded type summary section (#7859) (#8040)

2024-12-10 Thread Adrian Prantl via lldb-commits
Author: Dave Lee Date: 2024-12-10T09:36:38-08:00 New Revision: 1a650fde4a885420c6f2991b41039c4b16ff42e1 URL: https://github.com/llvm/llvm-project/commit/1a650fde4a885420c6f2991b41039c4b16ff42e1 DIFF: https://github.com/llvm/llvm-project/commit/1a650fde4a885420c6f2991b41039c4b16ff42e1.diff LOG:

[Lldb-commits] [lldb] 9a9c1d4 - [lldb] Implement a formatter bytecode interpreter in C++

2024-12-10 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-12-10T09:36:38-08:00 New Revision: 9a9c1d4a6155a96ce9be494cec7e25731d36b33e URL: https://github.com/llvm/llvm-project/commit/9a9c1d4a6155a96ce9be494cec7e25731d36b33e DIFF: https://github.com/llvm/llvm-project/commit/9a9c1d4a6155a96ce9be494cec7e25731d36b33e.diff

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-12-10 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/114333 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-12-10 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,41 @@ +// A bare-bones llvm::Optional reimplementation. + +template struct MyOptionalStorage { + MyOptionalStorage(T val) : value(val), hasVal(true) {} + MyOptionalStorage() {} + T value; + bool hasVal = false; +}; + +template struct MyOptional { + MyOptionalStor

[Lldb-commits] [lldb] e2bb474 - [lldb] Add comment

2024-12-10 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-12-10T09:39:51-08:00 New Revision: e2bb47443d2e5c022c7851dd6029e3869fc8835c URL: https://github.com/llvm/llvm-project/commit/e2bb47443d2e5c022c7851dd6029e3869fc8835c DIFF: https://github.com/llvm/llvm-project/commit/e2bb47443d2e5c022c7851dd6029e3869fc8835c.diff

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-12-10 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @sylvestre Also your revert was incomplete, and you broke a bunch of other lldb bots :-) I reverted your revert with a fix for https://github.com/llvm/llvm-project/issues/119467 https://github.com/llvm/llvm-project/pull/114333 __

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-12-10 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: See https://lab.llvm.org/buildbot/#/builders/59/builds/9599 https://github.com/llvm/llvm-project/pull/114333 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 87659a1 - Reland: [lldb] Implement a formatter bytecode interpreter in C++

2024-12-10 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-12-10T16:37:53-08:00 New Revision: 87659a17d0703c1244211d9f8d1f0c21e816f0e1 URL: https://github.com/llvm/llvm-project/commit/87659a17d0703c1244211d9f8d1f0c21e816f0e1 DIFF: https://github.com/llvm/llvm-project/commit/87659a17d0703c1244211d9f8d1f0c21e816f0e1.diff

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-12-10 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @dyung checking... https://github.com/llvm/llvm-project/pull/114333 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1593f36 - [lldb] Add explicit type conversion

2024-12-10 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-12-10T17:01:51-08:00 New Revision: 1593f36935edc97bede71bd1d722edf83eaf16a4 URL: https://github.com/llvm/llvm-project/commit/1593f36935edc97bede71bd1d722edf83eaf16a4 DIFF: https://github.com/llvm/llvm-project/commit/1593f36935edc97bede71bd1d722edf83eaf16a4.diff

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-12-10 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: My bad. I literally forgot to git-add that patch to my remand. Pushed as a separate commit now. https://github.com/llvm/llvm-project/pull/114333 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-12-10 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: The other lldb bots on the dashboard seem to have turned green again. (Windows is still building, but it was fine before). https://github.com/llvm/llvm-project/pull/114333 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-12-10 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: On which bot did you see this? I watched the lldb linux arm bot go green earlier today. In any case it looks like there was just one more explicit type conversion missing. https://github.com/llvm/llvm-project/pull/114333 ___ lldb

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-12-09 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/114333 >From 1e51be85ed88857a0ef53cf1a0756b98f7c11a1b Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 24 Jan 2024 12:42:45 -0800 Subject: [PATCH 1/2] [lldb] Load embedded type summary section (#7859) (#8040)

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-12-09 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/114333 >From 1e51be85ed88857a0ef53cf1a0756b98f7c11a1b Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 24 Jan 2024 12:42:45 -0800 Subject: [PATCH 1/2] [lldb] Load embedded type summary section (#7859) (#8040)

[Lldb-commits] [lldb] f6012a2 - [lldb] Add cast to fix compile error on 32-bit platforms

2024-12-10 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-12-10T10:28:14-08:00 New Revision: f6012a209dca6b1866d00e6b4f96279469884320 URL: https://github.com/llvm/llvm-project/commit/f6012a209dca6b1866d00e6b4f96279469884320 DIFF: https://github.com/llvm/llvm-project/commit/f6012a209dca6b1866d00e6b4f96279469884320.diff

[Lldb-commits] [lldb] 0be3348 - [lldb] Improve log message to include missing strings

2024-12-10 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-12-10T09:54:36-08:00 New Revision: 0be33484853557bc0fd9dfb94e0b6c15dda136ce URL: https://github.com/llvm/llvm-project/commit/0be33484853557bc0fd9dfb94e0b6c15dda136ce DIFF: https://github.com/llvm/llvm-project/commit/0be33484853557bc0fd9dfb94e0b6c15dda136ce.diff

[Lldb-commits] [lldb] [lldb] Load embedded type summary section (#7859) (#8040) (PR #113743)

2024-12-10 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Superseded by https://github.com/llvm/llvm-project/pull/114333 https://github.com/llvm/llvm-project/pull/113743 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Load embedded type summary section (#7859) (#8040) (PR #113743)

2024-12-10 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: I believe I also addressed all outstanding review feedback. https://github.com/llvm/llvm-project/pull/113743 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d300337 - [lldb] Add cast to fix compile error on 32-but platforms

2024-12-10 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-12-10T10:00:54-08:00 New Revision: d300337e93da4ed96b044557e4b0a30001967cf0 URL: https://github.com/llvm/llvm-project/commit/d300337e93da4ed96b044557e4b0a30001967cf0 DIFF: https://github.com/llvm/llvm-project/commit/d300337e93da4ed96b044557e4b0a30001967cf0.diff

[Lldb-commits] [lldb] [lldb] Load embedded type summary section (#7859) (#8040) (PR #113743)

2024-12-10 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/113743 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c00a708 - [lldb] Eliminate dead code (NFC)

2024-12-10 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-12-10T17:09:44-08:00 New Revision: c00a708fc954f450679bf0e171029f8da4841cfb URL: https://github.com/llvm/llvm-project/commit/c00a708fc954f450679bf0e171029f8da4841cfb DIFF: https://github.com/llvm/llvm-project/commit/c00a708fc954f450679bf0e171029f8da4841cfb.diff

[Lldb-commits] [lldb] [lldb] Implement a formatter bytecode interpreter in C++ (PR #114333)

2024-12-10 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @dyung https://lab.llvm.org/buildbot/#/builders/181/builds/10131 is green again, too. https://github.com/llvm/llvm-project/pull/114333 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [clang] [lldb] [clang][DebugInfo][gmodules] Set runtimeLang on ObjC forward declarations (PR #120154)

2024-12-16 Thread Adrian Prantl via lldb-commits
@@ -2995,20 +2995,21 @@ llvm::DIType *CGDebugInfo::CreateType(const ObjCInterfaceType *Ty, if (!ID) return nullptr; + auto RuntimeLang = + static_cast(TheCU->getSourceLanguage()); + // Return a forward declaration if this type was imported from a clang module,

[Lldb-commits] [lldb] 9ee454a - [lldb] Fix RST table formatting

2024-12-16 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-12-16T10:42:37-08:00 New Revision: 9ee454a57c061e47223e079cdc64d315580367ed URL: https://github.com/llvm/llvm-project/commit/9ee454a57c061e47223e079cdc64d315580367ed DIFF: https://github.com/llvm/llvm-project/commit/9ee454a57c061e47223e079cdc64d315580367ed.diff

[Lldb-commits] [lldb] [lldb] Add missing operations to GetOpcodeDataSize (PR #120163)

2024-12-17 Thread Adrian Prantl via lldb-commits
@@ -269,6 +269,7 @@ static lldb::offset_t GetOpcodeDataSize(const DataExtractor &data, // All opcodes that have a single ULEB (signed or unsigned) argument case DW_OP_addrx: // 0xa1 1 ULEB128 index + case DW_OP_constx: // 0xa2 1 ULEB128 index -

[Lldb-commits] [lldb] [lldb] Add missing operations to GetOpcodeDataSize (PR #120163)

2024-12-17 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/120163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve error reporting in GetLocation_DW_OP_addr (PR #120162)

2024-12-17 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/120162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang][DebugInfo][gmodules] Set runtimeLang on ObjC forward declarations (PR #120154)

2024-12-17 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/120154 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add missing operations to GetOpcodeDataSize (PR #120163)

2024-12-17 Thread Adrian Prantl via lldb-commits
@@ -307,6 +308,8 @@ static lldb::offset_t GetOpcodeDataSize(const DataExtractor &data, case DW_OP_regx:// 0x90 1 ULEB128 register case DW_OP_fbreg: // 0x91 1 SLEB128 offset case DW_OP_piece: // 0x93 1 ULEB128 size of piece addressed + cas

[Lldb-commits] [lldb] [lldb] Add a progress event for executing an expression (PR #119757)

2024-12-12 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/119757 Expressions can take arbitrary amounts of time to run, so IDEs might want to be informed about the fact that an expression is currently being executed. rdar://141253078 >From 596555941e1596132fcabe84ad80

[Lldb-commits] [lldb] [lldb] Add a progress event for executing an expression (PR #119757)

2024-12-12 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/119757 >From 084b096f2164042fb0a8a85c2614985c589b1788 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 12 Dec 2024 12:53:13 -0800 Subject: [PATCH] [lldb] Add a progress event for executing an expression E

[Lldb-commits] [lldb] [lldb] Add a progress event for executing an expression (PR #119757)

2024-12-12 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/119757 >From 9a4f8c4b3a9953a5f59bd58f538281a0f194473f Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 12 Dec 2024 12:53:13 -0800 Subject: [PATCH] [lldb] Add a progress event for executing an expression E

[Lldb-commits] [lldb] [lldb] Add a progress event for executing an expression (PR #119757)

2024-12-12 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/119757 >From c014afa4c7443c6696398da3d890d98630e14895 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 12 Dec 2024 12:53:13 -0800 Subject: [PATCH] [lldb] Add a progress event for executing an expression E

[Lldb-commits] [lldb] [lldb] Support zero-padding in formatter sections (PR #119934)

2024-12-13 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/119934 None >From 373a93b56b415003bff8ca0ae9de85c820c87036 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 13 Dec 2024 15:00:19 -0800 Subject: [PATCH] [lldb] Support zero-padding in formatter sections -

[Lldb-commits] [lldb] [WIP][lldb][DWARFASTParserClang] Eagerly search definitions for Objective-C classes (PR #119860)

2024-12-13 Thread Adrian Prantl via lldb-commits
@@ -1671,43 +1671,84 @@ DWARFASTParserClang::ParseStructureLikeDIE(const SymbolContext &sc, attrs.is_forward_declaration = true; } + DWARFDIE def_die; + if (attrs.is_forward_declaration && cu_language == eLanguageTypeObjC) { adrian-prantl wrote: Woul

[Lldb-commits] [lldb] [WIP][lldb][DWARFASTParserClang] Eagerly search definitions for Objective-C classes (PR #119860)

2024-12-13 Thread Adrian Prantl via lldb-commits
@@ -1671,43 +1671,84 @@ DWARFASTParserClang::ParseStructureLikeDIE(const SymbolContext &sc, attrs.is_forward_declaration = true; } + DWARFDIE def_die; + if (attrs.is_forward_declaration && cu_language == eLanguageTypeObjC) { adrian-prantl wrote: You'

[Lldb-commits] [lldb] [WIP][lldb][DWARFASTParserClang] Eagerly search definitions for Objective-C classes (PR #119860)

2024-12-13 Thread Adrian Prantl via lldb-commits
@@ -1671,43 +1671,84 @@ DWARFASTParserClang::ParseStructureLikeDIE(const SymbolContext &sc, attrs.is_forward_declaration = true; } + DWARFDIE def_die; + if (attrs.is_forward_declaration && cu_language == eLanguageTypeObjC) { +def_die = dwarf->FindDefinitionDIE(die

[Lldb-commits] [lldb] Convert the StackFrameList mutex to a shared mutex. (PR #117252)

2024-12-13 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > Yeah, I don’t disagree with that - and we’re at C++17 now already. Anyway, > requiring 10.12 from 2016 seems reasonable to me. Especially since nobody needs to run LLDB locally in order to do debugging. If you really want to debug with the very latest LLDB on a 10 year o

[Lldb-commits] [lldb] [lldb] Add a progress event for executing an expression (PR #119757)

2024-12-13 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/119757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support zero-padding in formatter sections (PR #119934)

2024-12-13 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/119934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] CompleteType: Lookup type in the declaration DIE's SymbolFile (PR #120569)

2024-12-19 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/120569 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] CompleteType: Lookup type in the declaration DIE's SymbolFile (PR #120569)

2024-12-19 Thread Adrian Prantl via lldb-commits
@@ -1593,7 +1593,9 @@ bool SymbolFileDWARF::CompleteType(CompilerType &compiler_type) { DWARFASTParser *dwarf_ast = GetDWARFParser(*def_die.GetCU()); if (!dwarf_ast) return false; - Type *type = GetDIEToType().lookup(decl_die.GetDIE()); + Type *type = decl_die.GetDWA

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

2024-12-20 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/120784 >From 88f6c19a87e82f1cc0c589029d8eb288ec53eaba Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 20 Dec 2024 10:35:47 -0800 Subject: [PATCH] [lldb] Expose structured errors in SBError Building on to

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

2024-12-20 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > LGTM. nit: I'd have called the API `SBError::GetStructuredError`. I have no strong feelings about this — I chose GetErrorData, because that's what `SBStructuredData SBCommandReturnObject::GetErrorData()` is called. https://github.com/llvm/llvm-project/pull/120784 ___

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

2024-12-20 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

2024-12-20 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/120784 Building on top of previous work that exposed expression diagnostics via SBCommandReturnObject, this patch generalizes the support to expose any SBError as machine-readable structured data. One use-case o

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

2024-12-20 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/120784 >From 59e2d804d49b549f0d3679caf72ed29493e8fd01 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 20 Dec 2024 10:35:47 -0800 Subject: [PATCH] [lldb] Expose structured errors in SBError Building on to

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

2024-12-20 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/120784 >From 3113275ebe67a970ec01c380153fc6b9814ee939 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 20 Dec 2024 10:35:47 -0800 Subject: [PATCH] [lldb] Expose structured errors in SBError Building on to

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Adrian Prantl via lldb-commits
@@ -339,12 +339,9 @@ void REPL::IOHandlerInputComplete(IOHandler &io_handler, std::string &code) { const char *expr_prefix = nullptr; lldb::ValueObjectSP result_valobj_sp; + lldb::ExpressionResults execution_results = UserExpression::Evaluate( + exe_

[Lldb-commits] [lldb] [lldb] Fix a regression in Status::GetErrorType() (PR #117095)

2024-11-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/117095 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a regression in SBValue::GetObjectDescription() (PR #117242)

2024-11-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/117242 >From dc8c3877594a513329a2b920b31f314684e6337c Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 21 Nov 2024 13:14:29 -0800 Subject: [PATCH] [lldb] Fix a regression in SBValue::GetObjectDescription()

[Lldb-commits] [lldb] [lldb] Fix a regression in SBValue::GetObjectDescription() (PR #117242)

2024-11-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/117242 >From e4a6563c21c251954b077a27b8375028134aa2f8 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 21 Nov 2024 13:14:29 -0800 Subject: [PATCH] [lldb] Fix a regression in SBValue::GetObjectDescription()

[Lldb-commits] [lldb] [lldb] Fix a regression in SBValue::GetObjectDescription() (PR #117242)

2024-11-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/117242 The old behavior was to return a null string in the error case,when refactoring the error handling I thought it would be a good idea to print the error in the description, but that breaks clients that try

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/117186 Prior to this patch, the function returned an exit status, sometimes a ValueObject with an error and a Status object. This patch removes the Status object and ensures the error is consistently returned as

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Adrian Prantl via lldb-commits
@@ -144,9 +144,13 @@ lldb::ExpressionResults UserExpression::Evaluate(ExecutionContext &exe_ctx, const EvaluateExpressionOptions &options, llvm::StringRef expr, llvm::StringRef prefix, - lldb::ValueObject

[Lldb-commits] [lldb] [lldb] Refactor UserExpression::Evaluate to only have one error channel. (PR #117186)

2024-11-21 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/117186 >From 208fa0afd563506c91afb320ff6cca4fa579c36a Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 21 Nov 2024 08:32:06 -0800 Subject: [PATCH] [lldb] Refactor UserExpression::Evaluate to only have one

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/119022 >From 60ab35f50652e761d465cc1410b8d3352fa86b3f Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 6 Dec 2024 12:09:27 -0800 Subject: [PATCH] [lldb] Add a per-CU API to read the SDK. This is needed by

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
@@ -1429,3 +1430,40 @@ PlatformDarwin::ResolveSDKPathFromDebugInfo(Module &module) { return path_or_err->str(); } + +llvm::Expected> +PlatformDarwin::GetSDKPathFromDebugInfo(CompileUnit &unit) { + ModuleSP module_sp = unit.CalculateSymbolContextModule(); + if (!module_sp)

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/119022 >From 60ab35f50652e761d465cc1410b8d3352fa86b3f Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 6 Dec 2024 12:09:27 -0800 Subject: [PATCH 1/2] [lldb] Add a per-CU API to read the SDK. This is neede

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
@@ -473,6 +473,32 @@ class Platform : public PluginInterface { LLVM_PRETTY_FUNCTION, GetName())); } + /// Search CU for the SDK path the CUs was compiled against. + /// + /// \param[in] unit The CU + /// + /// \returns If successful, returns a pars

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/119022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-12-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From 7e3da87ca896484a11ac09df297183147154ac91 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH] [lldb] Add a compiler/interpreter of LLDB data formatter

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-12-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/113398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
@@ -473,6 +473,32 @@ class Platform : public PluginInterface { LLVM_PRETTY_FUNCTION, GetName())); } + /// Search CU for the SDK path the CUs was compiled against. + /// + /// \param[in] unit The CU + /// + /// \returns A parsed XcodeSDK object if s

[Lldb-commits] [lldb] 8ab76a4 - Revert "[lldb] Add a compiler/interpreter of LLDB data formatter bytecode to examples"

2024-12-06 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-12-06T15:34:12-08:00 New Revision: 8ab76a47b242addc82109a3b3b6de9c3d6426eca URL: https://github.com/llvm/llvm-project/commit/8ab76a47b242addc82109a3b3b6de9c3d6426eca DIFF: https://github.com/llvm/llvm-project/commit/8ab76a47b242addc82109a3b3b6de9c3d6426eca.diff

[Lldb-commits] [lldb] 9f98949 - [lldb] Move the python module import workaround further up

2024-12-06 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-12-06T17:01:58-08:00 New Revision: 9f98949c9424addbc573fac7912cc164965b8994 URL: https://github.com/llvm/llvm-project/commit/9f98949c9424addbc573fac7912cc164965b8994 DIFF: https://github.com/llvm/llvm-project/commit/9f98949c9424addbc573fac7912cc164965b8994.diff

[Lldb-commits] [lldb] 60380cd - [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to examples

2024-12-06 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-12-06T16:10:09-08:00 New Revision: 60380cd27c6fa5ed6e39866c51b18a64bc4d566a URL: https://github.com/llvm/llvm-project/commit/60380cd27c6fa5ed6e39866c51b18a64bc4d566a DIFF: https://github.com/llvm/llvm-project/commit/60380cd27c6fa5ed6e39866c51b18a64bc4d566a.diff

[Lldb-commits] [lldb] b504c87 - Revert "[lldb] Add a compiler/interpreter of LLDB data formatter bytecode to examples"

2024-12-06 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-12-06T16:26:55-08:00 New Revision: b504c8771f238883ef6c7234d741c2dc1d885ae3 URL: https://github.com/llvm/llvm-project/commit/b504c8771f238883ef6c7234d741c2dc1d885ae3 DIFF: https://github.com/llvm/llvm-project/commit/b504c8771f238883ef6c7234d741c2dc1d885ae3.diff

[Lldb-commits] [lldb] fffe8c6 - [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to examples

2024-12-06 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-12-06T16:27:16-08:00 New Revision: fffe8c668461e73055182f229765cb7de908e295 URL: https://github.com/llvm/llvm-project/commit/fffe8c668461e73055182f229765cb7de908e295 DIFF: https://github.com/llvm/llvm-project/commit/fffe8c668461e73055182f229765cb7de908e295.diff

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
@@ -1429,3 +1430,40 @@ PlatformDarwin::ResolveSDKPathFromDebugInfo(Module &module) { return path_or_err->str(); } + +llvm::Expected> +PlatformDarwin::GetSDKPathFromDebugInfo(CompileUnit &unit) { + ModuleSP module_sp = unit.CalculateSymbolContextModule(); + if (!module_sp)

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-12-05 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From ca04cd4dbdba506ddc1f4816922819d0bfe3f1eb Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH] Add a compiler/interpreter of LLDB data formatter bytecode

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/119022 None >From aadb454d36e4c5058fffcc946a9ce97d7e25bf39 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 6 Dec 2024 12:09:27 -0800 Subject: [PATCH] [lldb] Add a per-CU API to read the SDK --- lldb/in

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

2024-12-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/119022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add missing operations to GetOpcodeDataSize (PR #120163)

2025-01-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/120163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add missing operations to GetOpcodeDataSize (PR #120163)

2025-01-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl commented: I found one bug, otherwise this looks good! https://github.com/llvm/llvm-project/pull/120163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb] Add missing operations to GetOpcodeDataSize (PR #120163)

2025-01-23 Thread Adrian Prantl via lldb-commits
@@ -327,27 +358,45 @@ static lldb::offset_t GetOpcodeDataSize(const DataExtractor &data, return offset - data_offset; } + case DW_OP_implicit_pointer: // 0xa0 4 + LEB128 + { +data.Skip_LEB128(&offset); +return 4 + offset - data_offset; adrian-

[Lldb-commits] [lldb] 8f18f36 - [lldb] Skip unreliable test under ASAN

2025-01-17 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2025-01-17T13:27:11-08:00 New Revision: 8f18f36b4906872ee0838ade2c0367c77b6f5bc0 URL: https://github.com/llvm/llvm-project/commit/8f18f36b4906872ee0838ade2c0367c77b6f5bc0 DIFF: https://github.com/llvm/llvm-project/commit/8f18f36b4906872ee0838ade2c0367c77b6f5bc0.diff

[Lldb-commits] [lldb] [lldb][test] Remove compiler version check and use regex (PR #123393)

2025-01-21 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: ``` Got output: (std::vector, std::allocator > >) $0 = size=2 { [0] = size=3 { [0] = 1 [1] = 2 [2] = 3 } [1] = size=3 { [0] = 3 [1] = 2 [2] = 1 } } Expecting regex pattern: "\(std::vector(, std::allocator )* >\) \$0 = size=2 \{ \[0\] = siz

[Lldb-commits] [lldb] [lldb][test] Remove compiler version check and use regex (PR #123393)

2025-01-21 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Generally speaking, it would be a lot more robust to not try and write a regex for the output, but individually check the summary/type for main node and children. https://github.com/llvm/llvm-project/pull/123393 ___ lldb-commits

[Lldb-commits] [lldb] [lldb] Handle a byte size of zero in CompilerType::GetValueAsScalar (PR #123107)

2025-01-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Either returning true or false is perfectly fine. The only argument I can come up for returning true is that now all call sites need to replicate this check as to not call this function with a size of 0. https://github.com/llvm/llvm-

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-16 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,106 @@ +//===-- DILEval.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-16 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,102 @@ +//===-- DILParser.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-16 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,296 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-03-15 Thread Adrian Prantl via lldb-commits
@@ -68,11 +68,9 @@ static bool CharStringSummaryProvider(ValueObject &valobj, Stream &stream) { template static bool CharSummaryProvider(ValueObject &valobj, Stream &stream) { - DataExtractor data; - Status error; - valobj.GetData(data, error); + auto data_or_err = valob

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-03-18 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > It would be useful to know if you can reproduce this problem locally (because > I can't -- the test passes on my mac). If you can't then it would be useful > to get as much information about this buildbot as possible (what kind of > debugserver it uses, OS versions and s

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-03-18 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: May I recommend we add a skip for macOS < 15 to get the bot green again? https://github.com/llvm/llvm-project/pull/128156 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP: DO NOT MERGE] [lldb][Format] Add option to highlight function names in backtraces (PR #131836)

2025-03-18 Thread Adrian Prantl via lldb-commits
@@ -83,6 +99,127 @@ class OutputBuffer { return std::string_view(Buffer, CurrentPosition); } + // Stores information about parts of a demangled function name. + struct FunctionNameInfo { +///< A [start, end) pair for the function basename. adrian-p

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP: DO NOT MERGE] [lldb][Format] Add option to highlight function names in backtraces (PR #131836)

2025-03-18 Thread Adrian Prantl via lldb-commits
@@ -83,6 +99,127 @@ class OutputBuffer { return std::string_view(Buffer, CurrentPosition); } + // Stores information about parts of a demangled function name. adrian-prantl wrote: ```suggestion /// Stores information about parts of a demangled functi

[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP: DO NOT MERGE] [lldb][Format] Add option to highlight function names in backtraces (PR #131836)

2025-03-18 Thread Adrian Prantl via lldb-commits
@@ -138,10 +139,10 @@ class CPlusPlusLanguage : public Language { ConstString GetDemangledFunctionNameWithoutArguments(Mangled mangled) const override; - bool GetFunctionDisplayName(const SymbolContext *sc, - const ExecutionContext *exe_ctx, -

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-03-17 Thread Adrian Prantl via lldb-commits
@@ -540,9 +537,9 @@ class EntityVariableBase : public Materializer::Entity { return; } -if (data.GetByteSize() < +if (data_or_err->GetByteSize() < adrian-prantl wrote: I like to add a ``` auto data = *data_or_err; ``` than t

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-03-17 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/130516 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-03-17 Thread Adrian Prantl via lldb-commits
@@ -207,15 +207,13 @@ lldb::ValueObjectSP lldb_private::formatters:: return lldb::ValueObjectSP(); StreamString stream; stream.Printf("[%" PRIu64 "]", (uint64_t)idx); - DataExtractor data; - Status error; - val_hash.first->GetData(data, error); - if (error.Fail()) +

<    11   12   13   14   15   16   17   18   >