[Lldb-commits] [lldb] r341080 - Remove redundant initialization

Author: adrian Date: Thu Aug 30 08:39:08 2018 New Revision: 341080 URL: http://llvm.org/viewvc/llvm-project?rev=341080&view=rev Log: Remove redundant initialization Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Modified: lldb/trunk/source/Plugins/Expre

Re: [Lldb-commits] [lldb] r341080 - Remove redundant initialization

t.org <http://swift.org/> branch of LLDB and I'm always trying to remove pointless differences between the two branches. > > Also, if we want to do this kind of cleanup, m_compiler initialization is > also redundant. That's a fair point! -- adrian > > On Thu, Aug

[Lldb-commits] [lldb] r341506 - Print column info in backtraces et al. if available

Author: adrian Date: Wed Sep 5 16:52:08 2018 New Revision: 341506 URL: http://llvm.org/viewvc/llvm-project?rev=341506&view=rev Log: Print column info in backtraces et al. if available This patch allows LLDB to print column info in backtraces et al. if available, which is useful when the backtrac

Re: [Lldb-commits] [lldb] r319653 - Makefile.rules: compile all tests with -fno-limit-debug-info

> On Dec 6, 2017, at 9:35 AM, Robinson, Paul wrote: > >> -Original Message- >> From: Pavel Labath [mailto:lab...@google.com] >> Sent: Wednesday, December 06, 2017 4:09 AM >> To: Jason Molenda >> Cc: lldb-commits@lists.llvm.org; Robinson, Paul >> Subject: Re: [Lldb-commits] [lldb] r31965

[Lldb-commits] [lldb] r321095 - Temporarily XFAIL test/functionalities/exec while investiagting bot breakage.

Author: adrian Date: Tue Dec 19 10:21:28 2017 New Revision: 321095 URL: http://llvm.org/viewvc/llvm-project?rev=321095&view=rev Log: Temporarily XFAIL test/functionalities/exec while investiagting bot breakage. When building with cmake on green gragon or on ci.swift.org, this test fails. rdar://

[Lldb-commits] [lldb] r321120 - Fix a couple of warnings (NFC)

Author: adrian Date: Tue Dec 19 14:54:37 2017 New Revision: 321120 URL: http://llvm.org/viewvc/llvm-project?rev=321120&view=rev Log: Fix a couple of warnings (NFC) Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp lldb/trunk/source/Plugins/Process/gdb-remote/G

[Lldb-commits] [lldb] r321123 - Replace an accidentally added "break" with an LLVM_FALLTHROUGH.

Author: adrian Date: Tue Dec 19 15:16:38 2017 New Revision: 321123 URL: http://llvm.org/viewvc/llvm-project?rev=321123&view=rev Log: Replace an accidentally added "break" with an LLVM_FALLTHROUGH. Thanks to Greg Clayton for catchting this! Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger

[Lldb-commits] [lldb] r321322 - Bring clang options in error messages up to date.

Author: adrian Date: Thu Dec 21 15:04:51 2017 New Revision: 321322 URL: http://llvm.org/viewvc/llvm-project?rev=321322&view=rev Log: Bring clang options in error messages up to date. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Modified: lldb/trunk/source/Plug

[Lldb-commits] [lldb] r321802 - Look for external types in all clang modules imported by the current symbol file.

Author: adrian Date: Thu Jan 4 08:42:05 2018 New Revision: 321802 URL: http://llvm.org/viewvc/llvm-project?rev=321802&view=rev Log: Look for external types in all clang modules imported by the current symbol file. This fixes a bug in -gmodules DWARF handling when debugging without a .dSYM bund

[Lldb-commits] [lldb] r323219 - Move getBuildArtifact() from TestBase to Base and derive MiTestCaseBase from it

Author: adrian Date: Tue Jan 23 08:43:01 2018 New Revision: 323219 URL: http://llvm.org/viewvc/llvm-project?rev=323219&view=rev Log: Move getBuildArtifact() from TestBase to Base and derive MiTestCaseBase from it Thanks to Pavel Labath for pointing this out! Modified: lldb/trunk/packages/Pyt

[Lldb-commits] [lldb] r323789 - Enforce that tests building with buildDefault set NO_DEBUG_INFO_TESTCASE

Author: adrian Date: Tue Jan 30 09:02:42 2018 New Revision: 323789 URL: http://llvm.org/viewvc/llvm-project?rev=323789&view=rev Log: Enforce that tests building with buildDefault set NO_DEBUG_INFO_TESTCASE and fix resulting errors. This is a prerequisite for building each test variant in its own

[Lldb-commits] [lldb] r323808 - Add more diagnostics to help diagnose flaky test

Author: adrian Date: Tue Jan 30 11:40:09 2018 New Revision: 323808 URL: http://llvm.org/viewvc/llvm-project?rev=323808&view=rev Log: Add more diagnostics to help diagnose flaky test Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestBadAddr

[Lldb-commits] [lldb] r323830 - Enforce that NO_DEBUG_INFO_TESTCASEs build using buildDefault().

Author: adrian Date: Tue Jan 30 15:15:49 2018 New Revision: 323830 URL: http://llvm.org/viewvc/llvm-project?rev=323830&view=rev Log: Enforce that NO_DEBUG_INFO_TESTCASEs build using buildDefault(). This is a prerequisite for building each test variant in its own subdirectory. Modified: lldb/

[Lldb-commits] [lldb] r323917 - replace os.mkdirs with lldbutil.mkdir_p (NFC)

Author: adrian Date: Wed Jan 31 13:39:00 2018 New Revision: 323917 URL: http://llvm.org/viewvc/llvm-project?rev=323917&view=rev Log: replace os.mkdirs with lldbutil.mkdir_p (NFC) Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestProcessLaunch.py lldb

[Lldb-commits] [lldb] r324019 - Create a marker for Spotlight to never index $BUILD_DIR.

Author: adrian Date: Thu Feb 1 14:18:02 2018 New Revision: 324019 URL: http://llvm.org/viewvc/llvm-project?rev=324019&view=rev Log: Create a marker for Spotlight to never index $BUILD_DIR. LLDB queries Spotlight to locate .dSYM bundles based on the UUID embedded in a binary, and because the UUID

[Lldb-commits] [lldb] r324115 - Use an alternative approach to prevent Spotlight from indexing the build directory.

Author: adrian Date: Fri Feb 2 10:32:29 2018 New Revision: 324115 URL: http://llvm.org/viewvc/llvm-project?rev=324115&view=rev Log: Use an alternative approach to prevent Spotlight from indexing the build directory. Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py lldb/trun

[Lldb-commits] [lldb] r324281 - CMake: fix build directory name in clean rule

Author: adrian Date: Mon Feb 5 14:35:46 2018 New Revision: 324281 URL: http://llvm.org/viewvc/llvm-project?rev=324281&view=rev Log: CMake: fix build directory name in clean rule Modified: lldb/trunk/test/CMakeLists.txt Modified: lldb/trunk/test/CMakeLists.txt URL: http://llvm.org/viewvc/ll

[Lldb-commits] [lldb] r324368 - Build each testcase variant in its own subdirectory and remove the srcdir lock file

Author: adrian Date: Tue Feb 6 10:22:51 2018 New Revision: 324368 URL: http://llvm.org/viewvc/llvm-project?rev=324368&view=rev Log: Build each testcase variant in its own subdirectory and remove the srcdir lock file This patch creates a .dwarf, .dwo, etc., build directory for each testcase vari

[Lldb-commits] [lldb] r324396 - Pass --build-dir to dotest in the Xcode project

Author: adrian Date: Tue Feb 6 12:48:35 2018 New Revision: 324396 URL: http://llvm.org/viewvc/llvm-project?rev=324396&view=rev Log: Pass --build-dir to dotest in the Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: h

[Lldb-commits] [lldb] r324400 - Remove obsolete file

Author: adrian Date: Tue Feb 6 13:04:06 2018 New Revision: 324400 URL: http://llvm.org/viewvc/llvm-project?rev=324400&view=rev Log: Remove obsolete file Removed: lldb/trunk/packages/Python/lldbsuite/test/bench-history Modified: lldb/trunk/packages/Python/lldbsuite/test/bench.py Removed:

Re: [Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

> On Feb 7, 2018, at 6:40 PM, Zachary Turner wrote: > and the command line in the log file doesn’t ever work for me' That's a bug. Can you show me an example where this breaks for you? I'd like to investigate this. -- adrian ___ lldb-commits maili

[Lldb-commits] [lldb] r324655 - Rewrite testcase to not depend on Foundation implementation details.

Author: adrian Date: Thu Feb 8 13:52:28 2018 New Revision: 324655 URL: http://llvm.org/viewvc/llvm-project?rev=324655&view=rev Log: Rewrite testcase to not depend on Foundation implementation details. TODO: Add a separate testcase testing *only* Foundation implementation details! Added:

[Lldb-commits] [lldb] r324775 - Make LLDB's clang module cache path customizable

Author: adrian Date: Fri Feb 9 14:08:26 2018 New Revision: 324775 URL: http://llvm.org/viewvc/llvm-project?rev=324775&view=rev Log: Make LLDB's clang module cache path customizable This patch makes LLDB's clang module cache path customizable via settings set target.clang-modules-cache-path and

[Lldb-commits] [lldb] r326140 - Add a sanity check for inline testcases.

Author: adrian Date: Mon Feb 26 14:40:20 2018 New Revision: 326140 URL: http://llvm.org/viewvc/llvm-project?rev=326140&view=rev Log: Add a sanity check for inline testcases. When writing an inline test, there is no way to make sure that any of the inline commands are actually executed, so this pa

Re: [Lldb-commits] [lldb] r323803 - Compile the LLDB tests out-of-tree.

ls.classCleanup() > File "/Users/vsk/src/llvm.org > <http://llvm.org/>-lldbsan/llvm/tools/lldb/packages/Python/lldbsuite/test/settings/quoting/TestQuoting.py", > line 25, in classCleanup > cls.RemoveTempFile(self.getBuildArtifact("stdout.txt")) > NameError

Re: [Lldb-commits] [lldb] r323803 - Compile the LLDB tests out-of-tree.

dbtest.py", >>>> line 584, in tearDownClass >>>> cls.classCleanup() >>>> File "/Users/vsk/src/llvm.org >>>> <http://llvm.org/>-lldbsan

Re: [Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

> On Mar 1, 2018, at 10:25 AM, Jim Ingham wrote: > > I have no general objections to macros, and reducing boiler-plate is good. > They do get in the way of debugging because of the weird C rule that a macro > has to pretend that it is all one source line, so if they contain code you > are in

Re: [Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

> On Mar 1, 2018, at 10:44 AM, Pavel Labath wrote: > > On 1 March 2018 at 10:34, Adrian Prantl wrote: >> >>> On Mar 1, 2018, at 10:25 AM, Jim Ingham wrote: >>> >>> I have no general objections to macros, and reducing boiler-plate is good. >>> They do get in the way of debugging because of

[Lldb-commits] [lldb] r326628 - Make the clang module cache setting available without a target

Author: adrian Date: Fri Mar 2 14:42:44 2018 New Revision: 326628 URL: http://llvm.org/viewvc/llvm-project?rev=326628&view=rev Log: Make the clang module cache setting available without a target It turns out that setting the clang module cache after LLDB has a Target can be too late. In particul

[Lldb-commits] [lldb] r326634 - Don't compile testcase with clang modules enabled.

Author: adrian Date: Fri Mar 2 15:15:04 2018 New Revision: 326634 URL: http://llvm.org/viewvc/llvm-project?rev=326634&view=rev Log: Don't compile testcase with clang modules enabled. It isn't actually necessary for what we are testing here and should fix the test on the Linux bots. Modified:

[Lldb-commits] [lldb] r326640 - Mark ObjC testcase as skipUnlessDarwin and fix a typo in test function.

Author: adrian Date: Fri Mar 2 15:57:09 2018 New Revision: 326640 URL: http://llvm.org/viewvc/llvm-project?rev=326640&view=rev Log: Mark ObjC testcase as skipUnlessDarwin and fix a typo in test function. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangMo

[Lldb-commits] [lldb] r326743 - Fix the install location of LLDBWrapPython.cpp when building

Author: adrian Date: Mon Mar 5 13:08:42 2018 New Revision: 326743 URL: http://llvm.org/viewvc/llvm-project?rev=326743&view=rev Log: Fix the install location of LLDBWrapPython.cpp when building LLDB.framework to point to the build directory where it is expected by the top-level CMakeLists.txt. Th

[Lldb-commits] [lldb] r326754 - LLDBStandalone.cmake: set path to llvm-lit inside of llvm build dir

Author: adrian Date: Mon Mar 5 15:57:46 2018 New Revision: 326754 URL: http://llvm.org/viewvc/llvm-project?rev=326754&view=rev Log: LLDBStandalone.cmake: set path to llvm-lit inside of llvm build dir Modified: lldb/trunk/cmake/modules/LLDBStandalone.cmake Modified: lldb/trunk/cmake/modules/

[Lldb-commits] [lldb] r326847 - Add test for lldb-mi interpreter

Author: adrian Date: Tue Mar 6 15:25:04 2018 New Revision: 326847 URL: http://llvm.org/viewvc/llvm-project?rev=326847&view=rev Log: Add test for lldb-mi interpreter Test that "lldb-mi --interpreter" can interpret "target list" CLI command. Patch by Alex Polyakov! Differential Revision: https:/

[Lldb-commits] [lldb] r327193 - Rename clang.modules-cache-path to symbols.clang-modules-cache-path

Author: adrian Date: Fri Mar 9 17:11:25 2018 New Revision: 327193 URL: http://llvm.org/viewvc/llvm-project?rev=327193&view=rev Log: Rename clang.modules-cache-path to symbols.clang-modules-cache-path I want to extend the properties on ModuleList to also contain other more general settings and re

[Lldb-commits] [lldb] r327330 - Introduce a setting to disable Spotlight while running the test suite

Author: adrian Date: Mon Mar 12 13:52:36 2018 New Revision: 327330 URL: http://llvm.org/viewvc/llvm-project?rev=327330&view=rev Log: Introduce a setting to disable Spotlight while running the test suite This is a more principled approach to disabling Spotlight .dSYM lookups while running the test

[Lldb-commits] [lldb] r327644 - Split skipIf decorator, the condition is supposed to be OR

Author: adrian Date: Thu Mar 15 10:07:05 2018 New Revision: 327644 URL: http://llvm.org/viewvc/llvm-project?rev=327644&view=rev Log: Split skipIf decorator, the condition is supposed to be OR Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-auto-import/TestModulesAutoImp

[Lldb-commits] [lldb] r327729 - Remove -gmodules restriction from test

Author: adrian Date: Fri Mar 16 11:21:48 2018 New Revision: 327729 URL: http://llvm.org/viewvc/llvm-project?rev=327729&view=rev Log: Remove -gmodules restriction from test Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-auto-import/TestModulesAutoImport.py Modified: l

[Lldb-commits] [lldb] r328365 - Log ObjC Runtime messages only in verbose mode

Author: adrian Date: Fri Mar 23 13:17:39 2018 New Revision: 328365 URL: http://llvm.org/viewvc/llvm-project?rev=328365&view=rev Log: Log ObjC Runtime messages only in verbose mode Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp Modified: lld

[Lldb-commits] [lldb] r328557 - Fix check for verbose logging.

Author: adrian Date: Mon Mar 26 10:40:44 2018 New Revision: 328557 URL: http://llvm.org/viewvc/llvm-project?rev=328557&view=rev Log: Fix check for verbose logging. Thanks to Pavel for pointing this out! Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRunti

Re: [Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

> On Apr 4, 2018, at 8:53 AM, Pavel Labath wrote: > > > > On Wed, 4 Apr 2018 at 16:47, Zachary Turner > wrote: > > On Wed, Apr 4, 2018 at 8:11 AM Jonas Devlieghere via Phabricator > mailto:revi...@reviews.llvm.org>> wrote: > JDevlieghere added a comment. > > In

Re: [Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

> On Apr 4, 2018, at 9:07 AM, Zachary Turner wrote: > > Sure, but getting lit to run one file at a time is a nice incremental step > towards that and can make both patches easier to review. Agreed, I just want to make sure that we are all on the same page as to which direction we want to evo

Re: [Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit

> On Apr 6, 2018, at 9:32 AM, Davide Italiano wrote: > > On Fri, Apr 6, 2018 at 1:02 AM, Jan Kratochvil via Phabricator > wrote: >> jankratochvil added a comment. >> >> I disagree with this patch as `DWARFUnit` was a lightweight wrapper for >> `DWARFPartialUnit`. Now I will have to create s

Re: [Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit

> On Apr 6, 2018, at 1:52 PM, Greg Clayton wrote: > > > >> On Apr 6, 2018, at 10:32 AM, Jan Kratochvil >> wrote: >> >> On Fri, 06 Apr 2018 18:58:27 +0200, Davide Italiano wrote: >>> Yes, I definitely agree. It's clear this needs more discussion, so I >>> don't think it's reasonable if we r

[Lldb-commits] [lldb] r330450 - Fix a crash when resolving overloads of C++ virtual methods.

Author: adrian Date: Fri Apr 20 10:14:05 2018 New Revision: 330450 URL: http://llvm.org/viewvc/llvm-project?rev=330450&view=rev Log: Fix a crash when resolving overloads of C++ virtual methods. The isOverload() method needs to account for situations where the two methods being compared don't have

Re: [Lldb-commits] [PATCH] D46005: [test] Add a utility for dumping all tests in the dotest suite

Disregarding the added complexity I believe that being able to communicate the number of tests filed/passed inside a single file would be very valuable. For example when one test gets broken by upstream clang changes and it takes a few days to fix it properly, we don't want to loose signal on th

Re: [Lldb-commits] [PATCH] D46005: [test] Add a utility for dumping all tests in the dotest suite

> On Apr 25, 2018, at 9:08 AM, Zachary Turner wrote: > > But is there a reason why that is more valuable with LLDB than it is with > LLVM? In LLVM when a test fails it stops and doesn't run subsequent run > lines. So you have the same issue there. That's not a good analogy. Multiple RUN l

[Lldb-commits] [lldb] r331230 - Remove premature caching of the global variables list in CompileUnit.

Author: adrian Date: Mon Apr 30 14:54:02 2018 New Revision: 331230 URL: http://llvm.org/viewvc/llvm-project?rev=331230&view=rev Log: Remove premature caching of the global variables list in CompileUnit. This fixes a bug where (lldb) target var g_ptr would populate the global variables list wi

[Lldb-commits] [lldb] r331235 - Refactor GetNextPersistentVariableName into a non-virtual method

Author: adrian Date: Mon Apr 30 16:59:17 2018 New Revision: 331235 URL: http://llvm.org/viewvc/llvm-project?rev=331235&view=rev Log: Refactor GetNextPersistentVariableName into a non-virtual method that takes a prefix string. This simplifies the implementation and allows plugins such as the Swift

[Lldb-commits] [lldb] r331234 - Move the persistent variable counter into Target

Author: adrian Date: Mon Apr 30 16:59:15 2018 New Revision: 331234 URL: http://llvm.org/viewvc/llvm-project?rev=331234&view=rev Log: Move the persistent variable counter into Target so it can be shared across multiple language plugins. In a multi-language project it is counterintuitive to have a

[Lldb-commits] [lldb] r331270 - Remove redundant command.

Author: adrian Date: Tue May 1 08:38:01 2018 New Revision: 331270 URL: http://llvm.org/viewvc/llvm-project?rev=331270&view=rev Log: Remove redundant command. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py Modified: lldb/trunk/packages/Py

[Lldb-commits] [lldb] r331375 - Silence compiler warning.

Author: adrian Date: Wed May 2 10:11:43 2018 New Revision: 331375 URL: http://llvm.org/viewvc/llvm-project?rev=331375&view=rev Log: Silence compiler warning. Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp URL: http://

[Lldb-commits] [lldb] r331462 - DWARFExpression: Convert file addresses to load addresses early on.

Author: adrian Date: Thu May 3 09:51:37 2018 New Revision: 331462 URL: http://llvm.org/viewvc/llvm-project?rev=331462&view=rev Log: DWARFExpression: Convert file addresses to load addresses early on. This is a change that only affects Swift and is NFC for the language plugins on llvm.org. In Swi

[Lldb-commits] [lldb] r331479 - Add back condition that was accidentally removed in r331462.

Author: adrian Date: Thu May 3 13:13:58 2018 New Revision: 331479 URL: http://llvm.org/viewvc/llvm-project?rev=331479&view=rev Log: Add back condition that was accidentally removed in r331462. This should make the bots much happier. Modified: lldb/trunk/source/Core/ValueObjectVariable.cpp

[Lldb-commits] [lldb] r331480 - Revert "DWARFExpression: Convert file addresses to load addresses early on."

Author: adrian Date: Thu May 3 13:19:39 2018 New Revision: 331480 URL: http://llvm.org/viewvc/llvm-project?rev=331480&view=rev Log: Revert "DWARFExpression: Convert file addresses to load addresses early on." This reverts commit 331462 while investigating bot breakage. Modified: lldb/trunk/

[Lldb-commits] [lldb] r331492 - DWARFExpression: Convert file addresses to load addresses early on.

Author: adrian Date: Thu May 3 16:32:47 2018 New Revision: 331492 URL: http://llvm.org/viewvc/llvm-project?rev=331492&view=rev Log: DWARFExpression: Convert file addresses to load addresses early on. This is a change that only affects Swift and is NFC for the language plugins on llvm.org. In Swi

Re: [Lldb-commits] [RFC] Type lookup for template types is broken...

I made a small experiment where I manually edited the DW_AT_name in the assembler output: Baseline: $ lldb with_params (lldb) target create "with_params" (lldb) b 5 (lldb) r Process 28369 stopped * thread #1, name = 'with_params', stop reason = breakpoint 1.1 frame #0: 0x004004fc wi

Re: [Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

> On Jul 22, 2017, at 2:26 PM, David Blaikie wrote: > > > > On Fri, Jul 21, 2017 at 6:14 PM Jim Ingham > wrote: > Not at present, but you presumably know more about this than I do. Part of > the point of Greg's extracting the DWARF parser from lldb and making it in

[Lldb-commits] [lldb] r308850 - Fix PR33875 by distinguishing between DWO and clang modules

Author: adrian Date: Sun Jul 23 10:59:07 2017 New Revision: 308850 URL: http://llvm.org/viewvc/llvm-project?rev=308850&view=rev Log: Fix PR33875 by distinguishing between DWO and clang modules The DWO handling code can get confused by clang modules which also use skeleton CUs to point to the obje

[Lldb-commits] [lldb] r308851 - Revert "Fix PR33875 by distinguishing between DWO and clang modules"

Author: adrian Date: Sun Jul 23 13:24:41 2017 New Revision: 308851 URL: http://llvm.org/viewvc/llvm-project?rev=308851&view=rev Log: Revert "Fix PR33875 by distinguishing between DWO and clang modules" This reverts commit r308850. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp

[Lldb-commits] [lldb] r308905 - RFix PR33875 by distinguishing between DWO and clang modules.

Author: adrian Date: Mon Jul 24 11:06:39 2017 New Revision: 308905 URL: http://llvm.org/viewvc/llvm-project?rev=308905&view=rev Log: RFix PR33875 by distinguishing between DWO and clang modules. This reapplies https://reviews.llvm.org/D35740 with a tweak to find the section by name rather than ty

[Lldb-commits] [lldb] r309019 - Improve the fix for PR33875 by not hardcoding the section name.

Author: adrian Date: Tue Jul 25 13:12:25 2017 New Revision: 309019 URL: http://llvm.org/viewvc/llvm-project?rev=309019&view=rev Log: Improve the fix for PR33875 by not hardcoding the section name. This is a follow-up to r308905. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileD

[Lldb-commits] [lldb] r350876 - lldbtest.py: try to fix a runtime exception

Author: adrian Date: Thu Jan 10 11:06:46 2019 New Revision: 350876 URL: http://llvm.org/viewvc/llvm-project?rev=350876&view=rev Log: lldbtest.py: try to fix a runtime exception found on http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/32/consoleFull#15046896708254eaf0-7326-4999-85b

[Lldb-commits] [lldb] r351215 - Silence compiler warnings

Author: adrian Date: Tue Jan 15 10:07:54 2019 New Revision: 351215 URL: http://llvm.org/viewvc/llvm-project?rev=351215&view=rev Log: Silence compiler warnings Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp lldb/trunk/source/Plugins/Platform/MacOSX/Platfor

[Lldb-commits] [lldb] r351237 - Replace auto -> llvm::Optional

Author: adrian Date: Tue Jan 15 12:33:58 2019 New Revision: 351237 URL: http://llvm.org/viewvc/llvm-project?rev=351237&view=rev Log: Replace auto -> llvm::Optional This addresses post-commit feedback for https://reviews.llvm.org/D56688 Modified: lldb/trunk/source/API/SBType.cpp lldb/trun

[Lldb-commits] [lldb] r351243 - Add Doxygen comments.

Author: adrian Date: Tue Jan 15 13:04:18 2019 New Revision: 351243 URL: http://llvm.org/viewvc/llvm-project?rev=351243&view=rev Log: Add Doxygen comments. Modified: lldb/trunk/include/lldb/Symbol/CompilerType.h Modified: lldb/trunk/include/lldb/Symbol/CompilerType.h URL: http://llvm.org/vie

[Lldb-commits] [lldb] r351244 - Simplify code

Author: adrian Date: Tue Jan 15 13:04:19 2019 New Revision: 351244 URL: http://llvm.org/viewvc/llvm-project?rev=351244&view=rev Log: Simplify code Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp URL: http://llvm.org/viewvc/llvm-p

[Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

Author: adrian Date: Tue Jan 15 13:26:03 2019 New Revision: 351250 URL: http://llvm.org/viewvc/llvm-project?rev=351250&view=rev Log: Simplify Value::GetValueByteSize() Modified: lldb/trunk/source/Core/Value.cpp Modified: lldb/trunk/source/Core/Value.cpp URL: http://llvm.org/viewvc/llvm-proj

[Lldb-commits] [lldb] r351264 - Simplify code by using Optional::getValueOr()

Author: adrian Date: Tue Jan 15 14:30:01 2019 New Revision: 351264 URL: http://llvm.org/viewvc/llvm-project?rev=351264&view=rev Log: Simplify code by using Optional::getValueOr() Modified: lldb/trunk/source/Core/ValueObjectVariable.cpp lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc6

[Lldb-commits] [lldb] r351274 - Remove redundant check.

Author: adrian Date: Tue Jan 15 15:33:26 2019 New Revision: 351274 URL: http://llvm.org/viewvc/llvm-project?rev=351274&view=rev Log: Remove redundant check. Modified: lldb/trunk/source/Core/Value.cpp Modified: lldb/trunk/source/Core/Value.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/tr

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

f = 0x00010920 (&::ref = ) with and without the patch. Which error message are you getting on Windows with my patch applied? I'll see if I can get LLDB to produce a more meaningful error message on Darwin, perhaps this will also improve the error on Windows. -- adrian > >

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

> On Jan 16, 2019, at 8:36 AM, Adrian Prantl via lldb-commits > wrote: > >> >> On Jan 16, 2019, at 4:22 AM, Pavel Labath wrote: >> >> Hi Adrian, Zachary, >> >> this commit breaks the SymbolFile/NativePDB/function-types-builtins.cpp test &

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

I posted a patch that should fix this in https://reviews.llvm.org/D56798 . thanks for your feedback! -- adrian ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] r351376 - Change TypeSystem::GetBitSize() to return an optional result.

Author: adrian Date: Wed Jan 16 13:19:20 2019 New Revision: 351376 URL: http://llvm.org/viewvc/llvm-project?rev=351376&view=rev Log: Change TypeSystem::GetBitSize() to return an optional result. This patch changes the behavior when printing C++ function references: where we previously would get a

[Lldb-commits] [lldb] r351385 - XFAIL test on Windows

Author: adrian Date: Wed Jan 16 14:07:21 2019 New Revision: 351385 URL: http://llvm.org/viewvc/llvm-project?rev=351385&view=rev Log: XFAIL test on Windows http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/677/steps/test/logs/stdio Modified: lldb/trunk/packages/Python/lldbsuite

[Lldb-commits] [lldb] r352009 - Skip test on clang <8 instead of 7

Author: adrian Date: Wed Jan 23 18:37:28 2019 New Revision: 352009 URL: http://llvm.org/viewvc/llvm-project?rev=352009&view=rev Log: Skip test on clang <8 instead of 7 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py

[Lldb-commits] [lldb] r352072 - Add decorator support for the DWARF version produced by the compiler

Author: adrian Date: Thu Jan 24 10:24:14 2019 New Revision: 352072 URL: http://llvm.org/viewvc/llvm-project?rev=352072&view=rev Log: Add decorator support for the DWARF version produced by the compiler and mark up some tests failing in http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-mat

[Lldb-commits] [lldb] r352073 - Rename test directory

Author: adrian Date: Thu Jan 24 10:24:17 2019 New Revision: 352073 URL: http://llvm.org/viewvc/llvm-project?rev=352073&view=rev Log: Rename test directory Added: lldb/trunk/packages/Python/lldbsuite/test/expression_command/scoped_enums/ lldb/trunk/packages/Python/lldbsuite/test/expressio

[Lldb-commits] [lldb] r352086 - Unbreak windows bots

Author: adrian Date: Thu Jan 24 11:16:45 2019 New Revision: 352086 URL: http://llvm.org/viewvc/llvm-project?rev=352086&view=rev Log: Unbreak windows bots Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py URL: http

[Lldb-commits] [lldb] r352094 - Only check the dwarf version when using the dwarf category

Author: adrian Date: Thu Jan 24 12:09:17 2019 New Revision: 352094 URL: http://llvm.org/viewvc/llvm-project?rev=352094&view=rev Log: Only check the dwarf version when using the dwarf category Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py lldb/trunk/packages/Python/lldb

[Lldb-commits] [lldb] r352111 - Remove NO_DEBUGINFO_TESTCASE from testcase.

Author: adrian Date: Thu Jan 24 13:32:32 2019 New Revision: 352111 URL: http://llvm.org/viewvc/llvm-project?rev=352111&view=rev Log: Remove NO_DEBUGINFO_TESTCASE from testcase. This makes it easier to exclude the test n bots that test earlier DWARF formats, also it feels like this is the better d

[Lldb-commits] [lldb] r352394 - Make Type::GetByteSize optional (NFC)

Author: adrian Date: Mon Jan 28 09:49:33 2019 New Revision: 352394 URL: http://llvm.org/viewvc/llvm-project?rev=352394&view=rev Log: Make Type::GetByteSize optional (NFC) This is a continuation of my quest to make the size 0 a supported value. Differential Revision: https://reviews.llvm.org/D572

[Lldb-commits] [lldb] r352417 - Remove unimplemented function

Author: adrian Date: Mon Jan 28 11:38:08 2019 New Revision: 352417 URL: http://llvm.org/viewvc/llvm-project?rev=352417&view=rev Log: Remove unimplemented function Looks like this was an unintended sideeffect of r124250. Differential Revision: https://reviews.llvm.org/D57272 Modified: lldb/t

[Lldb-commits] [lldb] r352434 - Revert "Make Type::GetByteSize optional (NFC)"

Author: adrian Date: Mon Jan 28 13:44:35 2019 New Revision: 352434 URL: http://llvm.org/viewvc/llvm-project?rev=352434&view=rev Log: Revert "Make Type::GetByteSize optional (NFC)" This reverts commit r352394 because it broke three windows-specific tests. Modified: lldb/trunk/include/lldb/Sym

[Lldb-commits] [lldb] r352521 - Make Type::GetByteSize optional (NFC)

Author: adrian Date: Tue Jan 29 09:52:34 2019 New Revision: 352521 URL: http://llvm.org/viewvc/llvm-project?rev=352521&view=rev Log: Make Type::GetByteSize optional (NFC) This is a continuation of my quest to make the size 0 a supported value. This reapplies r352394 with additional PDB parser fi

[Lldb-commits] [lldb] r352548 - Make a blind attempt at fixing PDBASTParser nullability issues

Author: adrian Date: Tue Jan 29 13:46:34 2019 New Revision: 352548 URL: http://llvm.org/viewvc/llvm-project?rev=352548&view=rev Log: Make a blind attempt at fixing PDBASTParser nullability issues Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp Modified: lldb/trunk/source/

Re: [Lldb-commits] [lldb] r353087 - Update stale comment in lang/c/struct_types/main.c

> On Feb 4, 2019, at 12:33 PM, Jonas Devlieghere via lldb-commits > wrote: > > Author: jdevlieghere > Date: Mon Feb 4 12:33:35 2019 > New Revision: 353087 > > URL: http://llvm.org/viewvc/llvm-project?rev=353087&view=rev > Log: > Update stale comment in lang/c/struct_types/main.c > > rdar://

[Lldb-commits] [lldb] r353468 - Silence fallthrough warnings in debugserver.

Author: adrian Date: Thu Feb 7 13:22:38 2019 New Revision: 353468 URL: http://llvm.org/viewvc/llvm-project?rev=353468&view=rev Log: Silence fallthrough warnings in debugserver. Modified: lldb/trunk/include/lldb/module.modulemap lldb/trunk/tools/debugserver/source/debugserver.cpp Modifie

[Lldb-commits] [lldb] r353961 - Deserialize Clang module search path from DWARF

Author: adrian Date: Wed Feb 13 10:10:41 2019 New Revision: 353961 URL: http://llvm.org/viewvc/llvm-project?rev=353961&view=rev Log: Deserialize Clang module search path from DWARF This patch properly extracts the full submodule path as well as its search paths from DWARF import decls and passes

[Lldb-commits] [lldb] r353971 - Add missing include

Author: adrian Date: Wed Feb 13 11:29:22 2019 New Revision: 353971 URL: http://llvm.org/viewvc/llvm-project?rev=353971&view=rev Log: Add missing include Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.h Modified: lldb/trunk/source/Plugins/ExpressionParser/C

[Lldb-commits] [lldb] r353979 - Add missing include

Author: adrian Date: Wed Feb 13 12:52:41 2019 New Revision: 353979 URL: http://llvm.org/viewvc/llvm-project?rev=353979&view=rev Log: Add missing include Modified: lldb/trunk/include/lldb/Symbol/CompileUnit.h Modified: lldb/trunk/include/lldb/Symbol/CompileUnit.h URL: http://llvm.org/viewvc/

[Lldb-commits] [lldb] r354048 - Add explicit language specifier to test.

Author: adrian Date: Thu Feb 14 10:49:14 2019 New Revision: 354048 URL: http://llvm.org/viewvc/llvm-project?rev=354048&view=rev Log: Add explicit language specifier to test. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/modules-import/TestCXXModulesImport.py Modified: lldb/t

[Lldb-commits] [lldb] r354418 - Move -fcxx-modules to MANDATORY_MODULE_BUILD_CFLAGS (NFC)

Author: adrian Date: Tue Feb 19 17:14:05 2019 New Revision: 354418 URL: http://llvm.org/viewvc/llvm-project?rev=354418&view=rev Log: Move -fcxx-modules to MANDATORY_MODULE_BUILD_CFLAGS (NFC) Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Modified: lldb/trunk/packages

[Lldb-commits] [lldb] r355042 - Remove unnecessary demangling operation (NFC)

Author: adrian Date: Wed Feb 27 14:54:47 2019 New Revision: 355042 URL: http://llvm.org/viewvc/llvm-project?rev=355042&view=rev Log: Remove unnecessary demangling operation (NFC) This extra call to the demangler doesn't affect the performance of C++ because the result is being cached anyway; but

[Lldb-commits] [lldb] r355238 - Delete commented-out code.

Author: adrian Date: Fri Mar 1 14:30:31 2019 New Revision: 355238 URL: http://llvm.org/viewvc/llvm-project?rev=355238&view=rev Log: Delete commented-out code. Modified: lldb/trunk/source/Host/common/ProcessRunLock.cpp Modified: lldb/trunk/source/Host/common/ProcessRunLock.cpp URL: http://l

[Lldb-commits] [lldb] r355457 - Remove tautological #ifdefs (NFC)

Author: adrian Date: Tue Mar 5 15:51:25 2019 New Revision: 355457 URL: http://llvm.org/viewvc/llvm-project?rev=355457&view=rev Log: Remove tautological #ifdefs (NFC) Differential Revision: https://reviews.llvm.org/D58838 Modified: lldb/trunk/source/Target/ExecutionContext.cpp Modified: lld

[Lldb-commits] [lldb] r355466 - Replace debug-only assert with a plain old assert.

Author: adrian Date: Tue Mar 5 17:07:45 2019 New Revision: 355466 URL: http://llvm.org/viewvc/llvm-project?rev=355466&view=rev Log: Replace debug-only assert with a plain old assert. Modified: lldb/trunk/source/Interpreter/CommandObject.cpp Modified: lldb/trunk/source/Interpreter/CommandObj

[Lldb-commits] [lldb] r355568 - Promote more debug-only assertions to regular assertions.

Author: adrian Date: Wed Mar 6 16:10:11 2019 New Revision: 355568 URL: http://llvm.org/viewvc/llvm-project?rev=355568&view=rev Log: Promote more debug-only assertions to regular assertions. Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

[Lldb-commits] [lldb] r355569 - Promote more debug-only assertions to regular assertions.

Author: adrian Date: Wed Mar 6 16:14:20 2019 New Revision: 355569 URL: http://llvm.org/viewvc/llvm-project?rev=355569&view=rev Log: Promote more debug-only assertions to regular assertions. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp lldb/trunk/source/Symbol/

[Lldb-commits] [lldb] r355571 - Relax testcase.

Author: adrian Date: Wed Mar 6 16:34:13 2019 New Revision: 355571 URL: http://llvm.org/viewvc/llvm-project?rev=355571&view=rev Log: Relax testcase. Recent versions of llvm monorepo builds build libc++abi.dylib as libc++abi.1.dylib. This accespts both variants. Modified: lldb/trunk/packages

<    1   2   3   4   5   6   7   8   9   10   >