> On Aug 30, 2018, at 9:43 AM, Leonard Mosescu <mose...@google.com> wrote: > > Just curious, what prompted this change? (compiler diagnostic? forcing value > initialization in the member initializer list is harmless in this case)
This particular change was (for whatever reason) in the swift.org <http://swift.org/> branch of LLDB and I'm always trying to remove pointless differences between the two branches. > > Also, if we want to do this kind of cleanup, m_compiler initialization is > also redundant. That's a fair point! -- adrian > > On Thu, Aug 30, 2018 at 8:39 AM, Adrian Prantl via lldb-commits > <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Thu Aug 30 08:39:08 2018 > New Revision: 341080 > > URL: http://llvm.org/viewvc/llvm-project?rev=341080&view=rev > <http://llvm.org/viewvc/llvm-project?rev=341080&view=rev> > Log: > Remove redundant initialization > > Modified: > lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp > > Modified: > lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp?rev=341080&r1=341079&r2=341080&view=diff > > <http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp?rev=341080&r1=341079&r2=341080&view=diff> > ============================================================================== > --- > lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp > (original) > +++ > lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp > Thu Aug 30 08:39:08 2018 > @@ -222,7 +222,7 @@ ClangExpressionParser::ClangExpressionPa > Expression &expr, > bool generate_debug_info) > : ExpressionParser(exe_scope, expr, generate_debug_info), m_compiler(), > - m_code_generator(), m_pp_callbacks(nullptr) { > + m_pp_callbacks(nullptr) { > Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_EXPRESSIONS)); > > // We can't compile expressions without a target. So if the exe_scope is > > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > <http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits> >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
