[Lldb-commits] [lldb] [WIP][lldb][test] Add a new __compressed_pair layout to libcxx simulator tests (PR #99012)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 27d961dab3caa89a78e68af094ddc8365d97dc91...242f78b67d6d6ef125b72c9c797fb2686cce280d lldb

[Lldb-commits] [lldb] 2ea4a03 - Fix test assertions in TestDAP_stepInTargets.py (#96687)

Author: Kendal Harland Date: 2024-07-16T12:59:08+02:00 New Revision: 2ea4a03c0f1be6dd11428e4c6eb840b745116ca2 URL: https://github.com/llvm/llvm-project/commit/2ea4a03c0f1be6dd11428e4c6eb840b745116ca2 DIFF: https://github.com/llvm/llvm-project/commit/2ea4a03c0f1be6dd11428e4c6eb840b745116ca2.diff

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

github-actions[bot] wrote: @kendalharland Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[Lldb-commits] [lldb] 139df36 - [LLDB] Make 'process load' take remote os path delimiter into account (#98690)

Author: Vladislav Dzhidzhoev Date: 2024-07-16T15:21:06+02:00 New Revision: 139df36d89bd731b5180be3cac2b58d4b2082368 URL: https://github.com/llvm/llvm-project/commit/139df36d89bd731b5180be3cac2b58d4b2082368 DIFF: https://github.com/llvm/llvm-project/commit/139df36d89bd731b5180be3cac2b58d4b208236

[Lldb-commits] [lldb] b7b77b0 - Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (#98361)

Author: Zequan Wu Date: 2024-07-16T16:22:31-04:00 New Revision: b7b77b0fe878d5620b042818cf527267521e51f5 URL: https://github.com/llvm/llvm-project/commit/b7b77b0fe878d5620b042818cf527267521e51f5 DIFF: https://github.com/llvm/llvm-project/commit/b7b77b0fe878d5620b042818cf527267521e51f5.diff LOG

[Lldb-commits] [lldb] [lldb] progressive progress reporting for darwin kernel/firmware (PR #98845)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff efde640cdfede834fa79e0eea69f82fb769d6beb e3c60eea579d3948156ec5d16f0f429700e8112b --e

[Lldb-commits] [lldb] [lldb] add RISCV target specific info in API tests (PR #99039)

@@ -34,6 +34,8 @@ def check_first_register_readable(test_case): test_case.expect("register read r0", substrs=["r0 = 0x"]) elif arch in ["powerpc64le"]: test_case.expect("register read r0", substrs=["r0 = 0x"]) +elif arch in ["rv64gc"]: d

[Lldb-commits] [lldb] [lldb][RISCV] function prologue backtrace fix (PR #99043)

dlav-sc wrote: > Agreed, this fix is correct, thanks for the PR. The register numbering in the > UnwindPlan can be any eRegisterKind, but it does need to be self consistent, > and this was not. Do you have permissions to merge this PR? I can do that for > you if not. Thanks for the review. I

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes These changes aim to support cross-compilation build on Windows host for Linux target for API tests execution. They're not final: changes will follow for refactoring and adjustments to make all tes

[Lldb-commits] [lldb] a751f65 - [lldb][RISCV] function prologue backtrace fix (#99043)

Author: dlav-sc Date: 2024-07-17T09:36:19+01:00 New Revision: a751f653b40f2021f091a2f1ebcc2d91bc4cc89d URL: https://github.com/llvm/llvm-project/commit/a751f653b40f2021f091a2f1ebcc2d91bc4cc89d DIFF: https://github.com/llvm/llvm-project/commit/a751f653b40f2021f091a2f1ebcc2d91bc4cc89d.diff LOG:

[Lldb-commits] [lldb] [lldb][RISCV] function prologue backtrace fix (PR #99043)

github-actions[bot] wrote: @dlav-sc Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] [lldb] Refactor TypeQuery::ContextMatches (PR #99305)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This is a preparatory step for teaching the function about anonymous namespaces. It started out as a way to remove the assumption that the pattern and target contexts must be of the same length -- that's will

[Lldb-commits] [lldb] [lldb] Disable verbose_trap.test on Windows (PR #99323)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Leandro Lupori (luporl) Changes verbose_trap.test, added in #80368, fails on some Windows bots. See https://lab.llvm.org/buildbot/#/builders/141/builds/808. --- Full diff: https://github.com/llvm/llvm-project/pull/99323.diff 1 Files Affe

[Lldb-commits] [lldb] ec9d62f - [lldb] Disable verbose_trap.test on Windows (#99323)

Author: Leandro Lupori Date: 2024-07-17T11:45:49-03:00 New Revision: ec9d62fe84fe314370a256306c083a9e7079b80b URL: https://github.com/llvm/llvm-project/commit/ec9d62fe84fe314370a256306c083a9e7079b80b DIFF: https://github.com/llvm/llvm-project/commit/ec9d62fe84fe314370a256306c083a9e7079b80b.diff

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

https://github.com/dlav-sc created https://github.com/llvm/llvm-project/pull/99336 To make function calls inside lldb expressions ABI support, JIT engine support are required. This patch augments corresponding functionality to RISCV ABI and implements RISCV relocation resolver in JIT, which al

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (dlav-sc) Changes To make function calls inside lldb expressions ABI support, JIT engine support are required. This patch augments corresponding functionality to RISCV ABI and implements RISCV relocation resolver in JIT, which allows

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r ac4b6b662630cd4d3bf6929f2b39ea203c0054a1...3ad75f024eec22f2dfd0ae7cc911f6d70202932d lldb/

[Lldb-commits] [lldb] 86ef699 - [lldb] progressive progress reporting for darwin kernel/firmware (#98845)

Author: Jason Molenda Date: 2024-07-17T10:05:55-07:00 New Revision: 86ef699060394c82dcda7e86ff70d8cabeabcc2a URL: https://github.com/llvm/llvm-project/commit/86ef699060394c82dcda7e86ff70d8cabeabcc2a DIFF: https://github.com/llvm/llvm-project/commit/86ef699060394c82dcda7e86ff70d8cabeabcc2a.diff

[Lldb-commits] [lldb] [lldb][test] Fix simulator test for std::unique_ptr (PR #99357)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Leandro Lupori (luporl) Changes libcxx-simulators/unique_ptr/main.cpp uses __builtin_printf, that maps to printf on Windows. Include stdio.h to avoid linker errors on Windows. See https://lab.llvm.org/buildbot/#/builders/141/builds/853 ---

[Lldb-commits] [lldb] [lldb][debuginfod] Fix the DebugInfoD PR that caused issues when working with stripped binaries (PR #99362)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kevin Frei (kevinfrei) Changes @walter-erquinigo found the the [PR with testing and a fix for DebugInfoD](https://github.com/llvm/llvm-project/pull/98344) caused an issue when working with stripped binaries. The issue is that when you're

[Lldb-commits] [lldb] 93d38d7 - [lldb][test] Fix simulator test for std::unique_ptr (#99357)

Author: Leandro Lupori Date: 2024-07-17T14:49:22-03:00 New Revision: 93d38d7f08864397f1e751c8cecde5ea302ecced URL: https://github.com/llvm/llvm-project/commit/93d38d7f08864397f1e751c8cecde5ea302ecced DIFF: https://github.com/llvm/llvm-project/commit/93d38d7f08864397f1e751c8cecde5ea302ecced.diff

[Lldb-commits] [lldb] [lldb] IRMemoryMap zero address mapping fix (PR #99045)

dlav-sc wrote: I connect to a riscv (rv64gv) machine, nothing special. Lldb can just allocate memory on remote target only if the target supports executing JIT-compiled code (`if (process_is_alive && process_sp->CanJIT())` on the line `68`), otherwise lldb falls through and starts finding sui

[Lldb-commits] [lldb] [lldb] change .sbss section type to eSectionTypeZeroFill (PR #99044)

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99044 >From 2bca6288a3d7ce04191c28280d05d6255fc3019a Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 14:09:04 + Subject: [PATCH] [lldb] SHT_NOBITS sections type Sections with SHT_NOBITS type sh

[Lldb-commits] [lldb] [lldb] change .sbss section type to eSectionTypeZeroFill (PR #99044)

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99044 >From 2b62658701e6a2c2cb651dc1a634c03bbb385f0d Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 14:09:04 + Subject: [PATCH] [lldb] SHT_NOBITS sections type Sections with SHT_NOBITS type sh

[Lldb-commits] [lldb] [lldb] change .sbss section type to eSectionTypeZeroFill (PR #99044)

dlav-sc wrote: > I'm wondering if there's a more fundamental fix to be made here. Like perhaps > treating treating any allocatable SHT_NOBITS section as ZeroFill. > > Basically to add `case SHT_NOBITS: if (H.sh_flags & SHF_ALLOC) return > eSectionTypeZeroFill;` to `GetSectionType` (line 1716)

[Lldb-commits] [lldb] [lldb] add RISCV target specific info in API tests (PR #99039)

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99039 >From e0e8ce7f438b17bfd1931021361ff5044e6e7ced Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:08:43 + Subject: [PATCH] [lldb] add RISCV target specific info in API tests Add informati

[Lldb-commits] [lldb] [lldb] add RISCV target specific info in API tests (PR #99039)

@@ -34,6 +34,8 @@ def check_first_register_readable(test_case): test_case.expect("register read r0", substrs=["r0 = 0x"]) elif arch in ["powerpc64le"]: test_case.expect("register read r0", substrs=["r0 = 0x"]) +elif arch in ["rv64gc"]: d

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From c35ab331df2bc76a32d36a51ecb020ea2c13ff39 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/5] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [lldb] SHT_NOBITS sections type (PR #99044)

https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/99044 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] SHT_NOBITS sections type (PR #99044)

dlav-sc wrote: I have also removed `.Cases(".bss", ".tbss", eSectionTypeZeroFill)`. To be honest, I'm not sure about that. .bss and .tbss have SHT_NOBITS type and SHF_ALLOC flag by [Linux Specification](https://refspecs.linuxbase.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/specialsections

[Lldb-commits] [lldb] cbd2559 - [lldb] add RISCV target specific info in API tests (#99039)

Author: dlav-sc Date: 2024-07-18T09:09:52+01:00 New Revision: cbd255942b52c3576aa0dca444811512fff43714 URL: https://github.com/llvm/llvm-project/commit/cbd255942b52c3576aa0dca444811512fff43714 DIFF: https://github.com/llvm/llvm-project/commit/cbd255942b52c3576aa0dca444811512fff43714.diff LOG:

[Lldb-commits] [lldb] [lldb] add RISCV target specific info in API tests (PR #99039)

github-actions[bot] wrote: @dlav-sc Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] [lldb][tests] Add ability to run API tests with qemu-user simulator (PR #89765)

ita-sc wrote: Sorry for huge delay, could you please merge this? (I do not have write access yet) https://github.com/llvm/llvm-project/pull/89765 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] d097f43 - [lldb] Fixed the error `unable to launch a GDB server` in API tests (#98833)

Author: Dmitry Vasilyev Date: 2024-07-18T10:04:49+01:00 New Revision: d097f430a172a5d798a39b416b1af84f4ec572e1 URL: https://github.com/llvm/llvm-project/commit/d097f430a172a5d798a39b416b1af84f4ec572e1 DIFF: https://github.com/llvm/llvm-project/commit/d097f430a172a5d798a39b416b1af84f4ec572e1.dif

[Lldb-commits] [lldb] [LLDB][test] Fix cmd.exe detection on recent Windows versions (PR #99532)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes Since Windows 10 the case of 'windir' env variable was changed. Such error appears without that change: ``` make: \system32\cmd.exe: Command not found Makefile.rules:628: recipe for target 'main.o

[Lldb-commits] [lldb] [LLDB][test] Drop OS/HOST_OS detection code from Makefile.rules (PR #99535)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes Remove commands for OS/HOST_OS detection from Makefile.rules to simplify it, since logic for these variables has been implemented in `lldb/packages/Python/lldbsuite/test/lldbplatformutil.py` (http

[Lldb-commits] [lldb] 78e3bfc - [LLDB][test] Drop OS/HOST_OS detection code from Makefile.rules (#99535)

Author: Vladislav Dzhidzhoev Date: 2024-07-18T20:04:21+02:00 New Revision: 78e3bfc120c8a23e246f544a5e9fb122828a21a7 URL: https://github.com/llvm/llvm-project/commit/78e3bfc120c8a23e246f544a5e9fb122828a21a7 DIFF: https://github.com/llvm/llvm-project/commit/78e3bfc120c8a23e246f544a5e9fb122828a21a

[Lldb-commits] [lldb] 4120570 - [LLDB][SaveCore] Add SBSaveCoreOptions Object, and SBProcess::SaveCore() overload (#98403)

Author: Jacob Lalonde Date: 2024-07-18T17:10:15-07:00 New Revision: 4120570dc408a6ccc7133b4bdbaf5cf6c4af9db7 URL: https://github.com/llvm/llvm-project/commit/4120570dc408a6ccc7133b4bdbaf5cf6c4af9db7 DIFF: https://github.com/llvm/llvm-project/commit/4120570dc408a6ccc7133b4bdbaf5cf6c4af9db7.diff

[Lldb-commits] [lldb] [lldb] SHT_NOBITS sections type (PR #99044)

dlav-sc wrote: > > I have also removed `.Cases(".bss", ".tbss", eSectionTypeZeroFill)`. > > To be honest, I'm not sure about that. .bss and .tbss have SHT_NOBITS type > > and SHF_ALLOC flag by [Linux > > Specification](https://refspecs.linuxbase.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/s

[Lldb-commits] [lldb] [lldb][test] Add ABI library to Makefile.rules link flags (PR #99589)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes This commit fixes an undefined reference linking problem with cross-compilation and remote testing on Linux host-Linux target configuration, that occurs when libcxx is linked statically. Many test

[Lldb-commits] [clang] [lldb] [clang] Split ObjectFilePCHContainerReader from ObjectFilePCHContainerWriter (PR #99599)

llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/99479 See https://github.com/llvm/llvm-project/issues/99479 for details --- Full diff: https://github.com/llvm/llvm-project/pull/99599.diff 16 Fil

[Lldb-commits] [clang] [lldb] [clang] Split ObjectFilePCHContainerReader from ObjectFilePCHContainerWriter (PR #99599)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 962d018234cb8c94e387fe3950cd030658850541 36e24bd88649e9d5771f1dbb668632d33ffe52d7 --e

[Lldb-commits] [lldb] 243af2f - [LLDB][test] Improve SHELL detection on Windows in Makefile.rules (#99532)

Author: Vladislav Dzhidzhoev Date: 2024-07-19T13:08:07+02:00 New Revision: 243af2ff217f65ef291232faa60779b86e01a967 URL: https://github.com/llvm/llvm-project/commit/243af2ff217f65ef291232faa60779b86e01a967 DIFF: https://github.com/llvm/llvm-project/commit/243af2ff217f65ef291232faa60779b86e01a96

[Lldb-commits] [lldb] fdfc491 - [lldb] SHT_NOBITS sections type (#99044)

Author: dlav-sc Date: 2024-07-19T13:22:18+02:00 New Revision: fdfc49186318727653cf6b13686bb77cfed60e33 URL: https://github.com/llvm/llvm-project/commit/fdfc49186318727653cf6b13686bb77cfed60e33 DIFF: https://github.com/llvm/llvm-project/commit/fdfc49186318727653cf6b13686bb77cfed60e33.diff LOG:

[Lldb-commits] [lldb] [lldb] SHT_NOBITS sections type (PR #99044)

github-actions[bot] wrote: @dlav-sc Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] [lldb/Target] Add GetStartSymbol method to DynamicLoader plugins (PR #99673)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch introduces a new method to the dynamic loader plugin, to fetch its `start` symbol. This can be useful to resolve the `start` symbol address for instance. --- Full diff: https://github.c

[Lldb-commits] [lldb] a96c906 - [lldb/Target] Add GetStartSymbol method to DynamicLoader plugins (#99673)

Author: Med Ismail Bennani Date: 2024-07-19T11:39:56-07:00 New Revision: a96c906102e8d0284c7a402eac4fa1ad9ab3e871 URL: https://github.com/llvm/llvm-project/commit/a96c906102e8d0284c7a402eac4fa1ad9ab3e871 DIFF: https://github.com/llvm/llvm-project/commit/a96c906102e8d0284c7a402eac4fa1ad9ab3e871.

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

@@ -577,15 +577,18 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( ProcessSP process_sp(thread.GetProcess()); RegisterContextSP reg_ctx_sp(thread.GetRegisterContext()); - BreakpointSiteSP bp_site_sp; - addr_t pc = LLDB_INVALID_ADDRESS; - if (reg

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

https://github.com/jimingham deleted https://github.com/llvm/llvm-project/pull/96260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

@@ -577,15 +577,18 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( ProcessSP process_sp(thread.GetProcess()); RegisterContextSP reg_ctx_sp(thread.GetRegisterContext()); - BreakpointSiteSP bp_site_sp; - addr_t pc = LLDB_INVALID_ADDRESS; - if (reg

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

https://github.com/jimingham approved this pull request. I had a couple trivial comment comments (and you didn't fix one typo). But this LGTM as well. https://github.com/llvm/llvm-project/pull/96260 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [lldb] [LLDB][SBSaveCoreOptions] Fix TestProcessSaveCore (PR #99692)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes In #98403 some of the tests were transitioned to the new `SBProcess::SaveCore(SBSaveCoreOptions)` API, but were not detected in testing. This patch addresses that. --- Full diff: https://github.com/llvm/llv

[Lldb-commits] [lldb] fada922 - [LLDB][SBSaveCoreOptions] Fix TestProcessSaveCore (#99692)

Author: Jacob Lalonde Date: 2024-07-19T15:49:22-07:00 New Revision: fada9227325b3eaa0bdc09a486f29a7f08b7b3fb URL: https://github.com/llvm/llvm-project/commit/fada9227325b3eaa0bdc09a486f29a7f08b7b3fb DIFF: https://github.com/llvm/llvm-project/commit/fada9227325b3eaa0bdc09a486f29a7f08b7b3fb.diff

[Lldb-commits] [lldb] [lldb][Windows] Fixed Host::Kill() (PR #99721)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes HostProcessWindows::Terminate() correctly uses m_process which type is process_t (HANDLE) to call ::TerminateProcess(). But Host::Kill() uses a cast from pid, which is wrong. --- Full diff: https://githu

[Lldb-commits] [lldb] 05f0e86 - [lldb] Change lldb's breakpoint handling behavior (#96260)

Author: Jason Molenda Date: 2024-07-19T17:26:13-07:00 New Revision: 05f0e86cc895181b3d2210458c78938f83353002 URL: https://github.com/llvm/llvm-project/commit/05f0e86cc895181b3d2210458c78938f83353002 DIFF: https://github.com/llvm/llvm-project/commit/05f0e86cc895181b3d2210458c78938f83353002.diff

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Robert O'Callahan (rocallahan) Changes This commit only adds support for the `SBProcess::ReverseContinue()` API. A user-accessible command for this will follow in a later commit. This feature depends on a gdbserver implementation (e.g. `rr

[Lldb-commits] [lldb] f6eb89c - [lldb][Windows] Fixed Host::Kill() (#99721)

Author: Dmitry Vasilyev Date: 2024-07-21T15:59:41+04:00 New Revision: f6eb89cdd02d73a3c9a0da858c3100986282aceb URL: https://github.com/llvm/llvm-project/commit/f6eb89cdd02d73a3c9a0da858c3100986282aceb DIFF: https://github.com/llvm/llvm-project/commit/f6eb89cdd02d73a3c9a0da858c3100986282aceb.dif

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch introduces Scripted Platform, a new platform plugin that can be customized with a python script. For now this can list processes described in the python script file but eventually, it w

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 867faeec054abb4c035673189c1169fef45f54c8...510fb37ba420a83d14233e4c835847e03879f674 lldb/

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

dlav-sc wrote: > > Thanks for the patches (if we end up going down this route you'll probably > > want to split out the LLVM JIT changes into a separate PR). > > I know little about the JIT side but this is my first reaction too. I wonder > if that has its own tests that need adding, and it'll

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

dlav-sc wrote: > A quick look at the RISCV ISA and it says that the JAL instruction is pc > relative and can jump +/- 1MB. JALR gets the upper 20 bits from a general > purpose register and it includes 12 low bits in its instruction encoding. I > know almost nothing about rv32, but is this what

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

dlav-sc wrote: > Thanks for the patches (if we end up going down this route you'll probably > want to split out the LLVM JIT changes into a separate PR). > > Not very familiar with RISCV. Could you elaborate on the exact failures you > were seeing and why we need the extra IR pass? > > > Also

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

@@ -0,0 +1,58 @@ +//===--- DirectToIndirectFCR.h - RISC-V specific pass -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

@@ -0,0 +1,58 @@ +//===--- DirectToIndirectFCR.h - RISC-V specific pass -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb/Target] Add GetStartSymbol method to DynamicLoader plugins (PR #99673)

jimingham wrote: I agree with Pavel, we don't for most purposes care whether there's a symbol at the start address (for instance we can use it for the "expression evaluation return breakpoint" as an address. So we shouldn't require the symbol. Jim > On Jul 22, 2024, at 12:04 AM, Pavel Labath

[Lldb-commits] [lldb] [lldb] Change GetStartSymbol to GetStartAddress in DynamicLoader (PR #99909)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes On linux, the start address doesn't necessarily have a symbol attached to it. This is why this patch replaces `DynamicLoader::GetStartSymbol` with `DynamicLoader::GetStartAddress` instead. --- Ful

[Lldb-commits] [lldb] bb8a740 - [lldb] Change GetStartSymbol to GetStartAddress in DynamicLoader (#99909)

Author: Med Ismail Bennani Date: 2024-07-22T11:43:32-07:00 New Revision: bb8a74075b164ea0d9b3155f64d0590fc6072cdd URL: https://github.com/llvm/llvm-project/commit/bb8a74075b164ea0d9b3155f64d0590fc6072cdd DIFF: https://github.com/llvm/llvm-project/commit/bb8a74075b164ea0d9b3155f64d0590fc6072cdd.

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -160,6 +160,8 @@ class LLDB_API SBProcess { lldb::SBError Continue(); + lldb::SBError ReverseContinue(); jimingham wrote: For programming uses, it might be more useful to have one API with a bool or RunDirection or something? It's nicer to write: `

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/99736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -1395,6 +1395,94 @@ Status ProcessGDBRemote::DoResume() { return error; } +Status ProcessGDBRemote::DoResumeReverse() { + Status error; + Log *log = GetLog(GDBRLog::Process); + LLDB_LOGF(log, "ProcessGDBRemote::DoResumeReverse()"); + + ListenerSP listener_sp( + L

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -3264,6 +3266,11 @@ Status Process::PrivateResume() { // filters before resuming. UpdateAutomaticSignalFiltering(); + if (m_last_run_direction != direction) { jimingham wrote: It might be hard, but it would be nice if this wasn't necessary. For insta

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -3281,7 +3288,11 @@ Status Process::PrivateResume() { "Process::PrivateResume PreResumeActions failed, not resuming."); } else { m_mod_id.BumpResumeID(); -error = DoResume(); +if (direction == eRunForward) { + error = DoResu

[Lldb-commits] [lldb] lldb: android: fix missing Python import of urlparse from lldb test utilities (PR #99934)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] lldb: android: fix missing Python import of urlparse from lldb test utilities (PR #99934)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Andrew Rogers (andrurogerz) Changes ## Issue Attempting to run the lldb API tests against a remote-android target fails with the error `NameError: name 'urlparse' is not defined`. ## Root Cause It looks the Python import of `urlparse` was

[Lldb-commits] [lldb] [lldb][debugserver] Retry sleep(0.25s) when interrupted (PR #99962)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes After lldb has ptrace()'ed the process, it sleeps for 0.25 seconds before trying to pause the process. We see logging that in some rare cases, this sleep is interrupted and the pause fails, the attach

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

jimingham wrote: > On Jul 22, 2024, at 2:52 PM, rocallahan ***@***.***> wrote: > > > @rocallahan commented on this pull request. > > In lldb/source/Target/Process.cpp > : > > > @@ -3264,6 +3266,11 @@ Status Process::Pr

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

jimingham wrote: > On Jul 22, 2024, at 2:56 PM, rocallahan ***@***.***> wrote: > > > @rocallahan commented on this pull request. > > In lldb/source/Target/Process.cpp > : > > > @@ -3264,6 +3266,11 @@ Status Process::Pr

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

jimingham wrote: > On Jul 22, 2024, at 2:54 PM, rocallahan ***@***.***> wrote: > > > @rocallahan commented on this pull request. > > In lldb/source/Target/Process.cpp > : > > > @@ -3264,6 +3266,11 @@ Status Process::Pr

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

jimingham wrote: > On Jul 22, 2024, at 3:44 PM, rocallahan ***@***.***> wrote: > > > You might have to be careful in the case where someone runs a function call, > stops at a breakpoint in the function call and decides to go backwards in the > function execution (if that's possible). > > T

[Lldb-commits] [lldb] [lldb] Unify WaitForSetEvents and WaitForEventsToReset (PR #99997)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Unify the implementations of WaitForSetEvents and WaitForEventsToReset. The former deals with the possibility of a race between the timeout and the predicate while the latter does not. The functions

[Lldb-commits] [lldb] [lldb] Unify WaitForSetEvents and WaitForEventsToReset (PR #99997)

https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/7 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d64eccf - [clang] Split ObjectFilePCHContainerReader from ObjectFilePCHContainerWriter (#99599)

Author: Chuanqi Xu Date: 2024-07-23T23:55:31+08:00 New Revision: d64eccf4335e99360132b724d060d704892fbb02 URL: https://github.com/llvm/llvm-project/commit/d64eccf4335e99360132b724d060d704892fbb02 DIFF: https://github.com/llvm/llvm-project/commit/d64eccf4335e99360132b724d060d704892fbb02.diff LO

[Lldb-commits] [lldb] [lldb-dap] Updated README.md for newly added attach properties. (PR #99926)

tedwoodward wrote: Please update the version number in package.json, so we can publish the new extension to the marketplace https://github.com/llvm/llvm-project/pull/99926 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] 87f2c25 - [lldb] Unify WaitForSetEvents and WaitForEventsToReset (#99997)

Author: Jonas Devlieghere Date: 2024-07-23T09:06:32-07:00 New Revision: 87f2c25f3dad65890fc8e9abbe9765e44979ed9d URL: https://github.com/llvm/llvm-project/commit/87f2c25f3dad65890fc8e9abbe9765e44979ed9d DIFF: https://github.com/llvm/llvm-project/commit/87f2c25f3dad65890fc8e9abbe9765e44979ed9d.d

[Lldb-commits] [lldb] ca102b2 - lldb: android: fix missing Python import of urlparse in lldb test utilities (#99934)

Author: Andrew Rogers Date: 2024-07-23T09:23:51-07:00 New Revision: ca102b2114fa8a00096d71ff9fc3b1b218f0f01a URL: https://github.com/llvm/llvm-project/commit/ca102b2114fa8a00096d71ff9fc3b1b218f0f01a DIFF: https://github.com/llvm/llvm-project/commit/ca102b2114fa8a00096d71ff9fc3b1b218f0f01a.diff

[Lldb-commits] [lldb] lldb: android: fix missing Python import of urlparse in lldb test utilities (PR #99934)

github-actions[bot] wrote: @andrurogerz Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bu

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -1363,6 +1374,43 @@ Status ProcessGDBRemote::DoResume() { } } +if (direction == RunDirection::eRunReverse && continue_packet_error) { + if (num_continue_C_tids > 0 || num_continue_S_tids > 0) { +error.SetErrorString("can't deliver signals while ru

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

jimingham wrote: > On Jul 23, 2024, at 9:47 AM, Greg Clayton ***@***.***> wrote: > > > @clayborg requested changes on this pull request. > > In lldb/include/lldb/API/SBProcess.h > : > > > - lldb::SBError Continue(); >

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

jimingham wrote: More generally, I think it will be more natural if reverse and forward continuations to be as much as possible "the exact same execution control machinery with a direction" not separate "forward" and "reverse" facilities. So I'd rather we not start off separating them artific

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -1363,6 +1374,43 @@ Status ProcessGDBRemote::DoResume() { } } +if (direction == RunDirection::eRunReverse && continue_packet_error) { + if (num_continue_C_tids > 0 || num_continue_S_tids > 0) { +error.SetErrorString("can't deliver signals while ru

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

@@ -158,7 +158,7 @@ class LLDB_API SBProcess { lldb::SBError Destroy(); - lldb::SBError Continue(); + lldb::SBError Continue(RunDirection direction = RunDirection::eRunForward); jimingham wrote: I think it should be possible for most of lldb not to care

[Lldb-commits] [lldb] 39c23a3 - Revert "[lldb/Commands] Add `scripting template list` command with auto discovery" (#100273)

Author: Med Ismail Bennani Date: 2024-07-23T16:04:48-07:00 New Revision: 39c23a31d2ab9a6068fcaa22ed9b1e10101db5ff URL: https://github.com/llvm/llvm-project/commit/39c23a31d2ab9a6068fcaa22ed9b1e10101db5ff DIFF: https://github.com/llvm/llvm-project/commit/39c23a31d2ab9a6068fcaa22ed9b1e10101db5ff.

[Lldb-commits] [lldb] Revert "[lldb/Commands] Add `scripting template list` command with auto discovery" (PR #100273)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes Reverts llvm/llvm-project#97273 since it broke the windows bot: https://lab.llvm.org/buildbot/#/builders/141/builds/1025/steps/4/logs/stdio --- Patch is 41.15 KiB, truncated to 20.00 KiB below, fu

[Lldb-commits] [clang] [lldb] [llvm] [BOLT][DWARF][NFC] Add parallelization for processing of DWO debug information (PR #100282)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r ef8de68faebee0226b4836e66574f225f724e768...cbcf4b3fb0ccad7eea5c1672b90a564e707028f6 cross

[Lldb-commits] [lldb] [lldb] Don't crash when attaching to pid and no binaries found (PR #100287)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes There is a narrow window during process launch on macOS where lldb can attach and no binaries will be seen as loaded in the process (none reported by libdyld SPI). A year ago I made changes to set the

[Lldb-commits] [lldb] [lldb] Don't crash when attaching to pid and no binaries found (PR #100287)

https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/100287 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 56535a0 - [lldb] Don't crash when attaching to pid and no binaries found (#100287)

Author: Jason Molenda Date: 2024-07-23T17:50:40-07:00 New Revision: 56535a090d91ff10a60c884bacbd314dcf9659db URL: https://github.com/llvm/llvm-project/commit/56535a090d91ff10a60c884bacbd314dcf9659db DIFF: https://github.com/llvm/llvm-project/commit/56535a090d91ff10a60c884bacbd314dcf9659db.diff

[Lldb-commits] [lldb] [lldb] Don't use a vm addr range starting at 0 for local memory (PR #100288)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes When an inferior stub cannot allocate memory for lldb, and lldb needs to store the result of expressions, it will do it in lldb's own memory range ("host memory"). But it needs to find a virtual addres

[Lldb-commits] [lldb] [lldb][Linux] Parse, but don't store "comm" from /proc/stat file (PR #100387)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes As reported in https://github.com/llvm/llvm-project/issues/89710, the %s code used for `comm` could and probably does, overflow the buffer. Likely we haven't seen it cause problems because the followi

<    1   2   3   4   5   6   7   8   9   10   >