[Lldb-commits] [lldb] ea4ae25 - [lldb] Fix section printing to always align. (#98521)

2024-07-11 Thread via lldb-commits
Author: Greg Clayton Date: 2024-07-11T12:58:24-07:00 New Revision: ea4ae2590dea6ab5acf790a6098863d4ba63300f URL: https://github.com/llvm/llvm-project/commit/ea4ae2590dea6ab5acf790a6098863d4ba63300f DIFF: https://github.com/llvm/llvm-project/commit/ea4ae2590dea6ab5acf790a6098863d4ba63300f.diff

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-11 Thread via lldb-commits
https://github.com/beetrees edited https://github.com/llvm/llvm-project/pull/98369 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

2024-07-11 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7021e44b2f0e11717c0d82456bad0fed4a0b48f9 1e86ac615e751f0c98836690a1a8ca2b007be03b --e

[Lldb-commits] [lldb] [lldb] Allow fetching of RA register when above fault handler (PR #98566)

2024-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes In RegisterContextUnwind::SavedLocationForRegister we have special logic for retrieving the Return Address register when it has the caller's return address in it. An example would be the lr register on

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-11 Thread via lldb-commits
https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/98568 Some targets have non-trivial amount of threads, when stopping, multiple stopped events can be sent causing VSCode to show multiple yellow lines in code editor which can be confusing to end users. This PR

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes Some targets have non-trivial amount of threads, when stopping, multiple stopped events can be sent causing VSCode to show multiple yellow lines in code editor which can be confusing to end users. This PR intr

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-11 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r b81fcd01bde51eb8976b81a2c0c19fc0645cd2ff...13af0ff31688ca0a23f1fec65ca2d5797b65e31f lldb/

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-11 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/98568 >From 13af0ff31688ca0a23f1fec65ca2d5797b65e31f Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Thu, 11 Jul 2024 17:24:41 -0700 Subject: [PATCH 1/2] Support single stopped event in lldb-dap --- .../test/t

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-11 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/98571 This fixes a bug where Process events were being delivered to secondary listeners when the Private state thread listener was processing the event. That meant the secondary listener could get an event before t

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes This fixes a bug where Process events were being delivered to secondary listeners when the Private state thread listener was processing the event. That meant the secondary listener could get an event before the Pr

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-11 Thread via lldb-commits
jimingham wrote: This test was marked as flakey on some Linux systems, but so were other of the process event tests in this file, which should not have been affected by this patch. So I don't think this is going to fix whatever was flakey in general, though it should help this test. https://

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-11 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7b604cdf75fd1c741a15138684ea0e98dca5e46f fb563e516f3a73d508ea7b3a61df4f1bab2f33a6 --e

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-11 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 7b604cdf75fd1c741a15138684ea0e98dca5e46f...fb563e516f3a73d508ea7b3a61df4f1bab2f33a6 lldb/

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-11 Thread via lldb-commits
@@ -46,6 +46,7 @@ static constexpr FormatInfo g_format_infos[] = { {eFormatHex, 'x', "hex"}, {eFormatHexUppercase, 'X', "uppercase hex"}, {eFormatFloat, 'f', "float"}, +{eFormatFloat128, '\0', "float128"}, beetrees wrote: There's a static asser

[Lldb-commits] [lldb] [LLDB] Fix Android debugging (PR #98581)

2024-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazuki Sakamoto (splhack) Changes # Goal Fix Android debugging # What This pull request reverts these two commits because it broke Android debugging as explained below. - https://github.com/llvm/llvm-project/commit/bf3e3289d67cb0fe136b

[Lldb-commits] [lldb] [LLDB] Fix Android debugging (PR #98581)

2024-07-11 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a853fe25df1cda0117055c0d836e7b107d98c791 8602d97a8a9b1f81b6776bede708eeb54bc3 --e

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-11 Thread via lldb-commits
https://github.com/beetrees updated https://github.com/llvm/llvm-project/pull/98369 >From 5e29db435c239a4817256d308727d772dca1a7e8 Mon Sep 17 00:00:00 2001 From: beetrees Date: Thu, 11 Jul 2024 19:56:45 +0100 Subject: [PATCH 1/2] [lldb] Format `lldb-enumerations.h` (NFC) --- lldb/include/lldb

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-11 Thread via lldb-commits
beetrees wrote: (I've fixed the CI failure.) https://github.com/llvm/llvm-project/pull/98369 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fe97671 - [lldb][test] Fix ComputeClangResourceDirectory test when CLANG_RESOURCE_DIR is set (#98464)

2024-07-12 Thread via lldb-commits
Author: David Spickett Date: 2024-07-12T09:30:33+01:00 New Revision: fe9767105af65f0a7345afb6bb2f14e5d4404a15 URL: https://github.com/llvm/llvm-project/commit/fe9767105af65f0a7345afb6bb2f14e5d4404a15 DIFF: https://github.com/llvm/llvm-project/commit/fe9767105af65f0a7345afb6bb2f14e5d4404a15.diff

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-12 Thread via lldb-commits
@@ -195,10 +199,10 @@ enum Format { ///< character arrays that can contain non printable ///< characters eFormatAddressInfo,///< Describe what an address points to (func + offset - ///< with file/line,

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-12 Thread via lldb-commits
https://github.com/beetrees updated https://github.com/llvm/llvm-project/pull/98369 >From 4f9774916d3d31f31c810d0930f7961bf348802c Mon Sep 17 00:00:00 2001 From: beetrees Date: Wed, 10 Jul 2024 18:49:45 +0100 Subject: [PATCH] [lldb] Add support for displaying `__float128` variables --- lldb/b

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-12 Thread via lldb-commits
@@ -195,10 +199,10 @@ enum Format { ///< character arrays that can contain non printable ///< characters eFormatAddressInfo,///< Describe what an address points to (func + offset - ///< with file/line,

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-12 Thread via lldb-commits
https://github.com/beetrees edited https://github.com/llvm/llvm-project/pull/98369 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Narrow enum test xfail to clang < 19.0 (PR #98616)

2024-07-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Since #98335 clang adds DW_AT_type, unless strict DWARF is requested. --- Full diff: https://github.com/llvm/llvm-project/pull/98616.diff 1 Files Affected: - (modified) lldb/test/API/commands/expre

[Lldb-commits] [lldb] c471d36 - [lldb][test] Narrow enum test xfail to clang < 19.0 (#98616)

2024-07-12 Thread via lldb-commits
Author: David Spickett Date: 2024-07-12T13:12:35+01:00 New Revision: c471d3650aa3c6c1ddab64c029b7b89b12d18938 URL: https://github.com/llvm/llvm-project/commit/c471d3650aa3c6c1ddab64c029b7b89b12d18938 DIFF: https://github.com/llvm/llvm-project/commit/c471d3650aa3c6c1ddab64c029b7b89b12d18938.diff

[Lldb-commits] [lldb] [LLDB] Fix remote executables load and caching (PR #98623)

2024-07-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes Seemingly, #96256 removed the only call to Platform::GetCachedExecutable, which broke the resolution of executable modules in the remote debugging mode (https://github.com/llvm/llvm-project/issues/9

[Lldb-commits] [lldb] [LLDB] Fix remote executables load and caching (PR #98623)

2024-07-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c471d3650aa3c6c1ddab64c029b7b89b12d18938 3f8a4164ddc06a3faffe61d95e5023d367d757f0 --e

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-12 Thread via lldb-commits
jimingham wrote: What is going to happen in this mode if I have 5 threads stop at breakpoints, and each have a breakpoint command that prints "I hit breakpoint X on thread Y". I'll see that in the console for all the threads that hit breakpoints. But what will I see when I look at the stop r

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-12 Thread via lldb-commits
jeffreytan81 wrote: > What is going to happen in this mode if I have 5 threads stop at breakpoints, > and each have a breakpoint command that prints "I hit breakpoint X on thread > Y". I'll see that in the console for all the threads that hit breakpoints. > But what will I see when I look at t

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-12 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/98568 >From 13af0ff31688ca0a23f1fec65ca2d5797b65e31f Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Thu, 11 Jul 2024 17:24:41 -0700 Subject: [PATCH 1/3] Support single stopped event in lldb-dap --- .../test/t

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-12 Thread via lldb-commits
jimingham wrote: If I have a program with lots of threads - particularly if they are running in a small set of work functions - it's very common to have multiple breakpoint hits at the same time. And if there are lots of threads, then in this mode I'm going to end up having to scroll down the

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-12 Thread via lldb-commits
jimingham wrote: That was actually from a debugging session using the test. I got rid of all the other evidence of that experiment in the test case, but missed this one. Jim > On Jul 12, 2024, at 10:34 AM, Alex Langford ***@***.***> wrote: > > > @bulbazord commented on this pull request. >

[Lldb-commits] [lldb] fd42417 - [lldb] Allow fetching of RA register when above fault handler (#98566)

2024-07-12 Thread via lldb-commits
Author: Jason Molenda Date: 2024-07-12T10:44:18-07:00 New Revision: fd424179dcb3417fc0675f77d2bf06c750dd1c33 URL: https://github.com/llvm/llvm-project/commit/fd424179dcb3417fc0675f77d2bf06c750dd1c33 DIFF: https://github.com/llvm/llvm-project/commit/fd424179dcb3417fc0675f77d2bf06c750dd1c33.diff

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-12 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/98571 >From fb563e516f3a73d508ea7b3a61df4f1bab2f33a6 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Thu, 11 Jul 2024 17:50:08 -0700 Subject: [PATCH 1/2] Fix a bug where process events were being delivered to the se

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-12 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/98571 >From fb563e516f3a73d508ea7b3a61df4f1bab2f33a6 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Thu, 11 Jul 2024 17:50:08 -0700 Subject: [PATCH 1/3] Fix a bug where process events were being delivered to the se

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-12 Thread via lldb-commits
@@ -4248,7 +4248,21 @@ bool Process::ProcessEventData::ShouldStop(Event *event_ptr, return still_should_stop; } +bool Process::ProcessEventData::ForwardEventToPendingListeners(Event *event_ptr) { + // STDIO and the other async event notifications should always be forwarde

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -377,6 +380,26 @@ class Thread : public std::enable_shared_from_this, virtual void SetQueueLibdispatchQueueAddress(lldb::addr_t dispatch_queue_t) {} + /// When a thread stops at an enabled BreakpointSite that has not exectued, jimingham wrote: exectue

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -377,6 +380,26 @@ class Thread : public std::enable_shared_from_this, virtual void SetQueueLibdispatchQueueAddress(lldb::addr_t dispatch_queue_t) {} + /// When a thread stops at an enabled BreakpointSite that has not exectued, + /// the Process plugin should call SetT

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -377,6 +380,26 @@ class Thread : public std::enable_shared_from_this, virtual void SetQueueLibdispatchQueueAddress(lldb::addr_t dispatch_queue_t) {} + /// When a thread stops at an enabled BreakpointSite that has not exectued, + /// the Process plugin should call SetT

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -128,6 +128,9 @@ class Thread : public std::enable_shared_from_this, register_backup_sp; // You need to restore the registers, of course... uint32_t current_inlined_depth; lldb::addr_t current_inlined_pc; +lldb::addr_t stopped_at_unexecuted_bp; // Set to

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -1311,6 +1334,16 @@ class Thread : public std::enable_shared_from_this, bool m_should_run_before_public_stop; // If this thread has "stop others" // private work to do, then it will // set

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

2024-07-12 Thread via lldb-commits
jeffreytan81 wrote: > If I have a program with lots of threads - particularly if they are running > in a small set of work functions - it's very common to have multiple > breakpoint hits at the same time. And in this mode I'm going to end up having > to scroll down the list - which if I have l

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] 73dad7a - [LLDB] Fix remote executables load and caching (#98623)

2024-07-12 Thread via lldb-commits
Author: Vladislav Dzhidzhoev Date: 2024-07-12T20:43:08+02:00 New Revision: 73dad7a765226bd7ade98f85d050e80f411f6dad URL: https://github.com/llvm/llvm-project/commit/73dad7a765226bd7ade98f85d050e80f411f6dad DIFF: https://github.com/llvm/llvm-project/commit/73dad7a765226bd7ade98f85d050e80f411f6da

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] jimingham wrote: This table is great, but it deserves a line saying what it is. https://

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -607,6 +575,18 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( target ? target->GetArchitecture().GetMachine() : llvm::Triple::UnknownArch; + ProcessSP process_sp(thread.GetProcess()); + RegisterContextSP reg_ctx_sp(thread.GetRe

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [LLDB] Make 'process load' take remote os path delimiter into account (PR #98690)

2024-07-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes Currently, if we execute 'process load' with remote debugging, it uses the host's path delimiter to look up files on a target machine. If we run remote debugging of Linux target on Windows and exec

[Lldb-commits] [lldb] [LLDB] Make 'process load' take remote os path delimiter into account (PR #98690)

2024-07-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 73dad7a765226bd7ade98f85d050e80f411f6dad 98b75927878e35ca556ecbbecb1125621a63fea9 --e

[Lldb-commits] [lldb] [LLDB] Make 'process load' take remote os path delimiter into account (PR #98690)

2024-07-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 73dad7a765226bd7ade98f85d050e80f411f6dad...98b75927878e35ca556ecbbecb1125621a63fea9 lldb/

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test for case when tests are linked with libc++ statically (PR #98694)

2024-07-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes The test expects 'libstdc++' or 'libc++' SO module in the module list. In case when static linking with libc++ is on by default, none of them may be present. Thus, USE_SYSTEM_STDLIB is added to ens

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test for case when tests are linked with libc++ statically (PR #98694)

2024-07-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r bee240367cc48bbc93fe5eb57d537968dfe4419f...e98b2f73269ba4e8f1a980ffb2b2765d1de5f655 lldb/

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/96260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -633,171 +613,142 @@ StopInfoSP StopInfoMachException::CreateStopReasonWithMachException( } break; + // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code] + // + // Instruction step: + // [6, 1, 0] + // Intel KDP [6, 3, ??] + // armv7 [6, 0x102, ] Sa

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -1880,60 +1849,40 @@ ThreadSP ProcessGDBRemote::SetThreadStopInfo( StopInfo::CreateStopReasonVForkDone(*thread_sp)); handled = true; } - } else if (!signo) { -addr_t pc = thread_sp->GetRegisterContext()->GetPC(); -lldb::Br

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-07-12 Thread via lldb-commits
@@ -229,6 +229,17 @@ bool ScriptedThread::CalculateStopInfo() { LLVM_PRETTY_FUNCTION, "Failed to get scripted thread stop info.", error, LLDBLog::Thread); + // If we're at a BreakpointSite, mark that we stopped there and jimingham wrote: Is

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-07-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes --whole-archive and --allow-multiple-definition options has been added to linker flags of these import-std-module tests in order to make them pass with libcxx static linking enabled. Darwin has be

[Lldb-commits] [lldb] Add lldb version into initialize response lldb-dap (PR #98703)

2024-07-12 Thread via lldb-commits
https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/98703 Frequently, while troubleshooting user's debugging issues in VScode, we would like to know its version so that we can confirm if certain patch/feature is in or not. This PR adds version string into `initia

[Lldb-commits] [lldb] Add lldb version into initialize response lldb-dap (PR #98703)

2024-07-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes Frequently, while troubleshooting user's debugging issues in VScode, we would like to know its version so that we can confirm if certain patch/feature is in or not. This PR adds version string into `initialize`

[Lldb-commits] [lldb] Add lldb version into initialize response lldb-dap (PR #98703)

2024-07-12 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/98703 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

2024-07-13 Thread via lldb-commits
https://github.com/temyurchenko created https://github.com/llvm/llvm-project/pull/98795 Relanding of #93913. Now, it also fixes incorrect declaration context in function parameters creation. >From 410c7ba9fb7667dabdfbc48fdbda427401ca8df0 Mon Sep 17 00:00:00 2001 From: Artem Yurchenko <44875844

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

2024-07-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (temyurchenko) Changes Relanding of #93913. Now, it also fixes incorrect declaration context in function parameters creation. --- Full diff: https://github.com/llvm/llvm-project/pull/98795.diff 7 Files Affected: - (modified) clang/

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

2024-07-13 Thread via lldb-commits
https://github.com/temyurchenko updated https://github.com/llvm/llvm-project/pull/98795 >From 410c7ba9fb7667dabdfbc48fdbda427401ca8df0 Mon Sep 17 00:00:00 2001 From: Artem Yurchenko <44875844+temyurche...@users.noreply.github.com> Date: Thu, 30 May 2024 16:18:47 -0400 Subject: [PATCH 1/4] [clang

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

2024-07-13 Thread via lldb-commits
temyurchenko wrote: @AaronBallman could you please review? I've fixed at least the LLDB tests. There was an actual bug in function parameters construction that was revealed by the invariant check. However, I can't run the whole LLDB suite. Even among the reported failing tests, some are «un

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-14 Thread via lldb-commits
@@ -0,0 +1,165 @@ +(* LLDB Debug Expressions, a subset of C++ *) +(* Insired by https://www.nongnu.org/hcb *) + +expression = assignment_expression ; + +assignment_expression = conditional_expression +logical_or_expression assignment_operator assignment_ex

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-14 Thread via lldb-commits
@@ -0,0 +1,43 @@ +(* LLDB Debug Expressions, a subset of C++ *) +(* Insired by https://www.nongnu.org/hcb *) + +expression = cast_expression; + +cast_expression = unary_expression; + +unary_expression = postfix_expression + | unary_operator cast_expression; + +unar

[Lldb-commits] [clang] [lldb] Add Static Build option for LLDB Libraries (PR #98827)

2024-07-14 Thread via lldb-commits
https://github.com/vortex73 created https://github.com/llvm/llvm-project/pull/98827 - [ ] Added Option to statically build lldb - [ ] Packages lldb for easier package finding in other builds. >From 8ecf1b30678503f96d41112feb3ac87944c13158 Mon Sep 17 00:00:00 2001 From: Vortex Date: Sun, 14 Jul

[Lldb-commits] [clang] [lldb] Add Static Build option for LLDB Libraries (PR #98827)

2024-07-14 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [clang] [lldb] Add Static Build option for LLDB Libraries (PR #98827)

2024-07-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Narayan (vortex73) Changes - [ ] Added Option to statically build lldb - [ ] Packages lldb for easier package finding in other builds. --- Full diff: https://github.com/llvm/llvm-project/pull/98827.diff 4 Files Affected: - (modified) cl

[Lldb-commits] [clang] [lldb] Add Static Build option for LLDB Libraries (PR #98827)

2024-07-14 Thread via lldb-commits
https://github.com/vortex73 edited https://github.com/llvm/llvm-project/pull/98827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] Add Static Build option for LLDB Libraries (PR #98827)

2024-07-14 Thread via lldb-commits
https://github.com/vortex73 closed https://github.com/llvm/llvm-project/pull/98827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] [CMake] added static libraries and LLDB packaging (PR #98829)

2024-07-14 Thread via lldb-commits
https://github.com/vortex73 created https://github.com/llvm/llvm-project/pull/98829 - [ ] Added Option to statically build lldb - [ ] Packages lldb for easier package finding in other builds. #98754 >From af75070543fed40899db18d236de01cc30652d9d Mon Sep 17 00:00:00 2001 From: Vortex Date: Sun

[Lldb-commits] [lldb] [LLDB] [CMake] added static libraries and LLDB packaging (PR #98829)

2024-07-14 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [LLDB] [CMake] added static libraries and LLDB packaging (PR #98829)

2024-07-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Narayan (vortex73) Changes - [ ] Added Option to statically build lldb - [ ] Packages lldb for easier package finding in other builds. #98754 --- Full diff: https://github.com/llvm/llvm-project/pull/98829.diff 2 Files Affected: - (modif

[Lldb-commits] [lldb] [lldb] Fixed the error `unable to launch a GDB server` in API tests (PR #98833)

2024-07-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes TestPlatformLaunchGDBServer.py runs ldb-server w/o parameters `--min-gdbserver-port`, `--max-gdbserver-port` or `--gdbserver-port`. So `gdbserver_portmap` is empty and `gdbserver_portmap.GetNextAvailableP

[Lldb-commits] [lldb] [LLDB] [CMake] added static libraries and LLDB packaging (PR #98829)

2024-07-14 Thread via lldb-commits
https://github.com/vortex73 updated https://github.com/llvm/llvm-project/pull/98829 >From af75070543fed40899db18d236de01cc30652d9d Mon Sep 17 00:00:00 2001 From: Vortex Date: Sun, 14 Jul 2024 23:41:36 +0530 Subject: [PATCH] [LLDB] [CMake] added static libraries and LLDB packaging --- lldb/sou

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-14 Thread via lldb-commits
@@ -0,0 +1,446 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] progressive progress reporting for darwin kernel/firmware (PR #98845)

2024-07-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes When doing firmware/kernel debugging, it is frequent that binaries and debug info need to be retrieved / downloaded, and the lack of progress reports made for a poor experience, with lldb seemingly hung

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-14 Thread via lldb-commits
cmtice wrote: > On Jul 10, 2024, at 9:22 PM, cmtice ***@***.***> wrote: @cmtice commented on > this pull request. In lldb/include/lldb/Core/DILAST.h <[#95738 > (comment)](https://github.com/llvm/llvm-project/pull/95738#discussion_r1673380259)>: > > +/// Checks to see if the CompilerType is a S

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-07-15 Thread via lldb-commits
ita-sc wrote: Thanks. Could you please merge this? (I do not write access yet) https://github.com/llvm/llvm-project/pull/90075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove restriction for remote working directory (PR #89768)

2024-07-15 Thread via lldb-commits
ita-sc wrote: Gentle ping https://github.com/llvm/llvm-project/pull/89768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 82af559 - [API] add GetSyntheticValue (#95959)

2024-07-15 Thread via lldb-commits
Author: Vincent Belliard Date: 2024-07-15T17:28:56+02:00 New Revision: 82af55983d75d4a821b76ee926b19725ec7fa889 URL: https://github.com/llvm/llvm-project/commit/82af55983d75d4a821b76ee926b19725ec7fa889 DIFF: https://github.com/llvm/llvm-project/commit/82af55983d75d4a821b76ee926b19725ec7fa889.di

[Lldb-commits] [lldb] Add lldb version into initialize response lldb-dap (PR #98703)

2024-07-15 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/98703 >From 4c8619989ffd647fbbabeb124ef101bb9ec495be Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Fri, 12 Jul 2024 17:34:31 -0700 Subject: [PATCH 1/2] Add lldb version into initialize response --- .../tools

[Lldb-commits] [lldb] 44d9692 - Private process events were being delivered to the secondary listener (#98571)

2024-07-15 Thread via lldb-commits
Author: jimingham Date: 2024-07-15T15:07:01-07:00 New Revision: 44d9692e6a657ec46e98e4912ac56417da67cfee URL: https://github.com/llvm/llvm-project/commit/44d9692e6a657ec46e98e4912ac56417da67cfee DIFF: https://github.com/llvm/llvm-project/commit/44d9692e6a657ec46e98e4912ac56417da67cfee.diff LOG

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-15 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/98571 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add frame recognizer for __builtin_verbose_trap (PR #80368)

2024-07-15 Thread via lldb-commits
jimingham wrote: Sure. Jim > On Jul 13, 2024, at 2:20 AM, Michael Buch ***@***.***> wrote: > > > @jimingham @JDevlieghere > @clayborg > just to confirm, are you still ok with me landing this and

[Lldb-commits] [lldb] [lldb/Symbol] Hoist SymbolLocation from AssertFrameRecognizer to reuse it (PR #98975)

2024-07-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch hoists the `SymbolLocation` struct from the `AssertFrameRecognizer` source file, since it's pretty generic and could be reused for other purposes. --- Full diff: https://github.com/llvm/

[Lldb-commits] [lldb] 1c85496 - [lldb/Symbol] Hoist SymbolLocation from AssertFrameRecognizer to reuse it (#98975)

2024-07-15 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2024-07-15T16:06:29-07:00 New Revision: 1c854965fb20b3b8e0118318357516428ac244b2 URL: https://github.com/llvm/llvm-project/commit/1c854965fb20b3b8e0118318357516428ac244b2 DIFF: https://github.com/llvm/llvm-project/commit/1c854965fb20b3b8e0118318357516428ac244b2.

[Lldb-commits] [lldb] [lldb] Fix help syntax for add-dsym (target symbols add) (PR #98976)

2024-07-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The help output incorrectly states that this command takes a shared library name () while really it takes a path to a symbol file. rdar://131777043 --- Full diff: https://github.com/llv

[Lldb-commits] [lldb] [lldb] Fix help syntax for add-dsym (target symbols add) (PR #98976)

2024-07-15 Thread via lldb-commits
jimingham wrote: I'm a little surprised we don't have an argument type for eArgTypeSymbolFile. But I guess this is really the only command that uses it. I don't think it matters all that much, however, eArgTypeFilename is fine. https://github.com/llvm/llvm-project/pull/98976 __

[Lldb-commits] [lldb] [lldb] Fix help syntax for add-dsym (target symbols add) (PR #98976)

2024-07-15 Thread via lldb-commits
https://github.com/jimingham approved this pull request. This is fine. https://github.com/llvm/llvm-project/pull/98976 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] db9ac92 - Add lldb version into initialize response lldb-dap (#98703)

2024-07-15 Thread via lldb-commits
Author: jeffreytan81 Date: 2024-07-15T20:03:50-04:00 New Revision: db9ac92501509ce02ed188bb20a5211a9f29d5d3 URL: https://github.com/llvm/llvm-project/commit/db9ac92501509ce02ed188bb20a5211a9f29d5d3 DIFF: https://github.com/llvm/llvm-project/commit/db9ac92501509ce02ed188bb20a5211a9f29d5d3.diff

[Lldb-commits] [lldb] Add lldb version into initialize response lldb-dap (PR #98703)

2024-07-15 Thread via lldb-commits
https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/98703 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a1ffabc - [lldb][riscv] Fix setting breakpoint for undecoded instruction (#90075)

2024-07-16 Thread via lldb-commits
Author: ita-sc Date: 2024-07-16T10:03:42+01:00 New Revision: a1ffabc403d4ce55ab2e665511b0b68a16d4850b URL: https://github.com/llvm/llvm-project/commit/a1ffabc403d4ce55ab2e665511b0b68a16d4850b DIFF: https://github.com/llvm/llvm-project/commit/a1ffabc403d4ce55ab2e665511b0b68a16d4850b.diff LOG: [

<    1   2   3   4   5   6   7   8   9   10   >