[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 7b604cdf75fd1c741a15138684ea0e98dca5e46f 
fb563e516f3a73d508ea7b3a61df4f1bab2f33a6 --extensions cpp,h -- 
lldb/include/lldb/Target/Process.h lldb/include/lldb/Utility/Event.h 
lldb/source/Target/Process.cpp lldb/source/Utility/Event.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/include/lldb/Target/Process.h 
b/lldb/include/lldb/Target/Process.h
index 37fc192b44..c8475db8ae 100644
--- a/lldb/include/lldb/Target/Process.h
+++ b/lldb/include/lldb/Target/Process.h
@@ -465,7 +465,6 @@ public:
     static bool SetUpdateStateOnRemoval(Event *event_ptr);
 
   private:
-  
     bool ForwardEventToPendingListeners(Event *event_ptr) override;
 
     void SetUpdateStateOnRemoval() { m_update_state++; }
diff --git a/lldb/include/lldb/Utility/Event.h 
b/lldb/include/lldb/Utility/Event.h
index 5bea328d1f..4f58f257d4 100644
--- a/lldb/include/lldb/Utility/Event.h
+++ b/lldb/include/lldb/Utility/Event.h
@@ -50,16 +50,14 @@ public:
 private:
   /// This will be queried for a Broadcaster with a primary and some secondary
   /// listeners after the primary listener pulled the event from the event 
queue
-  /// and ran its DoOnRemoval, right before the event is delivered.  
-  /// If it returns true, the event will also be forwarded to the secondary  
-  /// listeners, and if false, event propagation stops at the primary 
listener. 
+  /// and ran its DoOnRemoval, right before the event is delivered.
+  /// If it returns true, the event will also be forwarded to the secondary
+  /// listeners, and if false, event propagation stops at the primary listener.
   /// Some broadcasters (particularly the Process broadcaster) fetch events on
   /// a private Listener, and then forward the event to the Public Listeners
   /// after some processing.  The Process broadcaster does not want to forward
   /// to the secondary listeners at the private processing stage.
-  virtual bool ForwardEventToPendingListeners(Event *event_ptr) {
-    return true;
-  }
+  virtual bool ForwardEventToPendingListeners(Event *event_ptr) { return true; 
}
 
   virtual void DoOnRemoval(Event *event_ptr) {}
 
diff --git a/lldb/source/Target/Process.cpp b/lldb/source/Target/Process.cpp
index a43684c999..618a6cf2d1 100644
--- a/lldb/source/Target/Process.cpp
+++ b/lldb/source/Target/Process.cpp
@@ -4248,12 +4248,13 @@ bool Process::ProcessEventData::ShouldStop(Event 
*event_ptr,
   return still_should_stop;
 }
 
-bool Process::ProcessEventData::ForwardEventToPendingListeners(Event 
*event_ptr) {
+bool Process::ProcessEventData::ForwardEventToPendingListeners(
+    Event *event_ptr) {
   // STDIO and the other async event notifications should always be forwarded.
   if (event_ptr->GetType() != Process::eBroadcastBitStateChanged)
     return true;
 
-  // For state changed events, if the update state is one, we are handling 
+  // For state changed events, if the update state is one, we are handling
   // this on the private state thread.  We should wait for the public event.
   return m_update_state == 1;
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/98571
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits