https://github.com/jeffreytan81 approved this pull request.
I would suggest we added a unit test that checks that we do get an error
message if saving minidump failed.
Other than that, this looks good.
https://github.com/llvm/llvm-project/pull/108259
__
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
030c6da7af826b641db005be925b20f956c3a6bb...099f017208ddadc07b3743ea7b04612f0f79617f
lldb
jeffreytan81 wrote:
@jimingham, sounds good. I will move the logic into ValueObject.
> TryAllThreads is true
I did not see any client code setting this to true, I assume this happens
because `m_try_others` is true by default? Maybe we should set `m_try_others`'s
default value to false to avoi
jeffreytan81 wrote:
Also, I want to point out that, in this specific example, IRInterpreter will
try to interpret the "(bool)true" expression so it won't run the thread plan
with `TryAllThreads = true`, but I assume you are commenting the danger in a
general sense.
https://github.com/llvm/ll
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/107485
>From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 5 Sep 2024 15:51:35 -0700
Subject: [PATCH 1/5] [lldb-dap] Add feature to remember last non-empty
expression.
@@ -1364,8 +1364,20 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
jimingham wrote:
You are right, TryAllThreads defaults to True.
Not using TryAllThreads is actually dangerous in the general case. For
instance, you can have the thread you run take a lock, then call some code that
tries another lock that is held by a thread we aren't running. That times o
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/108414
>From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Mon, 19 Aug 2024 10:57:35 -0700
Subject: [PATCH 1/4] Fix StartDebuggingRequestHandler/ReplModeRequestHandler
jeffreytan81 wrote:
It's funny that there is already an `ValueObject::CreateValueObjectFromBool()`
function :-)
https://github.com/llvm/llvm-project/pull/108414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
jimingham wrote:
BTW, I agree that the "run one thread, then run all threads" strategy is
unfortunate. But I can't think of a better way to do that that's likely to be
supported on all platforms. It might be good at some point to add a "Lock
detection plugin" that could provide enough inform
jeffreytan81 wrote:
> You are right, TryAllThreads defaults to True.
>
> Not using TryAllThreads is actually dangerous in the general case. For
> instance, you can have the thread you run take a lock, then call some code
> that tries another lock that is held by a thread we aren't running. Tha
jimingham wrote:
> It's funny that there is already a `ValueObject::CreateValueObjectFromBool()`
> function :-)
The very thing I was worried about!
Might be a good idea to put the general "don't do substantial implementations
in SB API" principle in the "SBI API" doc page. I did a quick scan
jimingham wrote:
> > You are right, TryAllThreads defaults to True.
> > Not using TryAllThreads is actually dangerous in the general case. For
> > instance, you can have the thread you run take a lock, then call some code
> > that tries another lock that is held by a thread we aren't running. T
@@ -645,6 +645,23 @@ lldb::SBValue SBValue::CreateValueFromData(const char
*name, SBData data,
return sb_value;
}
+lldb::SBValue SBValue::CreateBoolValue(const char *name, bool value) {
+ LLDB_INSTRUMENT_VA(this, name);
+
+ lldb::SBValue sb_value;
+ lldb::ValueObjectSP n
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
c2b93e0671d8cfd6b1a24c6e1d7be290125b8974...33b647410bacca3e429d1021b8c8ef9ea14ddbe6
lldb
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/108462
None
>From f1b503559d9c488b3f2354b836fe5031548b7903 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 12 Sep 2024 15:25:19 -0700
Subject: [PATCH] Add a comment in the SB API doc about keeping the SB API's
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/108462.diff
1 Files Affected:
- (modified) lldb/docs/resources/sbapi.rst (+11)
``diff
diff --git a/lldb/docs/resources/sbapi.rst b/lldb/docs/re
jimingham wrote:
> > It's funny that there is already a
> > `ValueObject::CreateValueObjectFromBool()` function :-)
>
> The very thing I was worried about!
>
> Might be a good idea to put the general "don't do substantial implementations
> in SB API" principle in the "SBI API" doc page. I did
@@ -175,9 +175,10 @@
"type": "array",
"description": "Additional environment variables to set
when launching the program. E.g. `[\"FOO=1\", \"BAR\"]`",
"items": {
- "type": "string"
+
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/8] [lldb-dap] Make environment option an object
---
.../tools/l
jimingham wrote:
This is more an architectural issue. Right now, we're always handing out
ValueObjectSP's which means there are two ways of indicating failure, having an
empty ValueObjectSP, and having a ValueObjectSP that has a ValueObject in it,
but it's Error state is set. That's pretty a
jimingham wrote:
> Could you please recommend something to me? If you don't have something
> specific in mind right now, should I look it up and then ask if it is
> suitable to work on before I begin?
The conversion of error handling behaviors was Adrian's project, I haven't
thought about it
@@ -645,6 +645,23 @@ lldb::SBValue SBValue::CreateValueFromData(const char
*name, SBData data,
return sb_value;
}
+lldb::SBValue SBValue::CreateBoolValue(const char *name, bool value) {
+ LLDB_INSTRUMENT_VA(this, name);
+
+ lldb::SBValue sb_value;
+ lldb::ValueObjectSP n
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/108414
>From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Mon, 19 Aug 2024 10:57:35 -0700
Subject: [PATCH 1/5] Fix StartDebuggingRequestHandler/ReplModeRequestHandler
https://github.com/jeffreytan81 approved this pull request.
Now I wish we can feed this kind of information to AI and let AI code review
and catch it :-)
https://github.com/llvm/llvm-project/pull/108462
___
lldb-commits mailing list
lldb-commits@list
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Add an "always on" log category and channel. Unlike other, existing log
channels, it is not exposed to users. The channel is meant to be used sparsely
and deliberately for logging high-value informa
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Emit signpost intervals for progress events so that when users report an
operation takes a long time, we can see investigate the issue with Instruments.
---
Full diff: https://github.com/llvm/llvm-p
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
lldb-server built with NativeProcessLinux.cpp and NativeProcessFreeBSD.cpp can
use breakpoints to implement instruction stepping on cores where there is no
native instruction-step primitive. Currently
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
xusheng added support for swbreak/hwbreak a month ago, and no special support
was needed in ProcessGDBRemote when they're received because lldb already marks
a thread as having hit a breakpoint when it
Author: Pavel Labath
Date: 2024-09-13T11:18:05+02:00
New Revision: 069b841c2ecde39c65ca74660b681d4d25a4bbb2
URL:
https://github.com/llvm/llvm-project/commit/069b841c2ecde39c65ca74660b681d4d25a4bbb2
DIFF:
https://github.com/llvm/llvm-project/commit/069b841c2ecde39c65ca74660b681d4d25a4bbb2.diff
Author: Pavel Labath
Date: 2024-09-13T11:21:50+02:00
New Revision: e054712a85f924e0afe7f180fd960be7a8214d64
URL:
https://github.com/llvm/llvm-project/commit/e054712a85f924e0afe7f180fd960be7a8214d64
DIFF:
https://github.com/llvm/llvm-project/commit/e054712a85f924e0afe7f180fd960be7a8214d64.diff
Author: Michael Buch
Date: 2024-09-13T11:01:25+01:00
New Revision: 4ca8fb18129e6465c3594a8681f1cca0e2aff724
URL:
https://github.com/llvm/llvm-project/commit/4ca8fb18129e6465c3594a8681f1cca0e2aff724
DIFF:
https://github.com/llvm/llvm-project/commit/4ca8fb18129e6465c3594a8681f1cca0e2aff724.diff
Author: Pavel Labath
Date: 2024-09-13T12:56:52+02:00
New Revision: ebbc9ed2d60cacffc87232dc32374a2b38b92175
URL:
https://github.com/llvm/llvm-project/commit/ebbc9ed2d60cacffc87232dc32374a2b38b92175
DIFF:
https://github.com/llvm/llvm-project/commit/ebbc9ed2d60cacffc87232dc32374a2b38b92175.diff
@@ -471,6 +498,18 @@ static void SetupTargetOpts(CompilerInstance &compiler,
// Set the target ABI
if (std::string abi = GetClangTargetABI(target_arch); !abi.empty())
compiler.getTargetOpts().ABI = std::move(abi);
+
+ if ((target_machine == llvm::Triple::riscv64 &&
+
https://github.com/dlav-sc edited
https://github.com/llvm/llvm-project/pull/99336
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Da-Viper wrote:
> Nice improvement. Don't forget to write a test
Will do this evening
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
@@ -45,7 +45,8 @@ bool RunLLDBCommands(llvm::StringRef prefix,
// RunTerminateCommands.
static std::mutex handle_command_mutex;
std::lock_guard locker(handle_command_mutex);
- interp.HandleCommand(command.str().c_str(), result);
+ interp.HandleComman
Author: Jason Molenda
Date: 2024-09-13T09:02:31-07:00
New Revision: 213c59ddd2a702ddd3d849cea250440b1ed718e0
URL:
https://github.com/llvm/llvm-project/commit/213c59ddd2a702ddd3d849cea250440b1ed718e0
DIFF:
https://github.com/llvm/llvm-project/commit/213c59ddd2a702ddd3d849cea250440b1ed718e0.diff
Author: Jason Molenda
Date: 2024-09-13T09:04:28-07:00
New Revision: 65a4d11b1e67429d53df1fcee0f93492aa95c448
URL:
https://github.com/llvm/llvm-project/commit/65a4d11b1e67429d53df1fcee0f93492aa95c448
DIFF:
https://github.com/llvm/llvm-project/commit/65a4d11b1e67429d53df1fcee0f93492aa95c448.diff
Author: Jacob Lalonde
Date: 2024-09-13T09:17:06-07:00
New Revision: 661382f2c07ba464caa0ad0fb8c64c1c3b20e9a4
URL:
https://github.com/llvm/llvm-project/commit/661382f2c07ba464caa0ad0fb8c64c1c3b20e9a4
DIFF:
https://github.com/llvm/llvm-project/commit/661382f2c07ba464caa0ad0fb8c64c1c3b20e9a4.diff
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/107485
>From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 5 Sep 2024 15:51:35 -0700
Subject: [PATCH 1/6] [lldb-dap] Add feature to remember last non-empty
expression.
@@ -45,7 +45,8 @@ bool RunLLDBCommands(llvm::StringRef prefix,
// RunTerminateCommands.
static std::mutex handle_command_mutex;
std::lock_guard locker(handle_command_mutex);
- interp.HandleCommand(command.str().c_str(), result);
+ interp.HandleComman
@@ -1364,8 +1364,14 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
@@ -1376,6 +1382,16 @@ void request_evaluate(const llvm::json::Object &request)
{
EmplaceSafeString(body, "result", result);
body.try_emplace("variablesReference", (int64_t)0);
} else {
+if (context != "hover") {
cmtice wrote:
Done.
https://git
cmtice wrote:
All reviewer comments have been addressed. Please take another look. Thank you!
https://github.com/llvm/llvm-project/pull/107485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Adds a test that ensures two minidumps produced from the same target are the
same bytes. Covers the three primary core flavors.
---
Full diff: https://github.com/llvm/llvm-project/pull/108602.diff
1 Files
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
661382f2c07ba464caa0ad0fb8c64c1c3b20e9a4...60b48f98ffa70dbf633f1b9bf935479dbfce59d4
lldb
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/108414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -645,6 +645,23 @@ lldb::SBValue SBValue::CreateValueFromData(const char
*name, SBData data,
return sb_value;
}
+lldb::SBValue SBValue::CreateBoolValue(const char *name, bool value) {
+ LLDB_INSTRUMENT_VA(this, name);
+
+ lldb::SBValue sb_value;
+ lldb::ValueObjectSP n
Author: jimingham
Date: 2024-09-13T10:18:03-07:00
New Revision: 02d8813820b1ebf3fae6993e677db269f0077272
URL:
https://github.com/llvm/llvm-project/commit/02d8813820b1ebf3fae6993e677db269f0077272
DIFF:
https://github.com/llvm/llvm-project/commit/02d8813820b1ebf3fae6993e677db269f0077272.diff
LOG
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/108462
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jeffreytan81
Date: 2024-09-13T10:26:01-07:00
New Revision: b6bf27ef3c179eefd805f39aa681705fc980ceed
URL:
https://github.com/llvm/llvm-project/commit/b6bf27ef3c179eefd805f39aa681705fc980ceed
DIFF:
https://github.com/llvm/llvm-project/commit/b6bf27ef3c179eefd805f39aa681705fc980ceed.diff
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/108414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alex Langford
Date: 2024-09-13T10:33:43-07:00
New Revision: 0351dc522a25df0473a63b414a5bfde5814d3dc3
URL:
https://github.com/llvm/llvm-project/commit/0351dc522a25df0473a63b414a5bfde5814d3dc3
DIFF:
https://github.com/llvm/llvm-project/commit/0351dc522a25df0473a63b414a5bfde5814d3dc3.diff
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/106919
>From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 1 Sep 2024 17:26:11 +0100
Subject: [PATCH 1/9] [lldb-dap] Make environment option an object
---
.../tools/l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
These benchmarks don't get run as part of the regular API test-suite. And I'm
not aware of any CI running this. Also, I haven't quite managed to actually run
them locally using the `bench.py` script. It lo
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Brendan Shanks (mrpippy)
Changes
macOS 10.15 added a "full" x86_64 GPR thread state flavor, equivalent to the
normal one but with DS, ES, SS, and GSbase added. This flavor can only be used
with processes that install a custom LDT (function
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b74e7792194d9a8a9ef32c7dc1ffcd205b299336
4453801c7d8abf7a6adfb7fae57ad9fa9d52a0c4 --e
Author: Jonas Devlieghere
Date: 2024-09-14T10:50:44-07:00
New Revision: fa478bd275f473861f6d4df4896244a730d4853f
URL:
https://github.com/llvm/llvm-project/commit/fa478bd275f473861f6d4df4896244a730d4853f
DIFF:
https://github.com/llvm/llvm-project/commit/fa478bd275f473861f6d4df4896244a730d4853f.d
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Reverts llvm/llvm-project#106791 because it breaks
`trap_frame_sym_ctx.test ` on x86_64.
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/5745/
---
Full diff: https://github.com/ll
https://github.com/kusmour created
https://github.com/llvm/llvm-project/pull/108719
Summary: This introduced from upstream
[#107163](https://github.com/llvm/llvm-project/pull/107163)
Test Plan: I can build
>From ff2f26081b5535587e5ccb28522b728a596b6e12 Mon Sep 17 00:00:00 2001
From: Wanyi Ye
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Wanyi (kusmour)
Changes
Summary: This introduced from upstream [#107163](https://github.com/llvm/llvm-project/pull/107163)
Test Plan: I can build
---
Full diff: https://github.com/llvm/llvm-project/pull/108719.diff
1 Files Affected:
- (
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This is a follow-up to https://github.com/llvm/llvm-project/pull/98330 for the
upcoming `__compressed_pair` refactor in
https://github.com/llvm/llvm-project/issues/93069
This patch just adds the 2 new cop
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Youngsuk Kim (JOE1994)
Changes
* Don't call raw_string_ostream::flush(), which is essentially a no-op.
* Avoid unneeded calls to raw_string_ostream::str(), to avoid excess
indirection.
---
Patch is 26.83 KiB, truncated to 20.00 KiB below,
root-kidik wrote:
Ping
https://github.com/llvm/llvm-project/pull/105715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Youngsuk Kim
Date: 2024-09-16T00:26:51-04:00
New Revision: d7796855b87911b8ae6c726ab5df4949f173dbd2
URL:
https://github.com/llvm/llvm-project/commit/d7796855b87911b8ae6c726ab5df4949f173dbd2
DIFF:
https://github.com/llvm/llvm-project/commit/d7796855b87911b8ae6c726ab5df4949f173dbd2.diff
Author: Michael Buch
Date: 2024-09-16T10:11:49+01:00
New Revision: 9e9b1178ca435f690381ffe8241e4bf1bb7e60fb
URL:
https://github.com/llvm/llvm-project/commit/9e9b1178ca435f690381ffe8241e4bf1bb7e60fb
DIFF:
https://github.com/llvm/llvm-project/commit/9e9b1178ca435f690381ffe8241e4bf1bb7e60fb.diff
Author: Michael Buch
Date: 2024-09-16T10:15:52+01:00
New Revision: 7e5fe3ec5aed001c3b8f0bf59167b6472b91b9cc
URL:
https://github.com/llvm/llvm-project/commit/7e5fe3ec5aed001c3b8f0bf59167b6472b91b9cc
DIFF:
https://github.com/llvm/llvm-project/commit/7e5fe3ec5aed001c3b8f0bf59167b6472b91b9cc.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This can legitimately happen for static function-local variables with a
non-manual dwarf index. According to the DWARF spec, these variables should be
(and are) included in the compiler generated indexes, but
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
Use a `nullptr` map entry to mean "variable parse was attempted and it failed"
an the absence of an entry to mean "parsing hasn't been attempted yet".
I ran into this because parsing of function-static variabl
@@ -124,6 +124,9 @@ class ABISysV_riscv : public lldb_private::RegInfoBasedABI {
using lldb_private::RegInfoBasedABI::RegInfoBasedABI; // Call CreateInstance
// instead.
bool m_is_rv64; // true if target is riscv64; fa
https://github.com/dlav-sc updated
https://github.com/llvm/llvm-project/pull/99336
>From 10d7addd0a86789e268189e00a825af27516323e Mon Sep 17 00:00:00 2001
From: Daniil Avdeev
Date: Thu, 11 Jul 2024 11:21:36 +
Subject: [PATCH 1/5] [lldb][RISCV] add jitted function calls to ABI
Function call
@@ -164,11 +167,82 @@ TotalArgsSizeInWords(bool is_rv64,
return total_size;
}
+static bool UpdateRegister(RegisterContext *reg_ctx,
+ const lldb::RegisterKind reg_kind,
+ const uint32_t reg_num, const addr_t value) {
+ Log
@@ -164,11 +167,82 @@ TotalArgsSizeInWords(bool is_rv64,
return total_size;
}
+static bool UpdateRegister(RegisterContext *reg_ctx,
+ const lldb::RegisterKind reg_kind,
+ const uint32_t reg_num, const addr_t value) {
+ Log
dlav-sc wrote:
@JDevlieghere @jasonmolenda @labath @tedwoodward could you take another look,
please.
https://github.com/llvm/llvm-project/pull/99336
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
Author: Michael Buch
Date: 2024-09-16T13:46:19+01:00
New Revision: 765e106fb1b0e0aeb1bba18dfd93bd28233bba2f
URL:
https://github.com/llvm/llvm-project/commit/765e106fb1b0e0aeb1bba18dfd93bd28233bba2f
DIFF:
https://github.com/llvm/llvm-project/commit/765e106fb1b0e0aeb1bba18dfd93bd28233bba2f.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This attempts to improve user-experience when LLDB stops on a verbose_trap.
Currently if a `__builtin_verbose_trap` triggers, we display the first frame
above the call to the verbose_trap. So in the newly
@@ -1376,6 +1382,16 @@ void request_evaluate(const llvm::json::Object &request)
{
EmplaceSafeString(body, "result", result);
body.try_emplace("variablesReference", (int64_t)0);
} else {
+if (context == "repl") {
+ // If the expression is empty and the last e
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/107485
>From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 5 Sep 2024 15:51:35 -0700
Subject: [PATCH 1/7] [lldb-dap] Add feature to remember last non-empty
expression.
@@ -1364,8 +1364,14 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
- if (context == "repl" && g_dap.DetectExpressionContext(frame,
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) {
static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response,
uint64_t fail_result, Status &error)
{
+ // The packet is expected to have the following
https://github.com/kusmour updated
https://github.com/llvm/llvm-project/pull/108719
>From 9f41e2a32f1800a9d98a749cf109d9a3072e2210 Mon Sep 17 00:00:00 2001
From: Wanyi Ye
Date: Sat, 14 Sep 2024 14:23:01 -0700
Subject: [PATCH] [lldb][intel-pt] Fix build error on conversion from
llvm::Error to S
cmtice wrote:
Ping? Anybody?
https://github.com/llvm/llvm-project/pull/95738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
@llvm/pr-subscribers-libcxx
Author: Adrian Vogelsgesang (vogelsgesang)
Changes
This commit changes the libc++ frame recognizer to hide implementation details
of libc++ more aggressively. The applied heuristic is rather straightforward:
We consider
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
6d3f6c2170dd60e86743c205e33ead2f455656b4...f0ffdc6f1d999dc3c774f1d42d03db286705c1b5
lldb
Author: Adrian Vogelsgesang
Date: 2024-09-16T22:56:20+02:00
New Revision: 3acb1eac5eb6ef4e60dd64b7845615e076cc6a3e
URL:
https://github.com/llvm/llvm-project/commit/3acb1eac5eb6ef4e60dd64b7845615e076cc6a3e
DIFF:
https://github.com/llvm/llvm-project/commit/3acb1eac5eb6ef4e60dd64b7845615e076cc6a3e
cmtice wrote:
> Is the plan to get the DIL data structures merged before the rest of the
> patch series is up for review? I think it'd be great to see how the
> infrastructure introduced here will be used
There are 3 major pieces to the DIL implementation (soon to be 4, once I've got
the lexe
Author: Jacob Lalonde
Date: 2024-09-16T15:13:35-07:00
New Revision: 0975e2ac58b6d62429d51df54911fb4d03dcda05
URL:
https://github.com/llvm/llvm-project/commit/0975e2ac58b6d62429d51df54911fb4d03dcda05
DIFF:
https://github.com/llvm/llvm-project/commit/0975e2ac58b6d62429d51df54911fb4d03dcda05.diff
Author: Adrian Vogelsgesang
Date: 2024-09-17T02:18:52+02:00
New Revision: 0cc2cd781594aec741f7262df7a48d73a7d09a18
URL:
https://github.com/llvm/llvm-project/commit/0cc2cd781594aec741f7262df7a48d73a7d09a18
DIFF:
https://github.com/llvm/llvm-project/commit/0cc2cd781594aec741f7262df7a48d73a7d09a18
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/108907
## Context
We have a customer reporting scenario that expanding "this" pointer for a
non-trivial class method context takes more than **70~90 seconds**. This is a
linux target with .debug_names index table
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/108907
>From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Mon, 19 Aug 2024 10:57:35 -0700
Subject: [PATCH 1/5] Fix StartDebuggingRequestHandler/ReplModeRequestHandler
https://github.com/jeffreytan81 ready_for_review
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jeffreytan81)
Changes
## Context
We have a customer reporting scenario that expanding "this" pointer for a
non-trivial class method context takes more than **70~90 seconds**. This is a
linux target with .debug_names index table enabl
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/serby2000 created
https://github.com/llvm/llvm-project/pull/108948
Frequently, environment variables such as `LLDB_USE_NATIVE_PDB_READER` are
needed to be able to use lldb-dap in vscode
This PR adds a way to set the environment for the lldb-dap process using
configuration.
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Serban (serby2000)
Changes
Frequently, environment variables such as `LLDB_USE_NATIVE_PDB_READER` are
needed to be able to use lldb-dap in vscode
This PR adds a way to set the environment for the lldb-dap process using
configuration.
---
https://github.com/dlav-sc updated
https://github.com/llvm/llvm-project/pull/99336
>From 08b0bb18e46be06ddf6397455382c5b75bc3b757 Mon Sep 17 00:00:00 2001
From: Daniil Avdeev
Date: Thu, 11 Jul 2024 11:21:36 +
Subject: [PATCH 1/5] [lldb][RISCV] add jitted function calls to ABI
Function call
@@ -124,6 +124,9 @@ class ABISysV_riscv : public lldb_private::RegInfoBasedABI {
using lldb_private::RegInfoBasedABI::RegInfoBasedABI; // Call CreateInstance
// instead.
bool m_is_rv64; // true if target is riscv64; fa
2201 - 2300 of 98296 matches
Mail list logo
