[Lldb-commits] [lldb] [lldb] Add frame recognizers for libc++ `std::invoke` (PR #105695)

2024-08-25 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 675c748bb606d75a959481e6014299849cf3094c 32786ae0abb7c465dfab602b1d53da11dd1dc7a7 --e

[Lldb-commits] [lldb] Add logs for SymbolFileDWARF::FindTypes (PR #106030)

2024-08-25 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] Add logs for SymbolFileDWARF::FindTypes (PR #106030)

2024-08-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitrii Galimzianov (DmT021) Changes `SymbolFileDWARF::FindTypes` was logged prior to [this commit](https://github.com/llvm/llvm-project/commit/dd9587795811ba21e6ca6ad52b4531e17e6babd6#diff-edef3a65d5d569bbb75a4158d35b827aa5d42ee03ccd3b0c1d

[Lldb-commits] [lldb] [lldb] unique_ptr-ify some GetUserExpression APIs. (PR #106034)

2024-08-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Lang Hames (lhames) Changes These methods already returned a uniquely owned object, this just makes them self-documenting. --- Full diff: https://github.com/llvm/llvm-project/pull/106034.diff 7 Files Affected: - (modified) lldb/include/

[Lldb-commits] [lldb] 06ccd32 - [lldb][NFC] Moved the SharedSocket class to Socket.* (#104787)

2024-08-26 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-08-26T18:26:46+04:00 New Revision: 06ccd32bb7b26b84448036c18e7191d9e56adc82 URL: https://github.com/llvm/llvm-project/commit/06ccd32bb7b26b84448036c18e7191d9e56adc82 DIFF: https://github.com/llvm/llvm-project/commit/06ccd32bb7b26b84448036c18e7191d9e56adc82.dif

[Lldb-commits] [lldb] [lldb] IRMemoryMap zero address mapping fix (PR #99045)

2024-08-26 Thread via lldb-commits
https://github.com/dlav-sc closed https://github.com/llvm/llvm-project/pull/99045 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2024-08-26 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 1193f7d6487d2d94009f8d8d27da3907136482b9...e9ffeeaf7a0bf70c58a04315e451ba4553765586 .gith

[Lldb-commits] [lldb] Fix dap stacktrace perf issue (PR #104874)

2024-08-26 Thread via lldb-commits
jimingham wrote: This is compiling the "get me extended backtrace info function". That's a ClangFunction, so we should only compile it once and then reuse it for the rest of the session. Is it possible we aren't reusing this? After all, this is a compile of a function that's pretty careful

[Lldb-commits] [lldb] 924a7d8 - Use CLANG_RESOURCE_DIR more consistently (#103388)

2024-08-26 Thread via lldb-commits
Author: Kim Gräsman Date: 2024-08-26T14:49:56-03:00 New Revision: 924a7d83b4287b3b85dd1ca29d2d3e1f0a10ea68 URL: https://github.com/llvm/llvm-project/commit/924a7d83b4287b3b85dd1ca29d2d3e1f0a10ea68 DIFF: https://github.com/llvm/llvm-project/commit/924a7d83b4287b3b85dd1ca29d2d3e1f0a10ea68.diff L

[Lldb-commits] [lldb] 89c27d6 - [lldb-dap] Enabling instruction breakpoint support to lldb-dap. (#105278)

2024-08-26 Thread via lldb-commits
Author: Santhosh Kumar Ellendula Date: 2024-08-27T00:19:39+05:30 New Revision: 89c27d6b07dd03a71e5692caa4e20ab14f948921 URL: https://github.com/llvm/llvm-project/commit/89c27d6b07dd03a71e5692caa4e20ab14f948921 DIFF: https://github.com/llvm/llvm-project/commit/89c27d6b07dd03a71e5692caa4e20ab14f9

[Lldb-commits] [lldb] [lldb] Cleanup dyld_process_t after constructing SharedCacheInfo (PR #106157)

2024-08-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes Without calling `dyld_process_dispose`, LLDB will leak the memory associated with the `dyld_process_t`. rdar://134738265 --- Full diff: https://github.com/llvm/llvm-project/pull/106157.diff 1 Files Affe

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes This patch removes all of the Set.* methods from Status. This cleanup is part of a series of patches that make it harder use the anti-pattern of keeping a long-lives Status object around and updating i

[Lldb-commits] [lldb] Disable ThreadPlanSingleThreadTimeout during step over breakpoint (PR #104532)

2024-08-26 Thread via lldb-commits
jimingham wrote: This seems an okay solution for now. We really don't want to miss breakpoint hits if we can at all avoid it. This isn't a regression, it's just one case where the proposed enhancement to stepping doesn't enhance stepping. We haven't had many (any?) reports of single steppi

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

2024-08-26 Thread via lldb-commits
jimingham wrote: > > When we were talking about this originally I thought that StackFrames would > > get an "ImplementationFrame" property, and we would use that to determine > > whether to hide the frame in bt (when not passing --unfiltered). Then the > > frame recognizers when they are run o

[Lldb-commits] [lldb] [lldb][dap] always add column field in StackFrame body (PR #73393)

2024-08-26 Thread via lldb-commits
CheapMeow wrote: It still has bug in VSCode: The editor could not be opened due to an unexpected error: Invalid arguments My llvm version is ``` lldb version 18.1.8 clang version 18.1.8 Target: x86_64-pc-windows-msvc Thread model: posix InstalledDir: E:\software\LLVM\bin Found HIP installation

[Lldb-commits] [lldb] fbef4c2 - [lldb][lldb-dap] Fix for TestDAP_instruction_breakpoint.py test failure on windows. (#106200)

2024-08-27 Thread via lldb-commits
Author: Santhosh Kumar Ellendula Date: 2024-08-27T10:31:18+01:00 New Revision: fbef4c2d31d1e3d1e5f7e285fdf397aeb161 URL: https://github.com/llvm/llvm-project/commit/fbef4c2d31d1e3d1e5f7e285fdf397aeb161 DIFF: https://github.com/llvm/llvm-project/commit/fbef4c2d31d1e3d1e5f7e285fdf397a

[Lldb-commits] [lldb] ca3b9af - Add logs for SymbolFileDWARF::FindTypes (#106030)

2024-08-27 Thread via lldb-commits
Author: Dmitrii Galimzianov Date: 2024-08-27T10:41:09+01:00 New Revision: ca3b9af98c0b119598bc26a9130f468b196d83b3 URL: https://github.com/llvm/llvm-project/commit/ca3b9af98c0b119598bc26a9130f468b196d83b3 DIFF: https://github.com/llvm/llvm-project/commit/ca3b9af98c0b119598bc26a9130f468b196d83b3

[Lldb-commits] [lldb] Add logs for SymbolFileDWARF::FindTypes (PR #106030)

2024-08-27 Thread via lldb-commits
github-actions[bot] wrote: @DmT021 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [clang] [lldb] [llvm] [ARM] musttail fixes (PR #102896)

2024-08-27 Thread via lldb-commits
https://github.com/kiran-isaac updated https://github.com/llvm/llvm-project/pull/102896 >From 24806b179d34b4afb21832e4a2150c13995b59e0 Mon Sep 17 00:00:00 2001 From: Kiran Date: Thu, 8 Aug 2024 13:07:24 +0100 Subject: [PATCH 1/4] [ARM] musttail fixes Backend: - Caller and callee arguments no l

[Lldb-commits] [lldb] d517b22 - [LLDB][SBSaveCore] Add selectable memory regions to SBSaveCore (#105442)

2024-08-27 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-08-27T07:33:12-07:00 New Revision: d517b224117f760e6a7299b267256e3240c04edb URL: https://github.com/llvm/llvm-project/commit/d517b224117f760e6a7299b267256e3240c04edb DIFF: https://github.com/llvm/llvm-project/commit/d517b224117f760e6a7299b267256e3240c04edb.diff

[Lldb-commits] [lldb] [lldb] Fix and speedup the `memory find` command (PR #104193)

2024-08-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This patch fixes an issue where the `memory find` command would effectively stop searching after encountering a memory read error (which could happen due to unreadable memory), without giving any indication that

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6e44cb3ccb822085cd2f35c63daa60395dda26f2 37febe79c170b0575051b5fb24a9db3208721b0b --e

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread via lldb-commits
jimingham wrote: > On Aug 27, 2024, at 8:51 AM, Adrian Prantl ***@***.***> wrote: > > > I like this. I have just two remarks: > > it might be better to split this into three steps (add new APIs, port to new > APIs, remove old APIs), as that will make reverts easier/less disruptive (I > don

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread via lldb-commits
jimingham wrote: That should of course be lldb_private::Error -> lldb_private::Status... Jim > On Aug 27, 2024, at 9:48 AM, Jim Ingham ***@***.***> wrote: > >> >> >> >>> On Aug 27, 2024, at 8:51 AM, Adrian Prantl ***@***.***> wrote: >>> >>> >>> I like this. I have just two remarks: >>>

[Lldb-commits] [lldb] 384d69f - [lldb] Cleanup dyld_process_t after constructing SharedCacheInfo (#106157)

2024-08-27 Thread via lldb-commits
Author: Alex Langford Date: 2024-08-27T09:59:17-07:00 New Revision: 384d69fcbbd07941e7eb1899435e4d56d0469637 URL: https://github.com/llvm/llvm-project/commit/384d69fcbbd07941e7eb1899435e4d56d0469637 DIFF: https://github.com/llvm/llvm-project/commit/384d69fcbbd07941e7eb1899435e4d56d0469637.diff

[Lldb-commits] [lldb] dd060bd - [lldb] Add frame recognizers for libc++ `std::invoke` (#105695)

2024-08-27 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-08-27T19:15:42+02:00 New Revision: dd060bdede8edec18ad5ca122e15cc24a821e3fe URL: https://github.com/llvm/llvm-project/commit/dd060bdede8edec18ad5ca122e15cc24a821e3fe DIFF: https://github.com/llvm/llvm-project/commit/dd060bdede8edec18ad5ca122e15cc24a821e3fe

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-lldb Author: Rahul Joshi (jurahul) Changes - Change formatv() to validate that the number of arguments passed matches number of replacement fields in the format string. - When the format string is a literal, this f

[Lldb-commits] [lldb] [lldb] Fix test expectation in `TestFrameRecognizer.py` (PR #106281)

2024-08-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/106281.diff 1 Files Affected: - (modified) lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py (+1-1) ``diff diff

[Lldb-commits] [lldb] fc51797 - [lldb] Fix test expectation in `TestFrameRecognizer.py` (#106281)

2024-08-27 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-08-27T22:59:14+02:00 New Revision: fc517973c299d879f0795d37500a7db1f4d63588 URL: https://github.com/llvm/llvm-project/commit/fc517973c299d879f0795d37500a7db1f4d63588 DIFF: https://github.com/llvm/llvm-project/commit/fc517973c299d879f0795d37500a7db1f4d63588

[Lldb-commits] [lldb] Revert "[LLDB][SBSaveCore] Add selectable memory regions to SBSaveCor… (PR #106293)

2024-08-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Reverts #105442. Due to `TestSkinnyCoreFailing` and root causing of the failure will likely take longer than EOD. --- Patch is 29.32 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm

[Lldb-commits] [lldb] b959532 - Revert "[LLDB][SBSaveCore] Add selectable memory regions to SBSaveCor… (#106293)

2024-08-27 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-08-27T14:23:00-07:00 New Revision: b9595324846a96dd3443359a62c70cec5aa352b8 URL: https://github.com/llvm/llvm-project/commit/b9595324846a96dd3443359a62c70cec5aa352b8 DIFF: https://github.com/llvm/llvm-project/commit/b9595324846a96dd3443359a62c70cec5aa352b8.diff

[Lldb-commits] [lldb] Revert "[LLDB][SBSaveCore] Add selectable memory regions to SBSaveCor… (PR #106293)

2024-08-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 4ea2c73886c407d47215484ab6c983ac6189dd14...b0caffa2d427ea94e90186e32125452ab4e1dd1e lldb

[Lldb-commits] [lldb] Revert "[LLDB][SBSaveCore] Add selectable memory regions to SBSaveCor… (PR #106293)

2024-08-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4ea2c73886c407d47215484ab6c983ac6189dd14 b0caffa2d427ea94e90186e32125452ab4e1dd1e --e

[Lldb-commits] [lldb] 3280292 - [lldb] Don't scan more than 10MB of assembly insns (#105890)

2024-08-27 Thread via lldb-commits
Author: Jason Molenda Date: 2024-08-27T14:50:46-07:00 New Revision: 328029242136950204ce8bf953eb592bff946d30 URL: https://github.com/llvm/llvm-project/commit/328029242136950204ce8bf953eb592bff946d30 DIFF: https://github.com/llvm/llvm-project/commit/328029242136950204ce8bf953eb592bff946d30.diff

[Lldb-commits] [lldb] 3c5ab5a - [lldb] unique_ptr-ify some GetUserExpression APIs. (#106034)

2024-08-27 Thread via lldb-commits
Author: Lang Hames Date: 2024-08-28T15:36:57+10:00 New Revision: 3c5ab5a75a9c8fb87dcb13cdf4207aa975fd6972 URL: https://github.com/llvm/llvm-project/commit/3c5ab5a75a9c8fb87dcb13cdf4207aa975fd6972 DIFF: https://github.com/llvm/llvm-project/commit/3c5ab5a75a9c8fb87dcb13cdf4207aa975fd6972.diff LO

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-28 Thread via lldb-commits
jimingham wrote: I think Greg is saying that if we don't find a local symbol, and don't find the symbol in the global symbols of the current module, then we should search all the other modules, but in that case preferring external symbols to internal since those are the ones that are potential

[Lldb-commits] [lldb] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP request handlers (PR #105905)

2024-08-28 Thread via lldb-commits
@@ -3106,80 +3228,105 @@ void request_stackTrace(const llvm::json::Object &request) { llvm::json::Array stackFrames; llvm::json::Object body; + // Threads stacks may contain runtime specific extended backtraces, when + // constructing a stack trace first report the full

[Lldb-commits] [lldb] Disable ThreadPlanSingleThreadTimeout during step over breakpoint (PR #104532)

2024-08-28 Thread via lldb-commits
jeffreytan81 wrote: @jimingham, right, I am pretty sure that Microsoft Visual Studio debugger implements step-over breakpoint the same as lldb so it is a universal standard behavior and I haven't heard anyone really complaining about this. Based on this, if there is no further concern, anyone

[Lldb-commits] [lldb] Add armv7a and armv8a ArchSpecs (PR #106433)

2024-08-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jordan R AW (ajordanr-google) Changes armv7a and armv8a are common names for the application subarch for arm. These names in particular are used in ChromeOS, Android, and a few other known applications. In ChromeOS, we encountered a bug wh

[Lldb-commits] [lldb] [lldb][test] Improve toolchain detection in Makefile.rules (PR #102185)

2024-08-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 907c7eb311077c5da434bf67858b1173a351d800...f9275093d59c73fe99a0079d06ed61532775385c lldb/

[Lldb-commits] [lldb] [lldb] Add Status::Detail to store expression evaluator diagnostics [… (PR #106442)

2024-08-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes …NFC] This patch is the first patch in a series reworking of Pete Lawrence's (@PortalPete) amazing proposal for better expression evaluator error messages (https://github.com/llvm/llvm-project/pull/809

[Lldb-commits] [lldb] Disable ThreadPlanSingleThreadTimeout during step over breakpoint (PR #104532)

2024-08-28 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/104532 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Status::Detail to store expression evaluator diagnostics [… (PR #106442)

2024-08-28 Thread via lldb-commits
@@ -47,7 +48,34 @@ class Status { /// into ValueType. typedef uint32_t ValueType; - Status(); + /// A customizable "detail" for an error. For example, expression + /// evaluation failures often have more than one diagnostic that the + /// UI layer might want to render

[Lldb-commits] [lldb] [lldb] Add Status::Detail to store expression evaluator diagnostics [… (PR #106442)

2024-08-28 Thread via lldb-commits
jimingham wrote: "Detail" seems too generic a name for what is a very "compiler error" centric data structure in Status. But if it's ExprDetail, then the next time someone wants to add richer info about an error, would we have them add an `OtherErrorDetail` structure? Maybe the latter questi

[Lldb-commits] [lldb] 38b252a - Disable ThreadPlanSingleThreadTimeout during step over breakpoint (#104532)

2024-08-28 Thread via lldb-commits
Author: jeffreytan81 Date: 2024-08-28T13:34:35-07:00 New Revision: 38b252aa45abad53d7c07c666569b174a215d94d URL: https://github.com/llvm/llvm-project/commit/38b252aa45abad53d7c07c666569b174a215d94d DIFF: https://github.com/llvm/llvm-project/commit/38b252aa45abad53d7c07c666569b174a215d94d.diff

[Lldb-commits] [lldb] Disable ThreadPlanSingleThreadTimeout during step over breakpoint (PR #104532)

2024-08-28 Thread via lldb-commits
https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/104532 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb: get lldb API tests working with newer Android NDKs (PR #106443)

2024-08-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Andrew Rogers (andrurogerz) Changes ## Purpose Running the LLDB API tests against a remote Android target with NDK version r22 or later fails to compile the test inferiors. NDK r21 from 2021 is the most recent NDK that still works with the

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC] Fix formatv() usage in preparation of validation (PR #106454)

2024-08-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Fix several uses of formatv() that would be flagged as invalid by an upcoming change that will add additional validation to formatv(). --- Full diff: https://github.com/llvm/llvm-project/pull/106454.diff 10

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC] Fix formatv() usage in preparation of validation (PR #106454)

2024-08-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-mlir Author: Rahul Joshi (jurahul) Changes Fix several uses of formatv() that would be flagged as invalid by an upcoming change that will add additional validation to formatv(). --- Full diff: https://github.com/llvm/llvm-project/pull/106454.diff 10

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [NFC] Fix formatv() usage in preparation of validation (PR #106454)

2024-08-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff eb9c49c900f43aa79811f80847c97c6596197430 b97456af86580c7f2d4473fbc13d3e345f071486 --e

[Lldb-commits] [lldb] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP request handlers (PR #105905)

2024-08-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r cdd11d694a406a98a16d6265168ee2fbe1b6a87c...7960402faaeabeba610cc56cba04638e355563c8 lldb/

[Lldb-commits] [lldb] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP request handlers (PR #105905)

2024-08-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cdd11d694a406a98a16d6265168ee2fbe1b6a87c 7960402faaeabeba610cc56cba04638e355563c8 --e

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-08-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes This patch is a reworking of Pete Lawrence's (@PortalPete) proposal for better expression evaluator error messages: https://github.com/llvm/llvm-project/pull/80938 Before: ``` $ lldb -o "expr a+b" (lld

[Lldb-commits] [lldb] [LLDB][Minidumps] Read x64 registers as 64b and handle truncation in the file builder (PR #106473)

2024-08-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes This patch addresses a bug where `cs`/`gs` and other segmentation flags were being identified as having a type of `32b` and `64b` for `rflags`. In that case the register value was returning the fail value `0

[Lldb-commits] [lldb] [LLDB][Minidumps] Read x64 registers as 64b and handle truncation in the file builder (PR #106473)

2024-08-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r a7ba73bf614f6d147bd1cdaddee156bd85e31703...88a1a5d2b8698a5474bff0756012369401f7f433 lldb

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-08-28 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r af3ee626a396aa9ac9480131f48f6ebe2f6664c1...2e7f0469fb596dfd53142e1479ba3828ca00f48f lldb

[Lldb-commits] [lldb] Remove redundant symbol lookups in IRExecutionUnit::FindInSymbols (PR #102835)

2024-08-28 Thread via lldb-commits
jimingham wrote: > On Aug 28, 2024, at 3:43 PM, Michael Buch ***@***.***> wrote: > > > yes. If we can do it, find something in the local compile unit first, if > there are two symbols in the CU, then the public one, else the private. > > I guess here lies my hangup. What is the distinction

[Lldb-commits] [lldb] b75fe11 - [NFC] Fix formatv() usage in preparation of validation (#106454)

2024-08-28 Thread via lldb-commits
Author: Rahul Joshi Date: 2024-08-28T17:41:43-07:00 New Revision: b75fe11fd6fe751157012a8881ece2f247bd3887 URL: https://github.com/llvm/llvm-project/commit/b75fe11fd6fe751157012a8881ece2f247bd3887 DIFF: https://github.com/llvm/llvm-project/commit/b75fe11fd6fe751157012a8881ece2f247bd3887.diff L

[Lldb-commits] [lldb] [lldb][AArch64] Do not crash if NT_ARM_TLS is missing (PR #106478)

2024-08-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Igor Kudrin (igorkudrin) Changes [D156118](https://reviews.llvm.org/D156118) states that this note is always present, but it is better to check it explicitly, as otherwise `lldb` may crash when trying to read registers. --- Full diff: htt

[Lldb-commits] [lldb] [LLDB][Minidumps] Read x64 registers as 64b and handle truncation in the file builder (PR #106473)

2024-08-28 Thread via lldb-commits
https://github.com/jeffreytan81 approved this pull request. https://github.com/llvm/llvm-project/pull/106473 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidumps] Read x64 registers as 64b and handle truncation in the file builder (PR #106473)

2024-08-28 Thread via lldb-commits
@@ -62,6 +63,17 @@ def verify_core_file( # Try to read just past the red zone and fail process.ReadMemory(sp - red_zone - 1, 1, error) self.assertTrue(error.Fail(), "No failure when reading past the red zone") +# Verify the regis

[Lldb-commits] [lldb] 82ebd33 - [LLDB][Minidumps] Read x64 registers as 64b and handle truncation in the file builder (#106473)

2024-08-28 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-08-28T21:15:30-07:00 New Revision: 82ebd333a889d2372c8445dc3d5d527ec48537db URL: https://github.com/llvm/llvm-project/commit/82ebd333a889d2372c8445dc3d5d527ec48537db DIFF: https://github.com/llvm/llvm-project/commit/82ebd333a889d2372c8445dc3d5d527ec48537db.diff

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [NFC] Prefer subprocess.DEVNULL over os.devnull (PR #106500)

2024-08-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-testing-tools @llvm/pr-subscribers-clang Author: Nicolas van Kempen (nicovank) Changes There is no need to support Python 2.7 anymore, Python 3.3+ has `subprocess.DEVNULL`. This is good practice and also prevents file handles from staying open unneces

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lldb] [llvm] Rename Sanitizer Coverage => Coverage Sanitizer (PR #106505)

2024-08-29 Thread via lldb-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/106505 This is so that we are consistent with other sanitizers. Importantly, this makes the docs clearer. Driver flags are left unchanged (We are not proposing to rename `sancov` either). The good thing is that flag

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lldb] [llvm] Rename Sanitizer Coverage => Coverage Sanitizer (PR #106505)

2024-08-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb @llvm/pr-subscribers-libcxx Author: cor3ntin (cor3ntin) Changes This is so that we are consistent with other sanitizers. Importantly, this makes the docs clearer. Driver flags are left unchanged (We are not proposing to rename `sancov` either). T

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lldb] [llvm] Rename Sanitizer Coverage => Coverage Sanitizer (PR #106505)

2024-08-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: cor3ntin (cor3ntin) Changes This is so that we are consistent with other sanitizers. Importantly, this makes the docs clearer. Driver flags are left unchanged (We are not proposing to rename `sancov` either). The good thing is th

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lldb] [llvm] Rename Sanitizer Coverage => Coverage Sanitizer (PR #106505)

2024-08-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ec9f36a624fa9f8fea6e40384ce513b6da8c08e4 adb4a0eb00972811343ff05eac6977512f01970a --e

[Lldb-commits] [lldb] [lldb] Fix and speedup the `memory find` command (PR #104193)

2024-08-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cb9267f055156daabdbab87f4c1ca9064b0e7d7d 3fc95ce499d9e5d5691158fe0847afa8ec338106 --e

[Lldb-commits] [lldb] [lldb/linux] Make truncated reads work (PR #106532)

2024-08-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Previously, we were returning an error if we couldn't read the whole region. This doesn't matter most of the time, because lldb caches memory reads, and in that process it aligns them to cache line boundaries.

[Lldb-commits] [lldb] [lldb/linux] Make truncated reads work (PR #106532)

2024-08-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff fdca2c33a1f33f4886d969ea0f0219764c7b6b59 610757ced98139d3d10451dcca195692b0c2d832 --e

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-08-29 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From b7f51237438285b1be922ae754618b8c6b0b0ea3 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] 0a00d32 - [lldb] Add armv7a and armv8a ArchSpecs (#106433)

2024-08-29 Thread via lldb-commits
Author: Jordan R AW Date: 2024-08-29T10:16:17-07:00 New Revision: 0a00d32c5f88fce89006dcde6e235bc77d7b495e URL: https://github.com/llvm/llvm-project/commit/0a00d32c5f88fce89006dcde6e235bc77d7b495e DIFF: https://github.com/llvm/llvm-project/commit/0a00d32c5f88fce89006dcde6e235bc77d7b495e.diff L

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-08-29 Thread via lldb-commits
@@ -2076,7 +2077,11 @@ bool CommandInterpreter::HandleCommand(const char *command_line, } ElapsedTime elapsed(execute_time); -cmd_obj->Execute(remainder.c_str(), result); +size_t nchar = real_original_command_string.find(remainder); +std::optional pos_in_c

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-08-29 Thread via lldb-commits
@@ -2076,7 +2077,11 @@ bool CommandInterpreter::HandleCommand(const char *command_line, } ElapsedTime elapsed(execute_time); -cmd_obj->Execute(remainder.c_str(), result); +size_t nchar = real_original_command_string.find(remainder); +std::optional pos_in_c

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-08-29 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/106470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-08-29 Thread via lldb-commits
@@ -2076,7 +2077,11 @@ bool CommandInterpreter::HandleCommand(const char *command_line, } ElapsedTime elapsed(execute_time); -cmd_obj->Execute(remainder.c_str(), result); +size_t nchar = real_original_command_string.find(remainder); +std::optional pos_in_c

[Lldb-commits] [lldb] [LLDB][DWARF] Add an option to silence unsupported DW_FORM warnings (PR #106609)

2024-08-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes My build of LLDB is all the time loading targets with a version of libc++ that was built with gcc that uses the DW_FORM 0x1e that is not implemented by LLVM, and I doubt it'll ever implement it.

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-08-29 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/106470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix dap stacktrace perf issue (PR #104874)

2024-08-29 Thread via lldb-commits
oltolm wrote: Can you backport it into llvm-19 branch? This bug makes lldb-dap almost impossible to use on Windows. https://github.com/llvm/llvm-project/pull/104874 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP request handlers (PR #105905)

2024-08-29 Thread via lldb-commits
@@ -3106,80 +3235,109 @@ void request_stackTrace(const llvm::json::Object &request) { llvm::json::Array stackFrames; llvm::json::Object body; + // Threads stacks may contain runtime specific extended backtraces, when + // constructing a stack trace first report the full

[Lldb-commits] [lldb] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP request handlers (PR #105905)

2024-08-29 Thread via lldb-commits
https://github.com/jeffreytan81 approved this pull request. https://github.com/llvm/llvm-project/pull/105905 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Store SupportFiles in SourceManager::File (NFC) (PR #106639)

2024-08-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes To support detecting MD5 checksum mismatches, store a SupportFile rather than a plain FileSpec in SourceManager::File. --- Full diff: https://github.com/llvm/llvm-project/pull/106639.diff 5 Files

[Lldb-commits] [lldb] [lldb][NFC] Move few static helpers to the class Socket and make them public (PR #106640)

2024-08-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This is the prerequisite for #104238. --- Full diff: https://github.com/llvm/llvm-project/pull/106640.diff 3 Files Affected: - (modified) lldb/include/lldb/Host/Socket.h (+10-6) - (modified) lldb/sourc

[Lldb-commits] [lldb] ce7c828 - [lldb][AArch64] Do not crash if NT_ARM_TLS is missing (#106478)

2024-08-30 Thread via lldb-commits
Author: Igor Kudrin Date: 2024-08-30T09:00:35+01:00 New Revision: ce7c828e085563f29451ec5fac9626c76ebf70ee URL: https://github.com/llvm/llvm-project/commit/ce7c828e085563f29451ec5fac9626c76ebf70ee DIFF: https://github.com/llvm/llvm-project/commit/ce7c828e085563f29451ec5fac9626c76ebf70ee.diff L

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add Floating Point Mode Register (PR #106695)

2024-08-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Otherwise known as FEAT_FPMR. This register controls the behaviour of floating point operations. https://developer.arm.com/documentation/ddi0601/2024-06/AArch64-Registers/FPMR--Floating-point-Mode-Reg

[Lldb-commits] [lldb] Add no-op handing for HLSLAttributedResource switch cases (PR #106698)

2024-08-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Danial Klimkin (dklimkin) Changes New value added in e00e9a3f8294c9b96cb0328bf136fab72aeec749 --- Full diff: https://github.com/llvm/llvm-project/pull/106698.diff 1 Files Affected: - (modified) lldb/source/Plugins/TypeSystem/Clang/TypeSy

[Lldb-commits] [lldb] 1b32c3e - Add no-op handing for HLSLAttributedResource switch cases (#106698)

2024-08-30 Thread via lldb-commits
Author: Danial Klimkin Date: 2024-08-30T11:51:44+02:00 New Revision: 1b32c3e2985f89900030289eaa44e3d92cab85af URL: https://github.com/llvm/llvm-project/commit/1b32c3e2985f89900030289eaa44e3d92cab85af DIFF: https://github.com/llvm/llvm-project/commit/1b32c3e2985f89900030289eaa44e3d92cab85af.diff

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-08-30 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From b7f51237438285b1be922ae754618b8c6b0b0ea3 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lldb] [llvm] Rename Sanitizer Coverage => Coverage Sanitizer (PR #106505)

2024-08-30 Thread via lldb-commits
cor3ntin wrote: > Thank you for working on this; it's a minor inconsistency, but a needless one > as best I can tell. The changes mostly look good, but there are a bunch of > binary files (.exe) that seem to have changed; do you know why? Global find of replace in the binaries. Sadly I'm not s

[Lldb-commits] [lldb] ab40ae8 - [lldb] Store SupportFiles in SourceManager::File (NFC) (#106639)

2024-08-30 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-08-30T07:18:55-07:00 New Revision: ab40ae8ff9f87b6e3d68cab2c47d692016ede958 URL: https://github.com/llvm/llvm-project/commit/ab40ae8ff9f87b6e3d68cab2c47d692016ede958 DIFF: https://github.com/llvm/llvm-project/commit/ab40ae8ff9f87b6e3d68cab2c47d692016ede958.d

[Lldb-commits] [lldb] [lldb] Deal with SupportFiles in SourceManager (NFC) (PR #106740)

2024-08-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes To support detecting MD5 checksum mismatches, deal with SupportFiles rather than a plain FileSpecs in the SourceManager. --- Patch is 21.82 KiB, truncated to 20.00 KiB below, full version: https:/

[Lldb-commits] [lldb] [lldb] Deal with SupportFiles in SourceManager (NFC) (PR #106740)

2024-08-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b0eefb4c4e5136fd606cf4cff566df9dbc0fa051 f7b0874d6bd83c85f4fb6411fc4da7dfb4dd8453 --e

[Lldb-commits] [lldb] 9aa25b8 - [LLDB][DWARF] Add an option to silence unsupported DW_FORM warnings (#106609)

2024-08-30 Thread via lldb-commits
Author: Walter Erquinigo Date: 2024-08-30T12:51:56-04:00 New Revision: 9aa25b8c15c99d8e717121837a2559801e311e2d URL: https://github.com/llvm/llvm-project/commit/9aa25b8c15c99d8e717121837a2559801e311e2d DIFF: https://github.com/llvm/llvm-project/commit/9aa25b8c15c99d8e717121837a2559801e311e2d.di

[Lldb-commits] [lldb] Revert "[LLDB][DWARF] Add an option to silence unsupported DW_FORM warnings" (PR #106765)

2024-08-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes Reverts llvm/llvm-project#106609 --- Full diff: https://github.com/llvm/llvm-project/pull/106765.diff 2 Files Affected: - (modified) lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (+1

[Lldb-commits] [lldb] 5500e21 - Revert "[LLDB][DWARF] Add an option to silence unsupported DW_FORM warnings" (#106765)

2024-08-30 Thread via lldb-commits
Author: Walter Erquinigo Date: 2024-08-30T13:18:23-04:00 New Revision: 5500e21942f7047344b6fee62d3e08c0ba2f9182 URL: https://github.com/llvm/llvm-project/commit/5500e21942f7047344b6fee62d3e08c0ba2f9182 DIFF: https://github.com/llvm/llvm-project/commit/5500e21942f7047344b6fee62d3e08c0ba2f9182.di

[Lldb-commits] [lldb] [LLDB][Minidump] Extend the minidump x86_64 registers to include fs_base and gs_base (PR #106767)

2024-08-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes A follow up to #106473 Minidump wasn't collecting fs or gs_base. This patch extends the x86_64 register context and gated reading it behind an lldb specific flag. Additionally these registers are explicitly

[Lldb-commits] [lldb] 130eddf - [lldb] Deal with SupportFiles in SourceManager (NFC) (#106740)

2024-08-30 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-08-30T10:58:32-07:00 New Revision: 130eddf7a13f15c9c48b7fa7faf60e9bbee4f703 URL: https://github.com/llvm/llvm-project/commit/130eddf7a13f15c9c48b7fa7faf60e9bbee4f703 DIFF: https://github.com/llvm/llvm-project/commit/130eddf7a13f15c9c48b7fa7faf60e9bbee4f703.d

[Lldb-commits] [lldb] [LLDB][Minidump] Extend the minidump x86_64 registers to include fs_base and gs_base (PR #106767)

2024-08-30 Thread via lldb-commits
@@ -473,7 +473,8 @@ GetThreadContext_x86_64(RegisterContext *reg_ctx) { lldb_private::minidump::MinidumpContext_x86_64_Flags::x86_64_Flag | lldb_private::minidump::MinidumpContext_x86_64_Flags::Control | lldb_private::minidump::MinidumpContext_x86_64_Flags::Se

[Lldb-commits] [lldb] [lldb] Include checksum in source cache dump (PR #106773)

2024-08-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This patch updates the source cache dump command to print both the actual (on-disk) checksum and the expected (line table) checksum. To achieve that we now read and store the on-disk checksum in the

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-08-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes (based on a conversation I had with @labath yesterday in https://github.com/llvm/llvm-project/pull/106442) Most APIs that currently vend a Status would be better served by returning llvm::Expected<> i

<    15   16   17   18   19   20   21   22   23   24   >