llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) <details> <summary>Changes</summary> Without calling `dyld_process_dispose`, LLDB will leak the memory associated with the `dyld_process_t`. rdar://134738265 --- Full diff: https://github.com/llvm/llvm-project/pull/106157.diff 1 Files Affected: - (modified) lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm (+4-1) ``````````diff diff --git a/lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm b/lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm index d27bd1b7426e6c..6e924fdc684cfe 100644 --- a/lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm +++ b/lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm @@ -650,12 +650,15 @@ static bool ResolveAndVerifyCandidateSupportDir(FileSpec &path) { if (!dyld_process) return false; + auto cleanup_process_on_exit = + llvm::make_scope_exit([&]() { dyld_process_dispose(dyld_process); }); + dyld_process_snapshot_t snapshot = dyld_process_snapshot_create_for_process(dyld_process, nullptr); if (!snapshot) return false; - auto on_exit = + auto cleanup_snapshot_on_exit = llvm::make_scope_exit([&]() { dyld_process_snapshot_dispose(snapshot); }); dyld_shared_cache_t shared_cache = `````````` </details> https://github.com/llvm/llvm-project/pull/106157 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
