[Lldb-commits] [lldb] Re-merge `A few updates around "transcript"` (#92843) (PR #94067)

https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/94067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Re-merge `A few updates around "transcript"` (#92843) (PR #94067)

https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/94067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c2d061d - Re-merge `A few updates around "transcript"` (#92843) (#94067)

Author: royitaqi Date: 2024-06-03T13:52:03-07:00 New Revision: c2d061da7e17e61d4a0efad261e5280793c1b7ce URL: https://github.com/llvm/llvm-project/commit/c2d061da7e17e61d4a0efad261e5280793c1b7ce DIFF: https://github.com/llvm/llvm-project/commit/c2d061da7e17e61d4a0efad261e5280793c1b7ce.diff LOG:

[Lldb-commits] [lldb] 6c36bdb - [lldb] Add documentation for the max_children argument (#94192)

Author: Pavel Labath Date: 2024-06-04T09:06:31+02:00 New Revision: 6c36bdb6eab1a3de3bce24ee0285c7745b17e407 URL: https://github.com/llvm/llvm-project/commit/6c36bdb6eab1a3de3bce24ee0285c7745b17e407 DIFF: https://github.com/llvm/llvm-project/commit/6c36bdb6eab1a3de3bce24ee0285c7745b17e407.diff

[Lldb-commits] [lldb] [llvm] PR to try to fix Windows CI build (PR #94325)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff eea05c6b3369736b703e2a5e3ca08ba6ad8a51dc 6f90aea93cf1b2d6b8afad985f5f7168a4dc1da9 --

[Lldb-commits] [lldb] [lldb][test] Disable MD5 test for old versions of Visual Studio (PR #94325)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes In older versions there is this problem: https://developercommunity.visualstudio.com/t/c-shared-state-futuresstate-default-constructs-the/60897 Which prevents us making a future out of a result type. T

[Lldb-commits] [lldb] 8917739 - [lldb][test] Disable MD5 test for old versions of Visual Studio (#94325)

Author: David Spickett Date: 2024-06-04T15:38:11+01:00 New Revision: 8917739b4cb39e6cd2355672ff6e2c140b19aafd URL: https://github.com/llvm/llvm-project/commit/8917739b4cb39e6cd2355672ff6e2c140b19aafd DIFF: https://github.com/llvm/llvm-project/commit/8917739b4cb39e6cd2355672ff6e2c140b19aafd.diff

[Lldb-commits] [lldb] 7dc84e2 - [lldb] Support reading DW_OP_piece from file address (#94026)

Author: Jonas Devlieghere Date: 2024-06-04T10:24:59-07:00 New Revision: 7dc84e225e11e37925db6f4f08269f447d2f2347 URL: https://github.com/llvm/llvm-project/commit/7dc84e225e11e37925db6f4f08269f447d2f2347 DIFF: https://github.com/llvm/llvm-project/commit/7dc84e225e11e37925db6f4f08269f447d2f2347.d

[Lldb-commits] [lldb] [lldb][DebugNames] Only skip processing of DW_AT_declarations for class/union types (PR #94400)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This is a follow-up of https://github.com/llvm/llvm-project/pull/92328#issuecomment-2145849441 Clang attaches `DW_AT_declaration` to static inline data members and `dsymutil` indexes these constants. Skip

[Lldb-commits] [lldb] 679f75e - [easy] Fix spacing in help message of 'process save-core' command (#89445)

Author: Michael Christensen Date: 2024-06-04T14:02:41-07:00 New Revision: 679f75e24b81c3ba4a7666ad1f08aa40a6fdddfa URL: https://github.com/llvm/llvm-project/commit/679f75e24b81c3ba4a7666ad1f08aa40a6fdddfa DIFF: https://github.com/llvm/llvm-project/commit/679f75e24b81c3ba4a7666ad1f08aa40a6fdddfa

[Lldb-commits] [lldb] [easy] Fix spacing in help message of 'process save-core' command (PR #89445)

https://github.com/GeorgeHuyubo closed https://github.com/llvm/llvm-project/pull/89445 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] afe6ab7 - [lldb][DebugNames] Only skip processing of DW_AT_declarations for class/union types (#94400)

Author: Michael Buch Date: 2024-06-04T22:17:51+01:00 New Revision: afe6ab7586f7078cc410f6162bd9851e48e2a286 URL: https://github.com/llvm/llvm-project/commit/afe6ab7586f7078cc410f6162bd9851e48e2a286 DIFF: https://github.com/llvm/llvm-project/commit/afe6ab7586f7078cc410f6162bd9851e48e2a286.diff

[Lldb-commits] [clang] [lldb] [llvm] Refactor GDB Index into a new file (PR #94405)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Sayhaan Siddiqui (sayhaan) Changes Create a new class and file for functions that update GDB index. --- Patch is 40.93 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/94405.diff 24 Files Affect

[Lldb-commits] [clang] [lldb] [llvm] Refactor GDB Index into a new file (PR #94405)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Sayhaan Siddiqui (sayhaan) Changes Create a new class and file for functions that update GDB index. --- Patch is 40.93 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/94405.diff 24 Files Affec

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Change the interface of DWARFExpression::Evaluate and DWARFExpressionList::Evaluate to return an llvm::Expected instead of a boolean. This eliminates the Status output parameter and improves error han

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r e3ed9e30b7b7102daf37f9464efc06b3d2e1a160...183f76dfb73821640cfdf19901703d0a8ff447ff lldb/

[Lldb-commits] [lldb] d3a9043 - [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (#93297)

Author: Alexey Merzlyakov Date: 2024-06-05T10:14:48+01:00 New Revision: d3a9043ec2ee7ea278be4f3c86823512e44d01bf URL: https://github.com/llvm/llvm-project/commit/d3a9043ec2ee7ea278be4f3c86823512e44d01bf DIFF: https://github.com/llvm/llvm-project/commit/d3a9043ec2ee7ea278be4f3c86823512e44d01bf.d

[Lldb-commits] [lldb] [lldb][RISCV] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

github-actions[bot] wrote: @AlexeyMerzlyakov Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with

[Lldb-commits] [lldb] [lldb] Split ValueObject::CreateChildAtIndex into two functions (PR #94455)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The the function is doing two fairly different things, depending on how it is called. While this allows for some code reuse, it also makes it hard to override it correctly. Possibly for this reason ValueObject

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/87197 >From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 31 Mar 2024 10:59:38 -0700 Subject: [PATCH 1/5] [LLDB] Add more helper functions to ValueObject class. Create

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

cmtice wrote: I've updated with a few minor fixes. I've addressed all the review comments (I think). I've verified/tested that all the casting, etc. works properly. Please review/approve this. Thanks! https://github.com/llvm/llvm-project/pull/87197 ___

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes Test Plan: llvm-lit llvm-project/lldb/test/API/tools/lldb-dap/console/TestDAP_console.py --- Full diff: https://github.com/llvm/llvm-project/pull/94494.diff 1 Files Affected: - (modified) lldb/test/API/tools/l

[Lldb-commits] [lldb] [lldb] UpdateFormatsIfNeeded should respect the dynamic value type (PR #93262)

https://github.com/jimingham approved this pull request. I wish I knew why the original code was ignoring `GetDynamicValueType` here, when it does use it on the very next line... The old code looks wrong to me. However, the places where dynamic values matter for the Format choice are uncommo

[Lldb-commits] [lldb] 539b72f - [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (#94420)

Author: Jonas Devlieghere Date: 2024-06-05T10:57:46-07:00 New Revision: 539b72f2e15f0d8a74a6c05c7085035040a3a831 URL: https://github.com/llvm/llvm-project/commit/539b72f2e15f0d8a74a6c05c7085035040a3a831 DIFF: https://github.com/llvm/llvm-project/commit/539b72f2e15f0d8a74a6c05c7085035040a3a831.d

[Lldb-commits] [lldb] 59e9160 - [lldb] UpdateFormatsIfNeeded should respect the dynamic value type (#93262)

Author: Augusto Noronha Date: 2024-06-05T11:08:36-07:00 New Revision: 59e9160ac8c906c5448c2094cd28cb5bc7678a3f URL: https://github.com/llvm/llvm-project/commit/59e9160ac8c906c5448c2094cd28cb5bc7678a3f DIFF: https://github.com/llvm/llvm-project/commit/59e9160ac8c906c5448c2094cd28cb5bc7678a3f.dif

[Lldb-commits] [lldb] [lldb/crashlog] Add `--no-parallel-image-loading` hidden flag (PR #94513)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch adds the `--no-parallel-image-loading` to the crashlog command. By default, image loading will happen in parallel in the crashlog script however, sometimes, when running tests or debuggi

[Lldb-commits] [lldb] [lldb/crashlog] Use environment variable to manually set dsymForUUIDBinary (PR #94517)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes In lldb, users can change the `dsymForUUID` binary using the `LLDB_APPLE_DSYMFORUUID_EXECUTABLE` environment variable. This patch changes the crashlog to support the same behaviour as lldb and uses

[Lldb-commits] [lldb] [lldb][api-test] Add API test for SBCommandInterpreter::CommandOverrideCallback (PR #94518)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes `SBCommandInterpreter::CommandOverrideCallback` was not being exposed to the Python API has no coverage in the API test suite, so this commits exposes and adds a test for it. Doing this involves al

[Lldb-commits] [lldb] [lldb][api-test] Add API test for SBCommandInterpreter::CommandOverrideCallback (PR #94518)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r c6c08eee37bada190bd1aa4593c88a5e2c8cdaac...90602ed1b2f27fecb9e1fc28419587cf6bcb04bf lldb/

[Lldb-commits] [lldb] f8afa76 - [lldb/crashlog] Use environment variable to manually set dsymForUUIDBinary (#94517)

Author: Med Ismail Bennani Date: 2024-06-05T13:21:27-07:00 New Revision: f8afa763c6194f5bf485480e1fb94b953942f876 URL: https://github.com/llvm/llvm-project/commit/f8afa763c6194f5bf485480e1fb94b953942f876 DIFF: https://github.com/llvm/llvm-project/commit/f8afa763c6194f5bf485480e1fb94b953942f876.

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -3015,11 +3017,12 @@ llvm::Expected ValueObject::CastDerivedToBaseType( lldb::TargetSP target = GetTargetSP(); // The `value` can be a pointer, but GetChildAtIndex works for pointers too. - lldb::ValueObjectSP inner_value; + lldb::ValueObjectSP inner_value = GetSP();

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -3015,11 +3017,12 @@ llvm::Expected ValueObject::CastDerivedToBaseType( lldb::TargetSP target = GetTargetSP(); // The `value` can be a pointer, but GetChildAtIndex works for pointers too. - lldb::ValueObjectSP inner_value; + lldb::ValueObjectSP inner_value = GetSP();

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -3138,13 +3141,13 @@ lldb::ValueObjectSP ValueObject::CastToBasicType(CompilerType type) { val_byte_size = temp.value(); if (is_pointer) { -if (type.IsBoolean() && type_byte_size < val_byte_size) { +if (!type.IsBoolean() && type_byte_size < val_byte_size) { -

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/87197 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [NFC] Rewrite TestRedefinitionsInInlines.py as an API test (PR #94539)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes Rewrite an inline test as an API test, to be a little easier to debug, and add some additional checks that we're in the inlined test1, then step and we are now in the inlined test2 functions. --- Full

[Lldb-commits] [lldb] [lldb] [NFC] Rewrite TestRedefinitionsInInlines.py as an API test (PR #94539)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 55d2fffdae5531759569e4ea8985c3de2e96bcc1...c02e38e5ef017a966ef8b94a56e394309462 lldb/

[Lldb-commits] [lldb] 19bce17 - [lldb] [NFC] Rewrite TestRedefinitionsInInlines.py as an API test (#94539)

Author: Jason Molenda Date: 2024-06-05T15:39:40-07:00 New Revision: 19bce1702bd1e399bea76d0de2a649a14551b000 URL: https://github.com/llvm/llvm-project/commit/19bce1702bd1e399bea76d0de2a649a14551b000 DIFF: https://github.com/llvm/llvm-project/commit/19bce1702bd1e399bea76d0de2a649a14551b000.diff

[Lldb-commits] [lldb] 68a9cb7 - [lldb/crashlog] Add `--no-parallel-image-loading` hidden flag (#94513)

Author: Med Ismail Bennani Date: 2024-06-05T15:45:42-07:00 New Revision: 68a9cb799511506045ca26c04e7933f0e0ed46ec URL: https://github.com/llvm/llvm-project/commit/68a9cb799511506045ca26c04e7933f0e0ed46ec DIFF: https://github.com/llvm/llvm-project/commit/68a9cb799511506045ca26c04e7933f0e0ed46ec.

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -3015,11 +3017,12 @@ llvm::Expected ValueObject::CastDerivedToBaseType( lldb::TargetSP target = GetTargetSP(); // The `value` can be a pointer, but GetChildAtIndex works for pointers too. - lldb::ValueObjectSP inner_value; + lldb::ValueObjectSP inner_value = GetSP();

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/87197 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Split ValueObject::CreateChildAtIndex into two functions (PR #94455)

@@ -46,75 +46,116 @@ lldb::ValueObjectSP ValueObjectConstResultImpl::Dereference(Status &error) { return m_impl_backend->ValueObject::Dereference(error); } -ValueObject *ValueObjectConstResultImpl::CreateChildAtIndex( -size_t idx, bool synthetic_array_member, int32_t sy

[Lldb-commits] [lldb] [lldb] Split ValueObject::CreateChildAtIndex into two functions (PR #94455)

@@ -46,75 +46,116 @@ lldb::ValueObjectSP ValueObjectConstResultImpl::Dereference(Status &error) { return m_impl_backend->ValueObject::Dereference(error); } -ValueObject *ValueObjectConstResultImpl::CreateChildAtIndex( -size_t idx, bool synthetic_array_member, int32_t sy

[Lldb-commits] [lldb] [lldb] Split ValueObject::CreateChildAtIndex into two functions (PR #94455)

https://github.com/jimingham approved this pull request. This is much nicer. I would actually prefer we returned names that are "" rather than nullptr, but in any case I agree there's no particular reason to make that a contract. https://github.com/llvm/llvm-project/pull/94455 ___

[Lldb-commits] [lldb] [lldb/crashlog] Remove aarch64 requirement on crashlog tests (PR #94553)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This PR removes the `target-aarch64` requirement on the crashlog tests to exercice them on Intel bots and make image loading single-threaded temporarily while implementing a fix for a deadlock issu

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This patch make all errors start with a lowercase letter and removes trailing periods and newlines. This fixes inconsistencies between error messages and facilitate concatenating them. --- Patch i

[Lldb-commits] [lldb] [lldb] Refactor ReadRegisterValueAsScalar to return an llvm::Error (NFC) (PR #94556)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94556.diff 1 Files Affected: - (modified) lldb/source/Expression/DWARFExpression.cpp (+56-74) ``diff diff --git a/lldb/source/E

[Lldb-commits] [lldb] [lldb] Refactor ResolveLoadAddress to return an llvm::Expected (NFC) (PR #94558)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94558.diff 1 Files Affected: - (modified) lldb/source/Expression/DWARFExpression.cpp (+17-31) ``diff diff --git a/lldb/source/E

[Lldb-commits] [lldb] 6ca0f44 - [lldb] Fix inconsistencies in DWARFExpression errors (#94554)

Author: Jonas Devlieghere Date: 2024-06-05T19:47:49-07:00 New Revision: 6ca0f44cd89aa802c306c303764eabf83a7f5029 URL: https://github.com/llvm/llvm-project/commit/6ca0f44cd89aa802c306c303764eabf83a7f5029 DIFF: https://github.com/llvm/llvm-project/commit/6ca0f44cd89aa802c306c303764eabf83a7f5029.d

[Lldb-commits] [lldb] 86dddbe - [lldb/crashlog] Always load Application Specific Backtrace Thread images (#94259)

Author: Med Ismail Bennani Date: 2024-06-05T20:22:36-07:00 New Revision: 86dddbe3b54eae22db6e208e6bc1c3cda9b7e149 URL: https://github.com/llvm/llvm-project/commit/86dddbe3b54eae22db6e208e6bc1c3cda9b7e149 DIFF: https://github.com/llvm/llvm-project/commit/86dddbe3b54eae22db6e208e6bc1c3cda9b7e149.

[Lldb-commits] [lldb] [lldb/crashlog] Make interactive mode the new default (PR #94575)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch makes interactive mode as the default when using the crashlog command. It replaces the existing `-i|--interactive` flag with a new `-m|--mode` option, that can either be `interactive` or

[Lldb-commits] [lldb] [lldb] Disable TestPtyServer API test when remote testing (PR #94587)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes The local PTY is not available for the remotely executed lldb-server to pass the test. Also, in general, we cannot execute the local lldb-server instance because it could be compiled for the different sys

[Lldb-commits] [lldb] a6cc363 - [lldb] Disable TestPtyServer API test when remote testing (#94587)

Author: Dmitry Vasilyev Date: 2024-06-06T10:02:27+01:00 New Revision: a6cc363b2743a264eb06e46cac05c3c9c92e3ef7 URL: https://github.com/llvm/llvm-project/commit/a6cc363b2743a264eb06e46cac05c3c9c92e3ef7 DIFF: https://github.com/llvm/llvm-project/commit/a6cc363b2743a264eb06e46cac05c3c9c92e3ef7.dif

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/87197 >From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 31 Mar 2024 10:59:38 -0700 Subject: [PATCH 1/6] [LLDB] Add more helper functions to ValueObject class. Create

[Lldb-commits] [lldb] [lldb] Fix ThreadPlanStepOverRange name in log message (PR #94611)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Marianne Mailhot-Sarrasin (mariannems) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94611.diff 1 Files Affected: - (modified) lldb/source/Target/ThreadPlanStepOverRange.cpp (+1-1) ``diff diff --git a/lldb/

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/87197 >From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 31 Mar 2024 10:59:38 -0700 Subject: [PATCH 1/7] [LLDB] Add more helper functions to ValueObject class. Create

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -3138,13 +3141,13 @@ lldb::ValueObjectSP ValueObject::CastToBasicType(CompilerType type) { val_byte_size = temp.value(); if (is_pointer) { -if (type.IsBoolean() && type_byte_size < val_byte_size) { +if (!type.IsBoolean() && type_byte_size < val_byte_size) { -

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -3015,11 +3017,12 @@ llvm::Expected ValueObject::CastDerivedToBaseType( lldb::TargetSP target = GetTargetSP(); // The `value` can be a pointer, but GetChildAtIndex works for pointers too. - lldb::ValueObjectSP inner_value; + lldb::ValueObjectSP inner_value = GetSP();

[Lldb-commits] [lldb] d9e6a56 - [lldb] Fix ThreadPlanStepOverRange name in log message (#94611)

Author: Marianne Mailhot-Sarrasin Date: 2024-06-06T15:05:55+01:00 New Revision: d9e6a563206cea4e682d4c52eccf24178d7d8343 URL: https://github.com/llvm/llvm-project/commit/d9e6a563206cea4e682d4c52eccf24178d7d8343 DIFF: https://github.com/llvm/llvm-project/commit/d9e6a563206cea4e682d4c52eccf24178d

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

jeffreytan81 wrote: @jimingham , let me know any other comments/thoughts you have. https://github.com/llvm/llvm-project/pull/90930 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a76290d - [lldb] Refactor ReadRegisterValueAsScalar to return an llvm::Error (NFC) (#94556)

Author: Jonas Devlieghere Date: 2024-06-06T08:54:20-07:00 New Revision: a76290d6acedb4dcdd431cdd21f057255117f8d3 URL: https://github.com/llvm/llvm-project/commit/a76290d6acedb4dcdd431cdd21f057255117f8d3 DIFF: https://github.com/llvm/llvm-project/commit/a76290d6acedb4dcdd431cdd21f057255117f8d3.d

[Lldb-commits] [lldb] 67aaa9f - [lldb] Refactor ResolveLoadAddress to return an llvm::Expected (NFC) (#94558)

Author: Jonas Devlieghere Date: 2024-06-06T08:54:37-07:00 New Revision: 67aaa9f9974993f360cc0dabffd73b51c030d775 URL: https://github.com/llvm/llvm-project/commit/67aaa9f9974993f360cc0dabffd73b51c030d775 DIFF: https://github.com/llvm/llvm-project/commit/67aaa9f9974993f360cc0dabffd73b51c030d775.d

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -618,6 +631,24 @@ class ValueObject { virtual lldb::ValueObjectSP CastPointerType(const char *name, lldb::TypeSP &type_sp); + /// Return the target load address assocaited with this value object. cmtice wrote

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

jimingham wrote: I will get to this, WWDC is close upon us so we're all rather busy at present. Jim > On Jun 6, 2024, at 8:27 AM, jeffreytan81 ***@***.***> wrote: > > > @jimingham , let me know any other > comments/thoughts you have. > > — > Reply to this ema

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -3141,15 +3141,15 @@ lldb::ValueObjectSP ValueObject::CastToBasicType(CompilerType type) { val_byte_size = temp.value(); if (is_pointer) { +if (!type.IsInteger()) { + m_error.SetErrorString("target type must be an integer"); + return GetSP(); +}

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/87197 >From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 31 Mar 2024 10:59:38 -0700 Subject: [PATCH 1/8] [LLDB] Add more helper functions to ValueObject class. Create

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -2809,6 +2919,243 @@ ValueObjectSP ValueObject::CastPointerType(const char *name, TypeSP &type_sp) { return valobj_sp; } +lldb::addr_t ValueObject::GetLoadAddress() { + lldb::addr_t addr_value = LLDB_INVALID_ADDRESS; + lldb::TargetSP target_sp = GetTargetSP(); + if (t

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -3141,15 +3141,15 @@ lldb::ValueObjectSP ValueObject::CastToBasicType(CompilerType type) { val_byte_size = temp.value(); if (is_pointer) { +if (!type.IsInteger()) { + m_error.SetErrorString("target type must be an integer"); + return GetSP(); +}

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

https://github.com/cmtice deleted https://github.com/llvm/llvm-project/pull/87197 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -1089,6 +1089,154 @@ int64_t ValueObject::GetValueAsSigned(int64_t fail_value, bool *success) { return fail_value; } +llvm::Expected ValueObject::GetValueAsAPSInt() { + // Make sure the type can be converted to an APSInt. + if (!GetCompilerType().IsInteger() && +

[Lldb-commits] [lldb] d09231a - [lldb/crashlog] Remove aarch64 requirement on crashlog tests (#94553)

Author: Med Ismail Bennani Date: 2024-06-06T12:17:00-07:00 New Revision: d09231a422f052d6f6f44913fad610728a7c266b URL: https://github.com/llvm/llvm-project/commit/d09231a422f052d6f6f44913fad610728a7c266b DIFF: https://github.com/llvm/llvm-project/commit/d09231a422f052d6f6f44913fad610728a7c266b.

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

jimingham wrote: There was one comment that should probably be removed. This looks okay to me at this stage. https://github.com/llvm/llvm-project/pull/87197 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] [lldb] Include memory stats in statistics summary (PR #94671)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes The summary already includes other size information, e.g. total debug info size in bytes. The only other way I can get this information is by dumping all statistics which can be quite large. Adding it to t

[Lldb-commits] [lldb] [lldb] Fix TestModuleLoadedNotifys API test to work correctly on most of Linux targets (PR #94672)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes The different build configuration and target Linux system can load a different number of .so libraries (2 and more). As example, Linux x86_64 host shows the following loaded modules: ``` Loaded files: ld-

[Lldb-commits] [lldb] [lldb] Include memory stats in statistics summary (PR #94671)

https://github.com/kusmour approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/94671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Include memory stats in statistics summary (PR #94671)

https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/94671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9293fc7 - [lldb] Include memory stats in statistics summary (#94671)

Author: Alex Langford Date: 2024-06-06T13:18:06-07:00 New Revision: 9293fc7981526eaca0a28012f2e5963fff1b830b URL: https://github.com/llvm/llvm-project/commit/9293fc7981526eaca0a28012f2e5963fff1b830b DIFF: https://github.com/llvm/llvm-project/commit/9293fc7981526eaca0a28012f2e5963fff1b830b.diff

[Lldb-commits] [lldb] [llvm] [lldb] Encode operands and arity in Dwarf.def and use them in LLDB. (PR #94679)

llvmbot wrote: @llvm/pr-subscribers-objectyaml Author: Jonas Devlieghere (JDevlieghere) Changes This PR extends Dwarf.def to include the number of operands and the arity (the number of entries on the DWARF stack) and use it from the LLDB DWARF expression evaluator. --- Patch is 42.88 K

[Lldb-commits] [lldb] [llvm] [lldb] Encode operands and arity in Dwarf.def and use them in LLDB. (PR #94679)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This PR extends Dwarf.def to include the number of operands and the arity (the number of entries on the DWARF stack) and use it from the LLDB DWARF expression evaluator. --- Patch is 42.88 KiB, tr

[Lldb-commits] [lldb] [lldb] Fix TestStatisticsAPI after 9293fc798152 (PR #94683)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94683.diff 1 Files Affected: - (modified) lldb/test/API/functionalities/stats_api/TestStatisticsAPI.py (+4-3) ``diff diff --git a/lld

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -1089,6 +1089,154 @@ int64_t ValueObject::GetValueAsSigned(int64_t fail_value, bool *success) { return fail_value; } +llvm::Expected ValueObject::GetValueAsAPSInt() { + // Make sure the type can be converted to an APSInt. + if (!GetCompilerType().IsInteger() && +

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/87197 >From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 31 Mar 2024 10:59:38 -0700 Subject: [PATCH 1/9] [LLDB] Add more helper functions to ValueObject class. Create

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -1089,6 +1089,154 @@ int64_t ValueObject::GetValueAsSigned(int64_t fail_value, bool *success) { return fail_value; } +llvm::Expected ValueObject::GetValueAsAPSInt() { + // Make sure the type can be converted to an APSInt. + if (!GetCompilerType().IsInteger() && +

[Lldb-commits] [lldb] ba7f52c - [lldb] Fix TestStatisticsAPI after 9293fc798152 (#94683)

Author: Alex Langford Date: 2024-06-06T14:25:53-07:00 New Revision: ba7f52ccf42fd481a1b309fe76863729fdd18c1c URL: https://github.com/llvm/llvm-project/commit/ba7f52ccf42fd481a1b309fe76863729fdd18c1c DIFF: https://github.com/llvm/llvm-project/commit/ba7f52ccf42fd481a1b309fe76863729fdd18c1c.diff

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed (PR #93913)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5f243b3fffca42ed320529a54aefd86087aa85f8 db1eb9b69f2ed961a586d15d165acd000bb728c4 --

[Lldb-commits] [lldb] 90b9922 - [lldb] Split ValueObject::CreateChildAtIndex into two functions (#94455)

Author: Pavel Labath Date: 2024-06-07T08:39:10+02:00 New Revision: 90b9922df2d8fb65a33eb9abd002fa9262863b5b URL: https://github.com/llvm/llvm-project/commit/90b9922df2d8fb65a33eb9abd002fa9262863b5b DIFF: https://github.com/llvm/llvm-project/commit/90b9922df2d8fb65a33eb9abd002fa9262863b5b.diff

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

https://github.com/ita-sc updated https://github.com/llvm/llvm-project/pull/90075 >From a8ee2a2ee75fcfac96a45796d0675eaa89c1aca6 Mon Sep 17 00:00:00 2001 From: Ivan Tetyushkin Date: Fri, 7 Jun 2024 11:23:24 +0300 Subject: [PATCH] Fix setting breakpoint for undecoded instruction Copy gdb behavi

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext ®siter_context) { LLDB_INVALID_ADDRESS); } +static int GetSoftwareWatchpointSize(const ArchSpec &arch, + lldb::addr_t ne

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext ®siter_context) { LLDB_INVALID_ADDRESS); } +static int GetSoftwareWatchpointSize(const ArchSpec &arch, + lldb::addr_t ne

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

@@ -0,0 +1,27 @@ +""" +Test that we can set up software breakpoint even if we failed to decode and execute instruction +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class TestBreakpoin

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

@@ -115,8 +148,23 @@ Status NativeProcessSoftwareSingleStep::SetupSoftwareSingleStepping( emulator_up->SetWriteMemCallback(&WriteMemoryCallback); emulator_up->SetWriteRegCallback(&WriteRegisterCallback); - if (!emulator_up->ReadInstruction()) -return Status("Read ins

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 8ef5c98e9f9276f09c590e22ab88a20ae86f3859...a8ee2a2ee75fcfac96a45796d0675eaa89c1aca6 lldb/

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

https://github.com/ita-sc updated https://github.com/llvm/llvm-project/pull/90075 >From 11ecb22c9473a2eee135ba0373e3890b9389851a Mon Sep 17 00:00:00 2001 From: Ivan Tetyushkin Date: Fri, 7 Jun 2024 11:23:24 +0300 Subject: [PATCH] [lldb][riscv] Fix setting breakpoint for undecoded instruction

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext ®siter_context) { LLDB_INVALID_ADDRESS); } +static int GetSoftwareWatchpointSize(const ArchSpec &arch, ita-sc wrote: Fixed, changed to `Ge

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

https://github.com/ita-sc updated https://github.com/llvm/llvm-project/pull/90075 >From 936846a18f31bba09f08d73195fe4945ef3508d3 Mon Sep 17 00:00:00 2001 From: Ivan Tetyushkin Date: Fri, 7 Jun 2024 11:23:24 +0300 Subject: [PATCH] [lldb][riscv] Fix setting breakpoint for undecoded instruction

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

https://github.com/ita-sc updated https://github.com/llvm/llvm-project/pull/90075 >From b30ddc631ccc02b0bf1de6f1d98065199ed0b82d Mon Sep 17 00:00:00 2001 From: Ivan Tetyushkin Date: Fri, 7 Jun 2024 11:23:24 +0300 Subject: [PATCH] [lldb][riscv] Fix setting breakpoint for undecoded instruction

[Lldb-commits] [lldb] [lldb] Skip declaration DIEs in the debug_names index (PR #94744)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This makes sure we try to process declaration DIEs that are erroneously present in the index. Until bd5c6367bd7, clang was emitting index entries for declaration DIEs with DW_AT_signature attributes. This make

[Lldb-commits] [lldb] 35fa2de - Reapply PR/87550 (#94625)

Author: Vy Nguyen Date: 2024-06-07T11:27:52-04:00 New Revision: 35fa2ded2ac52151be22c206fc92b983d1fd8e30 URL: https://github.com/llvm/llvm-project/commit/35fa2ded2ac52151be22c206fc92b983d1fd8e30 DIFF: https://github.com/llvm/llvm-project/commit/35fa2ded2ac52151be22c206fc92b983d1fd8e30.diff LOG

[Lldb-commits] [lldb] [LLDB] [NFC] Fix a cppcheck warning in lldb/source/Utility/Scalar.cpp (PR #94775)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes Fixes #85985 lldb/source/Utility/Scalar.cpp:756:23: warning: Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition] --- Full diff: https://github.com/llvm/llvm-project/pull/94775.d

[Lldb-commits] [lldb] [LLDB][NFC] Fix a cppcheck warning in Python/Interfaces/ScriptedPythonInterface.h (PR #94779)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes Source code analyser cppcheck says: lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedPythonInterface.h:89:11: warning: Identical inner 'if' condition is always true. [identicalInnerCondition] ll

[Lldb-commits] [lldb] [LLDB][NFC] Fix a cppcheck warning in lldb/source/Host/linux/Host.cpp (PR #94783)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes Fix #89710 --- Full diff: https://github.com/llvm/llvm-project/pull/94783.diff 1 Files Affected: - (modified) lldb/source/Host/linux/Host.cpp (+1-1) ``diff diff --git a/lldb/source/Host/linux/Host

<    9   10   11   12   13   14   15   16   17   18   >