Re: [Lldb-commits] [PATCH] D19533: Introduce Connection::ReadAll and fix AdbClient

This revision was automatically updated to reflect the committed changes. Closed by commit rL268380: Add a read_full_buffer argument to ConnectionFileDescriptor::Read (authored by labath). Changed prior to commit: http://reviews.llvm.org/D19533?vs=55397&id=55986#toc Repository: rL LLVM http

[Lldb-commits] [lldb] r268384 - Revert "Add a read_full_buffer argument to ConnectionFileDescriptor::Read"

Author: labath Date: Tue May 3 09:07:41 2016 New Revision: 268384 URL: http://llvm.org/viewvc/llvm-project?rev=268384&view=rev Log: Revert "Add a read_full_buffer argument to ConnectionFileDescriptor::Read" This reverts commit r268380 as it breaks windows build (I forgot to make neccesary adjus

Re: [Lldb-commits] [PATCH] D19533: Introduce Connection::ReadAll and fix AdbClient

labath added a comment. This is going to be messier than I expected. I would need to introduce the same repeat-until-the-buffer-is-full loop into ConnectionGenericFileWindows, which I don't think is good for code reuse. I see two possibilities: - go back to the version with a separate function

Re: [Lldb-commits] [PATCH] D15067: Design building out of sources

labath added a comment. Good question. I don't really have an opinion on that... Is it just that single line? (this would be simpler if you uploaded the final version :) ). If it just that single line, then I think it's fine. If you also need to play with the ADDITIONAL_VERSIONS and such, then

[Lldb-commits] [PATCH] D19916: Fix EOF handling in AdbClient (take 2)

labath created this revision. labath added a reviewer: ovyalov. labath added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. AdbClient would spin in a loop in ReadAllBytes in case the remote end was closed before reading the requested number of bytes. Make sure we re

[Lldb-commits] [PATCH] D19927: Fix DW_AT_specification handling in DWO files

labath created this revision. labath added reviewers: clayborg, tberghammer. labath added subscribers: ovyalov, lldb-commits. We were trying to get a DWARFDIE from a CompileUnit belonging to a DWO file. However, this function does not understand the die encoding used by the DWO files. Instead us

[Lldb-commits] [lldb] r268615 - Fix DW_AT_specification handling in DWO files

Author: labath Date: Thu May 5 03:21:44 2016 New Revision: 268615 URL: http://llvm.org/viewvc/llvm-project?rev=268615&view=rev Log: Fix DW_AT_specification handling in DWO files Summary: We were trying to get a DWARFDIE from a CompileUnit belonging to a DWO file. However, this function does not

Re: [Lldb-commits] [PATCH] D19927: Fix DW_AT_specification handling in DWO files

This revision was automatically updated to reflect the committed changes. Closed by commit rL268615: Fix DW_AT_specification handling in DWO files (authored by labath). Changed prior to commit: http://reviews.llvm.org/D19927?vs=56168&id=56245#toc Repository: rL LLVM http://reviews.llvm.org/

[Lldb-commits] [lldb] r268616 - Fix syntax errors in TestEnumTypes

Author: labath Date: Thu May 5 03:33:56 2016 New Revision: 268616 URL: http://llvm.org/viewvc/llvm-project?rev=268616&view=rev Log: Fix syntax errors in TestEnumTypes Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/enum_types/TestEnumTypes.py Modified: lldb/trunk/packages/Python

Re: [Lldb-commits] [PATCH] D19916: Fix EOF handling in AdbClient (take 2)

This revision was automatically updated to reflect the committed changes. Closed by commit rL268617: Fix EOF handling in AdbClient (take 2) (authored by labath). Changed prior to commit: http://reviews.llvm.org/D19916?vs=56134&id=56246#toc Repository: rL LLVM http://reviews.llvm.org/D19916

[Lldb-commits] [lldb] r268617 - Fix EOF handling in AdbClient (take 2)

Author: labath Date: Thu May 5 03:42:17 2016 New Revision: 268617 URL: http://llvm.org/viewvc/llvm-project?rev=268617&view=rev Log: Fix EOF handling in AdbClient (take 2) Summary: AdbClient would spin in a loop in ReadAllBytes in case the remote end was closed before reading the requested numbe

[Lldb-commits] [lldb] r268619 - Downgrade skip to xfail in TestBitfields on linux

Author: labath Date: Thu May 5 04:03:22 2016 New Revision: 268619 URL: http://llvm.org/viewvc/llvm-project?rev=268619&view=rev Log: Downgrade skip to xfail in TestBitfields on linux the test should no longer crash, but we need to investigate why ToT clang still generates debug info we don't und

Re: [Lldb-commits] [PATCH] D17856: Fix expression evaluation with operator new

labath updated this revision to Diff 56252. labath added a comment. Rebase on ToT. http://reviews.llvm.org/D17856 Files: include/lldb/Symbol/ClangASTContext.h packages/Python/lldbsuite/test/lang/cpp/global_operators/TestCppGlobalOperators.py packages/Python/lldbsuite/test/lang/cpp/global

Re: [Lldb-commits] [PATCH] D17856: Fix expression evaluation with operator new

labath added a reviewer: clayborg. labath added a comment. This has been sitting in the queue for a long time. Greg, could you take a look? http://reviews.llvm.org/D17856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.or

Re: [Lldb-commits] [PATCH] D19533: Introduce Connection::ReadAll and fix AdbClient

labath added a comment. Ok, I've put it into AdbClient for now. We can revisit it if we see a second user somewhere... Repository: rL LLVM http://reviews.llvm.org/D19533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D19214: fix a race is the LLDB test suite results collection

labath added a comment. In http://reviews.llvm.org/D19214#405310, @tfiala wrote: > If you're in a position where you can grab a sample (using the OS X sample > tool) on the bot when they're "hanging", we can try to find out where they > are at. > > The reason I *think* they're not in a method i

[Lldb-commits] [lldb] r268623 - Bump up timeout in AdbClient

Author: labath Date: Thu May 5 06:25:57 2016 New Revision: 268623 URL: http://llvm.org/viewvc/llvm-project?rev=268623&view=rev Log: Bump up timeout in AdbClient now that the timeout actually means something, we see that sometimes adb is just really slow in replying to the DONE packet during fil

Re: [Lldb-commits] [PATCH] D19991: [LLDB] Fix standalone build on RHEL6

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks fine. Out of curiosity, where were the undefined symbols coming from? I'm curious to know why they weren't showing up in none of our builds? Repository: rL LLVM http://reviews.llvm.o

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

labath added a subscriber: labath. labath added a comment. I am glad to see more testing of the modules debugging. I have a couple of small comments though: - `-fmodules`: Why is it not being added to CXXFLAGS? Is this how clang is supposed to be invoked? (I am not very familiar clang modules)

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

labath added a comment. In http://reviews.llvm.org/D19998#423541, @aprantl wrote: > In http://reviews.llvm.org/D19998#423277, @labath wrote: > > > I am glad to see more testing of the modules debugging. I have a couple of > > small comments though: > > > > - `-fmodules`: Why is it not being adde

[Lldb-commits] [lldb] r268906 - Fix assertion in SymbolFilePDB

Author: labath Date: Mon May 9 06:07:43 2016 New Revision: 268906 URL: http://llvm.org/viewvc/llvm-project?rev=268906&view=rev Log: Fix assertion in SymbolFilePDB llvm::Error requires all errors to be handled. Simply checking the whether there was an error is not enough, you have to actuall cal

Re: [Lldb-commits] [lldb] r268906 - Fix assertion in SymbolFilePDB

Zach, I have put this in to unblock the builds with assertions enabled, please fix it up if you want to handle this differently. pl On 9 May 2016 at 12:07, Pavel Labath via lldb-commits wrote: > Author: labath > Date: Mon May 9 06:07:43 2016 > New Revision: 268906 > > URL:

[Lldb-commits] [PATCH] D20065: Fix race in TestExitDuringStep and unify pseudo_barrier handling

labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. TestExitDuringStep was very rarely hanging on the buildbots. I can't be sure, but I believe this was because of the fact that it declared its pseudo_barrier variable as "volatile int", which

[Lldb-commits] [lldb] r268923 - Enable NamespaceLookupTestCase.test_scope_lookup_before_using_with_run_command on linux

Author: labath Date: Mon May 9 09:43:22 2016 New Revision: 268923 URL: http://llvm.org/viewvc/llvm-project?rev=268923&view=rev Log: Enable NamespaceLookupTestCase.test_scope_lookup_before_using_with_run_command on linux test appears to be passing now. Modified: lldb/trunk/packages/Python/

[Lldb-commits] [lldb] r268934 - Mark TestPrintStackTraces as flaky on linux

Author: labath Date: Mon May 9 11:59:29 2016 New Revision: 268934 URL: http://llvm.org/viewvc/llvm-project?rev=268934&view=rev Log: Mark TestPrintStackTraces as flaky on linux PR27687 Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/lldbutil/process/TestPrintStackTraces.py M

Re: [Lldb-commits] [PATCH] D20065: Fix race in TestExitDuringStep and unify pseudo_barrier handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL269025: Fix race in TestExitDuringStep and unify pseudo_barrier handling (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20065?vs=56567&id=56669#toc Repository: rL LLVM http:

[Lldb-commits] [lldb] r269025 - Fix race in TestExitDuringStep and unify pseudo_barrier handling

Author: labath Date: Tue May 10 02:54:25 2016 New Revision: 269025 URL: http://llvm.org/viewvc/llvm-project?rev=269025&view=rev Log: Fix race in TestExitDuringStep and unify pseudo_barrier handling Summary: TestExitDuringStep was very rarely hanging on the buildbots. I can't be sure, but I belie

[Lldb-commits] [lldb] r269057 - Fix SymbolFilePDBTests.cpp

Author: labath Date: Tue May 10 08:46:22 2016 New Revision: 269057 URL: http://llvm.org/viewvc/llvm-project?rev=269057&view=rev Log: Fix SymbolFilePDBTests.cpp Modified: lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp Modified: lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTest

[Lldb-commits] [lldb] r269058 - Fix logging in Listener.cpp

Author: labath Date: Tue May 10 08:46:25 2016 New Revision: 269058 URL: http://llvm.org/viewvc/llvm-project?rev=269058&view=rev Log: Fix logging in Listener.cpp Clear() log message was claiming it was the destructor, which had me very confused when looking at the log messages. Fix the message, a

[Lldb-commits] [PATCH] D20106: Generalize child process monitoring functions

labath created this revision. labath added reviewers: clayborg, zturner, emaste, krytarowski. labath added a subscriber: lldb-commits. This replaces the C-style "void *" baton of the child process monitoring functions with a more C++-like API taking a std::function. The motivation for this was th

[Lldb-commits] [PATCH] D20107: Fix a race in ProcessGDBRemote::MonitorDebugServerProcess

labath created this revision. labath added a reviewer: clayborg. labath added subscribers: lldb-commits, tberghammer. MonitorDebugServerProcess went to a lot of effort to make sure its asynchronous invocation does not cause any mischief, but it was still not race-free. Specifically, in a quick s

Re: [Lldb-commits] [PATCH] D20106: Generalize child process monitoring functions

labath added a comment. I am going to try building this on as many systems as I can get my hands on tomorrow, as I am pretty sure I have missed some changes on host-specific code. I am posting this here now, to get early feedback and some round-trips. http://reviews.llvm.org/D20106

Re: [Lldb-commits] [PATCH] D20106: Generalize child process monitoring functions

labath added a comment. In http://reviews.llvm.org/D20106#425825, @labath wrote: > I am going to try building this on as many systems as I can get my hands on > tomorrow, as I am pretty sure I have missed some changes on host-specific > code. I am posting this here now, to get early feedback an

Re: [Lldb-commits] [PATCH] D20091: Rewriting TestMultithreaded.py to solve flakyness on Linux

labath accepted this revision. labath added a comment. I am somewhat surprised that this solves anything (I mean, you claim that the problem is the ordering between the push and pop, but I don't see how this could change that ordering). If the problem was that the check_listener was not waiting

Re: [Lldb-commits] [PATCH] D20106: Generalize child process monitoring functions

labath added a comment. In http://reviews.llvm.org/D20106#426224, @zturner wrote: > It's too bad llvm doesn't have an equivalent of boost::any, because that > would be perfect here :-/ I actually think that a `std::function` is better here than an `any` type because it ensures type safety (ev

Re: [Lldb-commits] [PATCH] D20106: Generalize child process monitoring functions

labath updated this revision to Diff 56903. labath marked 3 inline comments as done. labath added a comment. Herald added a subscriber: emaste. Remove the typedef and add changes to windows, osx, and freebsd-specific code. I didn't try building NetBSD, but given that there is no Plugins/Process/N

Re: [Lldb-commits] [lldb] r269025 - Fix race in TestExitDuringStep and unify pseudo_barrier handling

s = 1" from the relevant lines? If that doesn't fix it, then we'll need to think harder about this. pl On 10 May 2016 at 21:25, Ed Maste wrote: > On 10 May 2016 at 03:54, Pavel Labath via lldb-commits > wrote: >> Author: labath >> Date: Tue May 10 02:54:25 2016 &g

Re: [Lldb-commits] [lldb] r269025 - Fix race in TestExitDuringStep and unify pseudo_barrier handling

Hmm.. So you actually needed to insert the additional "continue" command. That is not good. I was hoping it would be enough to just remove the strict check for the location numbers. Working around it this way is quite ugly. Let's try something else. Would getting rid of the do{}while loop in the m

[Lldb-commits] [lldb] r269205 - Generalize child process monitoring functions

Author: labath Date: Wed May 11 11:59:04 2016 New Revision: 269205 URL: http://llvm.org/viewvc/llvm-project?rev=269205&view=rev Log: Generalize child process monitoring functions Summary: This replaces the C-style "void *" baton of the child process monitoring functions with a more C++-like API

Re: [Lldb-commits] [PATCH] D20106: Generalize child process monitoring functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL269205: Generalize child process monitoring functions (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20106?vs=56903&id=56932#toc Repository: rL LLVM http://reviews.llvm.org/

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

labath added a comment. I'm glad to see this getting fixed. I have a couple comments though. :) Comment at: packages/Python/lldbsuite/test/dotest.py:695 @@ -694,3 +694,3 @@ # Try to match the regexp pattern, if specified. if configuration.regexp:

Re: [Lldb-commits] [PATCH] D15067: Add CMake bits necessary for standalone build

labath accepted this revision. labath added a comment. In http://reviews.llvm.org/D15067#427848, @Eugene.Zelenko wrote: > In http://reviews.llvm.org/D15067#427834, @krytarowski wrote: > > > In http://reviews.llvm.org/D15067#427814, @Eugene.Zelenko wrote: > > > > > I would like to see implemented

Re: [Lldb-commits] [PATCH] D20107: Fix a race in ProcessGDBRemote::MonitorDebugServerProcess

This revision was automatically updated to reflect the committed changes. Closed by commit rL269281: Fix a race in ProcessGDBRemote::MonitorDebugServerProcess (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20107?vs=56722&id=57016#toc Repository: rL LLVM http://revie

[Lldb-commits] [lldb] r269281 - Fix a race in ProcessGDBRemote::MonitorDebugServerProcess

Author: labath Date: Thu May 12 06:10:01 2016 New Revision: 269281 URL: http://llvm.org/viewvc/llvm-project?rev=269281&view=rev Log: Fix a race in ProcessGDBRemote::MonitorDebugServerProcess Summary: MonitorDebugServerProcess went to a lot of effort to make sure its asynchronous invocation does

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

labath added inline comments. Comment at: packages/Python/lldbsuite/test_event/formatter/pickled.py:57 @@ +56,3 @@ +# end. +if self.use_send: +# Send it as {serialized_length_of_serialized_bytes}{serialized_bytes} tfiala wrote: > tfial

Re: [Lldb-commits] [PATCH] D20193: test infra: catch bad decorators and import-time errors

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks great from my side. Thank you for fixing this. http://reviews.llvm.org/D20193 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D20236: Remove ASTContexts from SystemInitializerCommon

labath created this revision. labath added reviewers: tberghammer, clayborg. labath added a subscriber: lldb-commits. The AST contexts are not needed in the server components, and the clang context in particular pulls in large parts of clang into the binary. Simply removing these two calls reduc

[Lldb-commits] [lldb] r269416 - Remove ASTContexts from SystemInitializerCommon

Author: labath Date: Fri May 13 08:40:51 2016 New Revision: 269416 URL: http://llvm.org/viewvc/llvm-project?rev=269416&view=rev Log: Remove ASTContexts from SystemInitializerCommon Summary: The AST contexts are not needed in the server components, and the clang context in particular pulls in lar

Re: [Lldb-commits] [PATCH] D20236: Remove ASTContexts from SystemInitializerCommon

This revision was automatically updated to reflect the committed changes. Closed by commit rL269416: Remove ASTContexts from SystemInitializerCommon (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20236?vs=57171&id=57175#toc Repository: rL LLVM http://reviews.llvm.or

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

labath added a subscriber: labath. labath added a comment. In http://reviews.llvm.org/D20278#430658, @krytarowski wrote: > Looks good, however could we merge firstly Plugins/Process/NetBSD > http://reviews.llvm.org/D20274 ? Otherwise I will need to keep syncing my > patch forever for generic ch

[Lldb-commits] [lldb] r269640 - Remove Mutex from NativeProcessLinux

Author: labath Date: Mon May 16 04:18:30 2016 New Revision: 269640 URL: http://llvm.org/viewvc/llvm-project?rev=269640&view=rev Log: Remove Mutex from NativeProcessLinux NPL now assumes it is running from a single thread now, so its thread-safety is untested anyway (and if that assumption is bro

[Lldb-commits] [lldb] r269648 - Bump up adb timeout more

Author: labath Date: Mon May 16 06:41:36 2016 New Revision: 269648 URL: http://llvm.org/viewvc/llvm-project?rev=269648&view=rev Log: Bump up adb timeout more still seeing very rare timeouts on the buildbot. Modified: lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp Modified: lldb/tr

Re: [Lldb-commits] [PATCH] D20306: Allow custom formatting of session log file names

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I agree with Todd that we should have a long option for this, as short ones tend to be cryptic. If we don't anticipate using this often (I don't), we could even drop the short option altogethe

Re: [Lldb-commits] [PATCH] D20344: [LLDB] Fix standalone LLDB build when LLVM/Clang were built with LLVM_INSTALL_TOOLCHAIN_ONLY=ON

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Let's give others a chance to respond though. Comment at: cmake/modules/LLDBStandalone.cmake:103 @@ -98,2 +102,3 @@ include("${LLVM_OBJ_ROOT}/lib${

Re: [Lldb-commits] [PATCH] D20355: Avoid an assertion failure when a bit field is extracted from a value of the same size.

labath added a subscriber: labath. labath added a reviewer: labath. labath added a comment. This fixes the same issue as http://reviews.llvm.org/D19535, which is stalled at the moment waiting for a unit test. You can take over if you write a quick unit test for this (unittests/Core/ScalarTest.cp

[Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

labath created this revision. labath added reviewers: tberghammer, omjavaid, nitesh.jain, uweigand. labath added a subscriber: lldb-commits. Herald added a subscriber: aemerson. this removes the last usage of the Platform plugin in NPL. It was being used for determining the architecture of a runn

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

labath added a comment. @nitesh.jain: I have checked that this compiles, but I could not verify the functionality for lack of hardware. Could you give this a spin? I am particularly interested in the "debugging 32 bit process with a 64 bit server" use case as that is most likely to break. If it

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. This adds a lot of code duplication, which should be trivial to remove. Please address that first. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:16

Re: [Lldb-commits] [PATCH] D20355: Avoid an assertion failure when a bit field is extracted from a value of the same size.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Thank you for taking the time to add the tests. Please consider the comment below though. Do you have commit access? Comment at: unittests/Core/ScalarTest.cpp:90

Re: [Lldb-commits] [PATCH] D20395: Remove m_decl_objects and look up variables for ComiplerDecls directly

labath added a subscriber: labath. labath added a comment. Siva and Paul are not active on LLDB any more. I don't know if they are still keeping an eye out on this, but I think you can go ahead with this if they don't respond. It should be fine as long as the test passes. OTOH, if it is possibl

Re: [Lldb-commits] [PATCH] D20355: Avoid an assertion failure when a bit field is extracted from a value of the same size.

labath added inline comments. Comment at: unittests/Core/ScalarTest.cpp:90 @@ +89,3 @@ +ASSERT_TRUE(s_scalar.ExtractBitfield(0, 0)); +ASSERT_EQ(0, memcmp(&a1, s_scalar.GetBytes(), sizeof(a1))); +ASSERT_TRUE(s_scalar.ExtractBitfield(len, 0)); bryanpkc w

[Lldb-commits] [PATCH] D20440: Remove platform plugins from lldb-server

labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. This removes the last usage of Platform plugins in lldb-server -- it was used for launching child processes, where it can be trivial

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

labath added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:39 @@ +38,3 @@ +int regset = NT_PRSTATUS; +Error error = NativeProcessLinux::PtraceWrapper(PTRACE_GETREGSET, tid, ®set, &ioVec, sizeof_native_regs_struct); +HostInfo:

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

labath added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:39 @@ +38,3 @@ +int regset = NT_PRSTATUS; +Error error = NativeProcessLinux::PtraceWrapper(PTRACE_GETREGSET, tid, ®set, &ioVec, sizeof_native_regs_struct); +HostInfo:

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

labath planned changes to this revision. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:53 @@ -22,2 +52,3 @@ + NativeRegisterContextLinux::NativeRegisterContextLinux(NativeThreadProtocol &native_thread,

Re: [Lldb-commits] [PATCH] D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. According to https://msdn.microsoft.com/en-gb/library/windows/desktop/aa365247%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396, characters with codes 1..31 (basically `< ' '`), are illegal as we

[Lldb-commits] [PATCH] D20567: Avoid using stdio in TestVirtual

labath created this revision. labath added a reviewer: clayborg. labath added subscribers: zturner, lldb-commits. using stdio in tests does not work on windows, and it is not completely reliable on linux. Avoid using stdio in this test, as it is not necessary for this purpose. http://reviews.llv

[Lldb-commits] [lldb] r270570 - Add a missing include to ItaniumABILanguageRuntime.h

Author: labath Date: Tue May 24 10:32:40 2016 New Revision: 270570 URL: http://llvm.org/viewvc/llvm-project?rev=270570&view=rev Log: Add a missing include to ItaniumABILanguageRuntime.h some (I'm not sure why only some, actually) implementations of std::map require the value type to be a fully s

[Lldb-commits] [PATCH] D20570: Add unit tests for ModuleCache

labath created this revision. labath added reviewers: ovyalov, zturner. labath added a subscriber: lldb-commits. http://reviews.llvm.org/D20570 Files: unittests/Utility/CMakeLists.txt unittests/Utility/Inputs/TestModule.c unittests/Utility/Inputs/TestModule.so unittests/Utility/ModuleCach

Re: [Lldb-commits] [PATCH] D20567: Avoid using stdio in TestVirtual

labath added inline comments. Comment at: packages/Python/lldbsuite/test/lang/cpp/virtual/TestVirtual.py:64 @@ +63,3 @@ +self.assertTrue(golden.IsValid(), "Encountered an error reading the process's golden variable") +golden_str = str(golden) +self.assertT

Re: [Lldb-commits] [PATCH] D20548: Replace file system forbidden symbols in the hostname which passed to the ModuleCache

labath added a comment. I like the idea of having a centralized place defining "invalid characters". However, I am not sure if that needs to be (at least in this case) system-dependent. Since presumably the code will need to work on all platforms anyway, having the escaping done in a divergent

Re: [Lldb-commits] [lldb] r270488 - We have many radars showing that stepping through C++ code can result in slow steps.

r270570 fixed it for me. On 24 May 2016 at 19:11, Ed Maste via lldb-commits wrote: > On 23 May 2016 at 16:37, Greg Clayton via lldb-commits > wrote: >> Author: gclayton >> Date: Mon May 23 15:37:24 2016 >> New Revision: 270488 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=270488&view=rev >>

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

labath added a comment. I think we should make one more iteration on this, as there is still some room for improvement. In http://reviews.llvm.org/D19998#438756, @zturner wrote: > Should this be disabled by default unless explicitly requested? Seems like > "run the entire test suite N times" s

[Lldb-commits] [lldb] r270684 - Add unit tests for ModuleCache

Author: labath Date: Wed May 25 05:48:16 2016 New Revision: 270684 URL: http://llvm.org/viewvc/llvm-project?rev=270684&view=rev Log: Add unit tests for ModuleCache Reviewers: ovyalov, zturner Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D20570 Added: lldb/trunk/

Re: [Lldb-commits] [PATCH] D20570: Add unit tests for ModuleCache

This revision was automatically updated to reflect the committed changes. Closed by commit rL270684: Add unit tests for ModuleCache (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20570?vs=58244&id=58400#toc Repository: rL LLVM http://reviews.llvm.org/D20570 Files:

Re: [Lldb-commits] [PATCH] D20570: Add unit tests for ModuleCache

labath added inline comments. Comment at: unittests/Utility/ModuleCacheTest.cpp:74 @@ +73,3 @@ +{ +HostInfo::Initialize(); +ObjectFileELF::Initialize(); ovyalov wrote: > If it's one-off initialization can we use setUpTestCase for these purposes > (for Hos

Re: [Lldb-commits] [PATCH] D20567: Avoid using stdio in TestVirtual

labath updated this revision to Diff 58418. labath added a comment. New version, which does not rely on pretty-printers. http://reviews.llvm.org/D20567 Files: packages/Python/lldbsuite/test/lang/cpp/virtual/TestVirtual.py packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp Index: pack

[Lldb-commits] [PATCH] D20623: [cmake] Add ability to customize (and skip) debugserver codesign

labath created this revision. labath added reviewers: sas, tberghammer. labath added a subscriber: lldb-commits. This adds the ability to customize the debugserver codesign process via cmake cache variable. The user can set the codesign indentity (with the default being the customary lldb_codesi

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

labath abandoned this revision. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:53 @@ -22,2 +52,3 @@ + NativeRegisterContextLinux::NativeRegisterContextLinux(NativeThreadProtocol &native_thread, uint

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

labath added inline comments. Comment at: packages/Python/lldbsuite/test/decorators.py:527 @@ -525,3 +526,3 @@ -def skipUnlessClangModules(): +def skipUnlessClangModules(func): """Decorate the item to skip test unless Clang -gmodules flag is supported."""

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

labath accepted this revision. labath added a reviewer: labath. labath added a comment. Looks great now. Thanks. Comment at: packages/Python/lldbsuite/test/test_categories.py:62 @@ +61,3 @@ +if not gmodules.is_compiler_clang_with_gmodules(compiler_path): +

Re: [Lldb-commits] [PATCH] D20623: [cmake] Add ability to customize (and skip) debugserver codesign

This revision was automatically updated to reflect the committed changes. Closed by commit rL270832: [cmake] Add ability to customize (and skip) debugserver codesign (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20623?vs=58424&id=58580#toc Repository: rL LLVM http:

[Lldb-commits] [lldb] r270831 - Avoid using stdio in TestVirtual

Author: labath Date: Thu May 26 03:38:02 2016 New Revision: 270831 URL: http://llvm.org/viewvc/llvm-project?rev=270831&view=rev Log: Avoid using stdio in TestVirtual Summary: using stdio in tests does not work on windows, and it is not completely reliable on linux. Avoid using stdio in this test

[Lldb-commits] [lldb] r270832 - [cmake] Add ability to customize (and skip) debugserver codesign

Author: labath Date: Thu May 26 03:38:10 2016 New Revision: 270832 URL: http://llvm.org/viewvc/llvm-project?rev=270832&view=rev Log: [cmake] Add ability to customize (and skip) debugserver codesign Summary: This adds the ability to customize the debugserver codesign process via cmake cache varia

Re: [Lldb-commits] [PATCH] D20567: Avoid using stdio in TestVirtual

This revision was automatically updated to reflect the committed changes. Closed by commit rL270831: Avoid using stdio in TestVirtual (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20567?vs=58418&id=58579#toc Repository: rL LLVM http://reviews.llvm.org/D20567 Files

[Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

labath created this revision. labath added reviewers: tberghammer, tfiala, nitesh.jain, omjavaid, emaste, krytarowski. labath added a subscriber: lldb-commits. Recent increase in the usage of std::weak_ptr has caused us to rediscover an issue in libstdc++ versions prior to 4.9

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

labath added a comment. I am adding everyone I think could be susceptible to this problem. It would be a good idea to check if you are still using libstdc++4.8 or older. http://reviews.llvm.org/D20671 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D20673: [cmake] Remove the LLDB versions of the exception-controlling variables

labath created this revision. labath added reviewers: zturner, tfiala. labath added a subscriber: lldb-commits. One can still use the LLVM variables to control this: LLVM_ENABLE_EH, LLVM_ENABLE_RTTI. It's not clear to me why one would want to control these at lldb level and it's generally not ev

Re: [Lldb-commits] [PATCH] D20673: [cmake] Remove the LLDB versions of the exception-controlling variables

labath added a comment. Zachary, Todd, you added these in http://reviews.llvm.org/D3929. I know it's a long time, but do you recall what was the original motivation for that? In light of the issue in http://reviews.llvm.org/D20671, I've experimenting with compiling lldb with exceptions enabled,

Re: [Lldb-commits] [lldb] r270745 - Mark some arm-linux specific xfails marking bug entries

Omair, please be careful about using arm xfails. You are using too wide annotations and disabling tests even on configurations where they are known to pass. On 25 May 2016 at 19:48, Omair Javaid via lldb-commits wrote: > Modified: > lldb/trunk/packages/Python/lldbsuite/test/expression_command/

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

labath added a comment. In http://reviews.llvm.org/D20671#440868, @zturner wrote: > Wondering if this should go in llvm. What do you think? I don't see any uses of weak_ptr in the llvm repository, so this issue should only affect lldb, I think. http://reviews.llvm.org/D20671 _

[Lldb-commits] [lldb] r270854 - [cmake] Add a big warning about a libstdc++ issue

Author: labath Date: Thu May 26 10:16:11 2016 New Revision: 270854 URL: http://llvm.org/viewvc/llvm-project?rev=270854&view=rev Log: [cmake] Add a big warning about a libstdc++ issue Summary: Recent increase in the usage of std::weak_ptr has caused us to rediscover an issue in libstdc++ versions

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

This revision was automatically updated to reflect the committed changes. Closed by commit rL270854: [cmake] Add a big warning about a libstdc++ issue (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20671?vs=58584&id=58616#toc Repository: rL LLVM http://reviews.llvm.

Re: [Lldb-commits] [PATCH] D20673: [cmake] Remove the LLDB versions of the exception-controlling variables

labath added a comment. In http://reviews.llvm.org/D20673#440660, @labath wrote: > Enabling this should not make any difference in the common case, as llvm > already adds one set of exception-disabling flags if you don't specify the > flag I mentioned (llvm/cmake/modules/AddLLVM.cmake). (And

[Lldb-commits] [lldb] r270863 - [cmake] Remove the LLDB versions of the exception-controlling variables

Author: labath Date: Thu May 26 11:11:04 2016 New Revision: 270863 URL: http://llvm.org/viewvc/llvm-project?rev=270863&view=rev Log: [cmake] Remove the LLDB versions of the exception-controlling variables Summary: One can still use the LLVM variables to control this: LLVM_ENABLE_EH, LLVM_ENABLE_

Re: [Lldb-commits] [PATCH] D20673: [cmake] Remove the LLDB versions of the exception-controlling variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL270863: [cmake] Remove the LLDB versions of the exception-controlling variables (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20673?vs=58587&id=58630#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D17856: Fix expression evaluation with operator new

labath added a comment. Sean, could you find some time to look at this please? http://reviews.llvm.org/D17856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D21088: Don't use SO_REUSEADDR for *client* sockets

labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. In the case of client sockets, we are not binding to a specific port, so we should be able to just request a new one. Disregarding refactors,

[Lldb-commits] [lldb] r272041 - Don't use SO_REUSEADDR for *client* sockets

Author: labath Date: Tue Jun 7 13:36:38 2016 New Revision: 272041 URL: http://llvm.org/viewvc/llvm-project?rev=272041&view=rev Log: Don't use SO_REUSEADDR for *client* sockets Summary: In the case of client sockets, we are not binding to a specific port, so we should be able to just request a ne

Re: [Lldb-commits] [PATCH] D21088: Don't use SO_REUSEADDR for *client* sockets

This revision was automatically updated to reflect the committed changes. Closed by commit rL272041: Don't use SO_REUSEADDR for *client* sockets (authored by labath). Changed prior to commit: http://reviews.llvm.org/D21088?vs=59916&id=59922#toc Repository: rL LLVM http://reviews.llvm.org/D2

<    10   11   12   13   14   15   16   17   18   19   >